Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John.C.Harrison@Intel.com
To: Intel-GFX@Lists.FreeDesktop.Org
Cc: DRI-Devel@Lists.FreeDesktop.Org
Subject: [Intel-gfx] [PATCH 3/3] drm/i915: Include timelines in error capture
Date: Thu,  2 Feb 2023 17:10:43 -0800	[thread overview]
Message-ID: <20230203011043.3427096-4-John.C.Harrison@Intel.com> (raw)
In-Reply-To: <20230203011043.3427096-1-John.C.Harrison@Intel.com>

From: John Harrison <John.C.Harrison@Intel.com>

The seqno value actually written out to memory is no longer in the
regular HWSP and therefore no longer visible in an error capture.
Instead, it is now in its own private timeline buffer. So include that
buffer in the capture too.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 904f21e1380cd..66bd4c1162f79 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1550,6 +1550,7 @@ engine_coredump_add_context(struct intel_engine_coredump *ee,
 	 */
 	vma = capture_vma(vma, ce->ring->vma, "ring", gfp);
 	vma = capture_vma(vma, ce->state, "HW context", gfp);
+	vma = capture_vma(vma, ce->timeline->hwsp_ggtt, "ctxt timeline HWSP", gfp);
 
 	return vma;
 }
@@ -1572,6 +1573,8 @@ intel_engine_coredump_add_request(struct intel_engine_coredump *ee,
 	 */
 	vma = capture_vma_snapshot(vma, rq->batch_res, gfp, "batch");
 	vma = capture_user(vma, rq, gfp);
+	if (rq->timeline != rq->context->timeline)
+		vma = capture_vma(vma, rq->timeline->hwsp_ggtt, "rq timeline HWSP", gfp);
 
 	ee->rq_head = rq->head;
 	ee->rq_post = rq->postfix;
-- 
2.39.1


  parent reply	other threads:[~2023-02-03  1:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03  1:10 [Intel-gfx] [PATCH 0/3] More error capture improvements John.C.Harrison
2023-02-03  1:10 ` [Intel-gfx] [PATCH 1/3] drm/i915/guc: Fix missing ecodes John.C.Harrison
2023-02-04  7:55   ` Teres Alexis, Alan Previn
2023-02-03  1:10 ` [Intel-gfx] [PATCH 2/3] drm/i915/guc: Clean up of register capture search John.C.Harrison
2023-02-04  7:29   ` Teres Alexis, Alan Previn
2023-02-07  3:18     ` John Harrison
2023-02-03  1:10 ` John.C.Harrison [this message]
2023-02-03  2:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More error capture improvements Patchwork
2023-02-03 12:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-02-03 16:41 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230203011043.3427096-4-John.C.Harrison@Intel.com \
    --to=john.c.harrison@intel.com \
    --cc=DRI-Devel@Lists.FreeDesktop.Org \
    --cc=Intel-GFX@Lists.FreeDesktop.Org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox