Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 4/4] drm/i915/opregion: Register/unregister opregion on platforms without display
Date: Tue, 21 Feb 2023 14:57:37 +0200	[thread overview]
Message-ID: <20230221125737.1813187-4-imre.deak@intel.com> (raw)
In-Reply-To: <20230221125737.1813187-1-imre.deak@intel.com>

Call the opregion register/unregister functions during driver
loading/unloading on !HAS_DISPLAY platforms. These functions will send
the opregion adapter power state notifications which is required on all
platforms (similarly how this is sent during runtime and system
suspend/resume). Skip registering the ACPI video notifier callback on
!HAS_DISPLAY, where the corresponding video extensions are not
supported.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c  | 11 +++++++----
 drivers/gpu/drm/i915/display/intel_opregion.c |  2 +-
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 7827ef3e2d1e6..467f6e2376057 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -8882,11 +8882,12 @@ bool intel_modeset_probe_defer(struct pci_dev *pdev)
 
 void intel_display_driver_register(struct drm_i915_private *i915)
 {
-	if (!HAS_DISPLAY(i915))
-		return;
-
 	/* Must be done after probing outputs */
 	intel_opregion_register(i915);
+
+	if (!HAS_DISPLAY(i915))
+		return;
+
 	intel_acpi_video_register(i915);
 
 	intel_audio_init(i915);
@@ -8914,7 +8915,7 @@ void intel_display_driver_register(struct drm_i915_private *i915)
 void intel_display_driver_unregister(struct drm_i915_private *i915)
 {
 	if (!HAS_DISPLAY(i915))
-		return;
+		goto unregister_opregion;
 
 	intel_fbdev_unregister(i915);
 	intel_audio_deinit(i915);
@@ -8928,6 +8929,8 @@ void intel_display_driver_unregister(struct drm_i915_private *i915)
 	drm_atomic_helper_shutdown(&i915->drm);
 
 	acpi_video_unregister();
+
+unregister_opregion:
 	intel_opregion_unregister(i915);
 }
 
diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c
index b7973a05d022d..37098e7f607e6 100644
--- a/drivers/gpu/drm/i915/display/intel_opregion.c
+++ b/drivers/gpu/drm/i915/display/intel_opregion.c
@@ -1150,7 +1150,7 @@ void intel_opregion_register(struct drm_i915_private *i915)
 	if (!opregion->header)
 		return;
 
-	if (opregion->acpi) {
+	if (HAS_DISPLAY(i915) && opregion->acpi) {
 		opregion->acpi_notifier.notifier_call =
 			intel_opregion_video_event;
 		register_acpi_notifier(&opregion->acpi_notifier);
-- 
2.37.1


  parent reply	other threads:[~2023-02-21 12:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 12:57 [Intel-gfx] [PATCH 1/4] drm/i915/opregion: Fix opregion setup during system resume on platforms without display Imre Deak
2023-02-21 12:57 ` [Intel-gfx] [PATCH 2/4] drm/i915/opregion: Cleanup opregion after errors during driver loading Imre Deak
2023-02-21 12:57 ` [Intel-gfx] [PATCH 3/4] drm/i915/opregion: Register display debugfs later, after initialization steps Imre Deak
2023-03-07  8:51   ` Jani Nikula
2023-02-21 12:57 ` Imre Deak [this message]
2023-03-07  8:50   ` [Intel-gfx] [PATCH 4/4] drm/i915/opregion: Register/unregister opregion on platforms without display Jani Nikula
2023-03-07 22:06     ` Imre Deak
2023-02-21 13:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/opregion: Fix opregion setup during system resume " Patchwork
2023-02-21 18:07 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-03-14 11:00 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/4] drm/i915/opregion: Fix opregion setup during system resume on platforms without display (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230221125737.1813187-4-imre.deak@intel.com \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox