Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915/opregion: Register display debugfs later, after initialization steps
Date: Tue, 07 Mar 2023 10:51:08 +0200	[thread overview]
Message-ID: <87r0u1rlkz.fsf@intel.com> (raw)
In-Reply-To: <20230221125737.1813187-3-imre.deak@intel.com>

On Tue, 21 Feb 2023, Imre Deak <imre.deak@intel.com> wrote:
> Move the display debugfs registration later, after initializing steps
> for opregion/acpi/audio. These latter ones don't depend on the debugfs
> entries, OTOH some debugfs entries may depend on the initialized state.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Patches 1-3,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index a1fbdf32bd214..7827ef3e2d1e6 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -8885,14 +8885,14 @@ void intel_display_driver_register(struct drm_i915_private *i915)
>  	if (!HAS_DISPLAY(i915))
>  		return;
>  
> -	intel_display_debugfs_register(i915);
> -
>  	/* Must be done after probing outputs */
>  	intel_opregion_register(i915);
>  	intel_acpi_video_register(i915);
>  
>  	intel_audio_init(i915);
>  
> +	intel_display_debugfs_register(i915);
> +
>  	/*
>  	 * Some ports require correctly set-up hpd registers for
>  	 * detection to work properly (leading to ghost connected

-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2023-03-07  8:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 12:57 [Intel-gfx] [PATCH 1/4] drm/i915/opregion: Fix opregion setup during system resume on platforms without display Imre Deak
2023-02-21 12:57 ` [Intel-gfx] [PATCH 2/4] drm/i915/opregion: Cleanup opregion after errors during driver loading Imre Deak
2023-02-21 12:57 ` [Intel-gfx] [PATCH 3/4] drm/i915/opregion: Register display debugfs later, after initialization steps Imre Deak
2023-03-07  8:51   ` Jani Nikula [this message]
2023-02-21 12:57 ` [Intel-gfx] [PATCH 4/4] drm/i915/opregion: Register/unregister opregion on platforms without display Imre Deak
2023-03-07  8:50   ` Jani Nikula
2023-03-07 22:06     ` Imre Deak
2023-02-21 13:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/opregion: Fix opregion setup during system resume " Patchwork
2023-02-21 18:07 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-03-14 11:00 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/4] drm/i915/opregion: Fix opregion setup during system resume on platforms without display (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0u1rlkz.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox