Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nirmoy Das <nirmoy.das@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: matthew.auld@intel.com, Nirmoy Das <nirmoy.das@intel.com>
Subject: [Intel-gfx] [RFC PATCH 2/2] drm/i915/display: Implement fb_mmap callback function
Date: Tue,  7 Mar 2023 15:46:52 +0100	[thread overview]
Message-ID: <20230307144652.17595-2-nirmoy.das@intel.com> (raw)
In-Reply-To: <20230307144652.17595-1-nirmoy.das@intel.com>

If stolen memory allocation fails for fbdev, the driver will
fallback to system memory. Calculation of smem_start is wrong
for such framebuffer objs if the platform comes with no gmadr or
no aperture. Solve this by adding fb_mmap callback which will
use GTT if aperture is available otherwise will use cpu to access
the framebuffer.

Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/i915/display/intel_fbdev.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index 3659350061a7..67427d020bd3 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -40,8 +40,10 @@
 #include <drm/drm_crtc.h>
 #include <drm/drm_fb_helper.h>
 #include <drm/drm_fourcc.h>
+#include <drm/drm_gem_framebuffer_helper.h>
 
 #include "gem/i915_gem_lmem.h"
+#include "gem/i915_gem_mman.h"
 
 #include "i915_drv.h"
 #include "intel_display_types.h"
@@ -120,6 +122,16 @@ static int intel_fbdev_pan_display(struct fb_var_screeninfo *var,
 	return ret;
 }
 
+#define to_intel_fbdev(x) container_of(x, struct intel_fbdev, helper)
+static int intel_fbdev_mmap(struct fb_info *info, struct vm_area_struct *vma)
+{
+	struct intel_fbdev *fbdev = to_intel_fbdev(info->par);
+	struct drm_gem_object *bo = drm_gem_fb_get_obj(&fbdev->fb->base, 0);
+	struct drm_i915_gem_object *obj = to_intel_bo(bo);
+
+	return i915_gem_fb_mmap(obj, vma);
+}
+
 static const struct fb_ops intelfb_ops = {
 	.owner = THIS_MODULE,
 	DRM_FB_HELPER_DEFAULT_OPS,
@@ -131,6 +143,7 @@ static const struct fb_ops intelfb_ops = {
 	.fb_imageblit = drm_fb_helper_cfb_imageblit,
 	.fb_pan_display = intel_fbdev_pan_display,
 	.fb_blank = intel_fbdev_blank,
+	.fb_mmap = intel_fbdev_mmap,
 };
 
 static int intelfb_alloc(struct drm_fb_helper *helper,
-- 
2.39.0


  reply	other threads:[~2023-03-07 14:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 14:46 [Intel-gfx] [RFC PATCH 1/2] drm/i915: Add a function to mmap framebuffer obj Nirmoy Das
2023-03-07 14:46 ` Nirmoy Das [this message]
2023-03-10 10:15   ` [Intel-gfx] [RFC PATCH 2/2] drm/i915/display: Implement fb_mmap callback function Das, Nirmoy
2023-03-13 18:49   ` Andi Shyti
2023-03-07 15:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [RFC,1/2] drm/i915: Add a function to mmap framebuffer obj Patchwork
2023-03-07 15:01 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-07 15:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-08 19:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-03-13 18:37 ` [Intel-gfx] [RFC PATCH 1/2] " Andi Shyti
2023-03-14  9:18   ` Das, Nirmoy
  -- strict thread matches above, loose matches on Subject: below --
2023-03-16 17:22 Nirmoy Das
2023-03-16 17:22 ` [Intel-gfx] [RFC PATCH 2/2] drm/i915/display: Implement fb_mmap callback function Nirmoy Das
2023-03-17  9:39   ` Jani Nikula
2023-03-17 10:08     ` Das, Nirmoy
2023-03-20  0:40   ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230307144652.17595-2-nirmoy.das@intel.com \
    --to=nirmoy.das@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox