Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Nirmoy Das <nirmoy.das@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Matthew Auld <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [RFC PATCH 2/2] drm/i915/display: Implement fb_mmap callback function
Date: Mon, 20 Mar 2023 01:40:00 +0100	[thread overview]
Message-ID: <ZBerYMHjihNfIAF5@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230316172220.16068-2-nirmoy.das@intel.com>

Hi Nirmoy,

On Thu, Mar 16, 2023 at 06:22:20PM +0100, Nirmoy Das wrote:
> If stolen memory allocation fails for fbdev, the driver will
> fallback to system memory. Calculation of smem_start is wrong
> for such framebuffer objs if the platform comes with no gmadr or
> no aperture. Solve this by adding fb_mmap callback which will
> use GTT if aperture is available otherwise will use cpu to access
> the framebuffer.
> 
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>

with Jani's suggestion:

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Andi

  parent reply	other threads:[~2023-03-20  0:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 17:22 [Intel-gfx] [RFC PATCH 1/2] drm/i915: Add a function to mmap framebuffer obj Nirmoy Das
2023-03-16 17:22 ` [Intel-gfx] [RFC PATCH 2/2] drm/i915/display: Implement fb_mmap callback function Nirmoy Das
2023-03-17  9:39   ` Jani Nikula
2023-03-17 10:08     ` Das, Nirmoy
2023-03-20  0:40   ` Andi Shyti [this message]
2023-03-20  0:38 ` [Intel-gfx] [RFC PATCH 1/2] drm/i915: Add a function to mmap framebuffer obj Andi Shyti
2023-03-20 10:04   ` Das, Nirmoy
  -- strict thread matches above, loose matches on Subject: below --
2023-03-07 14:46 Nirmoy Das
2023-03-07 14:46 ` [Intel-gfx] [RFC PATCH 2/2] drm/i915/display: Implement fb_mmap callback function Nirmoy Das
2023-03-10 10:15   ` Das, Nirmoy
2023-03-13 18:49   ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBerYMHjihNfIAF5@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=matthew.auld@intel.com \
    --cc=nirmoy.das@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox