Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kahola <mika.kahola@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v5 10/22] drm/i915/mtl: Dump C20 pll hw state
Date: Thu, 16 Mar 2023 13:13:23 +0200	[thread overview]
Message-ID: <20230316111335.66915-11-mika.kahola@intel.com> (raw)
In-Reply-To: <20230316111335.66915-1-mika.kahola@intel.com>

As we already do with C10 chip, let's dump the pll
hw state for C20 as well.

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 drivers/gpu/drm/i915/display/intel_cx0_phy.c | 20 ++++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_cx0_phy.h |  2 ++
 drivers/gpu/drm/i915/display/intel_ddi.c     |  1 +
 3 files changed, 23 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
index bfb264ea154a..bc6913a7444a 100644
--- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
@@ -1874,6 +1874,26 @@ void intel_c20pll_readout_hw_state(struct intel_encoder *encoder,
 	}
 }
 
+void intel_c20pll_dump_hw_state(struct drm_i915_private *i915,
+				const struct intel_c20pll_state *hw_state)
+{
+	int i;
+
+	drm_dbg_kms(&i915->drm, "c20pll_hw_state:\n");
+	drm_dbg_kms(&i915->drm, "tx[0] = 0x%.4x, tx[1] = 0x%.4x, tx[2] = 0x%.4x\n",
+		    hw_state->tx[0], hw_state->tx[1], hw_state->tx[2]);
+	drm_dbg_kms(&i915->drm, "cmn[0] = 0x%.4x, cmn[1] = 0x%.4x, cmn[2] = 0x%.4x, cmn[3] = 0x%.4x\n",
+		    hw_state->cmn[0], hw_state->cmn[1], hw_state->cmn[2], hw_state->cmn[3]);
+
+	if (intel_c20_use_mplla(hw_state->clock)) {
+		for (i = 0; i < ARRAY_SIZE(hw_state->mplla); i++)
+			drm_dbg_kms(&i915->drm, "mplla[%d] = 0x%.4x\n", i, hw_state->mplla[i]);
+	} else {
+		for (i = 0; i < ARRAY_SIZE(hw_state->mpllb); i++)
+			drm_dbg_kms(&i915->drm, "mpllb[%d] = 0x%.4x\n", i, hw_state->mpllb[i]);
+	}
+}
+
 static u8 intel_c20_get_dp_rate(u32 clock)
 {
 	switch (clock) {
diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.h b/drivers/gpu/drm/i915/display/intel_cx0_phy.h
index cf603080ce3d..0b46b2ad48a9 100644
--- a/drivers/gpu/drm/i915/display/intel_cx0_phy.h
+++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.h
@@ -37,6 +37,8 @@ void intel_c20pll_readout_hw_state(struct intel_encoder *encoder,
                                    struct intel_c20pll_state *pll_state);
 void intel_c10mpllb_dump_hw_state(struct drm_i915_private *dev_priv,
 				  const struct intel_c10mpllb_state *hw_state);
+void intel_c20pll_dump_hw_state(struct drm_i915_private *i915,
+				const struct intel_c20pll_state *hw_state);
 int intel_c10mpllb_calc_port_clock(struct intel_encoder *encoder,
 				   const struct intel_c10mpllb_state *pll_state);
 void intel_c10mpllb_state_verify(struct intel_atomic_state *state,
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 14b8dcee1c0c..d94add6e322d 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3521,6 +3521,7 @@ static void mtl_ddi_get_config(struct intel_encoder *encoder,
 		intel_c10mpllb_dump_hw_state(i915, &crtc_state->cx0pll_state.c10mpllb_state);
 	} else {
 		intel_c20pll_readout_hw_state(encoder, &crtc_state->cx0pll_state.c20pll_state);
+		intel_c20pll_dump_hw_state(i915, &crtc_state->cx0pll_state.c20pll_state);
 	}
 
 	crtc_state->port_clock = intel_c10mpllb_calc_port_clock(encoder, &crtc_state->cx0pll_state.c10mpllb_state);
-- 
2.34.1


  parent reply	other threads:[~2023-03-16 11:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 11:13 [Intel-gfx] [PATCH v5 00/22] drm/i915/mtl: Add C10 and C20 phy support Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 01/22] drm/i915/mtl: Initial DDI port setup Mika Kahola
2023-03-20 18:25   ` Lucas De Marchi
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 02/22] drm/i915/mtl: Add DP rates Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 03/22] drm/i915/mtl: Create separate reg file for PICA registers Mika Kahola
2023-03-20 18:06   ` Lucas De Marchi
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 04/22] drm/i915/mtl: Add Support for C10 PHY message bus and pll programming Mika Kahola
2023-03-24 17:47   ` Gustavo Sousa
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 05/22] drm/i915/mtl: Add C10 phy programming for HDMI Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 06/22] drm/i915/mtl: Add vswing programming for C10 phys Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 07/22] drm/i915/mtl: Add support for PM DEMAND Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 08/22] drm/i915/mtl: C20 PLL programming Mika Kahola
2023-03-24 19:56   ` Gustavo Sousa
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 09/22] drm/i915/mtl: C20 HW readout Mika Kahola
2023-03-24 20:21   ` Gustavo Sousa
2023-03-27  9:25   ` Imre Deak
2023-03-16 11:13 ` Mika Kahola [this message]
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 11/22] drm/i915/mtl: C20 port clock calculation Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 12/22] drm/i915/mtl: C20 HDMI state calculations Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 13/22] drm/i915/mtl: Add voltage swing sequence for C20 Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 14/22] drm/i915/mtl: For DP2.0 10G and 20G rates use MPLLA Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 15/22] drm/i915/mtl: Enabling/disabling sequence Thunderbolt pll Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 16/22] drm/i915/mtl: Readout Thunderbolt HW state Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 17/22] drm/i915/mtl: Enable TC ports Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 18/22] drm/i915/mtl: MTL PICA hotplug detection Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 19/22] drm/i915/mtl: Define mask for DDI AUX interrupts Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 20/22] drm/i915/mtl: Power up TCSS Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 21/22] drm/i915/mtl: TypeC HPD live status query Mika Kahola
2023-03-16 11:13 ` [Intel-gfx] [PATCH v5 22/22] drm/i915/mtl: Pin assignment for TypeC Mika Kahola
2023-04-11 14:32   ` Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230316111335.66915-11-mika.kahola@intel.com \
    --to=mika.kahola@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox