From: kernel test robot <lkp@intel.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
mcanal@igalia.com, stanislaw.gruszka@linux.intel.com,
ogabbay@kernel.org, quic_jhugo@quicinc.com, daniel@ffwll.ch,
jani.nikula@linux.intel.com, mwen@igalia.com, maxime@cerno.tech,
wambui.karugax@gmail.com, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [Intel-gfx] [PATCH 7/7] drm/debugfs: remove debugfs_root pointer from minor
Date: Thu, 16 Mar 2023 19:24:49 +0800 [thread overview]
Message-ID: <202303161920.xBWFRr94-lkp@intel.com> (raw)
In-Reply-To: <20230316082035.567520-8-christian.koenig@amd.com>
Hi Christian,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm-intel/for-linux-next-fixes linus/master v6.3-rc2]
[cannot apply to drm-tip/drm-tip drm-intel/for-linux-next tegra/for-next next-20230316]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-tegra-allow-compile-test-on-ARM/20230316-172205
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20230316082035.567520-8-christian.koenig%40amd.com
patch subject: [PATCH 7/7] drm/debugfs: remove debugfs_root pointer from minor
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20230316/202303161920.xBWFRr94-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/70b21b15c200ec426c806bf2aa03083e3b19dd41
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Christian-K-nig/drm-tegra-allow-compile-test-on-ARM/20230316-172205
git checkout 70b21b15c200ec426c806bf2aa03083e3b19dd41
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/gpu/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303161920.xBWFRr94-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/gpu/drm/msm/msm_debugfs.c: In function 'msm_debugfs_init':
>> drivers/gpu/drm/msm/msm_debugfs.c:329:58: error: 'struct drm_minor' has no member named 'debugfs_root'
329 | gpu_devfreq = debugfs_create_dir("devfreq", minor->debugfs_root);
| ^~
vim +329 drivers/gpu/drm/msm/msm_debugfs.c
edcd60ce243d16 Rob Clark 2016-03-16 303
7ce84471e3c72e Wambui Karuga 2020-03-10 304 void msm_debugfs_init(struct drm_minor *minor)
edcd60ce243d16 Rob Clark 2016-03-16 305 {
edcd60ce243d16 Rob Clark 2016-03-16 306 struct drm_device *dev = minor->dev;
bc5289eed48176 Rob Clark 2016-10-26 307 struct msm_drm_private *priv = dev->dev_private;
6563f60f14cbb3 Rob Clark 2023-01-10 308 struct dentry *gpu_devfreq;
edcd60ce243d16 Rob Clark 2016-03-16 309
9e2fd463ec346d Wambui Karuga 2020-03-10 310 drm_debugfs_create_files(msm_debugfs_list,
edcd60ce243d16 Rob Clark 2016-03-16 311 ARRAY_SIZE(msm_debugfs_list),
70b21b15c200ec Christian König 2023-03-16 312 minor->dev->debugfs_root, minor);
edcd60ce243d16 Rob Clark 2016-03-16 313
70b21b15c200ec Christian König 2023-03-16 314 debugfs_create_file("gpu", S_IRUSR, minor->dev->debugfs_root,
4f776f4511c7f7 Jordan Crouse 2018-07-24 315 dev, &msm_gpu_fops);
4f776f4511c7f7 Jordan Crouse 2018-07-24 316
70b21b15c200ec Christian König 2023-03-16 317 debugfs_create_file("kms", S_IRUSR, minor->dev->debugfs_root,
c1760555884b7f Rob Clark 2021-12-15 318 dev, &msm_kms_fops);
c1760555884b7f Rob Clark 2021-12-15 319
70b21b15c200ec Christian König 2023-03-16 320 debugfs_create_u32("hangcheck_period_ms", 0600, minor->dev->debugfs_root,
1d2fa58e0dda33 Samuel Iglesias Gonsalvez 2021-06-07 321 &priv->hangcheck_period);
1d2fa58e0dda33 Samuel Iglesias Gonsalvez 2021-06-07 322
70b21b15c200ec Christian König 2023-03-16 323 debugfs_create_bool("disable_err_irq", 0600, minor->dev->debugfs_root,
5edf2750d998b7 Rob Clark 2021-11-09 324 &priv->disable_err_irq);
5edf2750d998b7 Rob Clark 2021-11-09 325
70b21b15c200ec Christian König 2023-03-16 326 debugfs_create_file("shrink", S_IRWXU, minor->dev->debugfs_root,
5434941fd45d30 Rob Clark 2021-06-14 327 dev, &shrink_fops);
5434941fd45d30 Rob Clark 2021-06-14 328
6563f60f14cbb3 Rob Clark 2023-01-10 @329 gpu_devfreq = debugfs_create_dir("devfreq", minor->debugfs_root);
6563f60f14cbb3 Rob Clark 2023-01-10 330
6563f60f14cbb3 Rob Clark 2023-01-10 331 debugfs_create_bool("idle_clamp",0600, gpu_devfreq,
6563f60f14cbb3 Rob Clark 2023-01-10 332 &priv->gpu_clamp_to_idle);
6563f60f14cbb3 Rob Clark 2023-01-10 333
6563f60f14cbb3 Rob Clark 2023-01-10 334 debugfs_create_u32("upthreshold",0600, gpu_devfreq,
6563f60f14cbb3 Rob Clark 2023-01-10 335 &priv->gpu_devfreq_config.upthreshold);
6563f60f14cbb3 Rob Clark 2023-01-10 336
6563f60f14cbb3 Rob Clark 2023-01-10 337 debugfs_create_u32("downdifferential",0600, gpu_devfreq,
6563f60f14cbb3 Rob Clark 2023-01-10 338 &priv->gpu_devfreq_config.downdifferential);
6563f60f14cbb3 Rob Clark 2023-01-10 339
7ce84471e3c72e Wambui Karuga 2020-03-10 340 if (priv->kms && priv->kms->funcs->debugfs_init)
7ce84471e3c72e Wambui Karuga 2020-03-10 341 priv->kms->funcs->debugfs_init(priv->kms, minor);
6d29709de8028c Rob Clark 2022-08-07 342
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-03-16 11:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 8:20 [Intel-gfx] DRM debugfs cleanup take 3 Christian König
2023-03-16 8:20 ` [Intel-gfx] [PATCH 1/7] drm: remove drm_dev_set_unique Christian König
2023-03-16 14:15 ` Jeffrey Hugo
2023-03-16 8:20 ` [Intel-gfx] [PATCH 2/7] drm/tegra: allow compile test on !ARM Christian König
2023-03-16 22:58 ` kernel test robot
2023-03-16 8:20 ` [Intel-gfx] [PATCH 3/7] drm/debugfs: stop calling debugfs_init() for the render node Christian König
2023-03-16 8:20 ` [Intel-gfx] [PATCH 4/7] drm/debugfs: rework debugfs directory creation v2 Christian König
2023-03-16 22:27 ` kernel test robot
2023-03-22 11:17 ` Stanislaw Gruszka
2023-03-16 8:20 ` [Intel-gfx] [PATCH 5/7] drm/debugfs: remove dev->debugfs_list and debugfs_mutex v2 Christian König
2023-03-16 8:20 ` [Intel-gfx] [PATCH 6/7] drm/debugfs: rework drm_debugfs_create_files implementation Christian König
2023-03-16 8:20 ` [Intel-gfx] [PATCH 7/7] drm/debugfs: remove debugfs_root pointer from minor Christian König
2023-03-16 11:24 ` kernel test robot [this message]
2023-03-16 8:25 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/7] drm: remove drm_dev_set_unique Patchwork
2023-03-22 11:58 ` Jani Nikula
2023-03-22 13:51 ` Christian König
2023-03-22 11:20 ` [Intel-gfx] DRM debugfs cleanup take 3 Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202303161920.xBWFRr94-lkp@intel.com \
--to=lkp@intel.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mcanal@igalia.com \
--cc=mwen@igalia.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox