Re: [Intel-gfx] [PATCH 4/7] drm/debugfs: rework debugfs directory creation v2

[kernel test robot <lkp@intel.com>]

Hi Christian,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.3-rc2 next-20230316]
[cannot apply to drm-tip/drm-tip tegra/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-tegra-allow-compile-test-on-ARM/20230316-172205
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20230316082035.567520-5-christian.koenig%40amd.com
patch subject: [Intel-gfx] [PATCH 4/7] drm/debugfs: rework debugfs directory creation v2
config: ia64-defconfig (https://download.01.org/0day-ci/archive/20230317/202303170646.MwaW3iKp-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/a3ad5ec323e8f1864cc8b721dbb154f0e0e2919d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Christian-K-nig/drm-tegra-allow-compile-test-on-ARM/20230316-172205
        git checkout a3ad5ec323e8f1864cc8b721dbb154f0e0e2919d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/gpu/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303170646.MwaW3iKp-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/gpu/drm/drm_atomic.c:47:
>> drivers/gpu/drm/drm_internal.h:195:8: error: return type defaults to 'int' [-Werror=implicit-int]
     195 | static drm_debugfs_dev_register(struct drm_device *dev)
         |        ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/drm_internal.h:195:8: warning: 'drm_debugfs_dev_register' defined but not used [-Wunused-function]
   In file included from drivers/gpu/drm/drm_atomic.c:38:
   include/drm/drm_drv.h:596:13: warning: 'drm_debugfs_dev_init' defined but not used [-Wunused-function]
     596 | static void drm_debugfs_dev_init(struct drm_device *dev, struct dentry *root)
         |             ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from drivers/gpu/drm/drm_drv.c:50:
>> drivers/gpu/drm/drm_internal.h:195:8: error: return type defaults to 'int' [-Werror=implicit-int]
     195 | static drm_debugfs_dev_register(struct drm_device *dev)
         |        ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/drm_drv.c: In function 'drm_dev_unregister':
>> drivers/gpu/drm/drm_drv.c:1011:9: error: implicit declaration of function 'drm_debugfs_dev_fini'; did you mean 'drm_debugfs_dev_init'? [-Werror=implicit-function-declaration]
    1011 |         drm_debugfs_dev_fini(dev);
         |         ^~~~~~~~~~~~~~~~~~~~
         |         drm_debugfs_dev_init
   drivers/gpu/drm/drm_internal.h: In function 'drm_debugfs_dev_register':
   drivers/gpu/drm/drm_internal.h:197:1: error: control reaches end of non-void function [-Werror=return-type]
     197 | }
         | ^
   cc1: some warnings being treated as errors
--
   In file included from drivers/gpu/drm/drm_managed.c:18:
>> drivers/gpu/drm/drm_internal.h:195:8: error: return type defaults to 'int' [-Werror=implicit-int]
     195 | static drm_debugfs_dev_register(struct drm_device *dev)
         |        ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/drm_internal.h:195:8: warning: 'drm_debugfs_dev_register' defined but not used [-Wunused-function]
   cc1: some warnings being treated as errors


vim +/int +195 drivers/gpu/drm/drm_internal.h

   180	
   181	/* drm_debugfs.c drm_debugfs_crc.c */
   182	#if defined(CONFIG_DEBUG_FS)
   183	void drm_debugfs_dev_fini(struct drm_device *dev);
   184	void drm_debugfs_dev_register(struct drm_device *dev);
   185	int drm_debugfs_register(struct drm_minor *minor, int minor_id,
   186				 struct dentry *root);
   187	void drm_debugfs_cleanup(struct drm_minor *minor);
   188	void drm_debugfs_late_register(struct drm_device *dev);
   189	void drm_debugfs_connector_add(struct drm_connector *connector);
   190	void drm_debugfs_connector_remove(struct drm_connector *connector);
   191	void drm_debugfs_crtc_add(struct drm_crtc *crtc);
   192	void drm_debugfs_crtc_remove(struct drm_crtc *crtc);
   193	void drm_debugfs_crtc_crc_add(struct drm_crtc *crtc);
   194	#else
 > 195	static drm_debugfs_dev_register(struct drm_device *dev)
   196	{
   197	}
   198	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests