From: Andi Shyti <andi.shyti@linux.intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Andi Shyti <andi.shyti@kernel.org>,
Maciej Patelczyk <maciej.patelczyk@intel.com>,
Nirmoy Das <nirmoy.das@intel.com>
Subject: [Intel-gfx] [PATCH v3 2/2] drm/i915/debugfs: Enable upper layer interfaces to act on all gt's
Date: Sat, 18 Mar 2023 21:36:16 +0100 [thread overview]
Message-ID: <20230318203616.183765-4-andi.shyti@linux.intel.com> (raw)
In-Reply-To: <20230318203616.183765-1-andi.shyti@linux.intel.com>
The commit 82a149a62b6b5 ('drm/i915/gt: move remaining debugfs
interfaces into gt') moved gt-related debugfs files in the gtX/
directories to operate on individual gt's.
However, the original files were only functioning on the root
GT (GT 0) and have been left in the same location to maintain
compatibility with userspace users.
Add multiplexing functionality to the higher directories' files.
This enables the operations to be performed on all the GTs with
a single write. In the case of reads, the files provide an or'ed
value across all the tiles.
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Maciej Patelczyk <maciej.patelczyk@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 36 +++++++++++++++++++++++++----
1 file changed, 32 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 16011c0286ada..80c2bf98e341c 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -574,14 +574,34 @@ static int i915_wa_registers(struct seq_file *m, void *unused)
static int i915_wedged_get(void *data, u64 *val)
{
struct drm_i915_private *i915 = data;
+ struct intel_gt *gt;
+ unsigned int i;
- return intel_gt_debugfs_reset_show(to_gt(i915), val);
+ *val = 0;
+
+ for_each_gt(gt, i915, i) {
+ int ret;
+
+ ret = intel_gt_debugfs_reset_show(gt, val);
+ if (ret)
+ return ret;
+
+ /* at least one tile should be wedged */
+ if (*val)
+ break;
+ }
+
+ return 0;
}
static int i915_wedged_set(void *data, u64 val)
{
struct drm_i915_private *i915 = data;
- intel_gt_debugfs_reset_store(to_gt(i915), val);
+ struct intel_gt *gt;
+ unsigned int i;
+
+ for_each_gt(gt, i915, i)
+ intel_gt_debugfs_reset_store(gt, val);
return 0;
}
@@ -732,7 +752,11 @@ static int i915_sseu_status(struct seq_file *m, void *unused)
static int i915_forcewake_open(struct inode *inode, struct file *file)
{
struct drm_i915_private *i915 = inode->i_private;
- intel_gt_pm_debugfs_forcewake_user_open(to_gt(i915));
+ struct intel_gt *gt;
+ unsigned int i;
+
+ for_each_gt(gt, i915, i)
+ intel_gt_pm_debugfs_forcewake_user_open(gt);
return 0;
}
@@ -740,7 +764,11 @@ static int i915_forcewake_open(struct inode *inode, struct file *file)
static int i915_forcewake_release(struct inode *inode, struct file *file)
{
struct drm_i915_private *i915 = inode->i_private;
- intel_gt_pm_debugfs_forcewake_user_release(to_gt(i915));
+ struct intel_gt *gt;
+ unsigned int i;
+
+ for_each_gt(gt, i915, i)
+ intel_gt_pm_debugfs_forcewake_user_release(gt);
return 0;
}
--
2.39.2
next prev parent reply other threads:[~2023-03-18 20:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 20:36 [Intel-gfx] [PATCH v3 0/2] Some debugfs refactoring and improvements Andi Shyti
2023-03-18 20:36 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/gt: Create per-gt debugfs files Andi Shyti
2023-03-18 20:36 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/gt: Create per-tile " Andi Shyti
2023-03-18 20:36 ` Andi Shyti [this message]
2023-03-18 21:06 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning for Some debugfs refactoring and improvements (rev2) Patchwork
2023-03-18 21:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: " Patchwork
2023-03-18 21:06 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-18 21:06 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2023-03-18 21:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-03-18 22:02 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning for Some debugfs refactoring and improvements (rev3) Patchwork
2023-03-18 22:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: " Patchwork
2023-03-18 22:03 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-18 22:32 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-03-20 20:22 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Some debugfs refactoring and improvements (rev4) Patchwork
2023-03-20 20:22 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-20 20:22 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2023-03-20 20:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-21 0:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230318203616.183765-4-andi.shyti@linux.intel.com \
--to=andi.shyti@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maciej.patelczyk@intel.com \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox