Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v2 6/8] drm/i915/psr: Add a FIXME for the PSR vs. AUX usage conflict
Date: Tue, 11 Apr 2023 22:14:27 +0300	[thread overview]
Message-ID: <20230411191429.29895-7-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20230411191429.29895-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We need to disable PSR when we are doing AUX by hand, otherwise
it's possible that the PSR hardware could be using the AUX CH
while we try to do our manual stuff. Add a FIXME for now.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_aux.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 705915d50565..abf77ba76972 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -268,6 +268,11 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 
 	intel_pps_check_power_unlocked(intel_dp);
 
+	/*
+	 * FIXME PSR should be disabled here to prevent
+	 * it using the same AUX CH simultaneously
+	 */
+
 	/* Try to wait for any previous AUX channel activity */
 	for (try = 0; try < 3; try++) {
 		status = intel_de_read_notrace(i915, ch_ctl);
-- 
2.39.2


  parent reply	other threads:[~2023-04-11 19:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 19:14 [Intel-gfx] [PATCH v2 0/8] drm/i915: (mostly) PSR related register cleanups Ville Syrjala
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 1/8] drm/i915: Fix up whitespace in some display chicken registers Ville Syrjala
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 2/8] drm/i915: Clean up various " Ville Syrjala
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 3/8] drm/i915/psr: Clean up PSR register defininitions Ville Syrjala
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 4/8] drm/i915/psr: Use intel_de_rmw() Ville Syrjala
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 5/8] drm/i915/psr: Define more PSR mask bits Ville Syrjala
2023-04-11 19:14 ` Ville Syrjala [this message]
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 7/8] drm/i915/psr: Include PSR_PERF_CNT in debugfs output on all platforms Ville Syrjala
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 8/8] drm/i915/psr: Sprinkle cpu_transcoder variables around Ville Syrjala
2023-04-12  0:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: (mostly) PSR related register cleanups (rev3) Patchwork
2023-04-12  0:51 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-04-12  1:05 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-04-12  8:18 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: (mostly) PSR related register cleanups (rev4) Patchwork
2023-04-12  8:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-04-12  8:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-04-12 15:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-04-20  8:07 ` [Intel-gfx] [PATCH v2 0/8] drm/i915: (mostly) PSR related register cleanups Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230411191429.29895-7-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox