From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v2 7/8] drm/i915/psr: Include PSR_PERF_CNT in debugfs output on all platforms
Date: Tue, 11 Apr 2023 22:14:28 +0300 [thread overview]
Message-ID: <20230411191429.29895-8-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20230411191429.29895-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The fact that DC states reset the PSR perofrmance counter
is no reason not to include it in the debug output.
But let's keep the comment there to remind people about
that caveat.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 28817f7bd8c3..843fec3651e0 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -2872,12 +2872,10 @@ static int intel_psr_status(struct seq_file *m, struct intel_dp *intel_dp)
/*
* SKL+ Perf counter is reset to 0 everytime DC state is entered
*/
- if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv)) {
- val = intel_de_read(dev_priv,
- EDP_PSR_PERF_CNT(intel_dp->psr.transcoder));
- seq_printf(m, "Performance counter: %u\n",
- REG_FIELD_GET(EDP_PSR_PERF_CNT_MASK, val));
- }
+ val = intel_de_read(dev_priv,
+ EDP_PSR_PERF_CNT(intel_dp->psr.transcoder));
+ seq_printf(m, "Performance counter: %u\n",
+ REG_FIELD_GET(EDP_PSR_PERF_CNT_MASK, val));
if (psr->debug & I915_PSR_DEBUG_IRQ) {
seq_printf(m, "Last attempted entry at: %lld\n",
--
2.39.2
next prev parent reply other threads:[~2023-04-11 19:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 19:14 [Intel-gfx] [PATCH v2 0/8] drm/i915: (mostly) PSR related register cleanups Ville Syrjala
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 1/8] drm/i915: Fix up whitespace in some display chicken registers Ville Syrjala
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 2/8] drm/i915: Clean up various " Ville Syrjala
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 3/8] drm/i915/psr: Clean up PSR register defininitions Ville Syrjala
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 4/8] drm/i915/psr: Use intel_de_rmw() Ville Syrjala
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 5/8] drm/i915/psr: Define more PSR mask bits Ville Syrjala
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 6/8] drm/i915/psr: Add a FIXME for the PSR vs. AUX usage conflict Ville Syrjala
2023-04-11 19:14 ` Ville Syrjala [this message]
2023-04-11 19:14 ` [Intel-gfx] [PATCH v2 8/8] drm/i915/psr: Sprinkle cpu_transcoder variables around Ville Syrjala
2023-04-12 0:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: (mostly) PSR related register cleanups (rev3) Patchwork
2023-04-12 0:51 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-04-12 1:05 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-04-12 8:18 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: (mostly) PSR related register cleanups (rev4) Patchwork
2023-04-12 8:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-04-12 8:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-04-12 15:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-04-20 8:07 ` [Intel-gfx] [PATCH v2 0/8] drm/i915: (mostly) PSR related register cleanups Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230411191429.29895-8-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox