Re: [Intel-gfx] [PATCH 3/5] drm/i915/display: Move display runtime info to display structure

[Matt Roper <matthew.d.roper@intel.com>]

On Thu, May 18, 2023 at 09:56:07AM +0200, Andrzej Hajda wrote:
> On 18.05.2023 05:18, Matt Roper wrote:
> > Move the runtime info specific to display into display-specific
> > structures as has already been done with the constant display info.
> > 
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> > ---
...
> > --- a/drivers/gpu/drm/i915/display/intel_display_device.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
> > @@ -29,7 +29,30 @@
> >   	func(overlay_needs_physical); \
> >   	func(supports_tv);
> > +struct intel_display_runtime_info {
> > +	struct {
> > +		u16 ver;
> > +		u16 rel;
> > +		u16 step;
> > +	} ip;
> 
> Why not intel_ip_version? Maybe upgrdaded to 16bit.

intel_ip_version is an i915-specific structure.  Part of the goal of
this series is to minimize the use of i915 types (aside from those that
are specific to display) so that the code can be more easily re-used in
Xe with a smaller compatibility layer.


Matt

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation