* [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size
@ 2023-05-22 20:17 Ashutosh Dixit
2023-05-22 21:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Ashutosh Dixit @ 2023-05-22 20:17 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel
Clearing out report id and timestamp as means to detect unlanded reports
only works if report size is power of 2. That is, only when report size is
a sub-multiple of the OA buffer size can we be certain that reports will
land at the same place each time in the OA buffer (after rewind). If report
size is not a power of 2, we need to zero out the entire report to be able
to detect unlanded reports reliably.
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
drivers/gpu/drm/i915/i915_perf.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 19d5652300eeb..58284156428dc 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -877,12 +877,17 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
stream->oa_buffer.last_ctx_id = ctx_id;
}
- /*
- * Clear out the report id and timestamp as a means to detect unlanded
- * reports.
- */
- oa_report_id_clear(stream, report32);
- oa_timestamp_clear(stream, report32);
+ if (is_power_of_2(report_size)) {
+ /*
+ * Clear out the report id and timestamp as a means
+ * to detect unlanded reports.
+ */
+ oa_report_id_clear(stream, report32);
+ oa_timestamp_clear(stream, report32);
+ } else {
+ /* Zero out the entire report */
+ memset(report32, 0, report_size);
+ }
}
if (start_offset != *offset) {
--
2.38.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/perf: Clear out entire reports after reading if not power of 2 size
2023-05-22 20:17 [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size Ashutosh Dixit
@ 2023-05-22 21:19 ` Patchwork
2023-05-22 21:34 ` [Intel-gfx] [PATCH] " Umesh Nerlige Ramappa
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-05-22 21:19 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9919 bytes --]
== Series Details ==
Series: drm/i915/perf: Clear out entire reports after reading if not power of 2 size
URL : https://patchwork.freedesktop.org/series/118151/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13175 -> Patchwork_118151v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_118151v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_118151v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/index.html
Participating hosts (39 -> 38)
------------------------------
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_118151v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@load:
- bat-adln-1: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/bat-adln-1/igt@i915_module_load@load.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-adln-1/igt@i915_module_load@load.html
Known issues
------------
Here are the changes found in Patchwork_118151v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_mmap@basic:
- bat-dg2-8: NOTRUN -> [SKIP][3] ([i915#4083])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@gem_mmap@basic.html
* igt@gem_mmap_gtt@basic:
- bat-dg2-8: NOTRUN -> [SKIP][4] ([i915#4077]) +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@gem_mmap_gtt@basic.html
* igt@gem_tiled_pread_basic:
- bat-dg2-8: NOTRUN -> [SKIP][5] ([i915#4079]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg2-8: NOTRUN -> [SKIP][6] ([i915#5354] / [i915#7561])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rps@basic-api:
- bat-dg2-8: NOTRUN -> [SKIP][7] ([i915#6621])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@i915_pm_rps@basic-api.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-dg2-8: NOTRUN -> [SKIP][8] ([i915#6645])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-dg2-8: NOTRUN -> [SKIP][9] ([i915#5190])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg2-8: NOTRUN -> [SKIP][10] ([i915#4215] / [i915#5190])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_addfb_basic@framebuffer-vs-set-tiling:
- bat-dg2-8: NOTRUN -> [SKIP][11] ([i915#4212]) +7 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- bat-dg2-8: NOTRUN -> [SKIP][12] ([i915#7828]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-dg2-8: NOTRUN -> [SKIP][13] ([i915#4103] / [i915#4213]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg2-8: NOTRUN -> [SKIP][14] ([fdo#109285])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-dg2-8: NOTRUN -> [SKIP][15] ([i915#5274])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_psr@cursor_plane_move:
- bat-dg2-8: NOTRUN -> [SKIP][16] ([i915#1072]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@kms_psr@cursor_plane_move.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg2-8: NOTRUN -> [SKIP][17] ([i915#3555] / [i915#4579])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-dg2-8: NOTRUN -> [SKIP][18] ([i915#3708])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-dg2-8: NOTRUN -> [SKIP][19] ([i915#3708] / [i915#4077]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-write:
- bat-dg2-8: NOTRUN -> [SKIP][20] ([i915#3291] / [i915#3708]) +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-dg2-8/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_mocs:
- {bat-mtlp-8}: [DMESG-FAIL][21] ([i915#7059]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: [DMESG-FAIL][23] ([i915#4258] / [i915#7913]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@migrate:
- bat-atsm-1: [DMESG-FAIL][25] ([i915#7699] / [i915#7913]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/bat-atsm-1/igt@i915_selftest@live@migrate.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-atsm-1/igt@i915_selftest@live@migrate.html
#### Warnings ####
* igt@kms_psr@primary_mmap_gtt:
- bat-rplp-1: [SKIP][27] ([i915#1072]) -> [ABORT][28] ([i915#8442])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#8189]: https://gitlab.freedesktop.org/drm/intel/issues/8189
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
Build changes
-------------
* Linux: CI_DRM_13175 -> Patchwork_118151v1
CI-20190529: 20190529
CI_DRM_13175: 4c702fe1c1be3fe0bb9de7143b9e2fa03a74a884 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7300: da81a90afee713460d783164f2456524623d3016 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118151v1: 4c702fe1c1be3fe0bb9de7143b9e2fa03a74a884 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
6c7f21980c2b drm/i915/perf: Clear out entire reports after reading if not power of 2 size
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v1/index.html
[-- Attachment #2: Type: text/html, Size: 11238 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size
2023-05-22 20:17 [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size Ashutosh Dixit
2023-05-22 21:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2023-05-22 21:34 ` Umesh Nerlige Ramappa
2023-05-22 21:50 ` Dixit, Ashutosh
2023-05-23 8:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev2) Patchwork
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Umesh Nerlige Ramappa @ 2023-05-22 21:34 UTC (permalink / raw)
To: Ashutosh Dixit; +Cc: intel-gfx, dri-devel
On Mon, May 22, 2023 at 01:17:49PM -0700, Ashutosh Dixit wrote:
>Clearing out report id and timestamp as means to detect unlanded reports
>only works if report size is power of 2. That is, only when report size is
>a sub-multiple of the OA buffer size can we be certain that reports will
>land at the same place each time in the OA buffer (after rewind). If report
>size is not a power of 2, we need to zero out the entire report to be able
>to detect unlanded reports reliably.
>
>Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>---
> drivers/gpu/drm/i915/i915_perf.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
>index 19d5652300eeb..58284156428dc 100644
>--- a/drivers/gpu/drm/i915/i915_perf.c
>+++ b/drivers/gpu/drm/i915/i915_perf.c
>@@ -877,12 +877,17 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
> stream->oa_buffer.last_ctx_id = ctx_id;
> }
>
>- /*
>- * Clear out the report id and timestamp as a means to detect unlanded
>- * reports.
>- */
>- oa_report_id_clear(stream, report32);
>- oa_timestamp_clear(stream, report32);
>+ if (is_power_of_2(report_size)) {
>+ /*
>+ * Clear out the report id and timestamp as a means
>+ * to detect unlanded reports.
>+ */
>+ oa_report_id_clear(stream, report32);
>+ oa_timestamp_clear(stream, report32);
>+ } else {
>+ /* Zero out the entire report */
>+ memset(report32, 0, report_size);
Indeed, this was a bug. For a minute, I started wondering if this is the
issue I am running into with the other patch posted for DG2, but then I
see the issue within the first fill of the OA buffer where chunks of the
reports are zeroed out, so this is a new issue.
lgtm,
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Thanks,
Umesh
>+ }
> }
>
> if (start_offset != *offset) {
>--
>2.38.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size
2023-05-22 21:34 ` [Intel-gfx] [PATCH] " Umesh Nerlige Ramappa
@ 2023-05-22 21:50 ` Dixit, Ashutosh
2023-05-23 17:50 ` Umesh Nerlige Ramappa
0 siblings, 1 reply; 9+ messages in thread
From: Dixit, Ashutosh @ 2023-05-22 21:50 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: intel-gfx, dri-devel
On Mon, 22 May 2023 14:34:18 -0700, Umesh Nerlige Ramappa wrote:
>
> On Mon, May 22, 2023 at 01:17:49PM -0700, Ashutosh Dixit wrote:
> > Clearing out report id and timestamp as means to detect unlanded reports
> > only works if report size is power of 2. That is, only when report size is
> > a sub-multiple of the OA buffer size can we be certain that reports will
> > land at the same place each time in the OA buffer (after rewind). If report
> > size is not a power of 2, we need to zero out the entire report to be able
> > to detect unlanded reports reliably.
> >
> > Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_perf.c | 17 +++++++++++------
> > 1 file changed, 11 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> > index 19d5652300eeb..58284156428dc 100644
> > --- a/drivers/gpu/drm/i915/i915_perf.c
> > +++ b/drivers/gpu/drm/i915/i915_perf.c
> > @@ -877,12 +877,17 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
> > stream->oa_buffer.last_ctx_id = ctx_id;
> > }
> >
> > - /*
> > - * Clear out the report id and timestamp as a means to detect unlanded
> > - * reports.
> > - */
> > - oa_report_id_clear(stream, report32);
> > - oa_timestamp_clear(stream, report32);
> > + if (is_power_of_2(report_size)) {
> > + /*
> > + * Clear out the report id and timestamp as a means
> > + * to detect unlanded reports.
> > + */
> > + oa_report_id_clear(stream, report32);
> > + oa_timestamp_clear(stream, report32);
> > + } else {
> > + /* Zero out the entire report */
> > + memset(report32, 0, report_size);
>
> Indeed, this was a bug. For a minute, I started wondering if this is the
> issue I am running into with the other patch posted for DG2, but then I see
> the issue within the first fill of the OA buffer where chunks of the
> reports are zeroed out, so this is a new issue.
Yes I saw this while reviewing your patch. And also I thought your issue
was happening on DG2 with power of 2 report size, only on MTL OAM we
introduce non power of 2 report size.
> lgtm,
>
> Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Thanks.
--
Ashutosh
>
> > + }
> > }
> >
> > if (start_offset != *offset) {
> > --
> > 2.38.0
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev2)
2023-05-22 20:17 [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size Ashutosh Dixit
2023-05-22 21:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-05-22 21:34 ` [Intel-gfx] [PATCH] " Umesh Nerlige Ramappa
@ 2023-05-23 8:32 ` Patchwork
2023-05-23 10:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-05-23 14:31 ` [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size Lionel Landwerlin
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-05-23 8:32 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10047 bytes --]
== Series Details ==
Series: drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev2)
URL : https://patchwork.freedesktop.org/series/118151/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13175 -> Patchwork_118151v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/index.html
Participating hosts (39 -> 37)
------------------------------
Missing (2): fi-snb-2520m bat-mtlp-6
Known issues
------------
Here are the changes found in Patchwork_118151v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@dmabuf@all-tests@dma_fence:
- bat-adlp-9: [PASS][1] -> [DMESG-FAIL][2] ([i915#8189])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/bat-adlp-9/igt@dmabuf@all-tests@dma_fence.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-adlp-9/igt@dmabuf@all-tests@dma_fence.html
* igt@dmabuf@all-tests@sanitycheck:
- bat-adlp-9: [PASS][3] -> [ABORT][4] ([i915#7699])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/bat-adlp-9/igt@dmabuf@all-tests@sanitycheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-adlp-9/igt@dmabuf@all-tests@sanitycheck.html
* igt@gem_mmap@basic:
- bat-dg2-8: NOTRUN -> [SKIP][5] ([i915#4083])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@gem_mmap@basic.html
* igt@gem_mmap_gtt@basic:
- bat-dg2-8: NOTRUN -> [SKIP][6] ([i915#4077]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@gem_mmap_gtt@basic.html
* igt@gem_tiled_pread_basic:
- bat-dg2-8: NOTRUN -> [SKIP][7] ([i915#4079]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg2-8: NOTRUN -> [SKIP][8] ([i915#5354] / [i915#7561])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rps@basic-api:
- bat-dg2-8: NOTRUN -> [SKIP][9] ([i915#6621])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@workarounds:
- bat-adlm-1: [PASS][10] -> [DMESG-FAIL][11] ([i915#7904])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/bat-adlm-1/igt@i915_selftest@live@workarounds.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-adlm-1/igt@i915_selftest@live@workarounds.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-dg2-8: NOTRUN -> [SKIP][12] ([i915#6645])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-dg2-8: NOTRUN -> [SKIP][13] ([i915#5190])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg2-8: NOTRUN -> [SKIP][14] ([i915#4215] / [i915#5190])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_addfb_basic@framebuffer-vs-set-tiling:
- bat-dg2-8: NOTRUN -> [SKIP][15] ([i915#4212]) +7 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- bat-dg2-8: NOTRUN -> [SKIP][16] ([i915#7828]) +8 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-dg2-8: NOTRUN -> [SKIP][17] ([i915#4103] / [i915#4213]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg2-8: NOTRUN -> [SKIP][18] ([fdo#109285])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-dg2-8: NOTRUN -> [SKIP][19] ([i915#5274])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck@pipe-d-dp-1:
- bat-dg2-8: NOTRUN -> [FAIL][20] ([i915#7932]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@kms_pipe_crc_basic@compare-crc-sanitycheck@pipe-d-dp-1.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][21] ([i915#1845] / [i915#5354]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
* igt@kms_psr@cursor_plane_move:
- bat-dg2-8: NOTRUN -> [SKIP][22] ([i915#1072]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@kms_psr@cursor_plane_move.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg2-8: NOTRUN -> [SKIP][23] ([i915#3555] / [i915#4579])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-dg2-8: NOTRUN -> [SKIP][24] ([i915#3708])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-dg2-8: NOTRUN -> [SKIP][25] ([i915#3708] / [i915#4077]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-write:
- bat-dg2-8: NOTRUN -> [SKIP][26] ([i915#3291] / [i915#3708]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-dg2-8/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: [DMESG-FAIL][27] ([i915#4258] / [i915#7913]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@migrate:
- bat-atsm-1: [DMESG-FAIL][29] ([i915#7699] / [i915#7913]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/bat-atsm-1/igt@i915_selftest@live@migrate.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/bat-atsm-1/igt@i915_selftest@live@migrate.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7904]: https://gitlab.freedesktop.org/drm/intel/issues/7904
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#8189]: https://gitlab.freedesktop.org/drm/intel/issues/8189
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
Build changes
-------------
* Linux: CI_DRM_13175 -> Patchwork_118151v2
CI-20190529: 20190529
CI_DRM_13175: 4c702fe1c1be3fe0bb9de7143b9e2fa03a74a884 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7300: da81a90afee713460d783164f2456524623d3016 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118151v2: 4c702fe1c1be3fe0bb9de7143b9e2fa03a74a884 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
2f70a065f750 drm/i915/perf: Clear out entire reports after reading if not power of 2 size
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/index.html
[-- Attachment #2: Type: text/html, Size: 11613 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev2)
2023-05-22 20:17 [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size Ashutosh Dixit
` (2 preceding siblings ...)
2023-05-23 8:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev2) Patchwork
@ 2023-05-23 10:21 ` Patchwork
2023-05-23 14:31 ` [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size Lionel Landwerlin
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-05-23 10:21 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 15633 bytes --]
== Series Details ==
Series: drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev2)
URL : https://patchwork.freedesktop.org/series/118151/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13175_full -> Patchwork_118151v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (7 -> 8)
------------------------------
Additional (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_118151v2_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_whisper@basic-fds-priority:
- {shard-dg1}: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-dg1-18/igt@gem_exec_whisper@basic-fds-priority.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-dg1-17/igt@gem_exec_whisper@basic-fds-priority.html
Known issues
------------
Here are the changes found in Patchwork_118151v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_mm@all-tests:
- shard-apl: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4579]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-apl4/igt@drm_mm@all-tests.html
* igt@gem_close_race@multigpu-basic-process:
- shard-apl: NOTRUN -> [SKIP][4] ([fdo#109271]) +21 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-apl4/igt@gem_close_race@multigpu-basic-process.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-apl4/igt@gem_huc_copy@huc-copy.html
* igt@kms_cursor_crc@cursor-sliding-256x85@pipe-a-hdmi-a-1:
- shard-glk: [PASS][6] -> [DMESG-FAIL][7] ([i915#118])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-glk8/igt@kms_cursor_crc@cursor-sliding-256x85@pipe-a-hdmi-a-1.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-glk8/igt@kms_cursor_crc@cursor-sliding-256x85@pipe-a-hdmi-a-1.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][8] -> [FAIL][9] ([IGT#6] / [i915#2346]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-render:
- shard-apl: NOTRUN -> [SKIP][10] ([IGT#6] / [fdo#109271]) +17 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-apl4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-render.html
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4579]) +12 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-snb4/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-b-vga-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-0-25@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][12] ([fdo#109271]) +20 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-snb1/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-0-25@pipe-a-hdmi-a-1.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][13] ([i915#7742]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-rkl-2/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@gem_eio@hibernate:
- {shard-dg1}: [ABORT][15] ([i915#4391] / [i915#7975] / [i915#8213]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-dg1-14/igt@gem_eio@hibernate.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-dg1-17/igt@gem_eio@hibernate.html
* igt@gem_exec_fair@basic-flow@rcs0:
- {shard-rkl}: [FAIL][17] ([i915#2842]) -> [PASS][18] +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-rkl-6/igt@gem_exec_fair@basic-flow@rcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-rkl-6/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@i915_pm_rpm@modeset-lpsp:
- {shard-rkl}: [SKIP][19] ([i915#1397]) -> [PASS][20] +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-rkl-2/igt@i915_pm_rpm@modeset-lpsp.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp.html
* igt@kms_flip@plain-flip-ts-check-interruptible@a-hdmi-a1:
- shard-glk: [FAIL][21] ([i915#2122]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-glk6/igt@kms_flip@plain-flip-ts-check-interruptible@a-hdmi-a1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-glk1/igt@kms_flip@plain-flip-ts-check-interruptible@a-hdmi-a1.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-apl: [ABORT][23] ([i915#180]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
#### Warnings ####
* igt@kms_content_protection@lic:
- shard-glk: [SKIP][25] ([fdo#109271] / [i915#4579]) -> [SKIP][26] ([IGT#6] / [fdo#109271] / [i915#4579]) +24 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-glk4/igt@kms_content_protection@lic.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-glk5/igt@kms_content_protection@lic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][27] ([i915#2346]) -> [FAIL][28] ([IGT#6] / [i915#2346]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-glk: [FAIL][29] ([i915#4767]) -> [FAIL][30] ([IGT#6] / [i915#4767])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-glk4/igt@kms_fbcon_fbt@fbc-suspend.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-glk3/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1:
- shard-apl: [FAIL][31] ([i915#7862]) -> [FAIL][32] ([IGT#6] / [i915#7862])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-apl3/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-apl4/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-apl: [SKIP][33] ([fdo#109271]) -> [SKIP][34] ([IGT#6] / [fdo#109271]) +538 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-apl2/igt@kms_psr@psr2_sprite_plane_onoff.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-apl3/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_vblank@pipe-d-wait-busy-hang:
- shard-glk: [SKIP][35] ([fdo#109271]) -> [SKIP][36] ([IGT#6] / [fdo#109271]) +404 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-glk7/igt@kms_vblank@pipe-d-wait-busy-hang.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-glk6/igt@kms_vblank@pipe-d-wait-busy-hang.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: [SKIP][37] ([fdo#109271] / [i915#533]) -> [SKIP][38] ([IGT#6] / [fdo#109271] / [i915#533])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-apl4/igt@kms_vblank@pipe-d-wait-idle.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-apl6/igt@kms_vblank@pipe-d-wait-idle.html
- shard-glk: [SKIP][39] ([fdo#109271] / [i915#533]) -> [SKIP][40] ([IGT#6] / [fdo#109271] / [i915#533])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-glk6/igt@kms_vblank@pipe-d-wait-idle.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-glk1/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_vrr@flip-suspend:
- shard-apl: [SKIP][41] ([fdo#109271] / [i915#4579]) -> [SKIP][42] ([IGT#6] / [fdo#109271] / [i915#4579]) +18 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13175/shard-apl1/igt@kms_vrr@flip-suspend.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/shard-apl3/igt@kms_vrr@flip-suspend.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7862]: https://gitlab.freedesktop.org/drm/intel/issues/7862
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381
Build changes
-------------
* Linux: CI_DRM_13175 -> Patchwork_118151v2
CI-20190529: 20190529
CI_DRM_13175: 4c702fe1c1be3fe0bb9de7143b9e2fa03a74a884 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7300: da81a90afee713460d783164f2456524623d3016 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118151v2: 4c702fe1c1be3fe0bb9de7143b9e2fa03a74a884 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118151v2/index.html
[-- Attachment #2: Type: text/html, Size: 15351 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size
2023-05-22 20:17 [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size Ashutosh Dixit
` (3 preceding siblings ...)
2023-05-23 10:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2023-05-23 14:31 ` Lionel Landwerlin
4 siblings, 0 replies; 9+ messages in thread
From: Lionel Landwerlin @ 2023-05-23 14:31 UTC (permalink / raw)
To: Ashutosh Dixit, intel-gfx; +Cc: dri-devel
On 22/05/2023 23:17, Ashutosh Dixit wrote:
> Clearing out report id and timestamp as means to detect unlanded reports
> only works if report size is power of 2. That is, only when report size is
> a sub-multiple of the OA buffer size can we be certain that reports will
> land at the same place each time in the OA buffer (after rewind). If report
> size is not a power of 2, we need to zero out the entire report to be able
> to detect unlanded reports reliably.
>
> Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Sad but necessary unfortunately....
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
> drivers/gpu/drm/i915/i915_perf.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 19d5652300eeb..58284156428dc 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -877,12 +877,17 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
> stream->oa_buffer.last_ctx_id = ctx_id;
> }
>
> - /*
> - * Clear out the report id and timestamp as a means to detect unlanded
> - * reports.
> - */
> - oa_report_id_clear(stream, report32);
> - oa_timestamp_clear(stream, report32);
> + if (is_power_of_2(report_size)) {
> + /*
> + * Clear out the report id and timestamp as a means
> + * to detect unlanded reports.
> + */
> + oa_report_id_clear(stream, report32);
> + oa_timestamp_clear(stream, report32);
> + } else {
> + /* Zero out the entire report */
> + memset(report32, 0, report_size);
> + }
> }
>
> if (start_offset != *offset) {
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size
2023-05-22 21:50 ` Dixit, Ashutosh
@ 2023-05-23 17:50 ` Umesh Nerlige Ramappa
0 siblings, 0 replies; 9+ messages in thread
From: Umesh Nerlige Ramappa @ 2023-05-23 17:50 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx, dri-devel
On Mon, May 22, 2023 at 02:50:51PM -0700, Dixit, Ashutosh wrote:
>On Mon, 22 May 2023 14:34:18 -0700, Umesh Nerlige Ramappa wrote:
>>
>> On Mon, May 22, 2023 at 01:17:49PM -0700, Ashutosh Dixit wrote:
>> > Clearing out report id and timestamp as means to detect unlanded reports
>> > only works if report size is power of 2. That is, only when report size is
>> > a sub-multiple of the OA buffer size can we be certain that reports will
>> > land at the same place each time in the OA buffer (after rewind). If report
>> > size is not a power of 2, we need to zero out the entire report to be able
>> > to detect unlanded reports reliably.
>> >
>> > Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>> > ---
>> > drivers/gpu/drm/i915/i915_perf.c | 17 +++++++++++------
>> > 1 file changed, 11 insertions(+), 6 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
>> > index 19d5652300eeb..58284156428dc 100644
>> > --- a/drivers/gpu/drm/i915/i915_perf.c
>> > +++ b/drivers/gpu/drm/i915/i915_perf.c
>> > @@ -877,12 +877,17 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
>> > stream->oa_buffer.last_ctx_id = ctx_id;
>> > }
>> >
>> > - /*
>> > - * Clear out the report id and timestamp as a means to detect unlanded
>> > - * reports.
>> > - */
>> > - oa_report_id_clear(stream, report32);
>> > - oa_timestamp_clear(stream, report32);
>> > + if (is_power_of_2(report_size)) {
>> > + /*
>> > + * Clear out the report id and timestamp as a means
>> > + * to detect unlanded reports.
>> > + */
>> > + oa_report_id_clear(stream, report32);
>> > + oa_timestamp_clear(stream, report32);
>> > + } else {
>> > + /* Zero out the entire report */
>> > + memset(report32, 0, report_size);
>>
>> Indeed, this was a bug. For a minute, I started wondering if this is the
>> issue I am running into with the other patch posted for DG2, but then I see
>> the issue within the first fill of the OA buffer where chunks of the
>> reports are zeroed out, so this is a new issue.
>
>Yes I saw this while reviewing your patch. And also I thought your issue
>was happening on DG2 with power of 2 report size, only on MTL OAM we
>introduce non power of 2 report size.
>
>> lgtm,
>>
>> Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Maybe this should include Fixes: tag pointing to the patch that
introduced the OAM non-power-of-2 format.
Umesh
>
>Thanks.
>--
>Ashutosh
>
>>
>> > + }
>> > }
>> >
>> > if (start_offset != *offset) {
>> > --
>> > 2.38.0
>> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size
@ 2023-05-23 20:40 Ashutosh Dixit
0 siblings, 0 replies; 9+ messages in thread
From: Ashutosh Dixit @ 2023-05-23 20:40 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel
Clearing out report id and timestamp as means to detect unlanded reports
only works if report size is power of 2. That is, only when report size is
a sub-multiple of the OA buffer size can we be certain that reports will
land at the same place each time in the OA buffer (after rewind). If report
size is not a power of 2, we need to zero out the entire report to be able
to detect unlanded reports reliably.
v2: Add Fixes tag (Umesh)
Fixes: 1cc064dce4ed ("drm/i915/perf: Add support for OA media units")
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
drivers/gpu/drm/i915/i915_perf.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 19d5652300eeb..58284156428dc 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -877,12 +877,17 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
stream->oa_buffer.last_ctx_id = ctx_id;
}
- /*
- * Clear out the report id and timestamp as a means to detect unlanded
- * reports.
- */
- oa_report_id_clear(stream, report32);
- oa_timestamp_clear(stream, report32);
+ if (is_power_of_2(report_size)) {
+ /*
+ * Clear out the report id and timestamp as a means
+ * to detect unlanded reports.
+ */
+ oa_report_id_clear(stream, report32);
+ oa_timestamp_clear(stream, report32);
+ } else {
+ /* Zero out the entire report */
+ memset(report32, 0, report_size);
+ }
}
if (start_offset != *offset) {
--
2.38.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-05-23 20:40 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-22 20:17 [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size Ashutosh Dixit
2023-05-22 21:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-05-22 21:34 ` [Intel-gfx] [PATCH] " Umesh Nerlige Ramappa
2023-05-22 21:50 ` Dixit, Ashutosh
2023-05-23 17:50 ` Umesh Nerlige Ramappa
2023-05-23 8:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Clear out entire reports after reading if not power of 2 size (rev2) Patchwork
2023-05-23 10:21 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-05-23 14:31 ` [Intel-gfx] [PATCH] drm/i915/perf: Clear out entire reports after reading if not power of 2 size Lionel Landwerlin
-- strict thread matches above, loose matches on Subject: below --
2023-05-23 20:40 Ashutosh Dixit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox