From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner
Date: Thu, 25 May 2023 13:10:36 +0300 [thread overview]
Message-ID: <20230525101036.21564-1-stanislav.lisovskiy@intel.com> (raw)
According to BSpec 49190, when enabling crtcs, we first setup
slave and then master crtc, however for disabling it should go
vice versa, i.e first master, then slave, however current code
does disabling in a same way as enabling. Fix this, by skipping
non-master crtcs, instead of non-slaves.
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 0490c6412ab5..68958ba0ef49 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -6662,7 +6662,7 @@ static void intel_commit_modeset_disables(struct intel_atomic_state *state)
*/
if (!is_trans_port_sync_slave(old_crtc_state) &&
!intel_dp_mst_is_slave_trans(old_crtc_state) &&
- !intel_crtc_is_bigjoiner_slave(old_crtc_state))
+ !intel_crtc_is_bigjoiner_master(old_crtc_state))
continue;
intel_old_crtc_state_disables(state, old_crtc_state,
--
2.37.3
next reply other threads:[~2023-05-25 10:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 10:10 Stanislav Lisovskiy [this message]
2023-05-25 19:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix the disabling sequence for Bigjoiner Patchwork
2023-05-26 4:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-07-05 13:26 ` [Intel-gfx] [PATCH] " Luca Coelho
2023-07-05 15:32 ` Imre Deak
2023-07-06 8:24 ` Lisovskiy, Stanislav
2023-07-06 8:47 ` Imre Deak
2023-07-06 8:50 ` Lisovskiy, Stanislav
2023-07-06 10:32 ` Lisovskiy, Stanislav
2023-07-06 18:02 ` Ville Syrjälä
2023-07-07 9:53 ` Lisovskiy, Stanislav
2023-07-06 8:33 ` Lisovskiy, Stanislav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525101036.21564-1-stanislav.lisovskiy@intel.com \
--to=stanislav.lisovskiy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox