public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Sui Jingfeng <15330273260@189.cn>
Cc: Somalapuram Amaranath <Amaranath.Somalapuram@amd.com>,
	Karol Herbst <kherbst@redhat.com>,
	nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	YiPeng Chai <YiPeng.Chai@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Sui Jingfeng <suijingfeng@loongson.cn>,
	David Airlie <airlied@gmail.com>, Yi Liu <yi.l.liu@intel.com>,
	kvm@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	Jason Gunthorpe <jgg@ziepe.ca>, Ben Skeggs <bskeggs@redhat.com>,
	linux-pci@vger.kernel.org,
	Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Lijo Lazar <lijo.lazar@amd.com>, Daniel Vetter <daniel@ffwll.ch>,
	Bokun Zhang <Bokun.Zhang@amd.com>,
	intel-gfx@lists.freedesktop.org,
	Maxime Ripard <mripard@kernel.org>,
	loongson-kernel@lists.loongnix.cn,
	Abhishek Sahu <abhsahu@nvidia.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Yishai Hadas <yishaih@nvidia.com>, Li Yi <liyi@loongson.cn>,
	Pan Xinhui <Xinhui.Pan@amd.com>,
	linux-kernel@vger.kernel.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Cornelia Huck <cohuck@redhat.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Christian Konig <christian.koenig@amd.com>,
	Hawking Zhang <Hawking.Zhang@amd.com>
Subject: Re: [Intel-gfx] [PATCH v3 1/4] PCI/VGA: tidy up the code and comment format
Date: Thu, 8 Jun 2023 14:07:30 -0500	[thread overview]
Message-ID: <20230608190730.GA1209607@bhelgaas> (raw)
In-Reply-To: <20230608114322.604887-2-15330273260@189.cn>

Capitalize subject to match ("Tidy ...")

On Thu, Jun 08, 2023 at 07:43:19PM +0800, Sui Jingfeng wrote:
> From: Sui Jingfeng <suijingfeng@loongson.cn>
> 
> This patch replaces the leading space with a tab and removes the double
> blank line, no functional change.

Can you move this to the end of the series?  The functional changes
are more likely to be backported, and I think the backport may be a
little easier without the cleanup in the middle.

>  	/* we could in theory hand out locks on IO and mem
> -	 * separately to userspace but it can cause deadlocks */
> +	 * separately to userspace but it can cause deadlocks
> +	 */

Since you're touching this anyway, can you update it to the
conventional multi-line comment style:

  /*
   * We could in theory ...
   */

And capitalize "We", add a period at end, and rewrap to fill 78
columns or so?  Same for other comments below.

> +++ b/include/linux/vgaarb.h
> @@ -23,9 +23,7 @@
>   * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>   * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
>   * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> - * DEALINGS
> - * IN THE SOFTWARE.
> - *
> + * DEALINGS IN THE SOFTWARE.
>   */

Can you make a separate patch to replace this entire copyright notice
with the appropriate SPDX-License-Identifier header?
Documentation/process/license-rules.rst has details.

Bjorn

  reply	other threads:[~2023-06-08 19:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 11:43 [Intel-gfx] [PATCH v3 0/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register Sui Jingfeng
2023-06-08 11:43 ` [Intel-gfx] [PATCH v3 1/4] PCI/VGA: tidy up the code and comment format Sui Jingfeng
2023-06-08 19:07   ` Bjorn Helgaas [this message]
2023-06-09  1:54     ` Sui Jingfeng
2023-06-08 11:43 ` [Intel-gfx] [PATCH v3 2/4] PCI/VGA: Use unsigned type for the io_state variable Sui Jingfeng
2023-06-08 11:43 ` [Intel-gfx] [PATCH v3 3/4] PCI/VGA: only deal with VGA class devices Sui Jingfeng
2023-06-08 19:12   ` Bjorn Helgaas
2023-06-09  2:11     ` Sui Jingfeng
2023-06-09 12:22     ` Sui Jingfeng
2023-06-08 11:43 ` [Intel-gfx] [PATCH v3 4/4] PCI/VGA: introduce is_boot_device function callback to vga_client_register Sui Jingfeng
2023-06-08 19:19   ` Bjorn Helgaas
2023-06-09  2:27     ` Sui Jingfeng
2023-06-09 16:48       ` Bjorn Helgaas
2023-06-09 17:43         ` Sui Jingfeng
2023-06-08 15:57 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230608190730.GA1209607@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=15330273260@189.cn \
    --cc=Amaranath.Somalapuram@amd.com \
    --cc=Bokun.Zhang@amd.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=YiPeng.Chai@amd.com \
    --cc=abhsahu@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrey.grodzovsky@amd.com \
    --cc=bhelgaas@google.com \
    --cc=bskeggs@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=cohuck@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jgg@ziepe.ca \
    --cc=kevin.tian@intel.com \
    --cc=kherbst@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lijo.lazar@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=liyi@loongson.cn \
    --cc=loongson-kernel@lists.loongnix.cn \
    --cc=mario.limonciello@amd.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=suijingfeng@loongson.cn \
    --cc=tzimmermann@suse.de \
    --cc=yi.l.liu@intel.com \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox