From: Zhanjun Dong <zhanjun.dong@intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting
Date: Thu, 22 Jun 2023 08:26:44 -0700 [thread overview]
Message-ID: <20230622152644.169400-1-zhanjun.dong@intel.com> (raw)
The previouse i915_gem_object_create_internal already set it with proper
value before function return. This hard coded setting is incorrect for
platforms like MTL, thus need to be removed.
Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
---
drivers/gpu/drm/i915/gt/intel_timeline.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c
index b9640212d659..693d18e14b00 100644
--- a/drivers/gpu/drm/i915/gt/intel_timeline.c
+++ b/drivers/gpu/drm/i915/gt/intel_timeline.c
@@ -26,8 +26,6 @@ static struct i915_vma *hwsp_alloc(struct intel_gt *gt)
if (IS_ERR(obj))
return ERR_CAST(obj);
- i915_gem_object_set_cache_coherency(obj, I915_CACHE_LLC);
-
vma = i915_vma_instance(obj, >->ggtt->vm, NULL);
if (IS_ERR(vma))
i915_gem_object_put(obj);
--
2.34.1
next reply other threads:[~2023-06-22 15:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 15:26 Zhanjun Dong [this message]
2023-06-22 15:29 ` [Intel-gfx] [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting Dong, Zhanjun
2023-06-22 18:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Remove incorrect hard coded cache coherrency setting (rev2) Patchwork
2023-06-22 22:20 ` [Intel-gfx] [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting Yang, Fei
2023-06-23 18:02 ` Dong, Zhanjun
2023-06-23 7:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Remove incorrect hard coded cache coherrency setting (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-06-16 22:11 [Intel-gfx] [PATCH] drm/i915/gt: Remove incorrect hard coded cache coherrency setting Zhanjun Dong
2023-06-22 12:27 ` Nirmoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622152644.169400-1-zhanjun.dong@intel.com \
--to=zhanjun.dong@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox