* [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection
@ 2023-07-26 15:53 Jonathan Cavitt
2023-07-26 15:53 ` [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric Jonathan Cavitt
` (11 more replies)
0 siblings, 12 replies; 21+ messages in thread
From: Jonathan Cavitt @ 2023-07-26 15:53 UTC (permalink / raw)
To: intel-gfx
Cc: andi.shyti, chris.p.wilson, jonathan.cavitt, matthew.d.roper,
nirmoy.das
The object pin created for shmem_create_from_object is just a
single use mapping with the sole purpose of reading the contents
of the whole object in bulk. And the whole source object is also
even a throw-away. Ergo, the additional logic required by
i915_coherent_map_type can be safely dropped and simplified.
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
---
drivers/gpu/drm/i915/gt/shmem_utils.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/shmem_utils.c b/drivers/gpu/drm/i915/gt/shmem_utils.c
index 449c9ed44382..bccc3a1200bc 100644
--- a/drivers/gpu/drm/i915/gt/shmem_utils.c
+++ b/drivers/gpu/drm/i915/gt/shmem_utils.c
@@ -33,7 +33,6 @@ struct file *shmem_create_from_data(const char *name, void *data, size_t len)
struct file *shmem_create_from_object(struct drm_i915_gem_object *obj)
{
- struct drm_i915_private *i915 = to_i915(obj->base.dev);
enum i915_map_type map_type;
struct file *file;
void *ptr;
@@ -44,7 +43,7 @@ struct file *shmem_create_from_object(struct drm_i915_gem_object *obj)
return file;
}
- map_type = i915_coherent_map_type(i915, obj, true);
+ map_type = i915_gem_object_is_lmem(obj) ? I915_MAP_WC : I915_MAP_WB;
ptr = i915_gem_object_pin_map_unlocked(obj, map_type);
if (IS_ERR(ptr))
return ERR_CAST(ptr);
--
2.25.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric 2023-07-26 15:53 [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Jonathan Cavitt @ 2023-07-26 15:53 ` Jonathan Cavitt 2023-07-27 11:35 ` Tvrtko Ursulin ` (2 more replies) 2023-07-26 15:53 ` [Intel-gfx] [PATCH 3/3] drm/i915/gt: Apply workaround 22016122933 correctly Jonathan Cavitt ` (10 subsequent siblings) 11 siblings, 3 replies; 21+ messages in thread From: Jonathan Cavitt @ 2023-07-26 15:53 UTC (permalink / raw) To: intel-gfx Cc: andi.shyti, chris.p.wilson, jonathan.cavitt, matthew.d.roper, nirmoy.das Refactor i915_coherent_map_type to be GT-centric rather than device-centric. Each GT may require different coherency handling due to hardware workarounds. Since the function now takes a GT instead of the i915, the function is renamed and moved to the gt folder. Suggested-by: Matt Roper <matthew.d.roper@intel.com> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> --- drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 3 ++- drivers/gpu/drm/i915/gem/i915_gem_object.h | 4 ---- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 15 --------------- .../gpu/drm/i915/gem/selftests/i915_gem_migrate.c | 12 ++++++------ drivers/gpu/drm/i915/gt/intel_engine_pm.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt.h | 3 +++ drivers/gpu/drm/i915/gt/intel_gtt.c | 4 ++-- drivers/gpu/drm/i915/gt/intel_lrc.c | 2 +- drivers/gpu/drm/i915/gt/intel_ring.c | 3 ++- drivers/gpu/drm/i915/gt/selftest_context.c | 2 +- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 4 ++-- drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 3 +-- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c | 3 +-- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 3 ++- drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c | 3 ++- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 3 ++- drivers/gpu/drm/i915/selftests/igt_spinner.c | 2 +- 20 files changed, 46 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c index ad0405375881..d753db3eef15 100644 --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c @@ -6,6 +6,7 @@ #include <drm/i915_hdcp_interface.h> #include "gem/i915_gem_region.h" +#include "gt/intel_gt.h" #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h" #include "i915_drv.h" #include "i915_utils.h" @@ -632,7 +633,7 @@ static int intel_hdcp_gsc_initialize_message(struct drm_i915_private *i915, return PTR_ERR(obj); } - cmd_in = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); + cmd_in = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, true)); if (IS_ERR(cmd_in)) { drm_err(&i915->drm, "Failed to map gsc message page!\n"); err = PTR_ERR(cmd_in); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h index 884a17275b3a..0c695b4c129f 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h @@ -716,10 +716,6 @@ void *__must_check i915_gem_object_pin_map(struct drm_i915_gem_object *obj, void *__must_check i915_gem_object_pin_map_unlocked(struct drm_i915_gem_object *obj, enum i915_map_type type); -enum i915_map_type i915_coherent_map_type(struct drm_i915_private *i915, - struct drm_i915_gem_object *obj, - bool always_coherent); - void __i915_gem_object_flush_map(struct drm_i915_gem_object *obj, unsigned long offset, unsigned long size); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c index 89fc8ea6bcfc..6d262d269c71 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c @@ -465,21 +465,6 @@ void *i915_gem_object_pin_map_unlocked(struct drm_i915_gem_object *obj, return ret; } -enum i915_map_type i915_coherent_map_type(struct drm_i915_private *i915, - struct drm_i915_gem_object *obj, - bool always_coherent) -{ - /* - * Wa_22016122933: always return I915_MAP_WC for MTL - */ - if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(i915)) - return I915_MAP_WC; - if (HAS_LLC(i915) || always_coherent) - return I915_MAP_WB; - else - return I915_MAP_WC; -} - void __i915_gem_object_flush_map(struct drm_i915_gem_object *obj, unsigned long offset, unsigned long size) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c index a93a90b15907..d8f4a10d71de 100644 --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c @@ -13,12 +13,12 @@ #include "selftests/igt_spinner.h" static int igt_fill_check_buffer(struct drm_i915_gem_object *obj, + struct intel_gt *gt, bool fill) { - struct drm_i915_private *i915 = to_i915(obj->base.dev); unsigned int i, count = obj->base.size / sizeof(u32); enum i915_map_type map_type = - i915_coherent_map_type(i915, obj, false); + intel_gt_coherent_map_type(gt, obj, false); u32 *cur; int err = 0; @@ -66,7 +66,7 @@ static int igt_create_migrate(struct intel_gt *gt, enum intel_region_id src, if (err) continue; - err = igt_fill_check_buffer(obj, true); + err = igt_fill_check_buffer(obj, gt, true); if (err) continue; @@ -86,7 +86,7 @@ static int igt_create_migrate(struct intel_gt *gt, enum intel_region_id src, if (err) continue; - err = igt_fill_check_buffer(obj, false); + err = igt_fill_check_buffer(obj, gt, false); } i915_gem_object_put(obj); @@ -233,7 +233,7 @@ static int __igt_lmem_pages_migrate(struct intel_gt *gt, continue; if (!vma) { - err = igt_fill_check_buffer(obj, true); + err = igt_fill_check_buffer(obj, gt, true); if (err) continue; } @@ -276,7 +276,7 @@ static int __igt_lmem_pages_migrate(struct intel_gt *gt, if (err) goto out_unlock; } else { - err = igt_fill_check_buffer(obj, false); + err = igt_fill_check_buffer(obj, gt, false); } out_unlock: diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pm.c b/drivers/gpu/drm/i915/gt/intel_engine_pm.c index 21af0ec52223..b538b5c04948 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_pm.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_pm.c @@ -39,7 +39,7 @@ static void dbg_poison_ce(struct intel_context *ce) if (ce->state) { struct drm_i915_gem_object *obj = ce->state->obj; - int type = i915_coherent_map_type(ce->engine->i915, obj, true); + int type = intel_gt_coherent_map_type(ce->engine->gt, obj, true); void *map; if (!i915_gem_object_trylock(obj, NULL)) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c index 02886c1eb0f1..62eda0ab9bfc 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.c +++ b/drivers/gpu/drm/i915/gt/intel_gt.c @@ -1134,6 +1134,21 @@ void intel_gt_invalidate_tlb(struct intel_gt *gt, u32 seqno) } } +enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, + struct drm_i915_gem_object *obj, + bool always_coherent) +{ + /* + * Wa_22016122933: always return I915_MAP_WC for MTL + */ + if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(gt->i915)) + return I915_MAP_WC; + if (HAS_LLC(gt->i915) || always_coherent) + return I915_MAP_WB; + else + return I915_MAP_WC; +} + #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) #include "selftest_tlb.c" #endif diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h b/drivers/gpu/drm/i915/gt/intel_gt.h index d2f4fbde5f9f..adb442aaa522 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.h +++ b/drivers/gpu/drm/i915/gt/intel_gt.h @@ -119,4 +119,7 @@ static inline u32 intel_gt_next_invalidate_tlb_full(const struct intel_gt *gt) void intel_gt_invalidate_tlb(struct intel_gt *gt, u32 seqno); +enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, + struct drm_i915_gem_object *obj, + bool always_coherent); #endif /* __INTEL_GT_H__ */ diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/intel_gtt.c index 731d9f2bbc56..13944a14ea2d 100644 --- a/drivers/gpu/drm/i915/gt/intel_gtt.c +++ b/drivers/gpu/drm/i915/gt/intel_gtt.c @@ -89,7 +89,7 @@ int map_pt_dma(struct i915_address_space *vm, struct drm_i915_gem_object *obj) enum i915_map_type type; void *vaddr; - type = i915_coherent_map_type(vm->i915, obj, true); + type = intel_gt_coherent_map_type(vm->gt, obj, true); vaddr = i915_gem_object_pin_map_unlocked(obj, type); if (IS_ERR(vaddr)) return PTR_ERR(vaddr); @@ -103,7 +103,7 @@ int map_pt_dma_locked(struct i915_address_space *vm, struct drm_i915_gem_object enum i915_map_type type; void *vaddr; - type = i915_coherent_map_type(vm->i915, obj, true); + type = intel_gt_coherent_map_type(vm->gt, obj, true); vaddr = i915_gem_object_pin_map(obj, type); if (IS_ERR(vaddr)) return PTR_ERR(vaddr); diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index 119deb9f938c..1897cb5aa2a2 100644 --- a/drivers/gpu/drm/i915/gt/intel_lrc.c +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c @@ -1191,7 +1191,7 @@ lrc_pre_pin(struct intel_context *ce, GEM_BUG_ON(!i915_vma_is_pinned(ce->state)); *vaddr = i915_gem_object_pin_map(ce->state->obj, - i915_coherent_map_type(ce->engine->i915, + intel_gt_coherent_map_type(ce->engine->gt, ce->state->obj, false) | I915_MAP_OVERRIDE); diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c index fb99143be98e..59da4b7bd262 100644 --- a/drivers/gpu/drm/i915/gt/intel_ring.c +++ b/drivers/gpu/drm/i915/gt/intel_ring.c @@ -13,6 +13,7 @@ #include "intel_engine_regs.h" #include "intel_gpu_commands.h" #include "intel_ring.h" +#include "intel_gt.h" #include "intel_timeline.h" unsigned int intel_ring_update_space(struct intel_ring *ring) @@ -56,7 +57,7 @@ int intel_ring_pin(struct intel_ring *ring, struct i915_gem_ww_ctx *ww) if (i915_vma_is_map_and_fenceable(vma) && !HAS_LLC(vma->vm->i915)) { addr = (void __force *)i915_vma_pin_iomap(vma); } else { - int type = i915_coherent_map_type(vma->vm->i915, vma->obj, false); + int type = intel_gt_coherent_map_type(vma->vm->gt, vma->obj, false); addr = i915_gem_object_pin_map(vma->obj, type); } diff --git a/drivers/gpu/drm/i915/gt/selftest_context.c b/drivers/gpu/drm/i915/gt/selftest_context.c index 76fbae358072..afce036bcaa8 100644 --- a/drivers/gpu/drm/i915/gt/selftest_context.c +++ b/drivers/gpu/drm/i915/gt/selftest_context.c @@ -88,7 +88,7 @@ static int __live_context_size(struct intel_engine_cs *engine) goto err; vaddr = i915_gem_object_pin_map_unlocked(ce->state->obj, - i915_coherent_map_type(engine->i915, + intel_gt_coherent_map_type(engine->gt, ce->state->obj, false)); if (IS_ERR(vaddr)) { err = PTR_ERR(vaddr); diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c index 8b0d84f2aad2..0dd4d00ee894 100644 --- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c +++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c @@ -73,7 +73,7 @@ static int hang_init(struct hang *h, struct intel_gt *gt) h->seqno = memset(vaddr, 0xff, PAGE_SIZE); vaddr = i915_gem_object_pin_map_unlocked(h->obj, - i915_coherent_map_type(gt->i915, h->obj, false)); + intel_gt_coherent_map_type(gt, h->obj, false)); if (IS_ERR(vaddr)) { err = PTR_ERR(vaddr); goto err_unpin_hws; @@ -119,7 +119,7 @@ hang_create_request(struct hang *h, struct intel_engine_cs *engine) return ERR_CAST(obj); } - vaddr = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(gt->i915, obj, false)); + vaddr = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, false)); if (IS_ERR(vaddr)) { i915_gem_object_put(obj); i915_vm_put(vm); diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c index a78a3d2c2e16..bc883de02295 100644 --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c @@ -1292,7 +1292,7 @@ static int compare_isolation(struct intel_engine_cs *engine, } lrc = i915_gem_object_pin_map_unlocked(ce->state->obj, - i915_coherent_map_type(engine->i915, + intel_gt_coherent_map_type(engine->gt, ce->state->obj, false)); if (IS_ERR(lrc)) { diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c index ab1a456f833d..6efb86c93bfc 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c @@ -268,7 +268,6 @@ static int gsc_fw_load(struct intel_gsc_uc *gsc) static int gsc_fw_load_prepare(struct intel_gsc_uc *gsc) { struct intel_gt *gt = gsc_uc_to_gt(gsc); - struct drm_i915_private *i915 = gt->i915; void *src; if (!gsc->local) @@ -278,7 +277,7 @@ static int gsc_fw_load_prepare(struct intel_gsc_uc *gsc) return -ENOSPC; src = i915_gem_object_pin_map_unlocked(gsc->fw.obj, - i915_coherent_map_type(i915, gsc->fw.obj, true)); + intel_gt_coherent_map_type(gt, gsc->fw.obj, true)); if (IS_ERR(src)) return PTR_ERR(src); diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c index 2eb891b270ae..c0fa9d232205 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c @@ -792,7 +792,7 @@ int intel_guc_allocate_and_map_vma(struct intel_guc *guc, u32 size, return PTR_ERR(vma); vaddr = i915_gem_object_pin_map_unlocked(vma->obj, - i915_coherent_map_type(guc_to_gt(guc)->i915, + intel_gt_coherent_map_type(guc_to_gt(guc), vma->obj, true)); if (IS_ERR(vaddr)) { i915_vma_unpin_and_release(&vma, 0); diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c index 48f506a26e6d..b648238cc675 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c @@ -27,7 +27,6 @@ struct mtl_huc_auth_msg_out { int intel_huc_fw_auth_via_gsccs(struct intel_huc *huc) { struct intel_gt *gt = huc_to_gt(huc); - struct drm_i915_private *i915 = gt->i915; struct drm_i915_gem_object *obj; struct mtl_huc_auth_msg_in *msg_in; struct mtl_huc_auth_msg_out *msg_out; @@ -43,7 +42,7 @@ int intel_huc_fw_auth_via_gsccs(struct intel_huc *huc) pkt_offset = i915_ggtt_offset(huc->heci_pkt); pkt_vaddr = i915_gem_object_pin_map_unlocked(obj, - i915_coherent_map_type(i915, obj, true)); + intel_gt_coherent_map_type(gt, obj, true)); if (IS_ERR(pkt_vaddr)) return PTR_ERR(pkt_vaddr); diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c index 7aadad5639c3..fc0d05d2df59 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c @@ -11,6 +11,7 @@ #include <drm/drm_print.h> #include "gem/i915_gem_lmem.h" +#include "gt/intel_gt.h" #include "gt/intel_gt_print.h" #include "intel_gsc_binary_headers.h" #include "intel_gsc_fw.h" @@ -1213,7 +1214,7 @@ static int uc_fw_rsa_data_create(struct intel_uc_fw *uc_fw) return PTR_ERR(vma); vaddr = i915_gem_object_pin_map_unlocked(vma->obj, - i915_coherent_map_type(gt->i915, vma->obj, true)); + intel_gt_coherent_map_type(gt, vma->obj, true)); if (IS_ERR(vaddr)) { i915_vma_unpin_and_release(&vma, 0); err = PTR_ERR(vaddr); diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c index c7df47364013..2a600184a077 100644 --- a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c @@ -6,6 +6,7 @@ #include "gem/i915_gem_internal.h" #include "gt/intel_context.h" +#include "gt/intel_gt.h" #include "gt/uc/intel_gsc_fw.h" #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h" @@ -336,7 +337,7 @@ gsccs_create_buffer(struct intel_gt *gt, } /* return a virtual pointer */ - *map = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); + *map = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, true)); if (IS_ERR(*map)) { drm_err(&i915->drm, "Failed to map gsccs backend %s.\n", bufname); err = PTR_ERR(*map); diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c index 1ce07d7e8769..8e0b5d48ddf6 100644 --- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c @@ -11,6 +11,7 @@ #include "gem/i915_gem_lmem.h" #include "i915_drv.h" +#include "gt/intel_gt.h" #include "intel_pxp.h" #include "intel_pxp_cmd_interface_42.h" @@ -245,7 +246,7 @@ static int alloc_streaming_command(struct intel_pxp *pxp) } /* map the lmem into the virtual memory pointer */ - cmd = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); + cmd = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(pxp->ctrl_gt, obj, true)); if (IS_ERR(cmd)) { drm_err(&i915->drm, "Failed to map gsc message page!\n"); err = PTR_ERR(cmd); diff --git a/drivers/gpu/drm/i915/selftests/igt_spinner.c b/drivers/gpu/drm/i915/selftests/igt_spinner.c index 3c5e0952f1b8..0f064930ef11 100644 --- a/drivers/gpu/drm/i915/selftests/igt_spinner.c +++ b/drivers/gpu/drm/i915/selftests/igt_spinner.c @@ -97,7 +97,7 @@ int igt_spinner_pin(struct igt_spinner *spin, if (!spin->batch) { unsigned int mode; - mode = i915_coherent_map_type(spin->gt->i915, spin->obj, false); + mode = intel_gt_coherent_map_type(spin->gt, spin->obj, false); vaddr = igt_spinner_pin_obj(ce, ww, spin->obj, mode, &spin->batch_vma); if (IS_ERR(vaddr)) return PTR_ERR(vaddr); -- 2.25.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric 2023-07-26 15:53 ` [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric Jonathan Cavitt @ 2023-07-27 11:35 ` Tvrtko Ursulin 2023-07-28 1:34 ` Andi Shyti 2023-07-27 12:16 ` Andi Shyti 2023-08-01 14:32 ` Andi Shyti 2 siblings, 1 reply; 21+ messages in thread From: Tvrtko Ursulin @ 2023-07-27 11:35 UTC (permalink / raw) To: Jonathan Cavitt, intel-gfx Cc: matthew.d.roper, chris.p.wilson, andi.shyti, nirmoy.das On 26/07/2023 16:53, Jonathan Cavitt wrote: > Refactor i915_coherent_map_type to be GT-centric rather than > device-centric. Each GT may require different coherency > handling due to hardware workarounds. > > Since the function now takes a GT instead of the i915, the function is > renamed and moved to the gt folder. > > Suggested-by: Matt Roper <matthew.d.roper@intel.com> > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> Works for me, thanks! I'd only suggest people familiar with the GuC/HuC/PXP side of things have a look on whether all the object in those path are shared access (GPU and CPU) at runtime. Maybe some are one off too. But that can be done later too. Regards, Tvrtko > --- > drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 3 ++- > drivers/gpu/drm/i915/gem/i915_gem_object.h | 4 ---- > drivers/gpu/drm/i915/gem/i915_gem_pages.c | 15 --------------- > .../gpu/drm/i915/gem/selftests/i915_gem_migrate.c | 12 ++++++------ > drivers/gpu/drm/i915/gt/intel_engine_pm.c | 2 +- > drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++ > drivers/gpu/drm/i915/gt/intel_gt.h | 3 +++ > drivers/gpu/drm/i915/gt/intel_gtt.c | 4 ++-- > drivers/gpu/drm/i915/gt/intel_lrc.c | 2 +- > drivers/gpu/drm/i915/gt/intel_ring.c | 3 ++- > drivers/gpu/drm/i915/gt/selftest_context.c | 2 +- > drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 4 ++-- > drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- > drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 3 +-- > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +- > drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c | 3 +-- > drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 3 ++- > drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c | 3 ++- > drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 3 ++- > drivers/gpu/drm/i915/selftests/igt_spinner.c | 2 +- > 20 files changed, 46 insertions(+), 44 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c > index ad0405375881..d753db3eef15 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c > +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c > @@ -6,6 +6,7 @@ > #include <drm/i915_hdcp_interface.h> > > #include "gem/i915_gem_region.h" > +#include "gt/intel_gt.h" > #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h" > #include "i915_drv.h" > #include "i915_utils.h" > @@ -632,7 +633,7 @@ static int intel_hdcp_gsc_initialize_message(struct drm_i915_private *i915, > return PTR_ERR(obj); > } > > - cmd_in = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); > + cmd_in = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, true)); > if (IS_ERR(cmd_in)) { > drm_err(&i915->drm, "Failed to map gsc message page!\n"); > err = PTR_ERR(cmd_in); > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h > index 884a17275b3a..0c695b4c129f 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h > @@ -716,10 +716,6 @@ void *__must_check i915_gem_object_pin_map(struct drm_i915_gem_object *obj, > void *__must_check i915_gem_object_pin_map_unlocked(struct drm_i915_gem_object *obj, > enum i915_map_type type); > > -enum i915_map_type i915_coherent_map_type(struct drm_i915_private *i915, > - struct drm_i915_gem_object *obj, > - bool always_coherent); > - > void __i915_gem_object_flush_map(struct drm_i915_gem_object *obj, > unsigned long offset, > unsigned long size); > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c > index 89fc8ea6bcfc..6d262d269c71 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c > @@ -465,21 +465,6 @@ void *i915_gem_object_pin_map_unlocked(struct drm_i915_gem_object *obj, > return ret; > } > > -enum i915_map_type i915_coherent_map_type(struct drm_i915_private *i915, > - struct drm_i915_gem_object *obj, > - bool always_coherent) > -{ > - /* > - * Wa_22016122933: always return I915_MAP_WC for MTL > - */ > - if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(i915)) > - return I915_MAP_WC; > - if (HAS_LLC(i915) || always_coherent) > - return I915_MAP_WB; > - else > - return I915_MAP_WC; > -} > - > void __i915_gem_object_flush_map(struct drm_i915_gem_object *obj, > unsigned long offset, > unsigned long size) > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c > index a93a90b15907..d8f4a10d71de 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c > @@ -13,12 +13,12 @@ > #include "selftests/igt_spinner.h" > > static int igt_fill_check_buffer(struct drm_i915_gem_object *obj, > + struct intel_gt *gt, > bool fill) > { > - struct drm_i915_private *i915 = to_i915(obj->base.dev); > unsigned int i, count = obj->base.size / sizeof(u32); > enum i915_map_type map_type = > - i915_coherent_map_type(i915, obj, false); > + intel_gt_coherent_map_type(gt, obj, false); > u32 *cur; > int err = 0; > > @@ -66,7 +66,7 @@ static int igt_create_migrate(struct intel_gt *gt, enum intel_region_id src, > if (err) > continue; > > - err = igt_fill_check_buffer(obj, true); > + err = igt_fill_check_buffer(obj, gt, true); > if (err) > continue; > > @@ -86,7 +86,7 @@ static int igt_create_migrate(struct intel_gt *gt, enum intel_region_id src, > if (err) > continue; > > - err = igt_fill_check_buffer(obj, false); > + err = igt_fill_check_buffer(obj, gt, false); > } > i915_gem_object_put(obj); > > @@ -233,7 +233,7 @@ static int __igt_lmem_pages_migrate(struct intel_gt *gt, > continue; > > if (!vma) { > - err = igt_fill_check_buffer(obj, true); > + err = igt_fill_check_buffer(obj, gt, true); > if (err) > continue; > } > @@ -276,7 +276,7 @@ static int __igt_lmem_pages_migrate(struct intel_gt *gt, > if (err) > goto out_unlock; > } else { > - err = igt_fill_check_buffer(obj, false); > + err = igt_fill_check_buffer(obj, gt, false); > } > > out_unlock: > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pm.c b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > index 21af0ec52223..b538b5c04948 100644 > --- a/drivers/gpu/drm/i915/gt/intel_engine_pm.c > +++ b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > @@ -39,7 +39,7 @@ static void dbg_poison_ce(struct intel_context *ce) > > if (ce->state) { > struct drm_i915_gem_object *obj = ce->state->obj; > - int type = i915_coherent_map_type(ce->engine->i915, obj, true); > + int type = intel_gt_coherent_map_type(ce->engine->gt, obj, true); > void *map; > > if (!i915_gem_object_trylock(obj, NULL)) > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c > index 02886c1eb0f1..62eda0ab9bfc 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c > @@ -1134,6 +1134,21 @@ void intel_gt_invalidate_tlb(struct intel_gt *gt, u32 seqno) > } > } > > +enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, > + struct drm_i915_gem_object *obj, > + bool always_coherent) > +{ > + /* > + * Wa_22016122933: always return I915_MAP_WC for MTL > + */ > + if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(gt->i915)) > + return I915_MAP_WC; > + if (HAS_LLC(gt->i915) || always_coherent) > + return I915_MAP_WB; > + else > + return I915_MAP_WC; > +} > + > #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) > #include "selftest_tlb.c" > #endif > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h b/drivers/gpu/drm/i915/gt/intel_gt.h > index d2f4fbde5f9f..adb442aaa522 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt.h > +++ b/drivers/gpu/drm/i915/gt/intel_gt.h > @@ -119,4 +119,7 @@ static inline u32 intel_gt_next_invalidate_tlb_full(const struct intel_gt *gt) > > void intel_gt_invalidate_tlb(struct intel_gt *gt, u32 seqno); > > +enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, > + struct drm_i915_gem_object *obj, > + bool always_coherent); > #endif /* __INTEL_GT_H__ */ > diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/intel_gtt.c > index 731d9f2bbc56..13944a14ea2d 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gtt.c > +++ b/drivers/gpu/drm/i915/gt/intel_gtt.c > @@ -89,7 +89,7 @@ int map_pt_dma(struct i915_address_space *vm, struct drm_i915_gem_object *obj) > enum i915_map_type type; > void *vaddr; > > - type = i915_coherent_map_type(vm->i915, obj, true); > + type = intel_gt_coherent_map_type(vm->gt, obj, true); > vaddr = i915_gem_object_pin_map_unlocked(obj, type); > if (IS_ERR(vaddr)) > return PTR_ERR(vaddr); > @@ -103,7 +103,7 @@ int map_pt_dma_locked(struct i915_address_space *vm, struct drm_i915_gem_object > enum i915_map_type type; > void *vaddr; > > - type = i915_coherent_map_type(vm->i915, obj, true); > + type = intel_gt_coherent_map_type(vm->gt, obj, true); > vaddr = i915_gem_object_pin_map(obj, type); > if (IS_ERR(vaddr)) > return PTR_ERR(vaddr); > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > index 119deb9f938c..1897cb5aa2a2 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > @@ -1191,7 +1191,7 @@ lrc_pre_pin(struct intel_context *ce, > GEM_BUG_ON(!i915_vma_is_pinned(ce->state)); > > *vaddr = i915_gem_object_pin_map(ce->state->obj, > - i915_coherent_map_type(ce->engine->i915, > + intel_gt_coherent_map_type(ce->engine->gt, > ce->state->obj, > false) | > I915_MAP_OVERRIDE); > diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c > index fb99143be98e..59da4b7bd262 100644 > --- a/drivers/gpu/drm/i915/gt/intel_ring.c > +++ b/drivers/gpu/drm/i915/gt/intel_ring.c > @@ -13,6 +13,7 @@ > #include "intel_engine_regs.h" > #include "intel_gpu_commands.h" > #include "intel_ring.h" > +#include "intel_gt.h" > #include "intel_timeline.h" > > unsigned int intel_ring_update_space(struct intel_ring *ring) > @@ -56,7 +57,7 @@ int intel_ring_pin(struct intel_ring *ring, struct i915_gem_ww_ctx *ww) > if (i915_vma_is_map_and_fenceable(vma) && !HAS_LLC(vma->vm->i915)) { > addr = (void __force *)i915_vma_pin_iomap(vma); > } else { > - int type = i915_coherent_map_type(vma->vm->i915, vma->obj, false); > + int type = intel_gt_coherent_map_type(vma->vm->gt, vma->obj, false); > > addr = i915_gem_object_pin_map(vma->obj, type); > } > diff --git a/drivers/gpu/drm/i915/gt/selftest_context.c b/drivers/gpu/drm/i915/gt/selftest_context.c > index 76fbae358072..afce036bcaa8 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_context.c > +++ b/drivers/gpu/drm/i915/gt/selftest_context.c > @@ -88,7 +88,7 @@ static int __live_context_size(struct intel_engine_cs *engine) > goto err; > > vaddr = i915_gem_object_pin_map_unlocked(ce->state->obj, > - i915_coherent_map_type(engine->i915, > + intel_gt_coherent_map_type(engine->gt, > ce->state->obj, false)); > if (IS_ERR(vaddr)) { > err = PTR_ERR(vaddr); > diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > index 8b0d84f2aad2..0dd4d00ee894 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > +++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > @@ -73,7 +73,7 @@ static int hang_init(struct hang *h, struct intel_gt *gt) > h->seqno = memset(vaddr, 0xff, PAGE_SIZE); > > vaddr = i915_gem_object_pin_map_unlocked(h->obj, > - i915_coherent_map_type(gt->i915, h->obj, false)); > + intel_gt_coherent_map_type(gt, h->obj, false)); > if (IS_ERR(vaddr)) { > err = PTR_ERR(vaddr); > goto err_unpin_hws; > @@ -119,7 +119,7 @@ hang_create_request(struct hang *h, struct intel_engine_cs *engine) > return ERR_CAST(obj); > } > > - vaddr = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(gt->i915, obj, false)); > + vaddr = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, false)); > if (IS_ERR(vaddr)) { > i915_gem_object_put(obj); > i915_vm_put(vm); > diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c > index a78a3d2c2e16..bc883de02295 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c > +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c > @@ -1292,7 +1292,7 @@ static int compare_isolation(struct intel_engine_cs *engine, > } > > lrc = i915_gem_object_pin_map_unlocked(ce->state->obj, > - i915_coherent_map_type(engine->i915, > + intel_gt_coherent_map_type(engine->gt, > ce->state->obj, > false)); > if (IS_ERR(lrc)) { > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c > index ab1a456f833d..6efb86c93bfc 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c > @@ -268,7 +268,6 @@ static int gsc_fw_load(struct intel_gsc_uc *gsc) > static int gsc_fw_load_prepare(struct intel_gsc_uc *gsc) > { > struct intel_gt *gt = gsc_uc_to_gt(gsc); > - struct drm_i915_private *i915 = gt->i915; > void *src; > > if (!gsc->local) > @@ -278,7 +277,7 @@ static int gsc_fw_load_prepare(struct intel_gsc_uc *gsc) > return -ENOSPC; > > src = i915_gem_object_pin_map_unlocked(gsc->fw.obj, > - i915_coherent_map_type(i915, gsc->fw.obj, true)); > + intel_gt_coherent_map_type(gt, gsc->fw.obj, true)); > if (IS_ERR(src)) > return PTR_ERR(src); > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c > index 2eb891b270ae..c0fa9d232205 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c > @@ -792,7 +792,7 @@ int intel_guc_allocate_and_map_vma(struct intel_guc *guc, u32 size, > return PTR_ERR(vma); > > vaddr = i915_gem_object_pin_map_unlocked(vma->obj, > - i915_coherent_map_type(guc_to_gt(guc)->i915, > + intel_gt_coherent_map_type(guc_to_gt(guc), > vma->obj, true)); > if (IS_ERR(vaddr)) { > i915_vma_unpin_and_release(&vma, 0); > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c > index 48f506a26e6d..b648238cc675 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c > @@ -27,7 +27,6 @@ struct mtl_huc_auth_msg_out { > int intel_huc_fw_auth_via_gsccs(struct intel_huc *huc) > { > struct intel_gt *gt = huc_to_gt(huc); > - struct drm_i915_private *i915 = gt->i915; > struct drm_i915_gem_object *obj; > struct mtl_huc_auth_msg_in *msg_in; > struct mtl_huc_auth_msg_out *msg_out; > @@ -43,7 +42,7 @@ int intel_huc_fw_auth_via_gsccs(struct intel_huc *huc) > pkt_offset = i915_ggtt_offset(huc->heci_pkt); > > pkt_vaddr = i915_gem_object_pin_map_unlocked(obj, > - i915_coherent_map_type(i915, obj, true)); > + intel_gt_coherent_map_type(gt, obj, true)); > if (IS_ERR(pkt_vaddr)) > return PTR_ERR(pkt_vaddr); > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c > index 7aadad5639c3..fc0d05d2df59 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c > @@ -11,6 +11,7 @@ > #include <drm/drm_print.h> > > #include "gem/i915_gem_lmem.h" > +#include "gt/intel_gt.h" > #include "gt/intel_gt_print.h" > #include "intel_gsc_binary_headers.h" > #include "intel_gsc_fw.h" > @@ -1213,7 +1214,7 @@ static int uc_fw_rsa_data_create(struct intel_uc_fw *uc_fw) > return PTR_ERR(vma); > > vaddr = i915_gem_object_pin_map_unlocked(vma->obj, > - i915_coherent_map_type(gt->i915, vma->obj, true)); > + intel_gt_coherent_map_type(gt, vma->obj, true)); > if (IS_ERR(vaddr)) { > i915_vma_unpin_and_release(&vma, 0); > err = PTR_ERR(vaddr); > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c > index c7df47364013..2a600184a077 100644 > --- a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c > @@ -6,6 +6,7 @@ > #include "gem/i915_gem_internal.h" > > #include "gt/intel_context.h" > +#include "gt/intel_gt.h" > #include "gt/uc/intel_gsc_fw.h" > #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h" > > @@ -336,7 +337,7 @@ gsccs_create_buffer(struct intel_gt *gt, > } > > /* return a virtual pointer */ > - *map = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); > + *map = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, true)); > if (IS_ERR(*map)) { > drm_err(&i915->drm, "Failed to map gsccs backend %s.\n", bufname); > err = PTR_ERR(*map); > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > index 1ce07d7e8769..8e0b5d48ddf6 100644 > --- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > @@ -11,6 +11,7 @@ > #include "gem/i915_gem_lmem.h" > > #include "i915_drv.h" > +#include "gt/intel_gt.h" > > #include "intel_pxp.h" > #include "intel_pxp_cmd_interface_42.h" > @@ -245,7 +246,7 @@ static int alloc_streaming_command(struct intel_pxp *pxp) > } > > /* map the lmem into the virtual memory pointer */ > - cmd = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); > + cmd = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(pxp->ctrl_gt, obj, true)); > if (IS_ERR(cmd)) { > drm_err(&i915->drm, "Failed to map gsc message page!\n"); > err = PTR_ERR(cmd); > diff --git a/drivers/gpu/drm/i915/selftests/igt_spinner.c b/drivers/gpu/drm/i915/selftests/igt_spinner.c > index 3c5e0952f1b8..0f064930ef11 100644 > --- a/drivers/gpu/drm/i915/selftests/igt_spinner.c > +++ b/drivers/gpu/drm/i915/selftests/igt_spinner.c > @@ -97,7 +97,7 @@ int igt_spinner_pin(struct igt_spinner *spin, > if (!spin->batch) { > unsigned int mode; > > - mode = i915_coherent_map_type(spin->gt->i915, spin->obj, false); > + mode = intel_gt_coherent_map_type(spin->gt, spin->obj, false); > vaddr = igt_spinner_pin_obj(ce, ww, spin->obj, mode, &spin->batch_vma); > if (IS_ERR(vaddr)) > return PTR_ERR(vaddr); ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric 2023-07-27 11:35 ` Tvrtko Ursulin @ 2023-07-28 1:34 ` Andi Shyti 2023-07-28 8:07 ` Tvrtko Ursulin 0 siblings, 1 reply; 21+ messages in thread From: Andi Shyti @ 2023-07-28 1:34 UTC (permalink / raw) To: Tvrtko Ursulin Cc: chris.p.wilson, intel-gfx, Jonathan Cavitt, matthew.d.roper, nirmoy.das Hi Daniele and John, On Thu, Jul 27, 2023 at 12:35:02PM +0100, Tvrtko Ursulin wrote: > > On 26/07/2023 16:53, Jonathan Cavitt wrote: > > Refactor i915_coherent_map_type to be GT-centric rather than > > device-centric. Each GT may require different coherency > > handling due to hardware workarounds. > > > > Since the function now takes a GT instead of the i915, the function is > > renamed and moved to the gt folder. > > > > Suggested-by: Matt Roper <matthew.d.roper@intel.com> > > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> > > Works for me, thanks! > > I'd only suggest people familiar with the GuC/HuC/PXP side of things have a > look on whether all the object in those path are shared access (GPU and CPU) > at runtime. Maybe some are one off too. But that can be done later too. could you please take a look at this patch and if everything looks all right from the GuC side, kindly ack it? Thanks, Andi > Regards, > > Tvrtko > > > --- > > drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 3 ++- > > drivers/gpu/drm/i915/gem/i915_gem_object.h | 4 ---- > > drivers/gpu/drm/i915/gem/i915_gem_pages.c | 15 --------------- > > .../gpu/drm/i915/gem/selftests/i915_gem_migrate.c | 12 ++++++------ > > drivers/gpu/drm/i915/gt/intel_engine_pm.c | 2 +- > > drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++ > > drivers/gpu/drm/i915/gt/intel_gt.h | 3 +++ > > drivers/gpu/drm/i915/gt/intel_gtt.c | 4 ++-- > > drivers/gpu/drm/i915/gt/intel_lrc.c | 2 +- > > drivers/gpu/drm/i915/gt/intel_ring.c | 3 ++- > > drivers/gpu/drm/i915/gt/selftest_context.c | 2 +- > > drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 4 ++-- > > drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- > > drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 3 +-- > > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +- > > drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c | 3 +-- > > drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 3 ++- > > drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c | 3 ++- > > drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 3 ++- > > drivers/gpu/drm/i915/selftests/igt_spinner.c | 2 +- > > 20 files changed, 46 insertions(+), 44 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c > > index ad0405375881..d753db3eef15 100644 > > --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c > > +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c > > @@ -6,6 +6,7 @@ > > #include <drm/i915_hdcp_interface.h> > > #include "gem/i915_gem_region.h" > > +#include "gt/intel_gt.h" > > #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h" > > #include "i915_drv.h" > > #include "i915_utils.h" > > @@ -632,7 +633,7 @@ static int intel_hdcp_gsc_initialize_message(struct drm_i915_private *i915, > > return PTR_ERR(obj); > > } > > - cmd_in = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); > > + cmd_in = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, true)); > > if (IS_ERR(cmd_in)) { > > drm_err(&i915->drm, "Failed to map gsc message page!\n"); > > err = PTR_ERR(cmd_in); > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h > > index 884a17275b3a..0c695b4c129f 100644 > > --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h > > @@ -716,10 +716,6 @@ void *__must_check i915_gem_object_pin_map(struct drm_i915_gem_object *obj, > > void *__must_check i915_gem_object_pin_map_unlocked(struct drm_i915_gem_object *obj, > > enum i915_map_type type); > > -enum i915_map_type i915_coherent_map_type(struct drm_i915_private *i915, > > - struct drm_i915_gem_object *obj, > > - bool always_coherent); > > - > > void __i915_gem_object_flush_map(struct drm_i915_gem_object *obj, > > unsigned long offset, > > unsigned long size); > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c > > index 89fc8ea6bcfc..6d262d269c71 100644 > > --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c > > @@ -465,21 +465,6 @@ void *i915_gem_object_pin_map_unlocked(struct drm_i915_gem_object *obj, > > return ret; > > } > > -enum i915_map_type i915_coherent_map_type(struct drm_i915_private *i915, > > - struct drm_i915_gem_object *obj, > > - bool always_coherent) > > -{ > > - /* > > - * Wa_22016122933: always return I915_MAP_WC for MTL > > - */ > > - if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(i915)) > > - return I915_MAP_WC; > > - if (HAS_LLC(i915) || always_coherent) > > - return I915_MAP_WB; > > - else > > - return I915_MAP_WC; > > -} > > - > > void __i915_gem_object_flush_map(struct drm_i915_gem_object *obj, > > unsigned long offset, > > unsigned long size) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c > > index a93a90b15907..d8f4a10d71de 100644 > > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c > > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c > > @@ -13,12 +13,12 @@ > > #include "selftests/igt_spinner.h" > > static int igt_fill_check_buffer(struct drm_i915_gem_object *obj, > > + struct intel_gt *gt, > > bool fill) > > { > > - struct drm_i915_private *i915 = to_i915(obj->base.dev); > > unsigned int i, count = obj->base.size / sizeof(u32); > > enum i915_map_type map_type = > > - i915_coherent_map_type(i915, obj, false); > > + intel_gt_coherent_map_type(gt, obj, false); > > u32 *cur; > > int err = 0; > > @@ -66,7 +66,7 @@ static int igt_create_migrate(struct intel_gt *gt, enum intel_region_id src, > > if (err) > > continue; > > - err = igt_fill_check_buffer(obj, true); > > + err = igt_fill_check_buffer(obj, gt, true); > > if (err) > > continue; > > @@ -86,7 +86,7 @@ static int igt_create_migrate(struct intel_gt *gt, enum intel_region_id src, > > if (err) > > continue; > > - err = igt_fill_check_buffer(obj, false); > > + err = igt_fill_check_buffer(obj, gt, false); > > } > > i915_gem_object_put(obj); > > @@ -233,7 +233,7 @@ static int __igt_lmem_pages_migrate(struct intel_gt *gt, > > continue; > > if (!vma) { > > - err = igt_fill_check_buffer(obj, true); > > + err = igt_fill_check_buffer(obj, gt, true); > > if (err) > > continue; > > } > > @@ -276,7 +276,7 @@ static int __igt_lmem_pages_migrate(struct intel_gt *gt, > > if (err) > > goto out_unlock; > > } else { > > - err = igt_fill_check_buffer(obj, false); > > + err = igt_fill_check_buffer(obj, gt, false); > > } > > out_unlock: > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pm.c b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > > index 21af0ec52223..b538b5c04948 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_engine_pm.c > > +++ b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > > @@ -39,7 +39,7 @@ static void dbg_poison_ce(struct intel_context *ce) > > if (ce->state) { > > struct drm_i915_gem_object *obj = ce->state->obj; > > - int type = i915_coherent_map_type(ce->engine->i915, obj, true); > > + int type = intel_gt_coherent_map_type(ce->engine->gt, obj, true); > > void *map; > > if (!i915_gem_object_trylock(obj, NULL)) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c > > index 02886c1eb0f1..62eda0ab9bfc 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_gt.c > > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c > > @@ -1134,6 +1134,21 @@ void intel_gt_invalidate_tlb(struct intel_gt *gt, u32 seqno) > > } > > } > > +enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, > > + struct drm_i915_gem_object *obj, > > + bool always_coherent) > > +{ > > + /* > > + * Wa_22016122933: always return I915_MAP_WC for MTL > > + */ > > + if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(gt->i915)) > > + return I915_MAP_WC; > > + if (HAS_LLC(gt->i915) || always_coherent) > > + return I915_MAP_WB; > > + else > > + return I915_MAP_WC; > > +} > > + > > #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) > > #include "selftest_tlb.c" > > #endif > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h b/drivers/gpu/drm/i915/gt/intel_gt.h > > index d2f4fbde5f9f..adb442aaa522 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_gt.h > > +++ b/drivers/gpu/drm/i915/gt/intel_gt.h > > @@ -119,4 +119,7 @@ static inline u32 intel_gt_next_invalidate_tlb_full(const struct intel_gt *gt) > > void intel_gt_invalidate_tlb(struct intel_gt *gt, u32 seqno); > > +enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, > > + struct drm_i915_gem_object *obj, > > + bool always_coherent); > > #endif /* __INTEL_GT_H__ */ > > diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/intel_gtt.c > > index 731d9f2bbc56..13944a14ea2d 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_gtt.c > > +++ b/drivers/gpu/drm/i915/gt/intel_gtt.c > > @@ -89,7 +89,7 @@ int map_pt_dma(struct i915_address_space *vm, struct drm_i915_gem_object *obj) > > enum i915_map_type type; > > void *vaddr; > > - type = i915_coherent_map_type(vm->i915, obj, true); > > + type = intel_gt_coherent_map_type(vm->gt, obj, true); > > vaddr = i915_gem_object_pin_map_unlocked(obj, type); > > if (IS_ERR(vaddr)) > > return PTR_ERR(vaddr); > > @@ -103,7 +103,7 @@ int map_pt_dma_locked(struct i915_address_space *vm, struct drm_i915_gem_object > > enum i915_map_type type; > > void *vaddr; > > - type = i915_coherent_map_type(vm->i915, obj, true); > > + type = intel_gt_coherent_map_type(vm->gt, obj, true); > > vaddr = i915_gem_object_pin_map(obj, type); > > if (IS_ERR(vaddr)) > > return PTR_ERR(vaddr); > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > > index 119deb9f938c..1897cb5aa2a2 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > > @@ -1191,7 +1191,7 @@ lrc_pre_pin(struct intel_context *ce, > > GEM_BUG_ON(!i915_vma_is_pinned(ce->state)); > > *vaddr = i915_gem_object_pin_map(ce->state->obj, > > - i915_coherent_map_type(ce->engine->i915, > > + intel_gt_coherent_map_type(ce->engine->gt, > > ce->state->obj, > > false) | > > I915_MAP_OVERRIDE); > > diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c > > index fb99143be98e..59da4b7bd262 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_ring.c > > +++ b/drivers/gpu/drm/i915/gt/intel_ring.c > > @@ -13,6 +13,7 @@ > > #include "intel_engine_regs.h" > > #include "intel_gpu_commands.h" > > #include "intel_ring.h" > > +#include "intel_gt.h" > > #include "intel_timeline.h" > > unsigned int intel_ring_update_space(struct intel_ring *ring) > > @@ -56,7 +57,7 @@ int intel_ring_pin(struct intel_ring *ring, struct i915_gem_ww_ctx *ww) > > if (i915_vma_is_map_and_fenceable(vma) && !HAS_LLC(vma->vm->i915)) { > > addr = (void __force *)i915_vma_pin_iomap(vma); > > } else { > > - int type = i915_coherent_map_type(vma->vm->i915, vma->obj, false); > > + int type = intel_gt_coherent_map_type(vma->vm->gt, vma->obj, false); > > addr = i915_gem_object_pin_map(vma->obj, type); > > } > > diff --git a/drivers/gpu/drm/i915/gt/selftest_context.c b/drivers/gpu/drm/i915/gt/selftest_context.c > > index 76fbae358072..afce036bcaa8 100644 > > --- a/drivers/gpu/drm/i915/gt/selftest_context.c > > +++ b/drivers/gpu/drm/i915/gt/selftest_context.c > > @@ -88,7 +88,7 @@ static int __live_context_size(struct intel_engine_cs *engine) > > goto err; > > vaddr = i915_gem_object_pin_map_unlocked(ce->state->obj, > > - i915_coherent_map_type(engine->i915, > > + intel_gt_coherent_map_type(engine->gt, > > ce->state->obj, false)); > > if (IS_ERR(vaddr)) { > > err = PTR_ERR(vaddr); > > diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > > index 8b0d84f2aad2..0dd4d00ee894 100644 > > --- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > > +++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > > @@ -73,7 +73,7 @@ static int hang_init(struct hang *h, struct intel_gt *gt) > > h->seqno = memset(vaddr, 0xff, PAGE_SIZE); > > vaddr = i915_gem_object_pin_map_unlocked(h->obj, > > - i915_coherent_map_type(gt->i915, h->obj, false)); > > + intel_gt_coherent_map_type(gt, h->obj, false)); > > if (IS_ERR(vaddr)) { > > err = PTR_ERR(vaddr); > > goto err_unpin_hws; > > @@ -119,7 +119,7 @@ hang_create_request(struct hang *h, struct intel_engine_cs *engine) > > return ERR_CAST(obj); > > } > > - vaddr = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(gt->i915, obj, false)); > > + vaddr = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, false)); > > if (IS_ERR(vaddr)) { > > i915_gem_object_put(obj); > > i915_vm_put(vm); > > diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c > > index a78a3d2c2e16..bc883de02295 100644 > > --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c > > +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c > > @@ -1292,7 +1292,7 @@ static int compare_isolation(struct intel_engine_cs *engine, > > } > > lrc = i915_gem_object_pin_map_unlocked(ce->state->obj, > > - i915_coherent_map_type(engine->i915, > > + intel_gt_coherent_map_type(engine->gt, > > ce->state->obj, > > false)); > > if (IS_ERR(lrc)) { > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c > > index ab1a456f833d..6efb86c93bfc 100644 > > --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c > > @@ -268,7 +268,6 @@ static int gsc_fw_load(struct intel_gsc_uc *gsc) > > static int gsc_fw_load_prepare(struct intel_gsc_uc *gsc) > > { > > struct intel_gt *gt = gsc_uc_to_gt(gsc); > > - struct drm_i915_private *i915 = gt->i915; > > void *src; > > if (!gsc->local) > > @@ -278,7 +277,7 @@ static int gsc_fw_load_prepare(struct intel_gsc_uc *gsc) > > return -ENOSPC; > > src = i915_gem_object_pin_map_unlocked(gsc->fw.obj, > > - i915_coherent_map_type(i915, gsc->fw.obj, true)); > > + intel_gt_coherent_map_type(gt, gsc->fw.obj, true)); > > if (IS_ERR(src)) > > return PTR_ERR(src); > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c > > index 2eb891b270ae..c0fa9d232205 100644 > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c > > @@ -792,7 +792,7 @@ int intel_guc_allocate_and_map_vma(struct intel_guc *guc, u32 size, > > return PTR_ERR(vma); > > vaddr = i915_gem_object_pin_map_unlocked(vma->obj, > > - i915_coherent_map_type(guc_to_gt(guc)->i915, > > + intel_gt_coherent_map_type(guc_to_gt(guc), > > vma->obj, true)); > > if (IS_ERR(vaddr)) { > > i915_vma_unpin_and_release(&vma, 0); > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c > > index 48f506a26e6d..b648238cc675 100644 > > --- a/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c > > @@ -27,7 +27,6 @@ struct mtl_huc_auth_msg_out { > > int intel_huc_fw_auth_via_gsccs(struct intel_huc *huc) > > { > > struct intel_gt *gt = huc_to_gt(huc); > > - struct drm_i915_private *i915 = gt->i915; > > struct drm_i915_gem_object *obj; > > struct mtl_huc_auth_msg_in *msg_in; > > struct mtl_huc_auth_msg_out *msg_out; > > @@ -43,7 +42,7 @@ int intel_huc_fw_auth_via_gsccs(struct intel_huc *huc) > > pkt_offset = i915_ggtt_offset(huc->heci_pkt); > > pkt_vaddr = i915_gem_object_pin_map_unlocked(obj, > > - i915_coherent_map_type(i915, obj, true)); > > + intel_gt_coherent_map_type(gt, obj, true)); > > if (IS_ERR(pkt_vaddr)) > > return PTR_ERR(pkt_vaddr); > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c > > index 7aadad5639c3..fc0d05d2df59 100644 > > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c > > @@ -11,6 +11,7 @@ > > #include <drm/drm_print.h> > > #include "gem/i915_gem_lmem.h" > > +#include "gt/intel_gt.h" > > #include "gt/intel_gt_print.h" > > #include "intel_gsc_binary_headers.h" > > #include "intel_gsc_fw.h" > > @@ -1213,7 +1214,7 @@ static int uc_fw_rsa_data_create(struct intel_uc_fw *uc_fw) > > return PTR_ERR(vma); > > vaddr = i915_gem_object_pin_map_unlocked(vma->obj, > > - i915_coherent_map_type(gt->i915, vma->obj, true)); > > + intel_gt_coherent_map_type(gt, vma->obj, true)); > > if (IS_ERR(vaddr)) { > > i915_vma_unpin_and_release(&vma, 0); > > err = PTR_ERR(vaddr); > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c > > index c7df47364013..2a600184a077 100644 > > --- a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c > > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c > > @@ -6,6 +6,7 @@ > > #include "gem/i915_gem_internal.h" > > #include "gt/intel_context.h" > > +#include "gt/intel_gt.h" > > #include "gt/uc/intel_gsc_fw.h" > > #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h" > > @@ -336,7 +337,7 @@ gsccs_create_buffer(struct intel_gt *gt, > > } > > /* return a virtual pointer */ > > - *map = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); > > + *map = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, true)); > > if (IS_ERR(*map)) { > > drm_err(&i915->drm, "Failed to map gsccs backend %s.\n", bufname); > > err = PTR_ERR(*map); > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > index 1ce07d7e8769..8e0b5d48ddf6 100644 > > --- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > @@ -11,6 +11,7 @@ > > #include "gem/i915_gem_lmem.h" > > #include "i915_drv.h" > > +#include "gt/intel_gt.h" > > #include "intel_pxp.h" > > #include "intel_pxp_cmd_interface_42.h" > > @@ -245,7 +246,7 @@ static int alloc_streaming_command(struct intel_pxp *pxp) > > } > > /* map the lmem into the virtual memory pointer */ > > - cmd = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); > > + cmd = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(pxp->ctrl_gt, obj, true)); > > if (IS_ERR(cmd)) { > > drm_err(&i915->drm, "Failed to map gsc message page!\n"); > > err = PTR_ERR(cmd); > > diff --git a/drivers/gpu/drm/i915/selftests/igt_spinner.c b/drivers/gpu/drm/i915/selftests/igt_spinner.c > > index 3c5e0952f1b8..0f064930ef11 100644 > > --- a/drivers/gpu/drm/i915/selftests/igt_spinner.c > > +++ b/drivers/gpu/drm/i915/selftests/igt_spinner.c > > @@ -97,7 +97,7 @@ int igt_spinner_pin(struct igt_spinner *spin, > > if (!spin->batch) { > > unsigned int mode; > > - mode = i915_coherent_map_type(spin->gt->i915, spin->obj, false); > > + mode = intel_gt_coherent_map_type(spin->gt, spin->obj, false); > > vaddr = igt_spinner_pin_obj(ce, ww, spin->obj, mode, &spin->batch_vma); > > if (IS_ERR(vaddr)) > > return PTR_ERR(vaddr); ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric 2023-07-28 1:34 ` Andi Shyti @ 2023-07-28 8:07 ` Tvrtko Ursulin 2023-07-28 8:18 ` Andi Shyti 0 siblings, 1 reply; 21+ messages in thread From: Tvrtko Ursulin @ 2023-07-28 8:07 UTC (permalink / raw) To: Andi Shyti Cc: chris.p.wilson, intel-gfx, Jonathan Cavitt, matthew.d.roper, nirmoy.das On 28/07/2023 02:34, Andi Shyti wrote: > Hi Daniele and John, > > On Thu, Jul 27, 2023 at 12:35:02PM +0100, Tvrtko Ursulin wrote: >> >> On 26/07/2023 16:53, Jonathan Cavitt wrote: >>> Refactor i915_coherent_map_type to be GT-centric rather than >>> device-centric. Each GT may require different coherency >>> handling due to hardware workarounds. >>> >>> Since the function now takes a GT instead of the i915, the function is >>> renamed and moved to the gt folder. >>> >>> Suggested-by: Matt Roper <matthew.d.roper@intel.com> >>> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> >> >> Works for me, thanks! >> >> I'd only suggest people familiar with the GuC/HuC/PXP side of things have a >> look on whether all the object in those path are shared access (GPU and CPU) >> at runtime. Maybe some are one off too. But that can be done later too. > > could you please take a look at this patch and if everything > looks all right from the GuC side, kindly ack it? Me? I can upgrade the "works for me" into an explicit ack if you want. Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko > Thanks, > Andi > >> Regards, >> >> Tvrtko >> >>> --- >>> drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 3 ++- >>> drivers/gpu/drm/i915/gem/i915_gem_object.h | 4 ---- >>> drivers/gpu/drm/i915/gem/i915_gem_pages.c | 15 --------------- >>> .../gpu/drm/i915/gem/selftests/i915_gem_migrate.c | 12 ++++++------ >>> drivers/gpu/drm/i915/gt/intel_engine_pm.c | 2 +- >>> drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++ >>> drivers/gpu/drm/i915/gt/intel_gt.h | 3 +++ >>> drivers/gpu/drm/i915/gt/intel_gtt.c | 4 ++-- >>> drivers/gpu/drm/i915/gt/intel_lrc.c | 2 +- >>> drivers/gpu/drm/i915/gt/intel_ring.c | 3 ++- >>> drivers/gpu/drm/i915/gt/selftest_context.c | 2 +- >>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 4 ++-- >>> drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- >>> drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 3 +-- >>> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +- >>> drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c | 3 +-- >>> drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 3 ++- >>> drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c | 3 ++- >>> drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 3 ++- >>> drivers/gpu/drm/i915/selftests/igt_spinner.c | 2 +- >>> 20 files changed, 46 insertions(+), 44 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c >>> index ad0405375881..d753db3eef15 100644 >>> --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c >>> +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c >>> @@ -6,6 +6,7 @@ >>> #include <drm/i915_hdcp_interface.h> >>> #include "gem/i915_gem_region.h" >>> +#include "gt/intel_gt.h" >>> #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h" >>> #include "i915_drv.h" >>> #include "i915_utils.h" >>> @@ -632,7 +633,7 @@ static int intel_hdcp_gsc_initialize_message(struct drm_i915_private *i915, >>> return PTR_ERR(obj); >>> } >>> - cmd_in = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); >>> + cmd_in = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, true)); >>> if (IS_ERR(cmd_in)) { >>> drm_err(&i915->drm, "Failed to map gsc message page!\n"); >>> err = PTR_ERR(cmd_in); >>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h >>> index 884a17275b3a..0c695b4c129f 100644 >>> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h >>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h >>> @@ -716,10 +716,6 @@ void *__must_check i915_gem_object_pin_map(struct drm_i915_gem_object *obj, >>> void *__must_check i915_gem_object_pin_map_unlocked(struct drm_i915_gem_object *obj, >>> enum i915_map_type type); >>> -enum i915_map_type i915_coherent_map_type(struct drm_i915_private *i915, >>> - struct drm_i915_gem_object *obj, >>> - bool always_coherent); >>> - >>> void __i915_gem_object_flush_map(struct drm_i915_gem_object *obj, >>> unsigned long offset, >>> unsigned long size); >>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c >>> index 89fc8ea6bcfc..6d262d269c71 100644 >>> --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c >>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c >>> @@ -465,21 +465,6 @@ void *i915_gem_object_pin_map_unlocked(struct drm_i915_gem_object *obj, >>> return ret; >>> } >>> -enum i915_map_type i915_coherent_map_type(struct drm_i915_private *i915, >>> - struct drm_i915_gem_object *obj, >>> - bool always_coherent) >>> -{ >>> - /* >>> - * Wa_22016122933: always return I915_MAP_WC for MTL >>> - */ >>> - if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(i915)) >>> - return I915_MAP_WC; >>> - if (HAS_LLC(i915) || always_coherent) >>> - return I915_MAP_WB; >>> - else >>> - return I915_MAP_WC; >>> -} >>> - >>> void __i915_gem_object_flush_map(struct drm_i915_gem_object *obj, >>> unsigned long offset, >>> unsigned long size) >>> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c >>> index a93a90b15907..d8f4a10d71de 100644 >>> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c >>> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c >>> @@ -13,12 +13,12 @@ >>> #include "selftests/igt_spinner.h" >>> static int igt_fill_check_buffer(struct drm_i915_gem_object *obj, >>> + struct intel_gt *gt, >>> bool fill) >>> { >>> - struct drm_i915_private *i915 = to_i915(obj->base.dev); >>> unsigned int i, count = obj->base.size / sizeof(u32); >>> enum i915_map_type map_type = >>> - i915_coherent_map_type(i915, obj, false); >>> + intel_gt_coherent_map_type(gt, obj, false); >>> u32 *cur; >>> int err = 0; >>> @@ -66,7 +66,7 @@ static int igt_create_migrate(struct intel_gt *gt, enum intel_region_id src, >>> if (err) >>> continue; >>> - err = igt_fill_check_buffer(obj, true); >>> + err = igt_fill_check_buffer(obj, gt, true); >>> if (err) >>> continue; >>> @@ -86,7 +86,7 @@ static int igt_create_migrate(struct intel_gt *gt, enum intel_region_id src, >>> if (err) >>> continue; >>> - err = igt_fill_check_buffer(obj, false); >>> + err = igt_fill_check_buffer(obj, gt, false); >>> } >>> i915_gem_object_put(obj); >>> @@ -233,7 +233,7 @@ static int __igt_lmem_pages_migrate(struct intel_gt *gt, >>> continue; >>> if (!vma) { >>> - err = igt_fill_check_buffer(obj, true); >>> + err = igt_fill_check_buffer(obj, gt, true); >>> if (err) >>> continue; >>> } >>> @@ -276,7 +276,7 @@ static int __igt_lmem_pages_migrate(struct intel_gt *gt, >>> if (err) >>> goto out_unlock; >>> } else { >>> - err = igt_fill_check_buffer(obj, false); >>> + err = igt_fill_check_buffer(obj, gt, false); >>> } >>> out_unlock: >>> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pm.c b/drivers/gpu/drm/i915/gt/intel_engine_pm.c >>> index 21af0ec52223..b538b5c04948 100644 >>> --- a/drivers/gpu/drm/i915/gt/intel_engine_pm.c >>> +++ b/drivers/gpu/drm/i915/gt/intel_engine_pm.c >>> @@ -39,7 +39,7 @@ static void dbg_poison_ce(struct intel_context *ce) >>> if (ce->state) { >>> struct drm_i915_gem_object *obj = ce->state->obj; >>> - int type = i915_coherent_map_type(ce->engine->i915, obj, true); >>> + int type = intel_gt_coherent_map_type(ce->engine->gt, obj, true); >>> void *map; >>> if (!i915_gem_object_trylock(obj, NULL)) >>> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c >>> index 02886c1eb0f1..62eda0ab9bfc 100644 >>> --- a/drivers/gpu/drm/i915/gt/intel_gt.c >>> +++ b/drivers/gpu/drm/i915/gt/intel_gt.c >>> @@ -1134,6 +1134,21 @@ void intel_gt_invalidate_tlb(struct intel_gt *gt, u32 seqno) >>> } >>> } >>> +enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, >>> + struct drm_i915_gem_object *obj, >>> + bool always_coherent) >>> +{ >>> + /* >>> + * Wa_22016122933: always return I915_MAP_WC for MTL >>> + */ >>> + if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(gt->i915)) >>> + return I915_MAP_WC; >>> + if (HAS_LLC(gt->i915) || always_coherent) >>> + return I915_MAP_WB; >>> + else >>> + return I915_MAP_WC; >>> +} >>> + >>> #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) >>> #include "selftest_tlb.c" >>> #endif >>> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h b/drivers/gpu/drm/i915/gt/intel_gt.h >>> index d2f4fbde5f9f..adb442aaa522 100644 >>> --- a/drivers/gpu/drm/i915/gt/intel_gt.h >>> +++ b/drivers/gpu/drm/i915/gt/intel_gt.h >>> @@ -119,4 +119,7 @@ static inline u32 intel_gt_next_invalidate_tlb_full(const struct intel_gt *gt) >>> void intel_gt_invalidate_tlb(struct intel_gt *gt, u32 seqno); >>> +enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, >>> + struct drm_i915_gem_object *obj, >>> + bool always_coherent); >>> #endif /* __INTEL_GT_H__ */ >>> diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/intel_gtt.c >>> index 731d9f2bbc56..13944a14ea2d 100644 >>> --- a/drivers/gpu/drm/i915/gt/intel_gtt.c >>> +++ b/drivers/gpu/drm/i915/gt/intel_gtt.c >>> @@ -89,7 +89,7 @@ int map_pt_dma(struct i915_address_space *vm, struct drm_i915_gem_object *obj) >>> enum i915_map_type type; >>> void *vaddr; >>> - type = i915_coherent_map_type(vm->i915, obj, true); >>> + type = intel_gt_coherent_map_type(vm->gt, obj, true); >>> vaddr = i915_gem_object_pin_map_unlocked(obj, type); >>> if (IS_ERR(vaddr)) >>> return PTR_ERR(vaddr); >>> @@ -103,7 +103,7 @@ int map_pt_dma_locked(struct i915_address_space *vm, struct drm_i915_gem_object >>> enum i915_map_type type; >>> void *vaddr; >>> - type = i915_coherent_map_type(vm->i915, obj, true); >>> + type = intel_gt_coherent_map_type(vm->gt, obj, true); >>> vaddr = i915_gem_object_pin_map(obj, type); >>> if (IS_ERR(vaddr)) >>> return PTR_ERR(vaddr); >>> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c >>> index 119deb9f938c..1897cb5aa2a2 100644 >>> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c >>> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c >>> @@ -1191,7 +1191,7 @@ lrc_pre_pin(struct intel_context *ce, >>> GEM_BUG_ON(!i915_vma_is_pinned(ce->state)); >>> *vaddr = i915_gem_object_pin_map(ce->state->obj, >>> - i915_coherent_map_type(ce->engine->i915, >>> + intel_gt_coherent_map_type(ce->engine->gt, >>> ce->state->obj, >>> false) | >>> I915_MAP_OVERRIDE); >>> diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c >>> index fb99143be98e..59da4b7bd262 100644 >>> --- a/drivers/gpu/drm/i915/gt/intel_ring.c >>> +++ b/drivers/gpu/drm/i915/gt/intel_ring.c >>> @@ -13,6 +13,7 @@ >>> #include "intel_engine_regs.h" >>> #include "intel_gpu_commands.h" >>> #include "intel_ring.h" >>> +#include "intel_gt.h" >>> #include "intel_timeline.h" >>> unsigned int intel_ring_update_space(struct intel_ring *ring) >>> @@ -56,7 +57,7 @@ int intel_ring_pin(struct intel_ring *ring, struct i915_gem_ww_ctx *ww) >>> if (i915_vma_is_map_and_fenceable(vma) && !HAS_LLC(vma->vm->i915)) { >>> addr = (void __force *)i915_vma_pin_iomap(vma); >>> } else { >>> - int type = i915_coherent_map_type(vma->vm->i915, vma->obj, false); >>> + int type = intel_gt_coherent_map_type(vma->vm->gt, vma->obj, false); >>> addr = i915_gem_object_pin_map(vma->obj, type); >>> } >>> diff --git a/drivers/gpu/drm/i915/gt/selftest_context.c b/drivers/gpu/drm/i915/gt/selftest_context.c >>> index 76fbae358072..afce036bcaa8 100644 >>> --- a/drivers/gpu/drm/i915/gt/selftest_context.c >>> +++ b/drivers/gpu/drm/i915/gt/selftest_context.c >>> @@ -88,7 +88,7 @@ static int __live_context_size(struct intel_engine_cs *engine) >>> goto err; >>> vaddr = i915_gem_object_pin_map_unlocked(ce->state->obj, >>> - i915_coherent_map_type(engine->i915, >>> + intel_gt_coherent_map_type(engine->gt, >>> ce->state->obj, false)); >>> if (IS_ERR(vaddr)) { >>> err = PTR_ERR(vaddr); >>> diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c >>> index 8b0d84f2aad2..0dd4d00ee894 100644 >>> --- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c >>> +++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c >>> @@ -73,7 +73,7 @@ static int hang_init(struct hang *h, struct intel_gt *gt) >>> h->seqno = memset(vaddr, 0xff, PAGE_SIZE); >>> vaddr = i915_gem_object_pin_map_unlocked(h->obj, >>> - i915_coherent_map_type(gt->i915, h->obj, false)); >>> + intel_gt_coherent_map_type(gt, h->obj, false)); >>> if (IS_ERR(vaddr)) { >>> err = PTR_ERR(vaddr); >>> goto err_unpin_hws; >>> @@ -119,7 +119,7 @@ hang_create_request(struct hang *h, struct intel_engine_cs *engine) >>> return ERR_CAST(obj); >>> } >>> - vaddr = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(gt->i915, obj, false)); >>> + vaddr = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, false)); >>> if (IS_ERR(vaddr)) { >>> i915_gem_object_put(obj); >>> i915_vm_put(vm); >>> diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c >>> index a78a3d2c2e16..bc883de02295 100644 >>> --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c >>> +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c >>> @@ -1292,7 +1292,7 @@ static int compare_isolation(struct intel_engine_cs *engine, >>> } >>> lrc = i915_gem_object_pin_map_unlocked(ce->state->obj, >>> - i915_coherent_map_type(engine->i915, >>> + intel_gt_coherent_map_type(engine->gt, >>> ce->state->obj, >>> false)); >>> if (IS_ERR(lrc)) { >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c >>> index ab1a456f833d..6efb86c93bfc 100644 >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c >>> @@ -268,7 +268,6 @@ static int gsc_fw_load(struct intel_gsc_uc *gsc) >>> static int gsc_fw_load_prepare(struct intel_gsc_uc *gsc) >>> { >>> struct intel_gt *gt = gsc_uc_to_gt(gsc); >>> - struct drm_i915_private *i915 = gt->i915; >>> void *src; >>> if (!gsc->local) >>> @@ -278,7 +277,7 @@ static int gsc_fw_load_prepare(struct intel_gsc_uc *gsc) >>> return -ENOSPC; >>> src = i915_gem_object_pin_map_unlocked(gsc->fw.obj, >>> - i915_coherent_map_type(i915, gsc->fw.obj, true)); >>> + intel_gt_coherent_map_type(gt, gsc->fw.obj, true)); >>> if (IS_ERR(src)) >>> return PTR_ERR(src); >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c >>> index 2eb891b270ae..c0fa9d232205 100644 >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c >>> @@ -792,7 +792,7 @@ int intel_guc_allocate_and_map_vma(struct intel_guc *guc, u32 size, >>> return PTR_ERR(vma); >>> vaddr = i915_gem_object_pin_map_unlocked(vma->obj, >>> - i915_coherent_map_type(guc_to_gt(guc)->i915, >>> + intel_gt_coherent_map_type(guc_to_gt(guc), >>> vma->obj, true)); >>> if (IS_ERR(vaddr)) { >>> i915_vma_unpin_and_release(&vma, 0); >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c >>> index 48f506a26e6d..b648238cc675 100644 >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c >>> @@ -27,7 +27,6 @@ struct mtl_huc_auth_msg_out { >>> int intel_huc_fw_auth_via_gsccs(struct intel_huc *huc) >>> { >>> struct intel_gt *gt = huc_to_gt(huc); >>> - struct drm_i915_private *i915 = gt->i915; >>> struct drm_i915_gem_object *obj; >>> struct mtl_huc_auth_msg_in *msg_in; >>> struct mtl_huc_auth_msg_out *msg_out; >>> @@ -43,7 +42,7 @@ int intel_huc_fw_auth_via_gsccs(struct intel_huc *huc) >>> pkt_offset = i915_ggtt_offset(huc->heci_pkt); >>> pkt_vaddr = i915_gem_object_pin_map_unlocked(obj, >>> - i915_coherent_map_type(i915, obj, true)); >>> + intel_gt_coherent_map_type(gt, obj, true)); >>> if (IS_ERR(pkt_vaddr)) >>> return PTR_ERR(pkt_vaddr); >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c >>> index 7aadad5639c3..fc0d05d2df59 100644 >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c >>> @@ -11,6 +11,7 @@ >>> #include <drm/drm_print.h> >>> #include "gem/i915_gem_lmem.h" >>> +#include "gt/intel_gt.h" >>> #include "gt/intel_gt_print.h" >>> #include "intel_gsc_binary_headers.h" >>> #include "intel_gsc_fw.h" >>> @@ -1213,7 +1214,7 @@ static int uc_fw_rsa_data_create(struct intel_uc_fw *uc_fw) >>> return PTR_ERR(vma); >>> vaddr = i915_gem_object_pin_map_unlocked(vma->obj, >>> - i915_coherent_map_type(gt->i915, vma->obj, true)); >>> + intel_gt_coherent_map_type(gt, vma->obj, true)); >>> if (IS_ERR(vaddr)) { >>> i915_vma_unpin_and_release(&vma, 0); >>> err = PTR_ERR(vaddr); >>> diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c >>> index c7df47364013..2a600184a077 100644 >>> --- a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c >>> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c >>> @@ -6,6 +6,7 @@ >>> #include "gem/i915_gem_internal.h" >>> #include "gt/intel_context.h" >>> +#include "gt/intel_gt.h" >>> #include "gt/uc/intel_gsc_fw.h" >>> #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h" >>> @@ -336,7 +337,7 @@ gsccs_create_buffer(struct intel_gt *gt, >>> } >>> /* return a virtual pointer */ >>> - *map = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); >>> + *map = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, true)); >>> if (IS_ERR(*map)) { >>> drm_err(&i915->drm, "Failed to map gsccs backend %s.\n", bufname); >>> err = PTR_ERR(*map); >>> diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c >>> index 1ce07d7e8769..8e0b5d48ddf6 100644 >>> --- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c >>> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c >>> @@ -11,6 +11,7 @@ >>> #include "gem/i915_gem_lmem.h" >>> #include "i915_drv.h" >>> +#include "gt/intel_gt.h" >>> #include "intel_pxp.h" >>> #include "intel_pxp_cmd_interface_42.h" >>> @@ -245,7 +246,7 @@ static int alloc_streaming_command(struct intel_pxp *pxp) >>> } >>> /* map the lmem into the virtual memory pointer */ >>> - cmd = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); >>> + cmd = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(pxp->ctrl_gt, obj, true)); >>> if (IS_ERR(cmd)) { >>> drm_err(&i915->drm, "Failed to map gsc message page!\n"); >>> err = PTR_ERR(cmd); >>> diff --git a/drivers/gpu/drm/i915/selftests/igt_spinner.c b/drivers/gpu/drm/i915/selftests/igt_spinner.c >>> index 3c5e0952f1b8..0f064930ef11 100644 >>> --- a/drivers/gpu/drm/i915/selftests/igt_spinner.c >>> +++ b/drivers/gpu/drm/i915/selftests/igt_spinner.c >>> @@ -97,7 +97,7 @@ int igt_spinner_pin(struct igt_spinner *spin, >>> if (!spin->batch) { >>> unsigned int mode; >>> - mode = i915_coherent_map_type(spin->gt->i915, spin->obj, false); >>> + mode = intel_gt_coherent_map_type(spin->gt, spin->obj, false); >>> vaddr = igt_spinner_pin_obj(ce, ww, spin->obj, mode, &spin->batch_vma); >>> if (IS_ERR(vaddr)) >>> return PTR_ERR(vaddr); ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric 2023-07-28 8:07 ` Tvrtko Ursulin @ 2023-07-28 8:18 ` Andi Shyti 0 siblings, 0 replies; 21+ messages in thread From: Andi Shyti @ 2023-07-28 8:18 UTC (permalink / raw) To: Tvrtko Ursulin Cc: chris.p.wilson, intel-gfx, Jonathan Cavitt, matthew.d.roper, nirmoy.das On Fri, Jul 28, 2023 at 09:07:14AM +0100, Tvrtko Ursulin wrote: > > On 28/07/2023 02:34, Andi Shyti wrote: > > Hi Daniele and John, > > > > On Thu, Jul 27, 2023 at 12:35:02PM +0100, Tvrtko Ursulin wrote: > > > > > > On 26/07/2023 16:53, Jonathan Cavitt wrote: > > > > Refactor i915_coherent_map_type to be GT-centric rather than > > > > device-centric. Each GT may require different coherency > > > > handling due to hardware workarounds. > > > > > > > > Since the function now takes a GT instead of the i915, the function is > > > > renamed and moved to the gt folder. > > > > > > > > Suggested-by: Matt Roper <matthew.d.roper@intel.com> > > > > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> > > > > > > Works for me, thanks! > > > > > > I'd only suggest people familiar with the GuC/HuC/PXP side of things have a > > > look on whether all the object in those path are shared access (GPU and CPU) > > > at runtime. Maybe some are one off too. But that can be done later too. > > > > could you please take a look at this patch and if everything > > looks all right from the GuC side, kindly ack it? > > Me? I can upgrade the "works for me" into an explicit ack if you want. ehehe... I was asking GuC guys because you wanted a confirmation from someone familiar with GuC/HuC/PXP :) Andi > Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Regards, > > Tvrtko > > > Thanks, > > Andi > > > > > Regards, > > > > > > Tvrtko > > > > > > > --- > > > > drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 3 ++- > > > > drivers/gpu/drm/i915/gem/i915_gem_object.h | 4 ---- > > > > drivers/gpu/drm/i915/gem/i915_gem_pages.c | 15 --------------- > > > > .../gpu/drm/i915/gem/selftests/i915_gem_migrate.c | 12 ++++++------ > > > > drivers/gpu/drm/i915/gt/intel_engine_pm.c | 2 +- > > > > drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++ > > > > drivers/gpu/drm/i915/gt/intel_gt.h | 3 +++ > > > > drivers/gpu/drm/i915/gt/intel_gtt.c | 4 ++-- > > > > drivers/gpu/drm/i915/gt/intel_lrc.c | 2 +- > > > > drivers/gpu/drm/i915/gt/intel_ring.c | 3 ++- > > > > drivers/gpu/drm/i915/gt/selftest_context.c | 2 +- > > > > drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 4 ++-- > > > > drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- > > > > drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 3 +-- > > > > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +- > > > > drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c | 3 +-- > > > > drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 3 ++- > > > > drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c | 3 ++- > > > > drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 3 ++- > > > > drivers/gpu/drm/i915/selftests/igt_spinner.c | 2 +- > > > > 20 files changed, 46 insertions(+), 44 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c > > > > index ad0405375881..d753db3eef15 100644 > > > > --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c > > > > +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c > > > > @@ -6,6 +6,7 @@ > > > > #include <drm/i915_hdcp_interface.h> > > > > #include "gem/i915_gem_region.h" > > > > +#include "gt/intel_gt.h" > > > > #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h" > > > > #include "i915_drv.h" > > > > #include "i915_utils.h" > > > > @@ -632,7 +633,7 @@ static int intel_hdcp_gsc_initialize_message(struct drm_i915_private *i915, > > > > return PTR_ERR(obj); > > > > } > > > > - cmd_in = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); > > > > + cmd_in = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, true)); > > > > if (IS_ERR(cmd_in)) { > > > > drm_err(&i915->drm, "Failed to map gsc message page!\n"); > > > > err = PTR_ERR(cmd_in); > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h > > > > index 884a17275b3a..0c695b4c129f 100644 > > > > --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h > > > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h > > > > @@ -716,10 +716,6 @@ void *__must_check i915_gem_object_pin_map(struct drm_i915_gem_object *obj, > > > > void *__must_check i915_gem_object_pin_map_unlocked(struct drm_i915_gem_object *obj, > > > > enum i915_map_type type); > > > > -enum i915_map_type i915_coherent_map_type(struct drm_i915_private *i915, > > > > - struct drm_i915_gem_object *obj, > > > > - bool always_coherent); > > > > - > > > > void __i915_gem_object_flush_map(struct drm_i915_gem_object *obj, > > > > unsigned long offset, > > > > unsigned long size); > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c > > > > index 89fc8ea6bcfc..6d262d269c71 100644 > > > > --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c > > > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c > > > > @@ -465,21 +465,6 @@ void *i915_gem_object_pin_map_unlocked(struct drm_i915_gem_object *obj, > > > > return ret; > > > > } > > > > -enum i915_map_type i915_coherent_map_type(struct drm_i915_private *i915, > > > > - struct drm_i915_gem_object *obj, > > > > - bool always_coherent) > > > > -{ > > > > - /* > > > > - * Wa_22016122933: always return I915_MAP_WC for MTL > > > > - */ > > > > - if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(i915)) > > > > - return I915_MAP_WC; > > > > - if (HAS_LLC(i915) || always_coherent) > > > > - return I915_MAP_WB; > > > > - else > > > > - return I915_MAP_WC; > > > > -} > > > > - > > > > void __i915_gem_object_flush_map(struct drm_i915_gem_object *obj, > > > > unsigned long offset, > > > > unsigned long size) > > > > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c > > > > index a93a90b15907..d8f4a10d71de 100644 > > > > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c > > > > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c > > > > @@ -13,12 +13,12 @@ > > > > #include "selftests/igt_spinner.h" > > > > static int igt_fill_check_buffer(struct drm_i915_gem_object *obj, > > > > + struct intel_gt *gt, > > > > bool fill) > > > > { > > > > - struct drm_i915_private *i915 = to_i915(obj->base.dev); > > > > unsigned int i, count = obj->base.size / sizeof(u32); > > > > enum i915_map_type map_type = > > > > - i915_coherent_map_type(i915, obj, false); > > > > + intel_gt_coherent_map_type(gt, obj, false); > > > > u32 *cur; > > > > int err = 0; > > > > @@ -66,7 +66,7 @@ static int igt_create_migrate(struct intel_gt *gt, enum intel_region_id src, > > > > if (err) > > > > continue; > > > > - err = igt_fill_check_buffer(obj, true); > > > > + err = igt_fill_check_buffer(obj, gt, true); > > > > if (err) > > > > continue; > > > > @@ -86,7 +86,7 @@ static int igt_create_migrate(struct intel_gt *gt, enum intel_region_id src, > > > > if (err) > > > > continue; > > > > - err = igt_fill_check_buffer(obj, false); > > > > + err = igt_fill_check_buffer(obj, gt, false); > > > > } > > > > i915_gem_object_put(obj); > > > > @@ -233,7 +233,7 @@ static int __igt_lmem_pages_migrate(struct intel_gt *gt, > > > > continue; > > > > if (!vma) { > > > > - err = igt_fill_check_buffer(obj, true); > > > > + err = igt_fill_check_buffer(obj, gt, true); > > > > if (err) > > > > continue; > > > > } > > > > @@ -276,7 +276,7 @@ static int __igt_lmem_pages_migrate(struct intel_gt *gt, > > > > if (err) > > > > goto out_unlock; > > > > } else { > > > > - err = igt_fill_check_buffer(obj, false); > > > > + err = igt_fill_check_buffer(obj, gt, false); > > > > } > > > > out_unlock: > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pm.c b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > > > > index 21af0ec52223..b538b5c04948 100644 > > > > --- a/drivers/gpu/drm/i915/gt/intel_engine_pm.c > > > > +++ b/drivers/gpu/drm/i915/gt/intel_engine_pm.c > > > > @@ -39,7 +39,7 @@ static void dbg_poison_ce(struct intel_context *ce) > > > > if (ce->state) { > > > > struct drm_i915_gem_object *obj = ce->state->obj; > > > > - int type = i915_coherent_map_type(ce->engine->i915, obj, true); > > > > + int type = intel_gt_coherent_map_type(ce->engine->gt, obj, true); > > > > void *map; > > > > if (!i915_gem_object_trylock(obj, NULL)) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c > > > > index 02886c1eb0f1..62eda0ab9bfc 100644 > > > > --- a/drivers/gpu/drm/i915/gt/intel_gt.c > > > > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c > > > > @@ -1134,6 +1134,21 @@ void intel_gt_invalidate_tlb(struct intel_gt *gt, u32 seqno) > > > > } > > > > } > > > > +enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, > > > > + struct drm_i915_gem_object *obj, > > > > + bool always_coherent) > > > > +{ > > > > + /* > > > > + * Wa_22016122933: always return I915_MAP_WC for MTL > > > > + */ > > > > + if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(gt->i915)) > > > > + return I915_MAP_WC; > > > > + if (HAS_LLC(gt->i915) || always_coherent) > > > > + return I915_MAP_WB; > > > > + else > > > > + return I915_MAP_WC; > > > > +} > > > > + > > > > #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) > > > > #include "selftest_tlb.c" > > > > #endif > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h b/drivers/gpu/drm/i915/gt/intel_gt.h > > > > index d2f4fbde5f9f..adb442aaa522 100644 > > > > --- a/drivers/gpu/drm/i915/gt/intel_gt.h > > > > +++ b/drivers/gpu/drm/i915/gt/intel_gt.h > > > > @@ -119,4 +119,7 @@ static inline u32 intel_gt_next_invalidate_tlb_full(const struct intel_gt *gt) > > > > void intel_gt_invalidate_tlb(struct intel_gt *gt, u32 seqno); > > > > +enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, > > > > + struct drm_i915_gem_object *obj, > > > > + bool always_coherent); > > > > #endif /* __INTEL_GT_H__ */ > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/intel_gtt.c > > > > index 731d9f2bbc56..13944a14ea2d 100644 > > > > --- a/drivers/gpu/drm/i915/gt/intel_gtt.c > > > > +++ b/drivers/gpu/drm/i915/gt/intel_gtt.c > > > > @@ -89,7 +89,7 @@ int map_pt_dma(struct i915_address_space *vm, struct drm_i915_gem_object *obj) > > > > enum i915_map_type type; > > > > void *vaddr; > > > > - type = i915_coherent_map_type(vm->i915, obj, true); > > > > + type = intel_gt_coherent_map_type(vm->gt, obj, true); > > > > vaddr = i915_gem_object_pin_map_unlocked(obj, type); > > > > if (IS_ERR(vaddr)) > > > > return PTR_ERR(vaddr); > > > > @@ -103,7 +103,7 @@ int map_pt_dma_locked(struct i915_address_space *vm, struct drm_i915_gem_object > > > > enum i915_map_type type; > > > > void *vaddr; > > > > - type = i915_coherent_map_type(vm->i915, obj, true); > > > > + type = intel_gt_coherent_map_type(vm->gt, obj, true); > > > > vaddr = i915_gem_object_pin_map(obj, type); > > > > if (IS_ERR(vaddr)) > > > > return PTR_ERR(vaddr); > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > > > > index 119deb9f938c..1897cb5aa2a2 100644 > > > > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > > > > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > > > > @@ -1191,7 +1191,7 @@ lrc_pre_pin(struct intel_context *ce, > > > > GEM_BUG_ON(!i915_vma_is_pinned(ce->state)); > > > > *vaddr = i915_gem_object_pin_map(ce->state->obj, > > > > - i915_coherent_map_type(ce->engine->i915, > > > > + intel_gt_coherent_map_type(ce->engine->gt, > > > > ce->state->obj, > > > > false) | > > > > I915_MAP_OVERRIDE); > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c > > > > index fb99143be98e..59da4b7bd262 100644 > > > > --- a/drivers/gpu/drm/i915/gt/intel_ring.c > > > > +++ b/drivers/gpu/drm/i915/gt/intel_ring.c > > > > @@ -13,6 +13,7 @@ > > > > #include "intel_engine_regs.h" > > > > #include "intel_gpu_commands.h" > > > > #include "intel_ring.h" > > > > +#include "intel_gt.h" > > > > #include "intel_timeline.h" > > > > unsigned int intel_ring_update_space(struct intel_ring *ring) > > > > @@ -56,7 +57,7 @@ int intel_ring_pin(struct intel_ring *ring, struct i915_gem_ww_ctx *ww) > > > > if (i915_vma_is_map_and_fenceable(vma) && !HAS_LLC(vma->vm->i915)) { > > > > addr = (void __force *)i915_vma_pin_iomap(vma); > > > > } else { > > > > - int type = i915_coherent_map_type(vma->vm->i915, vma->obj, false); > > > > + int type = intel_gt_coherent_map_type(vma->vm->gt, vma->obj, false); > > > > addr = i915_gem_object_pin_map(vma->obj, type); > > > > } > > > > diff --git a/drivers/gpu/drm/i915/gt/selftest_context.c b/drivers/gpu/drm/i915/gt/selftest_context.c > > > > index 76fbae358072..afce036bcaa8 100644 > > > > --- a/drivers/gpu/drm/i915/gt/selftest_context.c > > > > +++ b/drivers/gpu/drm/i915/gt/selftest_context.c > > > > @@ -88,7 +88,7 @@ static int __live_context_size(struct intel_engine_cs *engine) > > > > goto err; > > > > vaddr = i915_gem_object_pin_map_unlocked(ce->state->obj, > > > > - i915_coherent_map_type(engine->i915, > > > > + intel_gt_coherent_map_type(engine->gt, > > > > ce->state->obj, false)); > > > > if (IS_ERR(vaddr)) { > > > > err = PTR_ERR(vaddr); > > > > diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > > > > index 8b0d84f2aad2..0dd4d00ee894 100644 > > > > --- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > > > > +++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c > > > > @@ -73,7 +73,7 @@ static int hang_init(struct hang *h, struct intel_gt *gt) > > > > h->seqno = memset(vaddr, 0xff, PAGE_SIZE); > > > > vaddr = i915_gem_object_pin_map_unlocked(h->obj, > > > > - i915_coherent_map_type(gt->i915, h->obj, false)); > > > > + intel_gt_coherent_map_type(gt, h->obj, false)); > > > > if (IS_ERR(vaddr)) { > > > > err = PTR_ERR(vaddr); > > > > goto err_unpin_hws; > > > > @@ -119,7 +119,7 @@ hang_create_request(struct hang *h, struct intel_engine_cs *engine) > > > > return ERR_CAST(obj); > > > > } > > > > - vaddr = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(gt->i915, obj, false)); > > > > + vaddr = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, false)); > > > > if (IS_ERR(vaddr)) { > > > > i915_gem_object_put(obj); > > > > i915_vm_put(vm); > > > > diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c > > > > index a78a3d2c2e16..bc883de02295 100644 > > > > --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c > > > > +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c > > > > @@ -1292,7 +1292,7 @@ static int compare_isolation(struct intel_engine_cs *engine, > > > > } > > > > lrc = i915_gem_object_pin_map_unlocked(ce->state->obj, > > > > - i915_coherent_map_type(engine->i915, > > > > + intel_gt_coherent_map_type(engine->gt, > > > > ce->state->obj, > > > > false)); > > > > if (IS_ERR(lrc)) { > > > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c > > > > index ab1a456f833d..6efb86c93bfc 100644 > > > > --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c > > > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c > > > > @@ -268,7 +268,6 @@ static int gsc_fw_load(struct intel_gsc_uc *gsc) > > > > static int gsc_fw_load_prepare(struct intel_gsc_uc *gsc) > > > > { > > > > struct intel_gt *gt = gsc_uc_to_gt(gsc); > > > > - struct drm_i915_private *i915 = gt->i915; > > > > void *src; > > > > if (!gsc->local) > > > > @@ -278,7 +277,7 @@ static int gsc_fw_load_prepare(struct intel_gsc_uc *gsc) > > > > return -ENOSPC; > > > > src = i915_gem_object_pin_map_unlocked(gsc->fw.obj, > > > > - i915_coherent_map_type(i915, gsc->fw.obj, true)); > > > > + intel_gt_coherent_map_type(gt, gsc->fw.obj, true)); > > > > if (IS_ERR(src)) > > > > return PTR_ERR(src); > > > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c > > > > index 2eb891b270ae..c0fa9d232205 100644 > > > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c > > > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c > > > > @@ -792,7 +792,7 @@ int intel_guc_allocate_and_map_vma(struct intel_guc *guc, u32 size, > > > > return PTR_ERR(vma); > > > > vaddr = i915_gem_object_pin_map_unlocked(vma->obj, > > > > - i915_coherent_map_type(guc_to_gt(guc)->i915, > > > > + intel_gt_coherent_map_type(guc_to_gt(guc), > > > > vma->obj, true)); > > > > if (IS_ERR(vaddr)) { > > > > i915_vma_unpin_and_release(&vma, 0); > > > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c > > > > index 48f506a26e6d..b648238cc675 100644 > > > > --- a/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c > > > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c > > > > @@ -27,7 +27,6 @@ struct mtl_huc_auth_msg_out { > > > > int intel_huc_fw_auth_via_gsccs(struct intel_huc *huc) > > > > { > > > > struct intel_gt *gt = huc_to_gt(huc); > > > > - struct drm_i915_private *i915 = gt->i915; > > > > struct drm_i915_gem_object *obj; > > > > struct mtl_huc_auth_msg_in *msg_in; > > > > struct mtl_huc_auth_msg_out *msg_out; > > > > @@ -43,7 +42,7 @@ int intel_huc_fw_auth_via_gsccs(struct intel_huc *huc) > > > > pkt_offset = i915_ggtt_offset(huc->heci_pkt); > > > > pkt_vaddr = i915_gem_object_pin_map_unlocked(obj, > > > > - i915_coherent_map_type(i915, obj, true)); > > > > + intel_gt_coherent_map_type(gt, obj, true)); > > > > if (IS_ERR(pkt_vaddr)) > > > > return PTR_ERR(pkt_vaddr); > > > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c > > > > index 7aadad5639c3..fc0d05d2df59 100644 > > > > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c > > > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c > > > > @@ -11,6 +11,7 @@ > > > > #include <drm/drm_print.h> > > > > #include "gem/i915_gem_lmem.h" > > > > +#include "gt/intel_gt.h" > > > > #include "gt/intel_gt_print.h" > > > > #include "intel_gsc_binary_headers.h" > > > > #include "intel_gsc_fw.h" > > > > @@ -1213,7 +1214,7 @@ static int uc_fw_rsa_data_create(struct intel_uc_fw *uc_fw) > > > > return PTR_ERR(vma); > > > > vaddr = i915_gem_object_pin_map_unlocked(vma->obj, > > > > - i915_coherent_map_type(gt->i915, vma->obj, true)); > > > > + intel_gt_coherent_map_type(gt, vma->obj, true)); > > > > if (IS_ERR(vaddr)) { > > > > i915_vma_unpin_and_release(&vma, 0); > > > > err = PTR_ERR(vaddr); > > > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c > > > > index c7df47364013..2a600184a077 100644 > > > > --- a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c > > > > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c > > > > @@ -6,6 +6,7 @@ > > > > #include "gem/i915_gem_internal.h" > > > > #include "gt/intel_context.h" > > > > +#include "gt/intel_gt.h" > > > > #include "gt/uc/intel_gsc_fw.h" > > > > #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h" > > > > @@ -336,7 +337,7 @@ gsccs_create_buffer(struct intel_gt *gt, > > > > } > > > > /* return a virtual pointer */ > > > > - *map = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); > > > > + *map = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, true)); > > > > if (IS_ERR(*map)) { > > > > drm_err(&i915->drm, "Failed to map gsccs backend %s.\n", bufname); > > > > err = PTR_ERR(*map); > > > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > > > index 1ce07d7e8769..8e0b5d48ddf6 100644 > > > > --- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > > > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > > > @@ -11,6 +11,7 @@ > > > > #include "gem/i915_gem_lmem.h" > > > > #include "i915_drv.h" > > > > +#include "gt/intel_gt.h" > > > > #include "intel_pxp.h" > > > > #include "intel_pxp_cmd_interface_42.h" > > > > @@ -245,7 +246,7 @@ static int alloc_streaming_command(struct intel_pxp *pxp) > > > > } > > > > /* map the lmem into the virtual memory pointer */ > > > > - cmd = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); > > > > + cmd = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(pxp->ctrl_gt, obj, true)); > > > > if (IS_ERR(cmd)) { > > > > drm_err(&i915->drm, "Failed to map gsc message page!\n"); > > > > err = PTR_ERR(cmd); > > > > diff --git a/drivers/gpu/drm/i915/selftests/igt_spinner.c b/drivers/gpu/drm/i915/selftests/igt_spinner.c > > > > index 3c5e0952f1b8..0f064930ef11 100644 > > > > --- a/drivers/gpu/drm/i915/selftests/igt_spinner.c > > > > +++ b/drivers/gpu/drm/i915/selftests/igt_spinner.c > > > > @@ -97,7 +97,7 @@ int igt_spinner_pin(struct igt_spinner *spin, > > > > if (!spin->batch) { > > > > unsigned int mode; > > > > - mode = i915_coherent_map_type(spin->gt->i915, spin->obj, false); > > > > + mode = intel_gt_coherent_map_type(spin->gt, spin->obj, false); > > > > vaddr = igt_spinner_pin_obj(ce, ww, spin->obj, mode, &spin->batch_vma); > > > > if (IS_ERR(vaddr)) > > > > return PTR_ERR(vaddr); ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric 2023-07-26 15:53 ` [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric Jonathan Cavitt 2023-07-27 11:35 ` Tvrtko Ursulin @ 2023-07-27 12:16 ` Andi Shyti 2023-08-01 14:32 ` Andi Shyti 2 siblings, 0 replies; 21+ messages in thread From: Andi Shyti @ 2023-07-27 12:16 UTC (permalink / raw) To: Jonathan Cavitt; +Cc: chris.p.wilson, intel-gfx, matthew.d.roper, nirmoy.das Hi Jonathan, On Wed, Jul 26, 2023 at 08:53:55AM -0700, Jonathan Cavitt wrote: > Refactor i915_coherent_map_type to be GT-centric rather than > device-centric. Each GT may require different coherency > handling due to hardware workarounds. > > Since the function now takes a GT instead of the i915, the function is > renamed and moved to the gt folder. [...] > --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c > @@ -465,21 +465,6 @@ void *i915_gem_object_pin_map_unlocked(struct drm_i915_gem_object *obj, > return ret; > } > > -enum i915_map_type i915_coherent_map_type(struct drm_i915_private *i915, > - struct drm_i915_gem_object *obj, > - bool always_coherent) > -{ > - /* > - * Wa_22016122933: always return I915_MAP_WC for MTL > - */ > - if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(i915)) > - return I915_MAP_WC; > - if (HAS_LLC(i915) || always_coherent) > - return I915_MAP_WB; > - else > - return I915_MAP_WC; > -} > - [...] > --- a/drivers/gpu/drm/i915/gt/intel_gt.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c > @@ -1134,6 +1134,21 @@ void intel_gt_invalidate_tlb(struct intel_gt *gt, u32 seqno) > } > } > > +enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, > + struct drm_i915_gem_object *obj, > + bool always_coherent) > +{ > + /* > + * Wa_22016122933: always return I915_MAP_WC for MTL > + */ > + if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(gt->i915)) > + return I915_MAP_WC; > + if (HAS_LLC(gt->i915) || always_coherent) > + return I915_MAP_WB; > + else > + return I915_MAP_WC; > +} > + yep! That's how it should be! Thanks for moving it. I'm just thinking whether intel_gt.c is the right place to put it... I'm anyway OK with it. > --- a/drivers/gpu/drm/i915/gt/intel_ring.c > +++ b/drivers/gpu/drm/i915/gt/intel_ring.c > @@ -13,6 +13,7 @@ > #include "intel_engine_regs.h" > #include "intel_gpu_commands.h" > #include "intel_ring.h" > +#include "intel_gt.h" mmhhh... pity... this required this extra include because it needs the prototype of intel_gt_coherent_map_type(); Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric 2023-07-26 15:53 ` [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric Jonathan Cavitt 2023-07-27 11:35 ` Tvrtko Ursulin 2023-07-27 12:16 ` Andi Shyti @ 2023-08-01 14:32 ` Andi Shyti 2 siblings, 0 replies; 21+ messages in thread From: Andi Shyti @ 2023-08-01 14:32 UTC (permalink / raw) To: Jonathan Cavitt; +Cc: chris.p.wilson, intel-gfx, matthew.d.roper, nirmoy.das Hi Jonathan, Apparently checkpatch is complaining... [...] > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > index 119deb9f938c..1897cb5aa2a2 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > @@ -1191,7 +1191,7 @@ lrc_pre_pin(struct intel_context *ce, > GEM_BUG_ON(!i915_vma_is_pinned(ce->state)); > > *vaddr = i915_gem_object_pin_map(ce->state->obj, > - i915_coherent_map_type(ce->engine->i915, > + intel_gt_coherent_map_type(ce->engine->gt, > ce->state->obj, > false) | ... here: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > I915_MAP_OVERRIDE); [...] > diff --git a/drivers/gpu/drm/i915/gt/selftest_context.c b/drivers/gpu/drm/i915/gt/selftest_context.c > index 76fbae358072..afce036bcaa8 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_context.c > +++ b/drivers/gpu/drm/i915/gt/selftest_context.c > @@ -88,7 +88,7 @@ static int __live_context_size(struct intel_engine_cs *engine) > goto err; > > vaddr = i915_gem_object_pin_map_unlocked(ce->state->obj, > - i915_coherent_map_type(engine->i915, > + intel_gt_coherent_map_type(engine->gt, > ce->state->obj, false)); ... here: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > if (IS_ERR(vaddr)) { > err = PTR_ERR(vaddr); [...] > diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c > index a78a3d2c2e16..bc883de02295 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c > +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c > @@ -1292,7 +1292,7 @@ static int compare_isolation(struct intel_engine_cs *engine, > } > > lrc = i915_gem_object_pin_map_unlocked(ce->state->obj, > - i915_coherent_map_type(engine->i915, > + intel_gt_coherent_map_type(engine->gt, > ce->state->obj, > false)); ... here: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > if (IS_ERR(lrc)) { [...] > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c > index 2eb891b270ae..c0fa9d232205 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c > @@ -792,7 +792,7 @@ int intel_guc_allocate_and_map_vma(struct intel_guc *guc, u32 size, > return PTR_ERR(vma); > > vaddr = i915_gem_object_pin_map_unlocked(vma->obj, > - i915_coherent_map_type(guc_to_gt(guc)->i915, > + intel_gt_coherent_map_type(guc_to_gt(guc), > vma->obj, true)); ... here: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis > if (IS_ERR(vaddr)) { > i915_vma_unpin_and_release(&vma, 0); [...] > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > index 1ce07d7e8769..8e0b5d48ddf6 100644 > --- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > @@ -11,6 +11,7 @@ > #include "gem/i915_gem_lmem.h" > > #include "i915_drv.h" > +#include "gt/intel_gt.h" > > #include "intel_pxp.h" > #include "intel_pxp_cmd_interface_42.h" > @@ -245,7 +246,7 @@ static int alloc_streaming_command(struct intel_pxp *pxp) > } > > /* map the lmem into the virtual memory pointer */ > - cmd = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); > + cmd = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(pxp->ctrl_gt, obj, true)); ... and here: WARNING:LONG_LINE: line length of 105 exceeds 100 columns Can you please fix those, run again checkpatch.pl and resend? Thanks, Andi > if (IS_ERR(cmd)) { > drm_err(&i915->drm, "Failed to map gsc message page!\n"); > err = PTR_ERR(cmd); ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915/gt: Apply workaround 22016122933 correctly 2023-07-26 15:53 [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Jonathan Cavitt 2023-07-26 15:53 ` [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric Jonathan Cavitt @ 2023-07-26 15:53 ` Jonathan Cavitt 2023-07-27 12:20 ` Andi Shyti 2023-07-26 16:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Patchwork ` (9 subsequent siblings) 11 siblings, 1 reply; 21+ messages in thread From: Jonathan Cavitt @ 2023-07-26 15:53 UTC (permalink / raw) To: intel-gfx Cc: andi.shyti, chris.p.wilson, jonathan.cavitt, matthew.d.roper, nirmoy.das WA_22016122933 was recently applied to all MeteorLake engines, which is simultaneously too broad (should only apply to Media engines) and too specific (should apply to all platforms that use the same media engine as MeteorLake). Correct this in cases where coherency settings are modified. There were also two additional places where the workaround was applied unconditionally. The change was confirmed as necessary for all platforms, so the workaround label was removed. Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> Suggested-by: Matt Roper <matthew.d.roper@intel.com> --- drivers/gpu/drm/i915/gt/intel_gt.c | 5 +++-- drivers/gpu/drm/i915/gt/intel_gt.h | 6 ++++++ drivers/gpu/drm/i915/gt/intel_lrc.c | 7 ++++--- drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 4 ---- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 7 ++++--- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 4 ---- 6 files changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c index 62eda0ab9bfc..b0f029f2380d 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.c +++ b/drivers/gpu/drm/i915/gt/intel_gt.c @@ -1139,9 +1139,10 @@ enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, bool always_coherent) { /* - * Wa_22016122933: always return I915_MAP_WC for MTL + * Wa_22016122933: always return I915_MAP_WC for Media + * version 13.0 when the object is on the Media GT */ - if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(gt->i915)) + if (i915_gem_object_is_lmem(obj) || intel_gt_needs_wa_22016122933(gt)) return I915_MAP_WC; if (HAS_LLC(gt->i915) || always_coherent) return I915_MAP_WB; diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h b/drivers/gpu/drm/i915/gt/intel_gt.h index adb442aaa522..2444ceb42b1b 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.h +++ b/drivers/gpu/drm/i915/gt/intel_gt.h @@ -6,6 +6,7 @@ #ifndef __INTEL_GT__ #define __INTEL_GT__ +#include "i915_drv.h" #include "intel_engine_types.h" #include "intel_gt_types.h" #include "intel_reset.h" @@ -24,6 +25,11 @@ static inline bool gt_is_root(struct intel_gt *gt) return !gt->info.id; } +static inline bool intel_gt_needs_wa_22016122933(struct intel_gt *gt) +{ + return MEDIA_VER_FULL(gt->i915) == IP_VER(13, 0) && gt->type == GT_MEDIA; +} + static inline struct intel_gt *uc_to_gt(struct intel_uc *uc) { return container_of(uc, struct intel_gt, uc); diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index 1897cb5aa2a2..1c43276ae4b1 100644 --- a/drivers/gpu/drm/i915/gt/intel_lrc.c +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c @@ -1095,10 +1095,11 @@ __lrc_alloc_state(struct intel_context *ce, struct intel_engine_cs *engine) if (IS_ERR(obj)) { obj = i915_gem_object_create_shmem(engine->i915, context_size); /* - * Wa_22016122933: For MTL the shared memory needs to be mapped - * as WC on CPU side and UC (PAT index 2) on GPU side + * Wa_22016122933: For Media version 13.0, all Media GT shared + * memory needs to be mapped as WC on CPU side and UC (PAT + * index 2) on GPU side. */ - if (IS_METEORLAKE(engine->i915)) + if (intel_gt_needs_wa_22016122933(engine->gt)) i915_gem_object_set_cache_coherency(obj, I915_CACHE_NONE); } if (IS_ERR(obj)) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c index 6efb86c93bfc..52652a0350c6 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c @@ -284,10 +284,6 @@ static int gsc_fw_load_prepare(struct intel_gsc_uc *gsc) memcpy_toio(gsc->local_vaddr, src, gsc->fw.size); memset_io(gsc->local_vaddr + gsc->fw.size, 0, gsc->local->size - gsc->fw.size); - /* - * Wa_22016122933: Making sure the data in dst is - * visible to GSC right away - */ intel_guc_write_barrier(>->uc.guc); i915_gem_object_unpin_map(gsc->fw.obj); diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c index c0fa9d232205..63bdc000d76b 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c @@ -745,10 +745,11 @@ struct i915_vma *intel_guc_allocate_vma(struct intel_guc *guc, u32 size) return ERR_CAST(obj); /* - * Wa_22016122933: For MTL the shared memory needs to be mapped - * as WC on CPU side and UC (PAT index 2) on GPU side + * Wa_22016122933: For Media version 13.0, all Media GT shared + * memory needs to be mapped as WC on CPU side and UC (PAT + * index 2) on GPU side. */ - if (IS_METEORLAKE(gt->i915)) + if (intel_gt_needs_wa_22016122933(gt)) i915_gem_object_set_cache_coherency(obj, I915_CACHE_NONE); vma = i915_vma_instance(obj, >->ggtt->vm, NULL); diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c index f28a3a83742d..97eadd08181d 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c @@ -960,10 +960,6 @@ static int ct_read(struct intel_guc_ct *ct, struct ct_incoming_msg **msg) /* now update descriptor */ WRITE_ONCE(desc->head, head); - /* - * Wa_22016122933: Making sure the head update is - * visible to GuC right away - */ intel_guc_write_barrier(ct_to_guc(ct)); return available - len; -- 2.25.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915/gt: Apply workaround 22016122933 correctly 2023-07-26 15:53 ` [Intel-gfx] [PATCH 3/3] drm/i915/gt: Apply workaround 22016122933 correctly Jonathan Cavitt @ 2023-07-27 12:20 ` Andi Shyti 0 siblings, 0 replies; 21+ messages in thread From: Andi Shyti @ 2023-07-27 12:20 UTC (permalink / raw) To: Jonathan Cavitt; +Cc: chris.p.wilson, intel-gfx, matthew.d.roper, nirmoy.das Hi Jonathan, On Wed, Jul 26, 2023 at 08:53:56AM -0700, Jonathan Cavitt wrote: > WA_22016122933 was recently applied to all MeteorLake engines, which is > simultaneously too broad (should only apply to Media engines) and too > specific (should apply to all platforms that use the same media engine > as MeteorLake). Correct this in cases where coherency settings are > modified. > > There were also two additional places where the workaround was applied > unconditionally. The change was confirmed as necessary for all > platforms, so the workaround label was removed. > > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> > Suggested-by: Matt Roper <matthew.d.roper@intel.com> nitpick: the tag part is in chronological order. First Matt suggested it and then you developed and sent. > --- > drivers/gpu/drm/i915/gt/intel_gt.c | 5 +++-- > drivers/gpu/drm/i915/gt/intel_gt.h | 6 ++++++ > drivers/gpu/drm/i915/gt/intel_lrc.c | 7 ++++--- > drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 4 ---- > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 7 ++++--- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 4 ---- > 6 files changed, 17 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c > index 62eda0ab9bfc..b0f029f2380d 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c > @@ -1139,9 +1139,10 @@ enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, > bool always_coherent) > { > /* > - * Wa_22016122933: always return I915_MAP_WC for MTL > + * Wa_22016122933: always return I915_MAP_WC for Media > + * version 13.0 when the object is on the Media GT > */ > - if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(gt->i915)) > + if (i915_gem_object_is_lmem(obj) || intel_gt_needs_wa_22016122933(gt)) > return I915_MAP_WC; > if (HAS_LLC(gt->i915) || always_coherent) > return I915_MAP_WB; > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h b/drivers/gpu/drm/i915/gt/intel_gt.h > index adb442aaa522..2444ceb42b1b 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt.h > +++ b/drivers/gpu/drm/i915/gt/intel_gt.h > @@ -6,6 +6,7 @@ > #ifndef __INTEL_GT__ > #define __INTEL_GT__ > > +#include "i915_drv.h" > #include "intel_engine_types.h" > #include "intel_gt_types.h" > #include "intel_reset.h" > @@ -24,6 +25,11 @@ static inline bool gt_is_root(struct intel_gt *gt) > return !gt->info.id; > } > > +static inline bool intel_gt_needs_wa_22016122933(struct intel_gt *gt) > +{ > + return MEDIA_VER_FULL(gt->i915) == IP_VER(13, 0) && gt->type == GT_MEDIA; > +} > + I like this format! I think we should make it a standard way to handle workarounds. Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi [...] ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection 2023-07-26 15:53 [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Jonathan Cavitt 2023-07-26 15:53 ` [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric Jonathan Cavitt 2023-07-26 15:53 ` [Intel-gfx] [PATCH 3/3] drm/i915/gt: Apply workaround 22016122933 correctly Jonathan Cavitt @ 2023-07-26 16:37 ` Patchwork 2023-07-26 16:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork ` (8 subsequent siblings) 11 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2023-07-26 16:37 UTC (permalink / raw) To: Jonathan Cavitt; +Cc: intel-gfx == Series Details == Series: series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection URL : https://patchwork.freedesktop.org/series/121373/ State : warning == Summary == Error: dim checkpatch failed dd84f9f99c63 drm/i915/gt: Simplify shmem_create_from_object map_type selection bf170c1d59f6 drm/i915: Make i915_coherent_map_type GT-centric -:216: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #216: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1195: + intel_gt_coherent_map_type(ce->engine->gt, ce->state->obj, -:250: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #250: FILE: drivers/gpu/drm/i915/gt/selftest_context.c:92: + intel_gt_coherent_map_type(engine->gt, ce->state->obj, false)); -:285: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #285: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1296: + intel_gt_coherent_map_type(engine->gt, ce->state->obj, -:319: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #319: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc.c:796: + intel_gt_coherent_map_type(guc_to_gt(guc), vma->obj, true)); -:402: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #402: FILE: drivers/gpu/drm/i915/pxp/intel_pxp_tee.c:249: + cmd = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(pxp->ctrl_gt, obj, true)); total: 0 errors, 1 warnings, 4 checks, 290 lines checked 8f99ef785777 drm/i915/gt: Apply workaround 22016122933 correctly ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection 2023-07-26 15:53 [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Jonathan Cavitt ` (2 preceding siblings ...) 2023-07-26 16:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Patchwork @ 2023-07-26 16:37 ` Patchwork 2023-07-26 16:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (7 subsequent siblings) 11 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2023-07-26 16:37 UTC (permalink / raw) To: Jonathan Cavitt; +Cc: intel-gfx == Series Details == Series: series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection URL : https://patchwork.freedesktop.org/series/121373/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection 2023-07-26 15:53 [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Jonathan Cavitt ` (3 preceding siblings ...) 2023-07-26 16:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork @ 2023-07-26 16:51 ` Patchwork 2023-07-26 20:30 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork ` (6 subsequent siblings) 11 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2023-07-26 16:51 UTC (permalink / raw) To: Jonathan Cavitt; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 10192 bytes --] == Series Details == Series: series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection URL : https://patchwork.freedesktop.org/series/121373/ State : success == Summary == CI Bug Log - changes from CI_DRM_13426 -> Patchwork_121373v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/index.html Participating hosts (41 -> 41) ------------------------------ Additional (1): bat-adlp-11 Missing (1): fi-snb-2520m Known issues ------------ Here are the changes found in Patchwork_121373v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@core_auth@basic-auth: - bat-adlp-11: NOTRUN -> [ABORT][1] ([i915#8011]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-adlp-11/igt@core_auth@basic-auth.html * igt@gem_exec_suspend@basic-s0@smem: - fi-skl-6600u: [PASS][2] -> [ABORT][3] ([i915#5122]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/fi-skl-6600u/igt@gem_exec_suspend@basic-s0@smem.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/fi-skl-6600u/igt@gem_exec_suspend@basic-s0@smem.html * igt@gem_exec_suspend@basic-s3@lmem0: - bat-dg2-9: [PASS][4] -> [INCOMPLETE][5] ([i915#7793]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/bat-dg2-9/igt@gem_exec_suspend@basic-s3@lmem0.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-dg2-9/igt@gem_exec_suspend@basic-s3@lmem0.html * igt@i915_module_load@load: - bat-adlp-11: NOTRUN -> [DMESG-WARN][6] ([i915#4423]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-adlp-11/igt@i915_module_load@load.html * igt@i915_pm_rpm@basic-rte: - fi-skl-guc: [PASS][7] -> [FAIL][8] ([i915#7940]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/fi-skl-guc/igt@i915_pm_rpm@basic-rte.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/fi-skl-guc/igt@i915_pm_rpm@basic-rte.html * igt@i915_selftest@live@slpc: - bat-mtlp-6: [PASS][9] -> [DMESG-WARN][10] ([i915#6367]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/bat-mtlp-6/igt@i915_selftest@live@slpc.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-mtlp-6/igt@i915_selftest@live@slpc.html - bat-rpls-2: NOTRUN -> [DMESG-WARN][11] ([i915#6367]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-rpls-2/igt@i915_selftest@live@slpc.html - bat-rpls-1: NOTRUN -> [DMESG-WARN][12] ([i915#6367]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-rpls-1/igt@i915_selftest@live@slpc.html * igt@i915_suspend@basic-s3-without-i915: - bat-rpls-1: NOTRUN -> [ABORT][13] ([i915#6687] / [i915#7978] / [i915#8668]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_chamelium_hpd@common-hpd-after-suspend: - bat-rpls-2: NOTRUN -> [SKIP][14] ([i915#7828]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-rpls-2/igt@kms_chamelium_hpd@common-hpd-after-suspend.html - bat-jsl-3: NOTRUN -> [SKIP][15] ([i915#7828]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-jsl-3/igt@kms_chamelium_hpd@common-hpd-after-suspend.html * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1: - bat-rplp-1: [PASS][16] -> [ABORT][17] ([i915#8442] / [i915#8668]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html * igt@kms_pipe_crc_basic@suspend-read-crc: - bat-rpls-2: NOTRUN -> [SKIP][18] ([i915#1845]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-rpls-2/igt@kms_pipe_crc_basic@suspend-read-crc.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s0@smem: - bat-jsl-3: [ABORT][19] ([i915#5122]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/bat-jsl-3/igt@gem_exec_suspend@basic-s0@smem.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-jsl-3/igt@gem_exec_suspend@basic-s0@smem.html * igt@i915_pm_rpm@basic-rte: - fi-kbl-x1275: [FAIL][21] ([i915#8843]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/fi-kbl-x1275/igt@i915_pm_rpm@basic-rte.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/fi-kbl-x1275/igt@i915_pm_rpm@basic-rte.html * igt@i915_pm_rpm@module-reload: - fi-rkl-11600: [FAIL][23] ([i915#7940]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live@gt_heartbeat: - fi-apl-guc: [DMESG-FAIL][25] ([i915#5334]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html * igt@i915_selftest@live@migrate: - bat-mtlp-6: [DMESG-FAIL][27] ([i915#7699]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/bat-mtlp-6/igt@i915_selftest@live@migrate.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-mtlp-6/igt@i915_selftest@live@migrate.html - bat-mtlp-8: [DMESG-FAIL][29] ([i915#7699]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/bat-mtlp-8/igt@i915_selftest@live@migrate.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-mtlp-8/igt@i915_selftest@live@migrate.html * igt@i915_selftest@live@requests: - bat-mtlp-8: [DMESG-FAIL][31] ([i915#8497]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/bat-mtlp-8/igt@i915_selftest@live@requests.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-mtlp-8/igt@i915_selftest@live@requests.html - bat-mtlp-6: [DMESG-FAIL][33] ([i915#7269]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/bat-mtlp-6/igt@i915_selftest@live@requests.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-mtlp-6/igt@i915_selftest@live@requests.html * igt@i915_selftest@live@reset: - bat-rpls-1: [ABORT][35] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/bat-rpls-1/igt@i915_selftest@live@reset.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-rpls-1/igt@i915_selftest@live@reset.html - bat-rpls-2: [ABORT][37] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/bat-rpls-2/igt@i915_selftest@live@reset.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-rpls-2/igt@i915_selftest@live@reset.html * igt@i915_suspend@basic-s3-without-i915: - bat-jsl-3: [FAIL][39] ([fdo#103375]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/bat-jsl-3/igt@i915_suspend@basic-s3-without-i915.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/bat-jsl-3/igt@i915_suspend@basic-s3-without-i915.html [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122 [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367 [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687 [i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269 [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461 [i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699 [i915#7793]: https://gitlab.freedesktop.org/drm/intel/issues/7793 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 [i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940 [i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978 [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011 [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347 [i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384 [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442 [i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497 [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668 [i915#8843]: https://gitlab.freedesktop.org/drm/intel/issues/8843 Build changes ------------- * Linux: CI_DRM_13426 -> Patchwork_121373v1 CI-20190529: 20190529 CI_DRM_13426: 50f130ab3021dd575aca3fab9c08eae15cd323a8 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7405: 6745761cb6050514a12aac973d02aeccdff06255 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_121373v1: 50f130ab3021dd575aca3fab9c08eae15cd323a8 @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits b492225c21e7 drm/i915/gt: Apply workaround 22016122933 correctly 813bf596d716 drm/i915: Make i915_coherent_map_type GT-centric fd5ace07b409 drm/i915/gt: Simplify shmem_create_from_object map_type selection == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/index.html [-- Attachment #2: Type: text/html, Size: 12024 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection 2023-07-26 15:53 [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Jonathan Cavitt ` (4 preceding siblings ...) 2023-07-26 16:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2023-07-26 20:30 ` Patchwork 2023-07-27 11:27 ` [Intel-gfx] [PATCH 1/3] " Tvrtko Ursulin ` (5 subsequent siblings) 11 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2023-07-26 20:30 UTC (permalink / raw) To: Jonathan Cavitt; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 50322 bytes --] == Series Details == Series: series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection URL : https://patchwork.freedesktop.org/series/121373/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13426_full -> Patchwork_121373v1_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_121373v1_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_121373v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_121373v1_full: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_fence@basic-wait-all: - shard-rkl: [PASS][1] -> [ABORT][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-rkl-6/igt@gem_exec_fence@basic-wait-all.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-1/igt@gem_exec_fence@basic-wait-all.html Known issues ------------ Here are the changes found in Patchwork_121373v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@drm_fdinfo@busy-hang@rcs0: - shard-mtlp: NOTRUN -> [SKIP][3] ([i915#8414]) +11 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@drm_fdinfo@busy-hang@rcs0.html * igt@drm_fdinfo@most-busy-check-all@rcs0: - shard-rkl: [PASS][4] -> [FAIL][5] ([i915#7742]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-rkl-1/igt@drm_fdinfo@most-busy-check-all@rcs0.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-7/igt@drm_fdinfo@most-busy-check-all@rcs0.html * igt@gem_basic@multigpu-create-close: - shard-rkl: NOTRUN -> [SKIP][6] ([i915#7697]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@gem_basic@multigpu-create-close.html * igt@gem_ccs@ctrl-surf-copy: - shard-mtlp: NOTRUN -> [SKIP][7] ([i915#5325]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@gem_ccs@ctrl-surf-copy.html * igt@gem_ctx_persistence@file: - shard-snb: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1099]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-snb2/igt@gem_ctx_persistence@file.html * igt@gem_ctx_persistence@heartbeat-hostile: - shard-mtlp: NOTRUN -> [SKIP][9] ([i915#8555]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@gem_ctx_persistence@heartbeat-hostile.html * igt@gem_eio@in-flight-contexts-10ms: - shard-apl: [PASS][10] -> [TIMEOUT][11] ([i915#3063]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-apl6/igt@gem_eio@in-flight-contexts-10ms.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-apl4/igt@gem_eio@in-flight-contexts-10ms.html * igt@gem_exec_balancer@parallel-balancer: - shard-rkl: NOTRUN -> [SKIP][12] ([i915#4525]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@gem_exec_balancer@parallel-balancer.html * igt@gem_exec_capture@pi@ccs0: - shard-mtlp: [PASS][13] -> [FAIL][14] ([i915#7765]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-1/igt@gem_exec_capture@pi@ccs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-2/igt@gem_exec_capture@pi@ccs0.html * igt@gem_exec_capture@pi@vcs0: - shard-mtlp: [PASS][15] -> [FAIL][16] ([i915#4475]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-1/igt@gem_exec_capture@pi@vcs0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-2/igt@gem_exec_capture@pi@vcs0.html * igt@gem_exec_endless@dispatch@vcs0: - shard-mtlp: [PASS][17] -> [TIMEOUT][18] ([i915#3778] / [i915#7941]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-3/igt@gem_exec_endless@dispatch@vcs0.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-1/igt@gem_exec_endless@dispatch@vcs0.html * igt@gem_exec_fair@basic-deadline: - shard-rkl: [PASS][19] -> [FAIL][20] ([i915#2846]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-rkl-4/igt@gem_exec_fair@basic-deadline.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-2/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-rkl: [PASS][21] -> [FAIL][22] ([i915#2842]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-rkl-6/igt@gem_exec_fair@basic-none-share@rcs0.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-1/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-apl: [PASS][23] -> [FAIL][24] ([i915#2842]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_fence@submit67: - shard-mtlp: NOTRUN -> [SKIP][25] ([i915#4812]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@gem_exec_fence@submit67.html * igt@gem_exec_reloc@basic-cpu-gtt-active: - shard-rkl: NOTRUN -> [SKIP][26] ([i915#3281]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@gem_exec_reloc@basic-cpu-gtt-active.html * igt@gem_exec_reloc@basic-range: - shard-mtlp: NOTRUN -> [SKIP][27] ([i915#3281]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@gem_exec_reloc@basic-range.html * igt@gem_exec_suspend@basic-s3@smem: - shard-snb: NOTRUN -> [DMESG-WARN][28] ([i915#8841]) +4 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-snb6/igt@gem_exec_suspend@basic-s3@smem.html * igt@gem_lmem_swapping@heavy-random: - shard-glk: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#4613]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-glk6/igt@gem_lmem_swapping@heavy-random.html * igt@gem_lmem_swapping@parallel-multi: - shard-rkl: NOTRUN -> [SKIP][30] ([i915#4613]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@gem_lmem_swapping@parallel-multi.html * igt@gem_lmem_swapping@verify: - shard-mtlp: NOTRUN -> [SKIP][31] ([i915#4613]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@gem_lmem_swapping@verify.html * igt@gem_partial_pwrite_pread@writes-after-reads-uncached: - shard-rkl: NOTRUN -> [SKIP][32] ([i915#3282]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html * igt@gem_pwrite@basic-exhaustion: - shard-snb: NOTRUN -> [WARN][33] ([i915#2658]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-snb6/igt@gem_pwrite@basic-exhaustion.html * igt@gem_pxp@dmabuf-shared-protected-dst-is-context-refcounted: - shard-mtlp: NOTRUN -> [SKIP][34] ([i915#4270]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@gem_pxp@dmabuf-shared-protected-dst-is-context-refcounted.html * igt@gem_pxp@reject-modify-context-protection-on: - shard-rkl: NOTRUN -> [SKIP][35] ([i915#4270]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@gem_pxp@reject-modify-context-protection-on.html * igt@gem_render_copy@yf-tiled-to-vebox-x-tiled: - shard-mtlp: NOTRUN -> [SKIP][36] ([i915#8428]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@gem_render_copy@yf-tiled-to-vebox-x-tiled.html * igt@gem_userptr_blits@forbidden-operations: - shard-mtlp: NOTRUN -> [SKIP][37] ([i915#3282]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-5/igt@gem_userptr_blits@forbidden-operations.html * igt@gem_userptr_blits@readonly-pwrite-unsync: - shard-rkl: NOTRUN -> [SKIP][38] ([i915#3297]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@gem_userptr_blits@readonly-pwrite-unsync.html * igt@gen7_exec_parse@cmd-crossing-page: - shard-rkl: NOTRUN -> [SKIP][39] ([fdo#109289]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@gen7_exec_parse@cmd-crossing-page.html * igt@gen9_exec_parse@allowed-single: - shard-mtlp: NOTRUN -> [SKIP][40] ([i915#2856]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@gen9_exec_parse@allowed-single.html * igt@gen9_exec_parse@bb-start-out: - shard-rkl: NOTRUN -> [SKIP][41] ([i915#2527]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@gen9_exec_parse@bb-start-out.html * igt@i915_pm_freq_mult@media-freq@gt0: - shard-rkl: NOTRUN -> [SKIP][42] ([i915#6590]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@i915_pm_freq_mult@media-freq@gt0.html * igt@i915_pm_rc6_residency@rc6-accuracy: - shard-dg2: [PASS][43] -> [FAIL][44] ([i915#8230]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg2-12/igt@i915_pm_rc6_residency@rc6-accuracy.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-3/igt@i915_pm_rc6_residency@rc6-accuracy.html * igt@i915_pm_rc6_residency@rc6-idle@rcs0: - shard-dg1: [PASS][45] -> [FAIL][46] ([i915#3591]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg1-17/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html * igt@i915_pm_rpm@basic-pci-d3-state: - shard-dg1: [PASS][47] -> [FAIL][48] ([i915#7691]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg1-19/igt@i915_pm_rpm@basic-pci-d3-state.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-14/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_pm_rpm@dpms-mode-unset-lpsp: - shard-dg2: [PASS][49] -> [SKIP][50] ([i915#1397]) +2 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg2-10/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-8/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html - shard-dg1: [PASS][51] -> [SKIP][52] ([i915#1397]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg1-19/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-15/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html * igt@i915_pm_rpm@dpms-non-lpsp: - shard-rkl: [PASS][53] -> [SKIP][54] ([i915#1397]) +1 similar issue [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-rkl-2/igt@i915_pm_rpm@dpms-non-lpsp.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-7/igt@i915_pm_rpm@dpms-non-lpsp.html * igt@i915_pm_rpm@pm-caching: - shard-mtlp: NOTRUN -> [SKIP][55] ([i915#4077]) +3 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-5/igt@i915_pm_rpm@pm-caching.html * igt@i915_pm_rpm@sysfs-read: - shard-dg1: [PASS][56] -> [FAIL][57] ([i915#7940]) +1 similar issue [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg1-17/igt@i915_pm_rpm@sysfs-read.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-13/igt@i915_pm_rpm@sysfs-read.html * igt@i915_pm_rps@min-max-config-idle: - shard-mtlp: NOTRUN -> [SKIP][58] ([i915#6621]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@i915_pm_rps@min-max-config-idle.html * igt@i915_pm_rps@waitboost: - shard-mtlp: NOTRUN -> [FAIL][59] ([i915#8346]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-5/igt@i915_pm_rps@waitboost.html * igt@kms_atomic_transition@plane-all-modeset-transition: - shard-mtlp: NOTRUN -> [SKIP][60] ([i915#1769]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_atomic_transition@plane-all-modeset-transition.html * igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels: - shard-snb: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#1769]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-snb6/igt@kms_atomic_transition@plane-all-modeset-transition-fencing-internal-panels.html * igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels: - shard-rkl: NOTRUN -> [SKIP][62] ([i915#1769] / [i915#3555]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html * igt@kms_big_fb@4-tiled-32bpp-rotate-0: - shard-rkl: NOTRUN -> [SKIP][63] ([i915#5286]) +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_big_fb@4-tiled-32bpp-rotate-0.html * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip: - shard-mtlp: [PASS][64] -> [FAIL][65] ([i915#5138]) +1 similar issue [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-5/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-8/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html * igt@kms_big_fb@x-tiled-16bpp-rotate-90: - shard-rkl: NOTRUN -> [SKIP][66] ([fdo#111614] / [i915#3638]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_big_fb@x-tiled-16bpp-rotate-90.html * igt@kms_big_fb@x-tiled-32bpp-rotate-270: - shard-mtlp: NOTRUN -> [SKIP][67] ([fdo#111614]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_big_fb@x-tiled-32bpp-rotate-270.html * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0: - shard-mtlp: NOTRUN -> [SKIP][68] ([fdo#111615]) +1 similar issue [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-0: - shard-rkl: NOTRUN -> [SKIP][69] ([fdo#110723]) +1 similar issue [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_big_fb@yf-tiled-64bpp-rotate-0.html * igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs: - shard-glk: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#3886]) +3 similar issues [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-glk6/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-b-ccs-on-another-bo-yf_tiled_ccs: - shard-rkl: NOTRUN -> [SKIP][71] ([i915#3734] / [i915#5354] / [i915#6095]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_ccs@pipe-b-ccs-on-another-bo-yf_tiled_ccs.html * igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_ccs: - shard-snb: NOTRUN -> [SKIP][72] ([fdo#109271]) +189 similar issues [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-snb2/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_ccs.html * igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_mtl_rc_ccs_cc: - shard-rkl: NOTRUN -> [SKIP][73] ([i915#5354] / [i915#6095]) +4 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-4_tiled_mtl_rc_ccs_cc.html * igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs: - shard-mtlp: NOTRUN -> [SKIP][74] ([i915#6095]) +7 similar issues [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-5/igt@kms_ccs@pipe-b-random-ccs-data-4_tiled_dg2_rc_ccs.html * igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs: - shard-mtlp: NOTRUN -> [SKIP][75] ([i915#3886] / [i915#6095]) +3 similar issues [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-5/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-c-random-ccs-data-yf_tiled_ccs: - shard-rkl: NOTRUN -> [SKIP][76] ([i915#5354]) +7 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_ccs@pipe-c-random-ccs-data-yf_tiled_ccs.html * igt@kms_cdclk@plane-scaling@pipe-a-hdmi-a-2: - shard-dg2: NOTRUN -> [SKIP][77] ([i915#4087]) +3 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-2/igt@kms_cdclk@plane-scaling@pipe-a-hdmi-a-2.html * igt@kms_chamelium_color@ctm-0-75: - shard-rkl: NOTRUN -> [SKIP][78] ([fdo#111827]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_chamelium_color@ctm-0-75.html * igt@kms_chamelium_color@ctm-blue-to-red: - shard-mtlp: NOTRUN -> [SKIP][79] ([fdo#111827]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_chamelium_color@ctm-blue-to-red.html * igt@kms_chamelium_hpd@hdmi-hpd-fast: - shard-rkl: NOTRUN -> [SKIP][80] ([i915#7828]) +1 similar issue [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_chamelium_hpd@hdmi-hpd-fast.html * igt@kms_chamelium_hpd@vga-hpd: - shard-mtlp: NOTRUN -> [SKIP][81] ([i915#7828]) +1 similar issue [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_chamelium_hpd@vga-hpd.html * igt@kms_concurrent@pipe-c: - shard-rkl: NOTRUN -> [SKIP][82] ([i915#4070] / [i915#6768]) +1 similar issue [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_concurrent@pipe-c.html * igt@kms_content_protection@dp-mst-lic-type-0: - shard-mtlp: NOTRUN -> [SKIP][83] ([i915#3299]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_content_protection@dp-mst-lic-type-0.html * igt@kms_content_protection@uevent@pipe-a-dp-2: - shard-dg2: NOTRUN -> [FAIL][84] ([i915#1339]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-12/igt@kms_content_protection@uevent@pipe-a-dp-2.html * igt@kms_cursor_crc@cursor-sliding-32x32: - shard-rkl: NOTRUN -> [SKIP][85] ([i915#3555]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_cursor_crc@cursor-sliding-32x32.html * igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy: - shard-mtlp: NOTRUN -> [SKIP][86] ([i915#3546]) +1 similar issue [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-apl: [PASS][87] -> [FAIL][88] ([i915#2346]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_dsc@dsc-with-formats: - shard-mtlp: NOTRUN -> [SKIP][89] ([i915#3840]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_dsc@dsc-with-formats.html * igt@kms_flip@2x-flip-vs-fences-interruptible: - shard-mtlp: NOTRUN -> [SKIP][90] ([i915#8381]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_flip@2x-flip-vs-fences-interruptible.html * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible: - shard-mtlp: NOTRUN -> [SKIP][91] ([i915#3637]) +1 similar issue [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html * igt@kms_flip@2x-plain-flip-interruptible: - shard-rkl: NOTRUN -> [SKIP][92] ([fdo#111825]) +1 similar issue [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_flip@2x-plain-flip-interruptible.html * igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode: - shard-rkl: NOTRUN -> [SKIP][93] ([i915#2672]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite: - shard-dg2: [PASS][94] -> [FAIL][95] ([i915#6880]) [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg2-8/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-12/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-dg2: [PASS][96] -> [FAIL][97] ([fdo#103375]) [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg2-2/igt@kms_frontbuffer_tracking@fbc-suspend.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-5/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-gtt: - shard-mtlp: NOTRUN -> [SKIP][98] ([i915#8708]) +1 similar issue [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff: - shard-rkl: NOTRUN -> [SKIP][99] ([fdo#111825] / [i915#1825]) +7 similar issues [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff.html * igt@kms_frontbuffer_tracking@fbcpsr-farfromfence-mmap-gtt: - shard-rkl: NOTRUN -> [SKIP][100] ([i915#3023]) +5 similar issues [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_frontbuffer_tracking@fbcpsr-farfromfence-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-wc: - shard-apl: NOTRUN -> [SKIP][101] ([fdo#109271]) +4 similar issues [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-apl6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-cpu: - shard-mtlp: NOTRUN -> [SKIP][102] ([i915#1825]) +6 similar issues [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html * igt@kms_hdr@invalid-hdr: - shard-rkl: NOTRUN -> [SKIP][103] ([i915#3555] / [i915#8228]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-2/igt@kms_hdr@invalid-hdr.html * igt@kms_hdr@static-swap: - shard-dg2: NOTRUN -> [SKIP][104] ([i915#3555] / [i915#8228]) +1 similar issue [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-3/igt@kms_hdr@static-swap.html * igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1: - shard-rkl: NOTRUN -> [FAIL][105] ([i915#8292]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-7/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1.html * igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4: - shard-dg1: NOTRUN -> [FAIL][106] ([i915#8292]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-14/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4.html * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1: - shard-rkl: NOTRUN -> [SKIP][107] ([i915#5176]) +9 similar issues [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1.html * igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-hdmi-a-3: - shard-dg2: NOTRUN -> [SKIP][108] ([i915#5176]) +7 similar issues [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-3/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-hdmi-a-3.html * igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-4: - shard-dg1: NOTRUN -> [SKIP][109] ([i915#5176]) +27 similar issues [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-14/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-4.html * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-1: - shard-rkl: NOTRUN -> [SKIP][110] ([i915#5235]) +9 similar issues [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-7/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-1.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-3: - shard-dg2: NOTRUN -> [SKIP][111] ([i915#5235]) +15 similar issues [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-8/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-3.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-4: - shard-dg1: NOTRUN -> [SKIP][112] ([i915#5235]) +15 similar issues [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-15/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-4.html * igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf: - shard-glk: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#658]) +1 similar issue [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-glk6/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html * igt@kms_psr@primary_mmap_cpu: - shard-rkl: NOTRUN -> [SKIP][114] ([i915#1072]) [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_psr@primary_mmap_cpu.html * igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0: - shard-mtlp: NOTRUN -> [SKIP][115] ([i915#5289]) [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0.html * igt@kms_setmode@basic@pipe-a-vga-1: - shard-snb: NOTRUN -> [FAIL][116] ([i915#5465]) +1 similar issue [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-snb4/igt@kms_setmode@basic@pipe-a-vga-1.html * igt@kms_tiled_display@basic-test-pattern-with-chamelium: - shard-mtlp: NOTRUN -> [SKIP][117] ([i915#8623]) [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html * igt@kms_vblank@pipe-d-query-busy: - shard-rkl: NOTRUN -> [SKIP][118] ([i915#4070] / [i915#533] / [i915#6768]) +1 similar issue [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_vblank@pipe-d-query-busy.html * igt@kms_vblank@pipe-d-wait-busy-hang: - shard-glk: NOTRUN -> [SKIP][119] ([fdo#109271]) +30 similar issues [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-glk6/igt@kms_vblank@pipe-d-wait-busy-hang.html * igt@perf_pmu@busy-double-start@bcs0: - shard-mtlp: [PASS][120] -> [FAIL][121] ([i915#4349]) +1 similar issue [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-2/igt@perf_pmu@busy-double-start@bcs0.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-6/igt@perf_pmu@busy-double-start@bcs0.html * igt@v3d/v3d_submit_cl@valid-submission: - shard-mtlp: NOTRUN -> [SKIP][122] ([i915#2575]) +3 similar issues [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@v3d/v3d_submit_cl@valid-submission.html * igt@v3d/v3d_submit_csd@valid-multisync-submission: - shard-rkl: NOTRUN -> [SKIP][123] ([fdo#109315]) +2 similar issues [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@v3d/v3d_submit_csd@valid-multisync-submission.html * igt@vc4/vc4_mmap@mmap-bo: - shard-rkl: NOTRUN -> [SKIP][124] ([i915#7711]) +1 similar issue [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@vc4/vc4_mmap@mmap-bo.html * igt@vc4/vc4_purgeable_bo@free-purged-bo: - shard-mtlp: NOTRUN -> [SKIP][125] ([i915#7711]) +1 similar issue [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@vc4/vc4_purgeable_bo@free-purged-bo.html #### Possible fixes #### * igt@gem_barrier_race@remote-request@rcs0: - shard-apl: [ABORT][126] ([i915#7461] / [i915#8211] / [i915#8234] / [i915#8690]) -> [PASS][127] [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-apl2/igt@gem_barrier_race@remote-request@rcs0.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-apl6/igt@gem_barrier_race@remote-request@rcs0.html * igt@gem_caching@reads: - shard-dg1: [DMESG-WARN][128] ([i915#4423]) -> [PASS][129] [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg1-15/igt@gem_caching@reads.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-15/igt@gem_caching@reads.html * igt@gem_create@hog-create@smem0: - shard-dg2: [FAIL][130] ([i915#5892] / [i915#8758]) -> [PASS][131] [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg2-5/igt@gem_create@hog-create@smem0.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-7/igt@gem_create@hog-create@smem0.html * igt@gem_exec_balancer@full-pulse: - shard-dg2: [FAIL][132] ([i915#6032]) -> [PASS][133] [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg2-5/igt@gem_exec_balancer@full-pulse.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-7/igt@gem_exec_balancer@full-pulse.html * igt@gem_exec_whisper@basic-contexts-forked-all: - shard-mtlp: [TIMEOUT][134] ([i915#8628]) -> [PASS][135] [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-2/igt@gem_exec_whisper@basic-contexts-forked-all.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-6/igt@gem_exec_whisper@basic-contexts-forked-all.html * igt@gem_exec_whisper@basic-contexts-priority-all: - shard-mtlp: [ABORT][136] ([i915#8131]) -> [PASS][137] [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-7/igt@gem_exec_whisper@basic-contexts-priority-all.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-3/igt@gem_exec_whisper@basic-contexts-priority-all.html * igt@gem_lmem_swapping@smem-oom@lmem0: - shard-dg2: [DMESG-WARN][138] ([i915#4936] / [i915#5493]) -> [PASS][139] [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg2-3/igt@gem_lmem_swapping@smem-oom@lmem0.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-6/igt@gem_lmem_swapping@smem-oom@lmem0.html - shard-dg1: [TIMEOUT][140] ([i915#5493]) -> [PASS][141] [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg1-18/igt@gem_lmem_swapping@smem-oom@lmem0.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-18/igt@gem_lmem_swapping@smem-oom@lmem0.html * igt@i915_module_load@reload-with-fault-injection: - shard-mtlp: [ABORT][142] ([i915#8489] / [i915#8668]) -> [PASS][143] [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-4/igt@i915_module_load@reload-with-fault-injection.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-5/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_pipe_stress@stress-xrgb8888-untiled: - shard-mtlp: [FAIL][144] ([i915#8691]) -> [PASS][145] [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-2/igt@i915_pipe_stress@stress-xrgb8888-untiled.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-6/igt@i915_pipe_stress@stress-xrgb8888-untiled.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a: - shard-rkl: [SKIP][146] ([i915#1937]) -> [PASS][147] [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-rkl-4/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html * igt@i915_pm_rc6_residency@rc6-idle@bcs0: - shard-dg1: [FAIL][148] ([i915#3591]) -> [PASS][149] [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg1-17/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html * igt@i915_pm_rpm@gem-execbuf-stress@smem0: - shard-dg1: [FAIL][150] ([i915#7940]) -> [PASS][151] [150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg1-15/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-15/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html * igt@i915_pm_rpm@modeset-lpsp: - shard-dg1: [SKIP][152] ([i915#1397]) -> [PASS][153] +1 similar issue [152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg1-14/igt@i915_pm_rpm@modeset-lpsp.html [153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-19/igt@i915_pm_rpm@modeset-lpsp.html * igt@i915_pm_rpm@modeset-lpsp-stress-no-wait: - shard-rkl: [SKIP][154] ([i915#1397]) -> [PASS][155] [154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-rkl-2/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html * igt@i915_selftest@live@gt_mocs: - shard-mtlp: [DMESG-FAIL][156] ([i915#7059]) -> [PASS][157] [156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-1/igt@i915_selftest@live@gt_mocs.html [157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-2/igt@i915_selftest@live@gt_mocs.html * igt@i915_selftest@live@requests: - shard-mtlp: [DMESG-FAIL][158] ([i915#7269]) -> [PASS][159] [158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-1/igt@i915_selftest@live@requests.html [159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-2/igt@i915_selftest@live@requests.html * igt@kms_big_fb@4-tiled-64bpp-rotate-0: - shard-mtlp: [DMESG-WARN][160] ([i915#2017]) -> [PASS][161] [160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-3/igt@kms_big_fb@4-tiled-64bpp-rotate-0.html [161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-1/igt@kms_big_fb@4-tiled-64bpp-rotate-0.html * igt@kms_big_fb@4-tiled-64bpp-rotate-180: - shard-mtlp: [FAIL][162] ([i915#5138]) -> [PASS][163] [162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-4/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html [163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-5/igt@kms_big_fb@4-tiled-64bpp-rotate-180.html * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip: - shard-mtlp: [FAIL][164] ([i915#3743]) -> [PASS][165] +1 similar issue [164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-mtlp-3/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html [165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-mtlp-1/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-apl: [FAIL][166] ([i915#2346]) -> [PASS][167] [166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt: - shard-dg2: [FAIL][168] ([i915#6880]) -> [PASS][169] +1 similar issue [168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html [169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-blt.html * igt@kms_rotation_crc@primary-rotation-90: - shard-rkl: [ABORT][170] ([i915#8311]) -> [PASS][171] [170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-rkl-6/igt@kms_rotation_crc@primary-rotation-90.html [171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_rotation_crc@primary-rotation-90.html * igt@perf@stress-open-close@0-rcs0: - shard-glk: [ABORT][172] ([i915#5213] / [i915#7941]) -> [PASS][173] [172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-glk6/igt@perf@stress-open-close@0-rcs0.html [173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-glk6/igt@perf@stress-open-close@0-rcs0.html #### Warnings #### * igt@i915_pm_rpm@i2c: - shard-dg1: [DMESG-WARN][174] ([i915#4391]) -> [DMESG-WARN][175] ([i915#4391] / [i915#4423]) [174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg1-19/igt@i915_pm_rpm@i2c.html [175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-17/igt@i915_pm_rpm@i2c.html * igt@kms_fbcon_fbt@psr-suspend: - shard-rkl: [SKIP][176] ([fdo#110189] / [i915#3955]) -> [SKIP][177] ([i915#3955]) [176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-rkl-1/igt@kms_fbcon_fbt@psr-suspend.html [177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_fbcon_fbt@psr-suspend.html * igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible: - shard-dg1: [SKIP][178] ([fdo#111825] / [i915#4423]) -> [SKIP][179] ([fdo#111825]) [178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg1-15/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible.html [179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-15/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible.html * igt@kms_force_connector_basic@force-load-detect: - shard-rkl: [SKIP][180] ([fdo#109285]) -> [SKIP][181] ([fdo#109285] / [i915#4098]) [180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-rkl-6/igt@kms_force_connector_basic@force-load-detect.html [181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-1/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_multipipe_modeset@basic-max-pipe-crc-check: - shard-rkl: [SKIP][182] ([i915#4070] / [i915#4816]) -> [SKIP][183] ([i915#4816]) [182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-rkl-1/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html [183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-rkl-4/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html * igt@kms_psr@cursor_plane_move: - shard-dg1: [SKIP][184] ([i915#1072]) -> [SKIP][185] ([i915#1072] / [i915#4078]) +1 similar issue [184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg1-17/igt@kms_psr@cursor_plane_move.html [185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg1-18/igt@kms_psr@cursor_plane_move.html * igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem: - shard-dg2: [INCOMPLETE][186] ([i915#5493]) -> [CRASH][187] ([i915#7331]) [186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13426/shard-dg2-5/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html [187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/shard-dg2-10/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#1339]: https://gitlab.freedesktop.org/drm/intel/issues/1339 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937 [i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023 [i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743 [i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349 [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391 [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423 [i915#4475]: https://gitlab.freedesktop.org/drm/intel/issues/4475 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816 [i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936 [i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465 [i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493 [i915#5892]: https://gitlab.freedesktop.org/drm/intel/issues/5892 [i915#6032]: https://gitlab.freedesktop.org/drm/intel/issues/6032 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 [i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880 [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059 [i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269 [i915#7331]: https://gitlab.freedesktop.org/drm/intel/issues/7331 [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461 [i915#7691]: https://gitlab.freedesktop.org/drm/intel/issues/7691 [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742 [i915#7765]: https://gitlab.freedesktop.org/drm/intel/issues/7765 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940 [i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941 [i915#8131]: https://gitlab.freedesktop.org/drm/intel/issues/8131 [i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211 [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228 [i915#8230]: https://gitlab.freedesktop.org/drm/intel/issues/8230 [i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234 [i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292 [i915#8311]: https://gitlab.freedesktop.org/drm/intel/issues/8311 [i915#8346]: https://gitlab.freedesktop.org/drm/intel/issues/8346 [i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381 [i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414 [i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428 [i915#8489]: https://gitlab.freedesktop.org/drm/intel/issues/8489 [i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555 [i915#8623]: https://gitlab.freedesktop.org/drm/intel/issues/8623 [i915#8628]: https://gitlab.freedesktop.org/drm/intel/issues/8628 [i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661 [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668 [i915#8690]: https://gitlab.freedesktop.org/drm/intel/issues/8690 [i915#8691]: https://gitlab.freedesktop.org/drm/intel/issues/8691 [i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708 [i915#8758]: https://gitlab.freedesktop.org/drm/intel/issues/8758 [i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841 Build changes ------------- * Linux: CI_DRM_13426 -> Patchwork_121373v1 CI-20190529: 20190529 CI_DRM_13426: 50f130ab3021dd575aca3fab9c08eae15cd323a8 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7405: 6745761cb6050514a12aac973d02aeccdff06255 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_121373v1: 50f130ab3021dd575aca3fab9c08eae15cd323a8 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v1/index.html [-- Attachment #2: Type: text/html, Size: 58152 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection 2023-07-26 15:53 [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Jonathan Cavitt ` (5 preceding siblings ...) 2023-07-26 20:30 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2023-07-27 11:27 ` Tvrtko Ursulin 2023-07-27 12:23 ` Andi Shyti ` (4 subsequent siblings) 11 siblings, 0 replies; 21+ messages in thread From: Tvrtko Ursulin @ 2023-07-27 11:27 UTC (permalink / raw) To: Jonathan Cavitt, intel-gfx Cc: matthew.d.roper, chris.p.wilson, andi.shyti, nirmoy.das On 26/07/2023 16:53, Jonathan Cavitt wrote: > The object pin created for shmem_create_from_object is just a > single use mapping with the sole purpose of reading the contents > of the whole object in bulk. And the whole source object is also > even a throw-away. Ergo, the additional logic required by > i915_coherent_map_type can be safely dropped and simplified. > > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> > Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > --- > drivers/gpu/drm/i915/gt/shmem_utils.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/shmem_utils.c b/drivers/gpu/drm/i915/gt/shmem_utils.c > index 449c9ed44382..bccc3a1200bc 100644 > --- a/drivers/gpu/drm/i915/gt/shmem_utils.c > +++ b/drivers/gpu/drm/i915/gt/shmem_utils.c > @@ -33,7 +33,6 @@ struct file *shmem_create_from_data(const char *name, void *data, size_t len) > > struct file *shmem_create_from_object(struct drm_i915_gem_object *obj) > { > - struct drm_i915_private *i915 = to_i915(obj->base.dev); > enum i915_map_type map_type; > struct file *file; > void *ptr; > @@ -44,7 +43,7 @@ struct file *shmem_create_from_object(struct drm_i915_gem_object *obj) > return file; > } > > - map_type = i915_coherent_map_type(i915, obj, true); > + map_type = i915_gem_object_is_lmem(obj) ? I915_MAP_WC : I915_MAP_WB; > ptr = i915_gem_object_pin_map_unlocked(obj, map_type); > if (IS_ERR(ptr)) > return ERR_CAST(ptr); Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection 2023-07-26 15:53 [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Jonathan Cavitt ` (6 preceding siblings ...) 2023-07-27 11:27 ` [Intel-gfx] [PATCH 1/3] " Tvrtko Ursulin @ 2023-07-27 12:23 ` Andi Shyti 2023-08-01 12:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection (rev2) Patchwork ` (3 subsequent siblings) 11 siblings, 0 replies; 21+ messages in thread From: Andi Shyti @ 2023-07-27 12:23 UTC (permalink / raw) To: Jonathan Cavitt; +Cc: chris.p.wilson, intel-gfx, matthew.d.roper, nirmoy.das Hi Jonathan, On Wed, Jul 26, 2023 at 08:53:54AM -0700, Jonathan Cavitt wrote: > The object pin created for shmem_create_from_object is just a > single use mapping with the sole purpose of reading the contents > of the whole object in bulk. And the whole source object is also > even a throw-away. Ergo, the additional logic required by > i915_coherent_map_type can be safely dropped and simplified. > > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> > Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > --- > drivers/gpu/drm/i915/gt/shmem_utils.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/shmem_utils.c b/drivers/gpu/drm/i915/gt/shmem_utils.c > index 449c9ed44382..bccc3a1200bc 100644 > --- a/drivers/gpu/drm/i915/gt/shmem_utils.c > +++ b/drivers/gpu/drm/i915/gt/shmem_utils.c > @@ -33,7 +33,6 @@ struct file *shmem_create_from_data(const char *name, void *data, size_t len) > > struct file *shmem_create_from_object(struct drm_i915_gem_object *obj) > { > - struct drm_i915_private *i915 = to_i915(obj->base.dev); > enum i915_map_type map_type; > struct file *file; > void *ptr; > @@ -44,7 +43,7 @@ struct file *shmem_create_from_object(struct drm_i915_gem_object *obj) > return file; > } > > - map_type = i915_coherent_map_type(i915, obj, true); > + map_type = i915_gem_object_is_lmem(obj) ? I915_MAP_WC : I915_MAP_WB; > ptr = i915_gem_object_pin_map_unlocked(obj, map_type); > if (IS_ERR(ptr)) > return ERR_CAST(ptr); Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thanks, Andi [ Nitpick section ] Next time, please: 1. Number your patches. 2. Add a changelog (either in the cover letter (which is best for multi-patch series) or after the '---' section (for single patches)). 3. Don't forget the previous tags, e.g. Acked-by Fei. ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection (rev2) 2023-07-26 15:53 [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Jonathan Cavitt ` (7 preceding siblings ...) 2023-07-27 12:23 ` Andi Shyti @ 2023-08-01 12:17 ` Patchwork 2023-08-01 12:17 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork ` (2 subsequent siblings) 11 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2023-08-01 12:17 UTC (permalink / raw) To: Jonathan Cavitt; +Cc: intel-gfx == Series Details == Series: series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection (rev2) URL : https://patchwork.freedesktop.org/series/121373/ State : warning == Summary == Error: dim checkpatch failed 45c69ff3c0cc drm/i915/gt: Simplify shmem_create_from_object map_type selection 0f15eef4dd9e drm/i915: Make i915_coherent_map_type GT-centric -:218: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #218: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:1195: + intel_gt_coherent_map_type(ce->engine->gt, ce->state->obj, -:252: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #252: FILE: drivers/gpu/drm/i915/gt/selftest_context.c:92: + intel_gt_coherent_map_type(engine->gt, ce->state->obj, false)); -:287: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #287: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1296: + intel_gt_coherent_map_type(engine->gt, ce->state->obj, -:321: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #321: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc.c:796: + intel_gt_coherent_map_type(guc_to_gt(guc), vma->obj, true)); -:404: WARNING:LONG_LINE: line length of 105 exceeds 100 columns #404: FILE: drivers/gpu/drm/i915/pxp/intel_pxp_tee.c:249: + cmd = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(pxp->ctrl_gt, obj, true)); total: 0 errors, 1 warnings, 4 checks, 290 lines checked 467847c18f1d drm/i915/gt: Apply workaround 22016122933 correctly ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection (rev2) 2023-07-26 15:53 [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Jonathan Cavitt ` (8 preceding siblings ...) 2023-08-01 12:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection (rev2) Patchwork @ 2023-08-01 12:17 ` Patchwork 2023-08-01 12:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2023-08-01 15:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 11 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2023-08-01 12:17 UTC (permalink / raw) To: Jonathan Cavitt; +Cc: intel-gfx == Series Details == Series: series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection (rev2) URL : https://patchwork.freedesktop.org/series/121373/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection (rev2) 2023-07-26 15:53 [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Jonathan Cavitt ` (9 preceding siblings ...) 2023-08-01 12:17 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork @ 2023-08-01 12:31 ` Patchwork 2023-08-01 15:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 11 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2023-08-01 12:31 UTC (permalink / raw) To: Jonathan Cavitt; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 12442 bytes --] == Series Details == Series: series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection (rev2) URL : https://patchwork.freedesktop.org/series/121373/ State : success == Summary == CI Bug Log - changes from CI_DRM_13455 -> Patchwork_121373v2 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/index.html Participating hosts (40 -> 40) ------------------------------ Additional (1): bat-atsm-1 Missing (1): fi-snb-2520m Known issues ------------ Here are the changes found in Patchwork_121373v2 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@core_auth@basic-auth: - bat-adlp-11: NOTRUN -> [ABORT][1] ([i915#4423] / [i915#8011]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-adlp-11/igt@core_auth@basic-auth.html * igt@gem_exec_suspend@basic-s0@smem: - bat-atsm-1: NOTRUN -> [DMESG-WARN][2] ([i915#8841]) +3 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@gem_exec_suspend@basic-s0@smem.html * igt@gem_exec_suspend@basic-s3@lmem0: - bat-atsm-1: NOTRUN -> [DMESG-WARN][3] ([i915#8504] / [i915#8841]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@gem_exec_suspend@basic-s3@lmem0.html * igt@gem_mmap@basic: - bat-atsm-1: NOTRUN -> [SKIP][4] ([i915#4083]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@gem_mmap@basic.html * igt@gem_tiled_fence_blits@basic: - bat-atsm-1: NOTRUN -> [SKIP][5] ([i915#4077]) +2 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@gem_tiled_fence_blits@basic.html * igt@gem_tiled_pread_basic: - bat-atsm-1: NOTRUN -> [SKIP][6] ([i915#4079]) +1 similar issue [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@gem_tiled_pread_basic.html * igt@i915_pm_rps@basic-api: - bat-atsm-1: NOTRUN -> [SKIP][7] ([i915#6621]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@i915_pm_rps@basic-api.html * igt@i915_selftest@live@reset: - bat-rpls-2: [PASS][8] -> [ABORT][9] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#7981] / [i915#8347]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/bat-rpls-2/igt@i915_selftest@live@reset.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-rpls-2/igt@i915_selftest@live@reset.html * igt@i915_suspend@basic-s3-without-i915: - bat-atsm-1: NOTRUN -> [SKIP][10] ([i915#6645]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@i915_suspend@basic-s3-without-i915.html - bat-rpls-1: NOTRUN -> [ABORT][11] ([i915#6687] / [i915#7978] / [i915#8668]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_addfb_basic@size-max: - bat-atsm-1: NOTRUN -> [SKIP][12] ([i915#6077]) +36 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@kms_addfb_basic@size-max.html * igt@kms_cursor_legacy@basic-flip-after-cursor-atomic: - bat-atsm-1: NOTRUN -> [SKIP][13] ([i915#6078]) +19 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html * igt@kms_flip@basic-plain-flip: - bat-atsm-1: NOTRUN -> [SKIP][14] ([i915#6166]) +3 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@kms_flip@basic-plain-flip.html * igt@kms_force_connector_basic@prune-stale-modes: - bat-atsm-1: NOTRUN -> [SKIP][15] ([i915#6093]) +3 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@kms_force_connector_basic@prune-stale-modes.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24: - bat-atsm-1: NOTRUN -> [SKIP][16] ([i915#1836]) +7 similar issues [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24.html * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence: - bat-dg2-11: NOTRUN -> [SKIP][17] ([i915#1845] / [i915#5354]) +3 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html * igt@kms_prop_blob@basic: - bat-atsm-1: NOTRUN -> [SKIP][18] ([i915#7357]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@kms_prop_blob@basic.html * igt@kms_psr@sprite_plane_onoff: - bat-atsm-1: NOTRUN -> [SKIP][19] ([i915#1072]) +3 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@kms_psr@sprite_plane_onoff.html * igt@kms_setmode@basic-clone-single-crtc: - bat-atsm-1: NOTRUN -> [SKIP][20] ([i915#6094]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-fence-flip: - bat-atsm-1: NOTRUN -> [SKIP][21] ([fdo#109295] / [i915#6078]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@prime_vgem@basic-fence-flip.html * igt@prime_vgem@basic-fence-mmap: - bat-atsm-1: NOTRUN -> [SKIP][22] ([fdo#109295] / [i915#4077]) +1 similar issue [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@prime_vgem@basic-fence-mmap.html * igt@prime_vgem@basic-write: - bat-atsm-1: NOTRUN -> [SKIP][23] ([fdo#109295]) +2 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-atsm-1/igt@prime_vgem@basic-write.html #### Possible fixes #### * igt@i915_pm_rpm@basic-rte: - fi-tgl-1115g4: [FAIL][24] ([i915#7940]) -> [PASS][25] [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/fi-tgl-1115g4/igt@i915_pm_rpm@basic-rte.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/fi-tgl-1115g4/igt@i915_pm_rpm@basic-rte.html * igt@i915_pm_rpm@module-reload: - fi-kbl-7567u: [FAIL][26] ([i915#7940]) -> [PASS][27] [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/fi-kbl-7567u/igt@i915_pm_rpm@module-reload.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/fi-kbl-7567u/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live@migrate: - bat-dg2-11: [DMESG-WARN][28] ([i915#7699]) -> [PASS][29] [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/bat-dg2-11/igt@i915_selftest@live@migrate.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-dg2-11/igt@i915_selftest@live@migrate.html * igt@i915_selftest@live@requests: - bat-rpls-1: [ABORT][30] ([i915#4983] / [i915#7911] / [i915#7920]) -> [PASS][31] [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/bat-rpls-1/igt@i915_selftest@live@requests.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-rpls-1/igt@i915_selftest@live@requests.html #### Warnings #### * igt@i915_module_load@load: - bat-adlp-11: [ABORT][32] ([i915#4423]) -> [DMESG-WARN][33] ([i915#4423]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/bat-adlp-11/igt@i915_module_load@load.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-adlp-11/igt@i915_module_load@load.html * igt@i915_pm_rpm@basic-pci-d3-state: - fi-kbl-guc: [FAIL][34] ([i915#7940]) -> [SKIP][35] ([fdo#109271]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_pm_rpm@basic-rte: - fi-kbl-8809g: [FAIL][36] ([i915#7940]) -> [FAIL][37] ([i915#8843]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/fi-kbl-8809g/igt@i915_pm_rpm@basic-rte.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/fi-kbl-8809g/igt@i915_pm_rpm@basic-rte.html * igt@i915_selftest@live@requests: - bat-mtlp-8: [DMESG-FAIL][38] ([i915#8497]) -> [ABORT][39] ([i915#7982]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/bat-mtlp-8/igt@i915_selftest@live@requests.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-mtlp-8/igt@i915_selftest@live@requests.html * igt@kms_psr@sprite_plane_onoff: - bat-rplp-1: [SKIP][40] ([i915#1072]) -> [ABORT][41] ([i915#8442] / [i915#8668] / [i915#8712]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077 [i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078 [i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093 [i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094 [i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645 [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687 [i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357 [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461 [i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699 [i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911 [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 [i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920 [i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940 [i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978 [i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981 [i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982 [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011 [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347 [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442 [i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497 [i915#8504]: https://gitlab.freedesktop.org/drm/intel/issues/8504 [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668 [i915#8712]: https://gitlab.freedesktop.org/drm/intel/issues/8712 [i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841 [i915#8843]: https://gitlab.freedesktop.org/drm/intel/issues/8843 Build changes ------------- * Linux: CI_DRM_13455 -> Patchwork_121373v2 CI-20190529: 20190529 CI_DRM_13455: 9a1dbae51db9a61173f3a613e406c15d9c990f7e @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7411: 7411 Patchwork_121373v2: 9a1dbae51db9a61173f3a613e406c15d9c990f7e @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits 697f71d8d469 drm/i915/gt: Apply workaround 22016122933 correctly 419443b72c46 drm/i915: Make i915_coherent_map_type GT-centric b2882e506930 drm/i915/gt: Simplify shmem_create_from_object map_type selection == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/index.html [-- Attachment #2: Type: text/html, Size: 14675 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection (rev2) 2023-07-26 15:53 [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Jonathan Cavitt ` (10 preceding siblings ...) 2023-08-01 12:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2023-08-01 15:38 ` Patchwork 11 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2023-08-01 15:38 UTC (permalink / raw) To: Jonathan Cavitt; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 59666 bytes --] == Series Details == Series: series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection (rev2) URL : https://patchwork.freedesktop.org/series/121373/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13455_full -> Patchwork_121373v2_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_121373v2_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_121373v2_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_121373v2_full: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_schedule@noreorder-corked@bcs0: - shard-mtlp: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-mtlp-7/igt@gem_exec_schedule@noreorder-corked@bcs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@gem_exec_schedule@noreorder-corked@bcs0.html * igt@gem_exec_schedule@noreorder-corked@vecs0: - shard-mtlp: [PASS][3] -> [DMESG-WARN][4] +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-mtlp-7/igt@gem_exec_schedule@noreorder-corked@vecs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@gem_exec_schedule@noreorder-corked@vecs0.html * igt@gem_exec_schedule@noreorder-priority@rcs0: - shard-mtlp: [PASS][5] -> [DMESG-FAIL][6] +3 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-mtlp-6/igt@gem_exec_schedule@noreorder-priority@rcs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@gem_exec_schedule@noreorder-priority@rcs0.html Known issues ------------ Here are the changes found in Patchwork_121373v2_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@api_intel_bb@object-noreloc-keep-cache-simple: - shard-snb: NOTRUN -> [SKIP][7] ([fdo#109271]) +200 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-snb5/igt@api_intel_bb@object-noreloc-keep-cache-simple.html * igt@device_reset@cold-reset-bound: - shard-dg2: NOTRUN -> [SKIP][8] ([i915#7701]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@device_reset@cold-reset-bound.html * igt@drm_fdinfo@busy-hang@bcs0: - shard-dg1: NOTRUN -> [SKIP][9] ([i915#8414]) +4 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@drm_fdinfo@busy-hang@bcs0.html * igt@drm_fdinfo@busy-hang@rcs0: - shard-mtlp: NOTRUN -> [SKIP][10] ([i915#8414]) +11 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@drm_fdinfo@busy-hang@rcs0.html * igt@drm_fdinfo@busy@ccs0: - shard-dg2: NOTRUN -> [SKIP][11] ([i915#8414]) +11 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@drm_fdinfo@busy@ccs0.html * igt@gem_caching@read-writes: - shard-mtlp: NOTRUN -> [SKIP][12] ([i915#4873]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@gem_caching@read-writes.html * igt@gem_ccs@block-multicopy-compressed: - shard-mtlp: NOTRUN -> [SKIP][13] ([i915#5325]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@gem_ccs@block-multicopy-compressed.html * igt@gem_ctx_persistence@hang: - shard-mtlp: NOTRUN -> [SKIP][14] ([i915#8555]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@gem_ctx_persistence@hang.html * igt@gem_ctx_persistence@smoketest: - shard-snb: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#1099]) +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-snb7/igt@gem_ctx_persistence@smoketest.html * igt@gem_eio@hibernate: - shard-dg1: [PASS][16] -> [ABORT][17] ([i915#4391] / [i915#7975] / [i915#8213]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-dg1-12/igt@gem_eio@hibernate.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@gem_eio@hibernate.html * igt@gem_eio@reset-stress: - shard-snb: NOTRUN -> [FAIL][18] ([i915#8898]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-snb5/igt@gem_eio@reset-stress.html * igt@gem_exec_balancer@bonded-dual: - shard-dg2: NOTRUN -> [SKIP][19] ([i915#4771]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@gem_exec_balancer@bonded-dual.html * igt@gem_exec_fair@basic-pace-solo: - shard-dg2: NOTRUN -> [SKIP][20] ([i915#3539]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@gem_exec_fair@basic-pace-solo.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-rkl: [PASS][21] -> [FAIL][22] ([i915#2842]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-rkl-4/igt@gem_exec_fair@basic-pace-solo@rcs0.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-rkl-6/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fair@basic-throttle: - shard-mtlp: NOTRUN -> [SKIP][23] ([i915#4473] / [i915#4771]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@gem_exec_fair@basic-throttle.html * igt@gem_exec_flush@basic-uc-pro-default: - shard-dg2: NOTRUN -> [SKIP][24] ([i915#3539] / [i915#4852]) +2 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@gem_exec_flush@basic-uc-pro-default.html * igt@gem_exec_gttfill@multigpu-basic: - shard-mtlp: NOTRUN -> [SKIP][25] ([i915#7697]) +1 similar issue [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@gem_exec_gttfill@multigpu-basic.html * igt@gem_exec_reloc@basic-cpu-gtt: - shard-dg2: NOTRUN -> [SKIP][26] ([i915#3281]) +7 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@gem_exec_reloc@basic-cpu-gtt.html * igt@gem_exec_reloc@basic-range-active: - shard-dg1: NOTRUN -> [SKIP][27] ([i915#3281]) +3 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@gem_exec_reloc@basic-range-active.html - shard-mtlp: NOTRUN -> [SKIP][28] ([i915#3281]) +4 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@gem_exec_reloc@basic-range-active.html * igt@gem_exec_schedule@reorder-wide: - shard-dg2: NOTRUN -> [SKIP][29] ([i915#4537] / [i915#4812]) +1 similar issue [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@gem_exec_schedule@reorder-wide.html * igt@gem_lmem_swapping@basic: - shard-mtlp: NOTRUN -> [SKIP][30] ([i915#4613]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@gem_lmem_swapping@basic.html * igt@gem_mmap@bad-size: - shard-mtlp: NOTRUN -> [SKIP][31] ([i915#4083]) +3 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@gem_mmap@bad-size.html * igt@gem_mmap_gtt@cpuset-big-copy-odd: - shard-dg2: NOTRUN -> [SKIP][32] ([i915#4077]) +8 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@gem_mmap_gtt@cpuset-big-copy-odd.html * igt@gem_mmap_gtt@flink-race: - shard-mtlp: NOTRUN -> [SKIP][33] ([i915#4077]) +8 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@gem_mmap_gtt@flink-race.html * igt@gem_mmap_gtt@medium-copy-odd: - shard-dg1: NOTRUN -> [SKIP][34] ([i915#4077]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@gem_mmap_gtt@medium-copy-odd.html * igt@gem_mmap_wc@invalid-flags: - shard-dg2: NOTRUN -> [SKIP][35] ([i915#4083]) +2 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@gem_mmap_wc@invalid-flags.html * igt@gem_pwrite@basic-random: - shard-mtlp: NOTRUN -> [SKIP][36] ([i915#3282]) +1 similar issue [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@gem_pwrite@basic-random.html * igt@gem_pwrite@basic-self: - shard-dg2: NOTRUN -> [SKIP][37] ([i915#3282]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@gem_pwrite@basic-self.html * igt@gem_pxp@reject-modify-context-protection-off-1: - shard-dg2: NOTRUN -> [SKIP][38] ([i915#4270]) +1 similar issue [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@gem_pxp@reject-modify-context-protection-off-1.html * igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-y-tiled: - shard-mtlp: NOTRUN -> [SKIP][39] ([i915#8428]) +3 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-y-tiled.html * igt@gem_set_tiling_vs_blt@tiled-to-tiled: - shard-mtlp: NOTRUN -> [SKIP][40] ([i915#4079]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@gem_set_tiling_vs_blt@tiled-to-tiled.html * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy: - shard-dg1: NOTRUN -> [SKIP][41] ([i915#3297] / [i915#4880]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html * igt@gem_userptr_blits@mmap-offset-banned@gtt: - shard-mtlp: NOTRUN -> [SKIP][42] ([i915#3297]) +1 similar issue [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@gem_userptr_blits@mmap-offset-banned@gtt.html * igt@gen3_mixed_blits: - shard-dg2: NOTRUN -> [SKIP][43] ([fdo#109289]) +2 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@gen3_mixed_blits.html * igt@gen7_exec_parse@cmd-crossing-page: - shard-mtlp: NOTRUN -> [SKIP][44] ([fdo#109289]) +2 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@gen7_exec_parse@cmd-crossing-page.html * igt@gen9_exec_parse@bb-start-cmd: - shard-mtlp: NOTRUN -> [SKIP][45] ([i915#2856]) +3 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@gen9_exec_parse@bb-start-cmd.html * igt@gen9_exec_parse@bb-start-out: - shard-dg1: NOTRUN -> [SKIP][46] ([i915#2527]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@gen9_exec_parse@bb-start-out.html * igt@i915_pipe_stress@stress-xrgb8888-untiled: - shard-mtlp: [PASS][47] -> [FAIL][48] ([i915#8691]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-mtlp-8/igt@i915_pipe_stress@stress-xrgb8888-untiled.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-7/igt@i915_pipe_stress@stress-xrgb8888-untiled.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a: - shard-dg2: [PASS][49] -> [SKIP][50] ([i915#1937]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-dg2-10/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html * igt@i915_pm_rpm@basic-pci-d3-state: - shard-dg1: [PASS][51] -> [FAIL][52] ([i915#7691]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-dg1-19/igt@i915_pm_rpm@basic-pci-d3-state.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-18/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_pm_rpm@debugfs-forcewake-user: - shard-dg1: [PASS][53] -> [FAIL][54] ([i915#7940]) +3 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-dg1-18/igt@i915_pm_rpm@debugfs-forcewake-user.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-17/igt@i915_pm_rpm@debugfs-forcewake-user.html * igt@i915_pm_rpm@dpms-non-lpsp: - shard-dg1: [PASS][55] -> [SKIP][56] ([i915#1397]) +3 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-dg1-15/igt@i915_pm_rpm@dpms-non-lpsp.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-19/igt@i915_pm_rpm@dpms-non-lpsp.html * igt@i915_pm_rpm@gem-execbuf-stress-pc8: - shard-dg2: NOTRUN -> [SKIP][57] ([fdo#109506]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html * igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0: - shard-tglu: [PASS][58] -> [FAIL][59] ([i915#7940]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-tglu-3/igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-tglu-8/igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0.html * igt@i915_pm_rpm@modeset-non-lpsp-stress: - shard-dg2: [PASS][60] -> [SKIP][61] ([i915#1397]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-dg2-3/igt@i915_pm_rpm@modeset-non-lpsp-stress.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-10/igt@i915_pm_rpm@modeset-non-lpsp-stress.html * igt@i915_pm_rps@basic-api: - shard-dg2: NOTRUN -> [SKIP][62] ([i915#6621]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@i915_pm_rps@basic-api.html * igt@i915_pm_rps@min-max-config-idle: - shard-mtlp: NOTRUN -> [SKIP][63] ([i915#6621]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@i915_pm_rps@min-max-config-idle.html * igt@i915_pm_rps@thresholds@gt0: - shard-dg2: NOTRUN -> [SKIP][64] ([i915#8925]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@i915_pm_rps@thresholds@gt0.html * igt@i915_pm_sseu@full-enable: - shard-mtlp: NOTRUN -> [SKIP][65] ([i915#8437]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@i915_pm_sseu@full-enable.html * igt@i915_selftest@live@gt_heartbeat: - shard-apl: [PASS][66] -> [DMESG-FAIL][67] ([i915#5334]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-apl1/igt@i915_selftest@live@gt_heartbeat.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-apl3/igt@i915_selftest@live@gt_heartbeat.html * igt@kms_addfb_basic@addfb25-x-tiled-legacy: - shard-mtlp: NOTRUN -> [SKIP][68] ([i915#4212]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@kms_addfb_basic@addfb25-x-tiled-legacy.html * igt@kms_addfb_basic@framebuffer-vs-set-tiling: - shard-dg2: NOTRUN -> [SKIP][69] ([i915#4212]) +1 similar issue [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html * igt@kms_async_flips@crc@pipe-b-hdmi-a-1: - shard-rkl: NOTRUN -> [FAIL][70] ([i915#8247]) +1 similar issue [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-rkl-7/igt@kms_async_flips@crc@pipe-b-hdmi-a-1.html * igt@kms_async_flips@crc@pipe-b-vga-1: - shard-snb: NOTRUN -> [FAIL][71] ([i915#8247]) +1 similar issue [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-snb7/igt@kms_async_flips@crc@pipe-b-vga-1.html * igt@kms_async_flips@crc@pipe-d-edp-1: - shard-mtlp: NOTRUN -> [DMESG-FAIL][72] ([i915#8561]) +3 similar issues [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@kms_async_flips@crc@pipe-d-edp-1.html * igt@kms_async_flips@invalid-async-flip: - shard-dg2: NOTRUN -> [SKIP][73] ([i915#6228]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@kms_async_flips@invalid-async-flip.html * igt@kms_atomic_transition@plane-all-modeset-transition: - shard-mtlp: NOTRUN -> [SKIP][74] ([i915#1769]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@kms_atomic_transition@plane-all-modeset-transition.html * igt@kms_big_fb@4-tiled-32bpp-rotate-90: - shard-mtlp: NOTRUN -> [SKIP][75] ([fdo#111614]) +1 similar issue [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@kms_big_fb@4-tiled-32bpp-rotate-90.html * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip: - shard-mtlp: NOTRUN -> [FAIL][76] ([i915#3743]) +1 similar issue [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html * igt@kms_big_fb@linear-16bpp-rotate-90: - shard-dg2: NOTRUN -> [SKIP][77] ([fdo#111614]) +1 similar issue [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@kms_big_fb@linear-16bpp-rotate-90.html * igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip: - shard-mtlp: [PASS][78] -> [FAIL][79] ([i915#3743]) +1 similar issue [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-mtlp-7/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html * igt@kms_big_fb@y-tiled-64bpp-rotate-0: - shard-dg2: NOTRUN -> [SKIP][80] ([i915#5190]) +11 similar issues [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip: - shard-mtlp: NOTRUN -> [SKIP][81] ([fdo#111615]) +7 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html * igt@kms_big_fb@yf-tiled-16bpp-rotate-270: - shard-dg1: NOTRUN -> [SKIP][82] ([i915#4538]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_big_fb@yf-tiled-16bpp-rotate-270.html * igt@kms_big_fb@yf-tiled-8bpp-rotate-270: - shard-dg2: NOTRUN -> [SKIP][83] ([i915#4538] / [i915#5190]) +3 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@kms_big_fb@yf-tiled-8bpp-rotate-270.html * igt@kms_big_fb@yf-tiled-addfb: - shard-dg1: NOTRUN -> [SKIP][84] ([fdo#111615]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_big_fb@yf-tiled-addfb.html - shard-mtlp: NOTRUN -> [SKIP][85] ([i915#6187]) +1 similar issue [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@kms_big_fb@yf-tiled-addfb.html * igt@kms_big_joiner@basic: - shard-dg2: NOTRUN -> [SKIP][86] ([i915#2705]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@kms_big_joiner@basic.html * igt@kms_ccs@pipe-a-missing-ccs-buffer-4_tiled_mtl_mc_ccs: - shard-dg2: NOTRUN -> [SKIP][87] ([i915#5354]) +24 similar issues [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@kms_ccs@pipe-a-missing-ccs-buffer-4_tiled_mtl_mc_ccs.html * igt@kms_ccs@pipe-b-bad-pixel-format-4_tiled_dg2_mc_ccs: - shard-dg1: NOTRUN -> [SKIP][88] ([i915#3689] / [i915#5354] / [i915#6095]) [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_ccs@pipe-b-bad-pixel-format-4_tiled_dg2_mc_ccs.html * igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc: - shard-dg2: NOTRUN -> [SKIP][89] ([i915#3689] / [i915#3886] / [i915#5354]) +8 similar issues [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs: - shard-mtlp: NOTRUN -> [SKIP][90] ([i915#3886] / [i915#6095]) +4 similar issues [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs.html - shard-dg1: NOTRUN -> [SKIP][91] ([i915#3689] / [i915#3886] / [i915#5354] / [i915#6095]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_dg2_rc_ccs_cc: - shard-mtlp: NOTRUN -> [SKIP][92] ([i915#6095]) +17 similar issues [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_dg2_rc_ccs_cc.html * igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs: - shard-dg2: NOTRUN -> [SKIP][93] ([i915#3689] / [i915#5354]) +17 similar issues [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_rc_ccs.html * igt@kms_ccs@pipe-d-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs: - shard-dg1: NOTRUN -> [SKIP][94] ([i915#5354] / [i915#6095]) +2 similar issues [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs.html * igt@kms_cdclk@plane-scaling@pipe-d-hdmi-a-1: - shard-dg2: NOTRUN -> [SKIP][95] ([i915#4087]) +3 similar issues [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-10/igt@kms_cdclk@plane-scaling@pipe-d-hdmi-a-1.html * igt@kms_chamelium_color@ctm-blue-to-red: - shard-dg2: NOTRUN -> [SKIP][96] ([fdo#111827]) [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@kms_chamelium_color@ctm-blue-to-red.html * igt@kms_chamelium_color@ctm-red-to-blue: - shard-mtlp: NOTRUN -> [SKIP][97] ([fdo#111827]) [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@kms_chamelium_color@ctm-red-to-blue.html * igt@kms_chamelium_frames@hdmi-cmp-planar-formats: - shard-dg2: NOTRUN -> [SKIP][98] ([i915#7828]) +6 similar issues [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@kms_chamelium_frames@hdmi-cmp-planar-formats.html * igt@kms_chamelium_hpd@hdmi-hpd-storm: - shard-dg1: NOTRUN -> [SKIP][99] ([i915#7828]) [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_chamelium_hpd@hdmi-hpd-storm.html * igt@kms_chamelium_hpd@vga-hpd-enable-disable-mode: - shard-mtlp: NOTRUN -> [SKIP][100] ([i915#7828]) +2 similar issues [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@kms_chamelium_hpd@vga-hpd-enable-disable-mode.html * igt@kms_color@deep-color: - shard-rkl: NOTRUN -> [SKIP][101] ([i915#3555]) [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-rkl-7/igt@kms_color@deep-color.html * igt@kms_content_protection@dp-mst-type-0: - shard-dg2: NOTRUN -> [SKIP][102] ([i915#3299]) [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@kms_content_protection@dp-mst-type-0.html * igt@kms_content_protection@mei_interface: - shard-mtlp: NOTRUN -> [SKIP][103] ([i915#8063]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@kms_content_protection@mei_interface.html * igt@kms_content_protection@srm: - shard-dg1: NOTRUN -> [SKIP][104] ([i915#7116]) [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_content_protection@srm.html - shard-mtlp: NOTRUN -> [SKIP][105] ([i915#6944]) +1 similar issue [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@kms_content_protection@srm.html * igt@kms_content_protection@type1: - shard-dg2: NOTRUN -> [SKIP][106] ([i915#7118]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@kms_content_protection@type1.html * igt@kms_cursor_crc@cursor-onscreen-32x10: - shard-mtlp: NOTRUN -> [SKIP][107] ([i915#8814]) +2 similar issues [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@kms_cursor_crc@cursor-onscreen-32x10.html - shard-dg1: NOTRUN -> [SKIP][108] ([i915#3555]) [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_cursor_crc@cursor-onscreen-32x10.html * igt@kms_cursor_crc@cursor-onscreen-512x512: - shard-mtlp: NOTRUN -> [SKIP][109] ([i915#3359]) +1 similar issue [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@kms_cursor_crc@cursor-onscreen-512x512.html * igt@kms_cursor_crc@cursor-rapid-movement-512x512: - shard-dg2: NOTRUN -> [SKIP][110] ([i915#3359]) [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@kms_cursor_crc@cursor-rapid-movement-512x512.html * igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1: - shard-apl: [PASS][111] -> [ABORT][112] ([i915#180]) +1 similar issue [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-apl4/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-apl3/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html * igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy: - shard-mtlp: NOTRUN -> [SKIP][113] ([i915#3546]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy.html * igt@kms_cursor_legacy@cursorb-vs-flipa-toggle: - shard-dg2: NOTRUN -> [SKIP][114] ([fdo#109274] / [i915#5354]) +4 similar issues [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@kms_cursor_legacy@cursorb-vs-flipa-toggle.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-apl: [PASS][115] -> [FAIL][116] ([i915#2346]) [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-glk: [PASS][117] -> [FAIL][118] ([i915#2346]) [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions: - shard-dg2: NOTRUN -> [SKIP][119] ([i915#4103] / [i915#4213]) [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions.html * igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle: - shard-mtlp: NOTRUN -> [SKIP][120] ([i915#4213]) [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle.html * igt@kms_dsc@dsc-basic: - shard-dg2: NOTRUN -> [SKIP][121] ([i915#3555] / [i915#3840]) [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@kms_dsc@dsc-basic.html * igt@kms_flip@2x-flip-vs-absolute-wf_vblank: - shard-mtlp: NOTRUN -> [SKIP][122] ([i915#3637]) +2 similar issues [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@kms_flip@2x-flip-vs-absolute-wf_vblank.html * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2: - shard-glk: [PASS][123] -> [FAIL][124] ([i915#2122]) [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-glk3/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-glk6/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2.html * igt@kms_flip@2x-plain-flip-ts-check: - shard-dg2: NOTRUN -> [SKIP][125] ([fdo#109274]) +4 similar issues [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@kms_flip@2x-plain-flip-ts-check.html * igt@kms_flip@flip-vs-fences-interruptible: - shard-dg2: NOTRUN -> [SKIP][126] ([i915#8381]) [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@kms_flip@flip-vs-fences-interruptible.html * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling@pipe-a-valid-mode: - shard-dg2: NOTRUN -> [SKIP][127] ([i915#2672]) +2 similar issues [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-upscaling@pipe-a-default-mode: - shard-mtlp: NOTRUN -> [SKIP][128] ([i915#2672]) +1 similar issue [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-upscaling@pipe-a-default-mode.html * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw: - shard-dg2: NOTRUN -> [FAIL][129] ([i915#6880]) [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc: - shard-dg2: NOTRUN -> [SKIP][130] ([i915#8708]) +10 similar issues [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-cpu: - shard-mtlp: NOTRUN -> [SKIP][131] ([i915#1825]) +18 similar issues [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-cpu.html * igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary: - shard-dg2: [PASS][132] -> [FAIL][133] ([i915#6880]) +3 similar issues [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff: - shard-dg1: NOTRUN -> [SKIP][134] ([i915#3458]) +1 similar issue [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-fullscreen: - shard-dg1: NOTRUN -> [SKIP][135] ([fdo#111825]) [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-fullscreen.html * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt: - shard-dg1: NOTRUN -> [SKIP][136] ([i915#8708]) [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt: - shard-mtlp: NOTRUN -> [SKIP][137] ([i915#8708]) +2 similar issues [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt: - shard-dg2: NOTRUN -> [SKIP][138] ([i915#3458]) +12 similar issues [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt.html * igt@kms_hdr@bpc-switch: - shard-rkl: NOTRUN -> [SKIP][139] ([i915#3555] / [i915#8228]) +1 similar issue [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-rkl-1/igt@kms_hdr@bpc-switch.html * igt@kms_hdr@static-toggle: - shard-dg1: NOTRUN -> [SKIP][140] ([i915#3555] / [i915#8228]) [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_hdr@static-toggle.html - shard-mtlp: NOTRUN -> [SKIP][141] ([i915#8228]) [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@kms_hdr@static-toggle.html * igt@kms_hdr@static-toggle-suspend: - shard-dg2: NOTRUN -> [SKIP][142] ([i915#3555] / [i915#8228]) +1 similar issue [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@kms_hdr@static-toggle-suspend.html * igt@kms_plane@pixel-format-source-clamping@pipe-b-planes: - shard-mtlp: [PASS][143] -> [FAIL][144] ([i915#1623]) [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-mtlp-1/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-2/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html * igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes: - shard-snb: NOTRUN -> [DMESG-WARN][145] ([i915#8841]) +6 similar issues [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-snb7/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html * igt@kms_plane_lowres@tiling-y: - shard-mtlp: NOTRUN -> [SKIP][146] ([i915#8821]) [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@kms_plane_lowres@tiling-y.html * igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1: - shard-dg1: NOTRUN -> [FAIL][147] ([i915#8292]) [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-19/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1.html * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1: - shard-rkl: NOTRUN -> [SKIP][148] ([i915#5176]) +5 similar issues [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1.html * igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1: - shard-dg2: NOTRUN -> [SKIP][149] ([i915#5176]) +3 similar issues [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-10/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1.html * igt@kms_plane_scaling@plane-scaler-with-rotation-unity-scaling@pipe-d-hdmi-a-4: - shard-dg1: NOTRUN -> [SKIP][150] ([i915#5176]) +7 similar issues [150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-18/igt@kms_plane_scaling@plane-scaler-with-rotation-unity-scaling@pipe-d-hdmi-a-4.html * igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-3: - shard-dg2: NOTRUN -> [SKIP][151] ([i915#5235]) +3 similar issues [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-3.html * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-1: - shard-dg1: NOTRUN -> [SKIP][152] ([i915#5235]) +3 similar issues [152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-19/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-1.html * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-a-edp-1: - shard-mtlp: NOTRUN -> [SKIP][153] ([i915#5235]) +3 similar issues [153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-a-edp-1.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-2: - shard-rkl: NOTRUN -> [SKIP][154] ([i915#5235]) +1 similar issue [154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-rkl-2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-2.html * igt@kms_prime@basic-crc-hybrid: - shard-mtlp: NOTRUN -> [SKIP][155] ([i915#6524]) [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@kms_prime@basic-crc-hybrid.html * igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf: - shard-dg2: NOTRUN -> [SKIP][156] ([i915#658]) [156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html * igt@kms_psr2_su@page_flip-nv12: - shard-mtlp: NOTRUN -> [SKIP][157] ([i915#4348]) +1 similar issue [157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@kms_psr2_su@page_flip-nv12.html * igt@kms_psr2_su@page_flip-p010: - shard-dg1: NOTRUN -> [SKIP][158] ([fdo#111068] / [i915#658]) [158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_psr2_su@page_flip-p010.html * igt@kms_psr@primary_blt: - shard-dg1: NOTRUN -> [SKIP][159] ([i915#1072]) [159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@kms_psr@primary_blt.html * igt@kms_psr@psr2_cursor_plane_move: - shard-dg2: NOTRUN -> [SKIP][160] ([i915#1072]) +4 similar issues [160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@kms_psr@psr2_cursor_plane_move.html * igt@kms_rotation_crc@bad-tiling: - shard-dg2: NOTRUN -> [SKIP][161] ([i915#4235]) +1 similar issue [161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@kms_rotation_crc@bad-tiling.html * igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270: - shard-dg2: NOTRUN -> [SKIP][162] ([i915#4235] / [i915#5190]) [162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270.html * igt@kms_rotation_crc@sprite-rotation-90: - shard-mtlp: NOTRUN -> [SKIP][163] ([i915#4235]) [163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@kms_rotation_crc@sprite-rotation-90.html * igt@kms_selftest@drm_cmdline: - shard-dg2: NOTRUN -> [SKIP][164] ([i915#8661]) [164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@kms_selftest@drm_cmdline.html * igt@kms_selftest@drm_damage: - shard-snb: NOTRUN -> [SKIP][165] ([fdo#109271] / [i915#8661]) [165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-snb5/igt@kms_selftest@drm_damage.html * igt@kms_setmode@invalid-clone-single-crtc: - shard-dg2: NOTRUN -> [SKIP][166] ([i915#3555]) +4 similar issues [166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@kms_setmode@invalid-clone-single-crtc.html * igt@kms_tiled_display@basic-test-pattern-with-chamelium: - shard-dg2: NOTRUN -> [SKIP][167] ([i915#8623]) [167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html * igt@kms_vblank@pipe-a-accuracy-idle: - shard-glk: [PASS][168] -> [FAIL][169] ([i915#8713]) [168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-glk4/igt@kms_vblank@pipe-a-accuracy-idle.html [169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-glk5/igt@kms_vblank@pipe-a-accuracy-idle.html * igt@perf@global-sseu-config-invalid: - shard-dg2: NOTRUN -> [SKIP][170] ([i915#7387]) [170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-3/igt@perf@global-sseu-config-invalid.html * igt@perf_pmu@busy-double-start@bcs0: - shard-mtlp: [PASS][171] -> [FAIL][172] ([i915#4349]) +1 similar issue [171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-mtlp-7/igt@perf_pmu@busy-double-start@bcs0.html [172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-7/igt@perf_pmu@busy-double-start@bcs0.html * igt@perf_pmu@rc6-all-gts: - shard-dg2: NOTRUN -> [SKIP][173] ([i915#8516]) [173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@perf_pmu@rc6-all-gts.html * igt@prime_vgem@basic-gtt: - shard-mtlp: NOTRUN -> [SKIP][174] ([i915#3708] / [i915#4077]) [174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@prime_vgem@basic-gtt.html * igt@tools_test@sysfs_l3_parity: - shard-dg2: NOTRUN -> [SKIP][175] ([i915#4818]) [175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@tools_test@sysfs_l3_parity.html * igt@v3d/v3d_get_param@get-bad-param: - shard-mtlp: NOTRUN -> [SKIP][176] ([i915#2575]) +6 similar issues [176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@v3d/v3d_get_param@get-bad-param.html * igt@v3d/v3d_submit_cl@bad-multisync-out-sync: - shard-dg2: NOTRUN -> [SKIP][177] ([i915#2575]) +5 similar issues [177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@v3d/v3d_submit_cl@bad-multisync-out-sync.html * igt@vc4/vc4_create_bo@create-bo-0: - shard-dg2: NOTRUN -> [SKIP][178] ([i915#7711]) +6 similar issues [178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-2/igt@vc4/vc4_create_bo@create-bo-0.html * igt@vc4/vc4_label_bo@set-bad-name: - shard-dg1: NOTRUN -> [SKIP][179] ([i915#7711]) [179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@vc4/vc4_label_bo@set-bad-name.html - shard-mtlp: NOTRUN -> [SKIP][180] ([i915#7711]) +1 similar issue [180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@vc4/vc4_label_bo@set-bad-name.html #### Possible fixes #### * igt@drm_fdinfo@most-busy-check-all@rcs0: - shard-rkl: [FAIL][181] ([i915#7742]) -> [PASS][182] [181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-rkl-4/igt@drm_fdinfo@most-busy-check-all@rcs0.html [182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-rkl-7/igt@drm_fdinfo@most-busy-check-all@rcs0.html * igt@gem_eio@in-flight-contexts-10ms: - shard-mtlp: [ABORT][183] ([i915#7941]) -> [PASS][184] [183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-mtlp-8/igt@gem_eio@in-flight-contexts-10ms.html [184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@gem_eio@in-flight-contexts-10ms.html * igt@gem_eio@reset-stress: - shard-dg1: [FAIL][185] ([i915#5784]) -> [PASS][186] [185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-dg1-18/igt@gem_eio@reset-stress.html [186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-14/igt@gem_eio@reset-stress.html * igt@gem_exec_whisper@basic-contexts-forked-all: - shard-mtlp: [TIMEOUT][187] ([i915#7392] / [i915#8628]) -> [PASS][188] [187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-mtlp-3/igt@gem_exec_whisper@basic-contexts-forked-all.html [188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-8/igt@gem_exec_whisper@basic-contexts-forked-all.html * igt@gem_exec_whisper@basic-contexts-priority-all: - shard-mtlp: [ABORT][189] ([i915#7392] / [i915#8131]) -> [PASS][190] [189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-mtlp-5/igt@gem_exec_whisper@basic-contexts-priority-all.html [190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-4/igt@gem_exec_whisper@basic-contexts-priority-all.html * igt@gem_lmem_swapping@smem-oom@lmem0: - shard-dg2: [TIMEOUT][191] ([i915#5493]) -> [PASS][192] [191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-dg2-10/igt@gem_lmem_swapping@smem-oom@lmem0.html [192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-6/igt@gem_lmem_swapping@smem-oom@lmem0.html * igt@i915_module_load@reload-with-fault-injection: - shard-mtlp: [ABORT][193] ([i915#8489] / [i915#8668]) -> [PASS][194] [193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-mtlp-3/igt@i915_module_load@reload-with-fault-injection.html [194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-6/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a: - shard-rkl: [SKIP][195] ([i915#1937]) -> [PASS][196] [195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-rkl-6/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html [196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-rkl-7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html * igt@i915_pm_rpm@dpms-mode-unset-lpsp: - shard-rkl: [SKIP][197] ([i915#1397]) -> [PASS][198] [197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-rkl-4/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html [198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html * igt@i915_selftest@perf@request: - shard-mtlp: [DMESG-FAIL][199] ([i915#8573]) -> [PASS][200] [199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-mtlp-8/igt@i915_selftest@perf@request.html [200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-7/igt@i915_selftest@perf@request.html * igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip: - shard-mtlp: [FAIL][201] ([i915#3743]) -> [PASS][202] [201]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-mtlp-4/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html [202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-mtlp-1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic: - shard-glk: [FAIL][203] ([i915#72]) -> [PASS][204] [203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html [204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-apl: [FAIL][205] ([i915#2346]) -> [PASS][206] [205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend: - shard-dg2: [FAIL][207] ([fdo#103375]) -> [PASS][208] +1 similar issue [207]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-dg2-5/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html [208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg2-1/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html * igt@perf_pmu@busy-double-start@vcs0: - shard-dg1: [FAIL][209] ([i915#4349]) -> [PASS][210] [209]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-dg1-18/igt@perf_pmu@busy-double-start@vcs0.html [210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-17/igt@perf_pmu@busy-double-start@vcs0.html #### Warnings #### * igt@kms_fbcon_fbt@psr: - shard-rkl: [SKIP][211] ([fdo#110189] / [i915#3955]) -> [SKIP][212] ([i915#3955]) [211]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-rkl-2/igt@kms_fbcon_fbt@psr.html [212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-rkl-7/igt@kms_fbcon_fbt@psr.html * igt@kms_multipipe_modeset@basic-max-pipe-crc-check: - shard-rkl: [SKIP][213] ([i915#4070] / [i915#4816]) -> [SKIP][214] ([i915#4816]) [213]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-rkl-2/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html [214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-rkl-4/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html * igt@kms_psr@cursor_plane_move: - shard-dg1: [SKIP][215] ([i915#1072]) -> [SKIP][216] ([i915#1072] / [i915#4078]) +1 similar issue [215]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13455/shard-dg1-14/igt@kms_psr@cursor_plane_move.html [216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/shard-dg1-16/igt@kms_psr@cursor_plane_move.html [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1623]: https://gitlab.freedesktop.org/drm/intel/issues/1623 [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4348]: https://gitlab.freedesktop.org/drm/intel/issues/4348 [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349 [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391 [i915#4473]: https://gitlab.freedesktop.org/drm/intel/issues/4473 [i915#4537]: https://gitlab.freedesktop.org/drm/intel/issues/4537 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816 [i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873 [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6187]: https://gitlab.freedesktop.org/drm/intel/issues/6187 [i915#6228]: https://gitlab.freedesktop.org/drm/intel/issues/6228 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880 [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944 [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72 [i915#7387]: https://gitlab.freedesktop.org/drm/intel/issues/7387 [i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392 [i915#7691]: https://gitlab.freedesktop.org/drm/intel/issues/7691 [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940 [i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941 [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975 [i915#8063]: https://gitlab.freedesktop.org/drm/intel/issues/8063 [i915#8131]: https://gitlab.freedesktop.org/drm/intel/issues/8131 [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213 [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228 [i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247 [i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292 [i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381 [i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414 [i915#8428]: https://gitlab.freedesktop.org/drm/intel/issues/8428 [i915#8437]: https://gitlab.freedesktop.org/drm/intel/issues/8437 [i915#8489]: https://gitlab.freedesktop.org/drm/intel/issues/8489 [i915#8516]: https://gitlab.freedesktop.org/drm/intel/issues/8516 [i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555 [i915#8561]: https://gitlab.freedesktop.org/drm/intel/issues/8561 [i915#8573]: https://gitlab.freedesktop.org/drm/intel/issues/8573 [i915#8623]: https://gitlab.freedesktop.org/drm/intel/issues/8623 [i915#8628]: https://gitlab.freedesktop.org/drm/intel/issues/8628 [i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661 [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668 [i915#8691]: https://gitlab.freedesktop.org/drm/intel/issues/8691 [i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708 [i915#8713]: https://gitlab.freedesktop.org/drm/intel/issues/8713 [i915#8814]: https://gitlab.freedesktop.org/drm/intel/issues/8814 [i915#8821]: https://gitlab.freedesktop.org/drm/intel/issues/8821 [i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841 [i915#8898]: https://gitlab.freedesktop.org/drm/intel/issues/8898 [i915#8925]: https://gitlab.freedesktop.org/drm/intel/issues/8925 Build changes ------------- * Linux: CI_DRM_13455 -> Patchwork_121373v2 CI-20190529: 20190529 CI_DRM_13455: 9a1dbae51db9a61173f3a613e406c15d9c990f7e @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7411: 7411 Patchwork_121373v2: 9a1dbae51db9a61173f3a613e406c15d9c990f7e @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121373v2/index.html [-- Attachment #2: Type: text/html, Size: 70201 bytes --] ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] [PATCH 0/3] drm/i915: Fix Wa_22016122933 implementation @ 2023-08-01 15:32 Jonathan Cavitt 2023-08-01 15:32 ` [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric Jonathan Cavitt 0 siblings, 1 reply; 21+ messages in thread From: Jonathan Cavitt @ 2023-08-01 15:32 UTC (permalink / raw) To: intel-gfx Cc: andi.shyti, chris.p.wilson, jonathan.cavitt, matthew.d.roper, nirmoy.das WA_22016122933 was recently applied to all MeteorLake engines, which is simultaneously too broad (should only apply to Media engines) and too specific (should apply to all platforms that use the same media engine as MeteorLake). Correct this for all current use cases. There are two additional changes that deserve special attention: First, the usage of the workaround in i915_coherent_map_type required a more invasive change to check the gt, which was split into its own patch. Second, the addition of write barriers during ct_read and gsc_fw_load_prepare were found to be unconditional, so the workaround tags were removed as the usages were not platform dependent. v2: - Refactor i915_coherent_map_type to intel_gt_coherent_map_type and move it to the gt folder as it now takes an intel_gt instead of a drm_i915_private. v3: - Remove additional gt requirement from shmem_create_from_object. Instead of passing a gt to check if the workaround applies in intel_gt_coherent_map_type, only check if the object is lmem to determine the map type to use. v4: - Fix formatting warnings. - Add this cover letter and all missing revision notes. - Add missing acks and reviews to commit messages. - Fix contributor ordering in commit messages. Jonathan Cavitt (3): drm/i915/gt: Simplify shmem_create_from_object map_type selection drm/i915: Make i915_coherent_map_type GT-centric drm/i915/gt: Apply workaround 22016122933 correctly drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 3 ++- drivers/gpu/drm/i915/gem/i915_gem_object.h | 4 ---- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 15 --------------- .../drm/i915/gem/selftests/i915_gem_migrate.c | 12 ++++++------ drivers/gpu/drm/i915/gt/intel_engine_pm.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt.c | 16 ++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt.h | 9 +++++++++ drivers/gpu/drm/i915/gt/intel_gtt.c | 4 ++-- drivers/gpu/drm/i915/gt/intel_lrc.c | 13 +++++++------ drivers/gpu/drm/i915/gt/intel_ring.c | 3 ++- drivers/gpu/drm/i915/gt/selftest_context.c | 5 +++-- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 4 ++-- drivers/gpu/drm/i915/gt/selftest_lrc.c | 6 +++--- drivers/gpu/drm/i915/gt/shmem_utils.c | 3 +-- drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 7 +------ drivers/gpu/drm/i915/gt/uc/intel_guc.c | 11 ++++++----- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 4 ---- drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c | 3 +-- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 3 ++- drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c | 3 ++- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 5 ++++- drivers/gpu/drm/i915/selftests/igt_spinner.c | 2 +- 22 files changed, 71 insertions(+), 66 deletions(-) -- 2.25.1 ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric 2023-08-01 15:32 [Intel-gfx] [PATCH 0/3] drm/i915: Fix Wa_22016122933 implementation Jonathan Cavitt @ 2023-08-01 15:32 ` Jonathan Cavitt 0 siblings, 0 replies; 21+ messages in thread From: Jonathan Cavitt @ 2023-08-01 15:32 UTC (permalink / raw) To: intel-gfx Cc: andi.shyti, chris.p.wilson, jonathan.cavitt, matthew.d.roper, nirmoy.das Refactor i915_coherent_map_type to be GT-centric rather than device-centric. Each GT may require different coherency handling due to hardware workarounds. Since the function now takes a GT instead of the i915, the function is renamed and moved to the gt folder. Suggested-by: Matt Roper <matthew.d.roper@intel.com> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> Acked-by: Fei Yang <fei.yang@intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> --- drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 3 ++- drivers/gpu/drm/i915/gem/i915_gem_object.h | 4 ---- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 15 --------------- .../gpu/drm/i915/gem/selftests/i915_gem_migrate.c | 12 ++++++------ drivers/gpu/drm/i915/gt/intel_engine_pm.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt.c | 15 +++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt.h | 3 +++ drivers/gpu/drm/i915/gt/intel_gtt.c | 4 ++-- drivers/gpu/drm/i915/gt/intel_lrc.c | 6 +++--- drivers/gpu/drm/i915/gt/intel_ring.c | 3 ++- drivers/gpu/drm/i915/gt/selftest_context.c | 5 +++-- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 4 ++-- drivers/gpu/drm/i915/gt/selftest_lrc.c | 6 +++--- drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 3 +-- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 4 ++-- drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c | 3 +-- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 3 ++- drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c | 3 ++- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 5 ++++- drivers/gpu/drm/i915/selftests/igt_spinner.c | 2 +- 20 files changed, 55 insertions(+), 50 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c index ad0405375881..d753db3eef15 100644 --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c @@ -6,6 +6,7 @@ #include <drm/i915_hdcp_interface.h> #include "gem/i915_gem_region.h" +#include "gt/intel_gt.h" #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h" #include "i915_drv.h" #include "i915_utils.h" @@ -632,7 +633,7 @@ static int intel_hdcp_gsc_initialize_message(struct drm_i915_private *i915, return PTR_ERR(obj); } - cmd_in = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); + cmd_in = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, true)); if (IS_ERR(cmd_in)) { drm_err(&i915->drm, "Failed to map gsc message page!\n"); err = PTR_ERR(cmd_in); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h index 112c130cfaaa..f607b87890dd 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h @@ -716,10 +716,6 @@ void *__must_check i915_gem_object_pin_map(struct drm_i915_gem_object *obj, void *__must_check i915_gem_object_pin_map_unlocked(struct drm_i915_gem_object *obj, enum i915_map_type type); -enum i915_map_type i915_coherent_map_type(struct drm_i915_private *i915, - struct drm_i915_gem_object *obj, - bool always_coherent); - void __i915_gem_object_flush_map(struct drm_i915_gem_object *obj, unsigned long offset, unsigned long size); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c index 89fc8ea6bcfc..6d262d269c71 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c @@ -465,21 +465,6 @@ void *i915_gem_object_pin_map_unlocked(struct drm_i915_gem_object *obj, return ret; } -enum i915_map_type i915_coherent_map_type(struct drm_i915_private *i915, - struct drm_i915_gem_object *obj, - bool always_coherent) -{ - /* - * Wa_22016122933: always return I915_MAP_WC for MTL - */ - if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(i915)) - return I915_MAP_WC; - if (HAS_LLC(i915) || always_coherent) - return I915_MAP_WB; - else - return I915_MAP_WC; -} - void __i915_gem_object_flush_map(struct drm_i915_gem_object *obj, unsigned long offset, unsigned long size) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c index a93a90b15907..d8f4a10d71de 100644 --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_migrate.c @@ -13,12 +13,12 @@ #include "selftests/igt_spinner.h" static int igt_fill_check_buffer(struct drm_i915_gem_object *obj, + struct intel_gt *gt, bool fill) { - struct drm_i915_private *i915 = to_i915(obj->base.dev); unsigned int i, count = obj->base.size / sizeof(u32); enum i915_map_type map_type = - i915_coherent_map_type(i915, obj, false); + intel_gt_coherent_map_type(gt, obj, false); u32 *cur; int err = 0; @@ -66,7 +66,7 @@ static int igt_create_migrate(struct intel_gt *gt, enum intel_region_id src, if (err) continue; - err = igt_fill_check_buffer(obj, true); + err = igt_fill_check_buffer(obj, gt, true); if (err) continue; @@ -86,7 +86,7 @@ static int igt_create_migrate(struct intel_gt *gt, enum intel_region_id src, if (err) continue; - err = igt_fill_check_buffer(obj, false); + err = igt_fill_check_buffer(obj, gt, false); } i915_gem_object_put(obj); @@ -233,7 +233,7 @@ static int __igt_lmem_pages_migrate(struct intel_gt *gt, continue; if (!vma) { - err = igt_fill_check_buffer(obj, true); + err = igt_fill_check_buffer(obj, gt, true); if (err) continue; } @@ -276,7 +276,7 @@ static int __igt_lmem_pages_migrate(struct intel_gt *gt, if (err) goto out_unlock; } else { - err = igt_fill_check_buffer(obj, false); + err = igt_fill_check_buffer(obj, gt, false); } out_unlock: diff --git a/drivers/gpu/drm/i915/gt/intel_engine_pm.c b/drivers/gpu/drm/i915/gt/intel_engine_pm.c index 21af0ec52223..b538b5c04948 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_pm.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_pm.c @@ -39,7 +39,7 @@ static void dbg_poison_ce(struct intel_context *ce) if (ce->state) { struct drm_i915_gem_object *obj = ce->state->obj; - int type = i915_coherent_map_type(ce->engine->i915, obj, true); + int type = intel_gt_coherent_map_type(ce->engine->gt, obj, true); void *map; if (!i915_gem_object_trylock(obj, NULL)) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c index 02886c1eb0f1..62eda0ab9bfc 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.c +++ b/drivers/gpu/drm/i915/gt/intel_gt.c @@ -1134,6 +1134,21 @@ void intel_gt_invalidate_tlb(struct intel_gt *gt, u32 seqno) } } +enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, + struct drm_i915_gem_object *obj, + bool always_coherent) +{ + /* + * Wa_22016122933: always return I915_MAP_WC for MTL + */ + if (i915_gem_object_is_lmem(obj) || IS_METEORLAKE(gt->i915)) + return I915_MAP_WC; + if (HAS_LLC(gt->i915) || always_coherent) + return I915_MAP_WB; + else + return I915_MAP_WC; +} + #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) #include "selftest_tlb.c" #endif diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h b/drivers/gpu/drm/i915/gt/intel_gt.h index d2f4fbde5f9f..adb442aaa522 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.h +++ b/drivers/gpu/drm/i915/gt/intel_gt.h @@ -119,4 +119,7 @@ static inline u32 intel_gt_next_invalidate_tlb_full(const struct intel_gt *gt) void intel_gt_invalidate_tlb(struct intel_gt *gt, u32 seqno); +enum i915_map_type intel_gt_coherent_map_type(struct intel_gt *gt, + struct drm_i915_gem_object *obj, + bool always_coherent); #endif /* __INTEL_GT_H__ */ diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/intel_gtt.c index 731d9f2bbc56..13944a14ea2d 100644 --- a/drivers/gpu/drm/i915/gt/intel_gtt.c +++ b/drivers/gpu/drm/i915/gt/intel_gtt.c @@ -89,7 +89,7 @@ int map_pt_dma(struct i915_address_space *vm, struct drm_i915_gem_object *obj) enum i915_map_type type; void *vaddr; - type = i915_coherent_map_type(vm->i915, obj, true); + type = intel_gt_coherent_map_type(vm->gt, obj, true); vaddr = i915_gem_object_pin_map_unlocked(obj, type); if (IS_ERR(vaddr)) return PTR_ERR(vaddr); @@ -103,7 +103,7 @@ int map_pt_dma_locked(struct i915_address_space *vm, struct drm_i915_gem_object enum i915_map_type type; void *vaddr; - type = i915_coherent_map_type(vm->i915, obj, true); + type = intel_gt_coherent_map_type(vm->gt, obj, true); vaddr = i915_gem_object_pin_map(obj, type); if (IS_ERR(vaddr)) return PTR_ERR(vaddr); diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index 119deb9f938c..339b02762bf9 100644 --- a/drivers/gpu/drm/i915/gt/intel_lrc.c +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c @@ -1191,9 +1191,9 @@ lrc_pre_pin(struct intel_context *ce, GEM_BUG_ON(!i915_vma_is_pinned(ce->state)); *vaddr = i915_gem_object_pin_map(ce->state->obj, - i915_coherent_map_type(ce->engine->i915, - ce->state->obj, - false) | + intel_gt_coherent_map_type(ce->engine->gt, + ce->state->obj, + false) | I915_MAP_OVERRIDE); return PTR_ERR_OR_ZERO(*vaddr); diff --git a/drivers/gpu/drm/i915/gt/intel_ring.c b/drivers/gpu/drm/i915/gt/intel_ring.c index fb99143be98e..59da4b7bd262 100644 --- a/drivers/gpu/drm/i915/gt/intel_ring.c +++ b/drivers/gpu/drm/i915/gt/intel_ring.c @@ -13,6 +13,7 @@ #include "intel_engine_regs.h" #include "intel_gpu_commands.h" #include "intel_ring.h" +#include "intel_gt.h" #include "intel_timeline.h" unsigned int intel_ring_update_space(struct intel_ring *ring) @@ -56,7 +57,7 @@ int intel_ring_pin(struct intel_ring *ring, struct i915_gem_ww_ctx *ww) if (i915_vma_is_map_and_fenceable(vma) && !HAS_LLC(vma->vm->i915)) { addr = (void __force *)i915_vma_pin_iomap(vma); } else { - int type = i915_coherent_map_type(vma->vm->i915, vma->obj, false); + int type = intel_gt_coherent_map_type(vma->vm->gt, vma->obj, false); addr = i915_gem_object_pin_map(vma->obj, type); } diff --git a/drivers/gpu/drm/i915/gt/selftest_context.c b/drivers/gpu/drm/i915/gt/selftest_context.c index 76fbae358072..47070cba7eb1 100644 --- a/drivers/gpu/drm/i915/gt/selftest_context.c +++ b/drivers/gpu/drm/i915/gt/selftest_context.c @@ -88,8 +88,9 @@ static int __live_context_size(struct intel_engine_cs *engine) goto err; vaddr = i915_gem_object_pin_map_unlocked(ce->state->obj, - i915_coherent_map_type(engine->i915, - ce->state->obj, false)); + intel_gt_coherent_map_type(engine->gt, + ce->state->obj, + false)); if (IS_ERR(vaddr)) { err = PTR_ERR(vaddr); intel_context_unpin(ce); diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c index 8b0d84f2aad2..0dd4d00ee894 100644 --- a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c +++ b/drivers/gpu/drm/i915/gt/selftest_hangcheck.c @@ -73,7 +73,7 @@ static int hang_init(struct hang *h, struct intel_gt *gt) h->seqno = memset(vaddr, 0xff, PAGE_SIZE); vaddr = i915_gem_object_pin_map_unlocked(h->obj, - i915_coherent_map_type(gt->i915, h->obj, false)); + intel_gt_coherent_map_type(gt, h->obj, false)); if (IS_ERR(vaddr)) { err = PTR_ERR(vaddr); goto err_unpin_hws; @@ -119,7 +119,7 @@ hang_create_request(struct hang *h, struct intel_engine_cs *engine) return ERR_CAST(obj); } - vaddr = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(gt->i915, obj, false)); + vaddr = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, false)); if (IS_ERR(vaddr)) { i915_gem_object_put(obj); i915_vm_put(vm); diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c index a78a3d2c2e16..5f826b6dcf5d 100644 --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c @@ -1292,9 +1292,9 @@ static int compare_isolation(struct intel_engine_cs *engine, } lrc = i915_gem_object_pin_map_unlocked(ce->state->obj, - i915_coherent_map_type(engine->i915, - ce->state->obj, - false)); + intel_gt_coherent_map_type(engine->gt, + ce->state->obj, + false)); if (IS_ERR(lrc)) { err = PTR_ERR(lrc); goto err_B1; diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c index 163021705210..f5381c1eb779 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c @@ -282,7 +282,6 @@ static int gsc_fw_load(struct intel_gsc_uc *gsc) static int gsc_fw_load_prepare(struct intel_gsc_uc *gsc) { struct intel_gt *gt = gsc_uc_to_gt(gsc); - struct drm_i915_private *i915 = gt->i915; void *src; if (!gsc->local) @@ -292,7 +291,7 @@ static int gsc_fw_load_prepare(struct intel_gsc_uc *gsc) return -ENOSPC; src = i915_gem_object_pin_map_unlocked(gsc->fw.obj, - i915_coherent_map_type(i915, gsc->fw.obj, true)); + intel_gt_coherent_map_type(gt, gsc->fw.obj, true)); if (IS_ERR(src)) return PTR_ERR(src); diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c index 2eb891b270ae..6c072f100c9b 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c @@ -792,8 +792,8 @@ int intel_guc_allocate_and_map_vma(struct intel_guc *guc, u32 size, return PTR_ERR(vma); vaddr = i915_gem_object_pin_map_unlocked(vma->obj, - i915_coherent_map_type(guc_to_gt(guc)->i915, - vma->obj, true)); + intel_gt_coherent_map_type(guc_to_gt(guc), + vma->obj, true)); if (IS_ERR(vaddr)) { i915_vma_unpin_and_release(&vma, 0); return PTR_ERR(vaddr); diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c index 48f506a26e6d..b648238cc675 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc_fw.c @@ -27,7 +27,6 @@ struct mtl_huc_auth_msg_out { int intel_huc_fw_auth_via_gsccs(struct intel_huc *huc) { struct intel_gt *gt = huc_to_gt(huc); - struct drm_i915_private *i915 = gt->i915; struct drm_i915_gem_object *obj; struct mtl_huc_auth_msg_in *msg_in; struct mtl_huc_auth_msg_out *msg_out; @@ -43,7 +42,7 @@ int intel_huc_fw_auth_via_gsccs(struct intel_huc *huc) pkt_offset = i915_ggtt_offset(huc->heci_pkt); pkt_vaddr = i915_gem_object_pin_map_unlocked(obj, - i915_coherent_map_type(i915, obj, true)); + intel_gt_coherent_map_type(gt, obj, true)); if (IS_ERR(pkt_vaddr)) return PTR_ERR(pkt_vaddr); diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c index 7aadad5639c3..fc0d05d2df59 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c @@ -11,6 +11,7 @@ #include <drm/drm_print.h> #include "gem/i915_gem_lmem.h" +#include "gt/intel_gt.h" #include "gt/intel_gt_print.h" #include "intel_gsc_binary_headers.h" #include "intel_gsc_fw.h" @@ -1213,7 +1214,7 @@ static int uc_fw_rsa_data_create(struct intel_uc_fw *uc_fw) return PTR_ERR(vma); vaddr = i915_gem_object_pin_map_unlocked(vma->obj, - i915_coherent_map_type(gt->i915, vma->obj, true)); + intel_gt_coherent_map_type(gt, vma->obj, true)); if (IS_ERR(vaddr)) { i915_vma_unpin_and_release(&vma, 0); err = PTR_ERR(vaddr); diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c index c7df47364013..2a600184a077 100644 --- a/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c @@ -6,6 +6,7 @@ #include "gem/i915_gem_internal.h" #include "gt/intel_context.h" +#include "gt/intel_gt.h" #include "gt/uc/intel_gsc_fw.h" #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h" @@ -336,7 +337,7 @@ gsccs_create_buffer(struct intel_gt *gt, } /* return a virtual pointer */ - *map = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); + *map = i915_gem_object_pin_map_unlocked(obj, intel_gt_coherent_map_type(gt, obj, true)); if (IS_ERR(*map)) { drm_err(&i915->drm, "Failed to map gsccs backend %s.\n", bufname); err = PTR_ERR(*map); diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c index 1ce07d7e8769..80bb00189865 100644 --- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c @@ -11,6 +11,7 @@ #include "gem/i915_gem_lmem.h" #include "i915_drv.h" +#include "gt/intel_gt.h" #include "intel_pxp.h" #include "intel_pxp_cmd_interface_42.h" @@ -245,7 +246,9 @@ static int alloc_streaming_command(struct intel_pxp *pxp) } /* map the lmem into the virtual memory pointer */ - cmd = i915_gem_object_pin_map_unlocked(obj, i915_coherent_map_type(i915, obj, true)); + cmd = i915_gem_object_pin_map_unlocked(obj, + intel_gt_coherent_map_type(pxp->ctrl_gt, + obj, true)); if (IS_ERR(cmd)) { drm_err(&i915->drm, "Failed to map gsc message page!\n"); err = PTR_ERR(cmd); diff --git a/drivers/gpu/drm/i915/selftests/igt_spinner.c b/drivers/gpu/drm/i915/selftests/igt_spinner.c index 3c5e0952f1b8..0f064930ef11 100644 --- a/drivers/gpu/drm/i915/selftests/igt_spinner.c +++ b/drivers/gpu/drm/i915/selftests/igt_spinner.c @@ -97,7 +97,7 @@ int igt_spinner_pin(struct igt_spinner *spin, if (!spin->batch) { unsigned int mode; - mode = i915_coherent_map_type(spin->gt->i915, spin->obj, false); + mode = intel_gt_coherent_map_type(spin->gt, spin->obj, false); vaddr = igt_spinner_pin_obj(ce, ww, spin->obj, mode, &spin->batch_vma); if (IS_ERR(vaddr)) return PTR_ERR(vaddr); -- 2.25.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
end of thread, other threads:[~2023-08-01 15:40 UTC | newest] Thread overview: 21+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-07-26 15:53 [Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Jonathan Cavitt 2023-07-26 15:53 ` [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric Jonathan Cavitt 2023-07-27 11:35 ` Tvrtko Ursulin 2023-07-28 1:34 ` Andi Shyti 2023-07-28 8:07 ` Tvrtko Ursulin 2023-07-28 8:18 ` Andi Shyti 2023-07-27 12:16 ` Andi Shyti 2023-08-01 14:32 ` Andi Shyti 2023-07-26 15:53 ` [Intel-gfx] [PATCH 3/3] drm/i915/gt: Apply workaround 22016122933 correctly Jonathan Cavitt 2023-07-27 12:20 ` Andi Shyti 2023-07-26 16:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection Patchwork 2023-07-26 16:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2023-07-26 16:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2023-07-26 20:30 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2023-07-27 11:27 ` [Intel-gfx] [PATCH 1/3] " Tvrtko Ursulin 2023-07-27 12:23 ` Andi Shyti 2023-08-01 12:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection (rev2) Patchwork 2023-08-01 12:17 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2023-08-01 12:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2023-08-01 15:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2023-08-01 15:32 [Intel-gfx] [PATCH 0/3] drm/i915: Fix Wa_22016122933 implementation Jonathan Cavitt 2023-08-01 15:32 ` [Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric Jonathan Cavitt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox