Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 0/4] Separate display workarounds from clock gating
@ 2023-09-06 23:47 Matt Roper
  2023-09-06 23:47 ` [Intel-gfx] [PATCH 1/4] drm/i915: Stop forcing clock gating init for future platforms Matt Roper
                   ` (14 more replies)
  0 siblings, 15 replies; 25+ messages in thread
From: Matt Roper @ 2023-09-06 23:47 UTC (permalink / raw)
  To: intel-gfx; +Cc: matthew.d.roper

The clock gating init hooks in i915 are a bit jumbled.  The current
implementation includes a mix of GT workarounds (which really should
have been in the GT workaround file instead), SoC/sgunit clock gating
workarounds, and display workarounds (some of which are entirely
unrelated to clock gating).  Some of this confusion originates from
really old platforms where the boundaries between GT/display/other IP
blocks weren't as clear as they are today, but at least on modern
platforms we should be able to do a better job of placing this
programming now.

Let's separate the display workarounds for gen11 and newer platforms
into a dedicated file and apply the workarounds during actual display
initialization, rather than having them applied indirectly during GEM
init.  This will help keep the clock gating hooks focused on actual
SoC/sgunit clock gating going forward and avoid making them a dumping
ground for assorted register programming.  It will also ensure that when
i915's display code is built into the Xe driver these workarounds will
still get applied during device probe rather than being missed as they
are today.

Matt Roper (4):
  drm/i915: Stop forcing clock gating init for future platforms
  drm/i915/adlp: Stop calling gen12lp_init_clock_gating()
  drm/i915/display: Extract display workarounds from clock gating init
  drm/i915/display: Apply workarounds during display init

 drivers/gpu/drm/i915/Makefile                 |  1 +
 .../drm/i915/display/intel_display_driver.c   |  2 +
 .../gpu/drm/i915/display/intel_display_wa.c   | 47 ++++++++++++++++
 .../gpu/drm/i915/display/intel_display_wa.h   | 13 +++++
 drivers/gpu/drm/i915/intel_clock_gating.c     | 53 ++-----------------
 5 files changed, 66 insertions(+), 50 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_wa.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_wa.h

-- 
2.41.0


^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2023-09-11  9:04 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-06 23:47 [Intel-gfx] [PATCH 0/4] Separate display workarounds from clock gating Matt Roper
2023-09-06 23:47 ` [Intel-gfx] [PATCH 1/4] drm/i915: Stop forcing clock gating init for future platforms Matt Roper
2023-09-08 21:45   ` Lucas De Marchi
2023-09-08 21:50     ` Matt Roper
2023-09-08 21:57       ` Lucas De Marchi
2023-09-06 23:47 ` [Intel-gfx] [PATCH 2/4] drm/i915/adlp: Stop calling gen12lp_init_clock_gating() Matt Roper
2023-09-08 21:46   ` Lucas De Marchi
2023-09-06 23:47 ` [Intel-gfx] [PATCH 3/4] drm/i915/display: Extract display workarounds from clock gating init Matt Roper
2023-09-07  0:10   ` [Intel-gfx] [PATCH v2 " Matt Roper
2023-09-08 21:51   ` [Intel-gfx] [PATCH " Lucas De Marchi
2023-09-06 23:47 ` [Intel-gfx] [PATCH 4/4] drm/i915/display: Apply workarounds during display init Matt Roper
2023-09-08 21:52   ` Lucas De Marchi
2023-09-06 23:55 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Separate display workarounds from clock gating Patchwork
2023-09-07  1:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Separate display workarounds from clock gating (rev2) Patchwork
2023-09-07  1:25 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-07  1:42 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-07 20:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Separate display workarounds from clock gating (rev3) Patchwork
2023-09-07 20:04 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-07 20:22 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-08  2:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Separate display workarounds from clock gating (rev4) Patchwork
2023-09-08  2:03 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-08  2:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-08  6:32 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-08 23:01   ` Matt Roper
2023-09-11  9:04     ` Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox