From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 1/2] drm/i915/display: Move releasing gem object away from fb tracking
Date: Thu, 12 Oct 2023 10:21:57 +0300 [thread overview]
Message-ID: <20231012072158.4115795-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20231012072158.4115795-1-jouni.hogander@intel.com>
As a preparation for Xe we want to remove all i915_gem_object details away
from frontbuffer tacking code. Due to this move releasing gem object
reference to i915_gem_object_set_frontbuffer.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_frontbuffer.c | 2 --
drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.h | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_frontbuffer.c b/drivers/gpu/drm/i915/display/intel_frontbuffer.c
index ec46716b2f49..2ea37c0414a9 100644
--- a/drivers/gpu/drm/i915/display/intel_frontbuffer.c
+++ b/drivers/gpu/drm/i915/display/intel_frontbuffer.c
@@ -265,8 +265,6 @@ static void frontbuffer_release(struct kref *ref)
spin_unlock(&intel_bo_to_i915(obj)->display.fb_tracking.lock);
i915_active_fini(&front->write);
-
- i915_gem_object_put(obj);
kfree_rcu(front, rcu);
}
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.h b/drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.h
index e5e870b6f186..9fbf14867a2a 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.h
+++ b/drivers/gpu/drm/i915/gem/i915_gem_object_frontbuffer.h
@@ -89,6 +89,7 @@ i915_gem_object_set_frontbuffer(struct drm_i915_gem_object *obj,
if (!front) {
RCU_INIT_POINTER(obj->frontbuffer, NULL);
+ drm_gem_object_put(intel_bo_to_drm_bo(obj));
} else if (rcu_access_pointer(obj->frontbuffer)) {
cur = rcu_dereference_protected(obj->frontbuffer, true);
kref_get(&cur->ref);
--
2.34.1
next prev parent reply other threads:[~2023-10-12 7:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 7:21 [Intel-gfx] [PATCH 0/2] Frontbuffer tracking preparing for Xe Jouni Högander
2023-10-12 7:21 ` Jouni Högander [this message]
2023-10-20 13:26 ` [Intel-gfx] [PATCH 1/2] drm/i915/display: Move releasing gem object away from fb tracking Juha-Pekka Heikkila
2023-10-23 6:10 ` Hogander, Jouni
2023-10-12 7:21 ` [Intel-gfx] [PATCH 2/2] drm/i915/display: Use intel_bo_to_drm_bo instead of obj->base Jouni Högander
2023-10-20 13:26 ` Juha-Pekka Heikkila
2023-10-12 23:35 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Frontbuffer tracking preparing for Xe (rev2) Patchwork
2023-10-12 23:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-13 22:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012072158.4115795-2-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox