From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: "Jouni Högander" <jouni.hogander@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: Use intel_bo_to_drm_bo instead of obj->base
Date: Fri, 20 Oct 2023 16:26:37 +0300 [thread overview]
Message-ID: <71f8d747-a93c-4e2e-9163-9d3d1414b925@gmail.com> (raw)
In-Reply-To: <20231012072158.4115795-3-jouni.hogander@intel.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 12.10.2023 10.21, Jouni Högander wrote:
> Xe and i915 objects have differing implementation. Use intel_bo_to_drm_bo
> instead of obj->base as xe_bo doesn't have base pointer.
>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
> index e7678571b0d7..e1d298efc510 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb.c
> @@ -1930,10 +1930,10 @@ static int intel_user_framebuffer_dirty(struct drm_framebuffer *fb,
> if (!atomic_read(&front->bits))
> return 0;
>
> - if (dma_resv_test_signaled(obj->base.resv, dma_resv_usage_rw(false)))
> + if (dma_resv_test_signaled(intel_bo_to_drm_bo(obj)->resv, dma_resv_usage_rw(false)))
> goto flush;
>
> - ret = dma_resv_get_singleton(obj->base.resv, dma_resv_usage_rw(false),
> + ret = dma_resv_get_singleton(intel_bo_to_drm_bo(obj)->resv, dma_resv_usage_rw(false),
> &fence);
> if (ret || !fence)
> goto flush;
next prev parent reply other threads:[~2023-10-20 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 7:21 [Intel-gfx] [PATCH 0/2] Frontbuffer tracking preparing for Xe Jouni Högander
2023-10-12 7:21 ` [Intel-gfx] [PATCH 1/2] drm/i915/display: Move releasing gem object away from fb tracking Jouni Högander
2023-10-20 13:26 ` Juha-Pekka Heikkila
2023-10-23 6:10 ` Hogander, Jouni
2023-10-12 7:21 ` [Intel-gfx] [PATCH 2/2] drm/i915/display: Use intel_bo_to_drm_bo instead of obj->base Jouni Högander
2023-10-20 13:26 ` Juha-Pekka Heikkila [this message]
2023-10-12 23:35 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Frontbuffer tracking preparing for Xe (rev2) Patchwork
2023-10-12 23:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-13 22:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71f8d747-a93c-4e2e-9163-9d3d1414b925@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox