[Intel-gfx] [PATCH v2 0/2] display device info as a separate debugfs entry

[Intel-gfx] [PATCH v2 0/2] display device info as a separate debugfs entry

[Vinod Govindapillai]

Expose the display device info as a separate debugfs entry to list out
display device info and remove the same from i915_capabilities

v2: rename the debugs entry to i915_display_capabilities and patch
    description changes

Vinod Govindapillai (2):
  drm/i915/display: debugfs entry to list display capabilities
  drm/i915: remove display device info from i915 capabilities

 drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 ++++++++++++
 drivers/gpu/drm/i915/i915_debugfs.c                  |  1 -
 2 files changed, 12 insertions(+), 1 deletion(-)

-- 
2.34.1

[Intel-gfx] [PATCH v2 1/2] drm/i915/display: debugfs entry to list display capabilities

[Vinod Govindapillai]

Create a separate debugfs entry to list the display capabilities
IGT can rely on this debugfs entry for tests that depend on
display device and display runtime info for both xe and i915
drivers.

v2: rename the entry to i915_display_capabilities (Chaitanya)

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index fbe75d47a165..b0248dfa8dea 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -641,6 +641,17 @@ static int i915_display_info(struct seq_file *m, void *unused)
 	return 0;
 }
 
+static int i915_display_capabilities(struct seq_file *m, void *unused)
+{
+	struct drm_i915_private *i915 = node_to_i915(m->private);
+	struct drm_printer p = drm_seq_file_printer(m);
+
+	intel_display_device_info_print(DISPLAY_INFO(i915),
+					DISPLAY_RUNTIME_INFO(i915), &p);
+
+	return 0;
+}
+
 static int i915_shared_dplls_info(struct seq_file *m, void *unused)
 {
 	struct drm_i915_private *dev_priv = node_to_i915(m->private);
@@ -1059,6 +1070,7 @@ static const struct drm_info_list intel_display_debugfs_list[] = {
 	{"i915_gem_framebuffer", i915_gem_framebuffer_info, 0},
 	{"i915_power_domain_info", i915_power_domain_info, 0},
 	{"i915_display_info", i915_display_info, 0},
+	{"i915_display_capabilities", i915_display_capabilities, 0},
 	{"i915_shared_dplls_info", i915_shared_dplls_info, 0},
 	{"i915_dp_mst_info", i915_dp_mst_info, 0},
 	{"i915_ddb_info", i915_ddb_info, 0},
-- 
2.34.1

[Intel-gfx] [PATCH v2 2/2] drm/i915: remove display device info from i915 capabilities

[Vinod Govindapillai]

Display device and display runtime info is exposed as part of
i915_display_capabilities debugfs entry. Remove this information
from i915_ capabilities as it is now reduntant.

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index e9b79c2c37d8..bb48feb3b12e 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -67,7 +67,6 @@ static int i915_capabilities(struct seq_file *m, void *data)
 	seq_printf(m, "pch: %d\n", INTEL_PCH_TYPE(i915));
 
 	intel_device_info_print(INTEL_INFO(i915), RUNTIME_INFO(i915), &p);
-	intel_display_device_info_print(DISPLAY_INFO(i915), DISPLAY_RUNTIME_INFO(i915), &p);
 	i915_print_iommu_status(i915, &p);
 	intel_gt_info_print(&to_gt(i915)->info, &p);
 	intel_driver_caps_print(&i915->caps, &p);
-- 
2.34.1

Re: [Intel-gfx] [PATCH v2 0/2] display device info as a separate debugfs entry

[Govindapillai, Vinod]

Hi Swati,

Realized that I cannot remove the display runtime info from i915_capabilties until IGT start using
this new created entry.

So excluded the patch to remove the redundant info from i915_capabilties from this series
A new version is sent! Sorry for the confusion!

BR
vinod

On Tue, 2023-10-17 at 23:37 +0300, Vinod Govindapillai wrote:
> Expose the display device info as a separate debugfs entry to list out
> display device info and remove the same from i915_capabilities
> 
> v2: rename the debugs entry to i915_display_capabilities and patch
>     description changes
> 
> Vinod Govindapillai (2):
>   drm/i915/display: debugfs entry to list display capabilities
>   drm/i915: remove display device info from i915 capabilities
> 
>  drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 ++++++++++++
>  drivers/gpu/drm/i915/i915_debugfs.c                  |  1 -
>  2 files changed, 12 insertions(+), 1 deletion(-)
>