From: kernel test robot <lkp@intel.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH 3/4] drm/ttm: improve idle/busy handling
Date: Thu, 14 Dec 2023 16:30:46 +0800 [thread overview]
Message-ID: <202312141637.ciYxVFVl-lkp@intel.com> (raw)
In-Reply-To: <20231213144222.1871-3-christian.koenig@amd.com>
Hi Christian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.7-rc5 next-20231214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-ttm-replace-busy-placement-with-flags-v3/20231213-224456
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20231213144222.1871-3-christian.koenig%40amd.com
patch subject: [PATCH 3/4] drm/ttm: improve idle/busy handling
config: arm-defconfig (https://download.01.org/0day-ci/archive/20231214/202312141637.ciYxVFVl-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231214/202312141637.ciYxVFVl-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312141637.ciYxVFVl-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/ttm/ttm_resource.c:301: warning: Function parameter or member 'busy' not described in 'ttm_resource_compatible'
vim +301 drivers/gpu/drm/ttm/ttm_resource.c
544432703b2fe7 Arunpravin Paneer Selvam 2022-08-20 289
544432703b2fe7 Arunpravin Paneer Selvam 2022-08-20 290 /**
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 291 * ttm_resource_compatible - check if resource is compatible with placement
544432703b2fe7 Arunpravin Paneer Selvam 2022-08-20 292 *
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 293 * @res: the resource to check
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 294 * @placement: the placement to check against
544432703b2fe7 Arunpravin Paneer Selvam 2022-08-20 295 *
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 296 * Returns true if the placement is compatible.
544432703b2fe7 Arunpravin Paneer Selvam 2022-08-20 297 */
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 298 bool ttm_resource_compatible(struct ttm_resource *res,
1e59504faf5d28 Christian König 2023-12-13 299 struct ttm_placement *placement,
1e59504faf5d28 Christian König 2023-12-13 300 bool busy)
98cca519df6da6 Christian König 2021-08-30 @301 {
544432703b2fe7 Arunpravin Paneer Selvam 2022-08-20 302 struct ttm_buffer_object *bo = res->bo;
544432703b2fe7 Arunpravin Paneer Selvam 2022-08-20 303 struct ttm_device *bdev = bo->bdev;
98cca519df6da6 Christian König 2021-08-30 304 unsigned i;
98cca519df6da6 Christian König 2021-08-30 305
98cca519df6da6 Christian König 2021-08-30 306 if (res->placement & TTM_PL_FLAG_TEMPORARY)
98cca519df6da6 Christian König 2021-08-30 307 return false;
98cca519df6da6 Christian König 2021-08-30 308
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 309 for (i = 0; i < placement->num_placement; i++) {
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 310 const struct ttm_place *place = &placement->placement[i];
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 311 struct ttm_resource_manager *man;
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 312
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 313 if (res->mem_type != place->mem_type)
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 314 continue;
98cca519df6da6 Christian König 2021-08-30 315
1e59504faf5d28 Christian König 2023-12-13 316 if (place->flags & (busy ? TTM_PL_FLAG_IDLE : TTM_PL_FLAG_BUSY))
1e59504faf5d28 Christian König 2023-12-13 317 continue;
1e59504faf5d28 Christian König 2023-12-13 318
1e59504faf5d28 Christian König 2023-12-13 319 if (place->flags & TTM_PL_FLAG_CONTIGUOUS &&
1e59504faf5d28 Christian König 2023-12-13 320 !(res->placement & TTM_PL_FLAG_CONTIGUOUS))
1e59504faf5d28 Christian König 2023-12-13 321 continue;
1e59504faf5d28 Christian König 2023-12-13 322
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 323 man = ttm_manager_type(bdev, res->mem_type);
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 324 if (man->func->compatible &&
9909b7ee1d1561 Somalapuram Amaranath 2023-12-13 325 !man->func->compatible(man, res, place, bo->base.size))
98cca519df6da6 Christian König 2021-08-30 326 continue;
98cca519df6da6 Christian König 2021-08-30 327
98cca519df6da6 Christian König 2021-08-30 328 return true;
98cca519df6da6 Christian König 2021-08-30 329 }
98cca519df6da6 Christian König 2021-08-30 330 return false;
98cca519df6da6 Christian König 2021-08-30 331 }
98cca519df6da6 Christian König 2021-08-30 332
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-12-14 8:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 14:42 [PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space Christian König
2023-12-13 14:42 ` [PATCH 2/4] drm/ttm: replace busy placement with flags v3 Christian König
2023-12-13 14:42 ` [PATCH 3/4] drm/ttm: improve idle/busy handling Christian König
2023-12-14 8:30 ` kernel test robot [this message]
2023-12-16 0:44 ` kernel test robot
2023-12-13 14:42 ` [PATCH 4/4] drm/amdgpu: use GTT only as fallback for VRAM|GTT Christian König
2023-12-13 14:50 ` [PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space Christian König
2023-12-13 21:24 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] " Patchwork
2023-12-13 21:24 ` ✗ Fi.CI.SPARSE: " Patchwork
2023-12-13 21:47 ` ✓ Fi.CI.BAT: success " Patchwork
2023-12-13 22:42 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312141637.ciYxVFVl-lkp@intel.com \
--to=lkp@intel.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox