Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 4/4] drm/i915/alpm: Alpm aux wake configuration for lnl
Date: Fri,  5 Jan 2024 16:15:04 +0200	[thread overview]
Message-ID: <20240105141504.2808991-5-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240105141504.2808991-1-jouni.hogander@intel.com>

Lunarlake has some configurations in ALPM_CTL register for legacy ALPM as
well. Write these.

Bspec: 71477

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 7fbd18f21c3b..09d496d7dcee 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1527,6 +1527,18 @@ static void wm_optimization_wa(struct intel_dp *intel_dp,
 			     wa_16013835468_bit_get(intel_dp), 0);
 }
 
+static void lnl_alpm_configure(struct intel_dp *intel_dp)
+{
+	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
+	enum transcoder cpu_transcoder = intel_dp->psr.transcoder;
+	struct alpm_parameters *alpm_params = &intel_dp->psr.alpm_params;
+
+	intel_de_write(dev_priv, ALPM_CTL(cpu_transcoder),
+		       ALPM_CTL_EXTENDED_FAST_WAKE_ENABLE |
+		       ALPM_CTL_ALPM_ENTRY_CHECK(alpm_params->check_entry_lines) |
+		       ALPM_CTL_EXTENDED_FAST_WAKE_TIME(alpm_params->fast_wake_lines));
+}
+
 static void intel_psr_enable_source(struct intel_dp *intel_dp,
 				    const struct intel_crtc_state *crtc_state)
 {
@@ -1582,6 +1594,9 @@ static void intel_psr_enable_source(struct intel_dp *intel_dp,
 			     intel_dp->psr.psr2_sel_fetch_enabled ?
 			     IGNORE_PSR2_HW_TRACKING : 0);
 
+	if (DISPLAY_VER(dev_priv) >= 20)
+		lnl_alpm_configure(intel_dp);
+
 	/*
 	 * Wa_16013835468
 	 * Wa_14015648006
-- 
2.34.1


  parent reply	other threads:[~2024-01-05 14:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-05 14:15 [PATCH v2 0/4] ALPM AUX Wake Configuration Jouni Högander
2024-01-05 14:15 ` [PATCH v2 1/4] drm/i915/alpm: Add ALPM register definitions Jouni Högander
2024-01-24  6:16   ` Murthy, Arun R
2024-01-05 14:15 ` [PATCH v2 2/4] drm/i915/psr: Add alpm_parameters struct Jouni Högander
2024-01-24  9:17   ` Murthy, Arun R
2024-01-24  9:24     ` Hogander, Jouni
2024-01-24  9:28       ` Murthy, Arun R
2024-01-24  9:39         ` Hogander, Jouni
2024-01-05 14:15 ` [PATCH v2 3/4] drm/i915/alpm: Calculate ALPM Entry check Jouni Högander
2024-01-29  2:08   ` Murthy, Arun R
2024-01-29  7:33     ` Hogander, Jouni
2024-01-05 14:15 ` Jouni Högander [this message]
2024-01-30  8:28   ` [PATCH v2 4/4] drm/i915/alpm: Alpm aux wake configuration for lnl Murthy, Arun R
2024-01-30  9:13     ` Hogander, Jouni
2024-01-05 16:10 ` ✗ Fi.CI.CHECKPATCH: warning for ALPM AUX Wake Configuration (rev2) Patchwork
2024-01-05 16:10 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-01-05 16:23 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-06  9:27 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240105141504.2808991-5-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox