Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 04/13] drm/i915/color: Use per-device debugs
Date: Thu,  8 Feb 2024 17:17:11 +0200	[thread overview]
Message-ID: <20240208151720.7866-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240208151720.7866-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Switch to drm_dbg_kms() in the LUT validation code so we see
which device generated the debugs. Need to plumb i915 a bit
deeper to make that happen.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_color.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
index c5092b7e87d5..ca7112b32cb3 100644
--- a/drivers/gpu/drm/i915/display/intel_color.c
+++ b/drivers/gpu/drm/i915/display/intel_color.c
@@ -2111,7 +2111,8 @@ static u32 intel_degamma_lut_size(const struct intel_crtc_state *crtc_state)
 	return DISPLAY_INFO(i915)->color.degamma_lut_size;
 }
 
-static int check_lut_size(const struct drm_property_blob *lut, int expected)
+static int check_lut_size(struct drm_i915_private *i915,
+			  const struct drm_property_blob *lut, int expected)
 {
 	int len;
 
@@ -2120,8 +2121,8 @@ static int check_lut_size(const struct drm_property_blob *lut, int expected)
 
 	len = drm_color_lut_size(lut);
 	if (len != expected) {
-		DRM_DEBUG_KMS("Invalid LUT size; got %d, expected %d\n",
-			      len, expected);
+		drm_dbg_kms(&i915->drm, "Invalid LUT size; got %d, expected %d\n",
+			    len, expected);
 		return -EINVAL;
 	}
 
@@ -2146,8 +2147,8 @@ static int _check_luts(const struct intel_crtc_state *crtc_state,
 	degamma_length = intel_degamma_lut_size(crtc_state);
 	gamma_length = intel_gamma_lut_size(crtc_state);
 
-	if (check_lut_size(degamma_lut, degamma_length) ||
-	    check_lut_size(gamma_lut, gamma_length))
+	if (check_lut_size(i915, degamma_lut, degamma_length) ||
+	    check_lut_size(i915, gamma_lut, gamma_length))
 		return -EINVAL;
 
 	if (drm_color_lut_check(degamma_lut, degamma_tests) ||
-- 
2.43.0


  parent reply	other threads:[~2024-02-08 15:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08 15:17 [PATCH 00/13] drm/i915: drm_dbg_kms() conversions and cleanups Ville Syrjala
2024-02-08 15:17 ` [PATCH 01/13] drm/i915: Correct for_each_old_global_obj_in_state() arguments Ville Syrjala
2024-02-08 15:17 ` [PATCH 02/13] drm/i915/sdvo: Convert to per-device debugs Ville Syrjala
2024-02-08 15:17 ` [PATCH 03/13] drm/i915/sdvo: Fix up code alignment Ville Syrjala
2024-02-08 15:17 ` Ville Syrjala [this message]
2024-02-08 15:17 ` [PATCH 05/13] drm/i915/fb: Use per-device debugs Ville Syrjala
2024-02-08 15:17 ` [PATCH 06/13] drm/i915/bios: Switch to kms debugs Ville Syrjala
2024-02-08 15:17 ` [PATCH 07/13] drm/i915/bios: Use per-device debugs for VBT related stuff Ville Syrjala
2024-02-08 15:17 ` [PATCH 08/13] drm/i915/hdcp: Use per-device debugs Ville Syrjala
2024-02-08 15:17 ` [PATCH 09/13] drm/i915/wm: Pass the whole i916 to intel_get_cxsr_latency() Ville Syrjala
2024-02-08 15:17 ` [PATCH 10/13] drm/i915/wm: Use per-device debugs in pre-ilk wm code Ville Syrjala
2024-02-08 15:17 ` [PATCH 11/13] drm/i915/wm: Use per-device debugs ilk " Ville Syrjala
2024-02-08 15:17 ` [PATCH 12/13] drm/i915/dvo/ns2501: Nuke pointless casts Ville Syrjala
2024-02-08 15:17 ` [PATCH 13/13] drm/i915/dvo: Use sizeof(*variable) instead of sizeof(type) Ville Syrjala
2024-02-08 15:52 ` [PATCH 00/13] drm/i915: drm_dbg_kms() conversions and cleanups Jani Nikula
2024-02-09 12:54   ` Ville Syrjälä
2024-02-08 21:43 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-02-08 21:43 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-02-08 22:02 ` ✓ Fi.CI.BAT: success " Patchwork
2024-02-09  3:35 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240208151720.7866-5-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox