From: Thomas Zimmermann <tzimmermann@suse.de>
To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com,
ville.syrjala@linux.intel.com, imre.deak@intel.com,
tejas.upadhyay@intel.com, jouni.hogander@intel.com,
javierm@redhat.com, airlied@gmail.com, daniel@ffwll.ch,
lucas.demarchi@intel.com, ogabbay@kernel.org,
thomas.hellstrom@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
intel-xe@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v7 2/6] drm/i915: Unregister in-kernel clients
Date: Fri, 1 Mar 2024 14:42:55 +0100 [thread overview]
Message-ID: <20240301134448.31289-3-tzimmermann@suse.de> (raw)
In-Reply-To: <20240301134448.31289-1-tzimmermann@suse.de>
Unregister all in-kernel clients before unloading the i915 driver. For
other drivers, drm_dev_unregister() does this automatically. As i915
does not use this helper, it has to perform the call by itself. For xe,
do the same in xe_device_remove()
Note that there are currently no in-kernel clients in i915 or xe. The
patch prepares the drivers for a related update of their fbdev support.
v7:
* update xe driver
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/i915/i915_driver.c | 3 +++
drivers/gpu/drm/xe/xe_device.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index 9ee902d5b72c4..97910a85e3917 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -41,6 +41,7 @@
#include <drm/drm_aperture.h>
#include <drm/drm_atomic_helper.h>
+#include <drm/drm_client.h>
#include <drm/drm_ioctl.h>
#include <drm/drm_managed.h>
#include <drm/drm_probe_helper.h>
@@ -852,6 +853,8 @@ void i915_driver_remove(struct drm_i915_private *i915)
{
intel_wakeref_t wakeref;
+ drm_client_dev_unregister(&i915->drm);
+
wakeref = intel_runtime_pm_get(&i915->runtime_pm);
i915_driver_unregister(i915);
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 919ad88f0495a..7f41f0ec819f0 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -9,6 +9,7 @@
#include <drm/drm_aperture.h>
#include <drm/drm_atomic_helper.h>
+#include <drm/drm_client.h>
#include <drm/drm_gem_ttm_helper.h>
#include <drm/drm_ioctl.h>
#include <drm/drm_managed.h>
@@ -614,6 +615,8 @@ void xe_device_remove(struct xe_device *xe)
struct xe_gt *gt;
u8 id;
+ drm_client_dev_unregister(&xe->drm);
+
xe_device_remove_display(xe);
xe_display_fini(xe);
--
2.43.2
next prev parent reply other threads:[~2024-03-01 13:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 13:42 [PATCH v7 0/6] drm/i915: Convert fbdev to DRM client Thomas Zimmermann
2024-03-01 13:42 ` [PATCH v7 1/6] drm/client: Export drm_client_dev_unregister() Thomas Zimmermann
2024-03-08 15:49 ` Rodrigo Vivi
2024-04-08 12:07 ` Thomas Zimmermann
2024-03-01 13:42 ` Thomas Zimmermann [this message]
2024-03-05 16:06 ` [PATCH v7 2/6] drm/i915: Unregister in-kernel clients Rodrigo Vivi
2024-03-05 16:25 ` Jani Nikula
2024-03-06 15:11 ` Thomas Zimmermann
2024-03-08 15:28 ` Rodrigo Vivi
2024-03-01 13:42 ` [PATCH v7 3/6] drm/i915: Move fbdev functions Thomas Zimmermann
2024-03-01 13:42 ` [PATCH v7 4/6] drm/i915: Initialize fbdev DRM client with callback functions Thomas Zimmermann
2024-04-05 8:59 ` Hogander, Jouni
2024-03-01 13:42 ` [PATCH v7 5/6] drm/i915: Implement fbdev client callbacks Thomas Zimmermann
2024-04-05 8:31 ` Hogander, Jouni
2024-03-01 13:42 ` [PATCH v7 6/6] drm/i915: Implement fbdev emulation as in-kernel client Thomas Zimmermann
2024-04-05 8:34 ` Hogander, Jouni
2024-04-05 8:59 ` Thomas Zimmermann
2024-04-05 9:04 ` Hogander, Jouni
2024-04-08 7:41 ` Thomas Zimmermann
2024-04-08 12:27 ` Thomas Zimmermann
2024-03-01 17:27 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Convert fbdev to DRM client (rev7) Patchwork
2024-03-01 17:42 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-06 16:42 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301134448.31289-3-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=javierm@redhat.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jouni.hogander@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=ogabbay@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tejas.upadhyay@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox