Re: [PATCH v7 6/6] drm/i915: Implement fbdev emulation as in-kernel client

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Fri, 2024-04-05 at 10:59 +0200, Thomas Zimmermann wrote:
> Hi
> 
> Am 05.04.24 um 10:34 schrieb Hogander, Jouni:
> [...]
> > >   
> > > diff --git a/drivers/gpu/drm/i915/i915_driver.c
> > > b/drivers/gpu/drm/i915/i915_driver.c
> > > index e0f13c62a1832..69178b73845e1 100644
> > > --- a/drivers/gpu/drm/i915/i915_driver.c
> > > +++ b/drivers/gpu/drm/i915/i915_driver.c
> > > @@ -816,6 +816,8 @@ int i915_driver_probe(struct pci_dev *pdev,
> > > const
> > > struct pci_device_id *ent)
> > >   
> > >          i915->do_release = true;
> > >   
> > > +       intel_fbdev_setup(i915);
> > > +
> > This doesn't work for Xe. I propose you move it to
> > drivers/gpu/drm/i915/display/intel_display_dirver.c:intel_display_d
> > rive
> > r_probe? Otherwise patch looks ok to me.
> 
> Can you say why it doesn't work? It's been a while, but IIRC I ran
> this 
> patch on xe for testing.

i915_driver_probe is not used by Xe driver and I can't find own call to
intel_fbdev_setup in Xe driver.

BR,

Jouni Högander
 
> 
> Best regards
> Thomas
> 
> > 
> > BR,
> > 
> > Jouni Högander
> > 
> > 
> > >          return 0;
> > >   
> > >   out_cleanup_gem:
> > > diff --git a/drivers/gpu/drm/xe/display/xe_display.c
> > > b/drivers/gpu/drm/xe/display/xe_display.c
> > > index cdbc3f04c80a7..ca5cbe1d8a03b 100644
> > > --- a/drivers/gpu/drm/xe/display/xe_display.c
> > > +++ b/drivers/gpu/drm/xe/display/xe_display.c
> > > @@ -214,9 +214,7 @@ void xe_display_fini(struct xe_device *xe)
> > >          if (!xe->info.enable_display)
> > >                  return;
> > >   
> > > -       /* poll work can call into fbdev, hence clean that up
> > > afterwards */
> > >          intel_hpd_poll_fini(xe);
> > > -       intel_fbdev_fini(xe);
> > >   
> > >          intel_hdcp_component_fini(xe);
> > >          intel_audio_deinit(xe);
>