Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][next] drm/i915: remove redundant assignement to variable err
@ 2024-04-15  9:56 Colin Ian King
  2024-04-15 11:21 ` Andi Shyti
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Colin Ian King @ 2024-04-15  9:56 UTC (permalink / raw)
  To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
	David Airlie, Daniel Vetter, Andi Shyti, intel-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

The variable err is being assigned a value 0 that is never read, the
break statement escapes a do-while loop and then the code returns
without referencing err. The assignment is redundant and can be
removed.

Cleans up clang scan build warning:
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:1075:5: warning: Value
stored to 'err' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
index 99a9ade73956..9ca9e9505244 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
@@ -1071,10 +1071,8 @@ static int igt_fill_mappable(struct intel_memory_region *mr,
 			if (err != -ENXIO && err != -ENOMEM)
 				goto err_close;
 
-			if (size == mr->min_page_size) {
-				err = 0;
+			if (size == mr->min_page_size)
 				break;
-			}
 
 			size >>= 1;
 			continue;
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-04-16  8:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-15  9:56 [PATCH][next] drm/i915: remove redundant assignement to variable err Colin Ian King
2024-04-15 11:21 ` Andi Shyti
2024-04-15 22:16 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-04-16  8:58 ` ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox