Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Animesh Manna" <animesh.manna@intel.com>,
	"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v7 06/11] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay
Date: Fri, 19 Apr 2024 15:11:36 +0300	[thread overview]
Message-ID: <20240419121141.2665945-7-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240419121141.2665945-1-jouni.hogander@intel.com>

Currently intel_dp_get_su_granularity doesn't support panel replay.
This fix modifies it to support panel replay as well.

v2: rely on PSR definitions on common bits

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Animesh Manna <animesh.manna@intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 62 +++++++++++++++++++++---
 1 file changed, 55 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index b94f8e33ed1f..29400fac13c2 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -466,6 +466,40 @@ static u8 intel_dp_get_sink_sync_latency(struct intel_dp *intel_dp)
 	return val;
 }
 
+static u8 intel_dp_get_su_capability(struct intel_dp *intel_dp)
+{
+	u8 su_capability;
+
+	if (intel_dp->psr.sink_panel_replay_su_support)
+		drm_dp_dpcd_read(&intel_dp->aux,
+				 DP_PANEL_PANEL_REPLAY_X_GRANULARITY,
+				 &su_capability, 1);
+	else
+		su_capability = intel_dp->psr_dpcd[1];
+
+	return su_capability;
+}
+
+static unsigned int
+intel_dp_get_su_x_granularity_offset(struct intel_dp *intel_dp)
+{
+	return intel_dp->psr.sink_panel_replay_su_support ?
+		DP_PANEL_PANEL_REPLAY_X_GRANULARITY :
+		DP_PSR2_SU_X_GRANULARITY;
+}
+
+static unsigned int
+intel_dp_get_su_y_granularity_offset(struct intel_dp *intel_dp)
+{
+	return intel_dp->psr.sink_panel_replay_su_support ?
+		DP_PANEL_PANEL_REPLAY_Y_GRANULARITY :
+		DP_PSR2_SU_Y_GRANULARITY;
+}
+
+/*
+ * Note: Bits related to granularity are same in panel replay and psr
+ * registers. Rely on PSR definitions on these "common" bits.
+ */
 static void intel_dp_get_su_granularity(struct intel_dp *intel_dp)
 {
 	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
@@ -473,18 +507,29 @@ static void intel_dp_get_su_granularity(struct intel_dp *intel_dp)
 	u16 w;
 	u8 y;
 
-	/* If sink don't have specific granularity requirements set legacy ones */
-	if (!(intel_dp->psr_dpcd[1] & DP_PSR2_SU_GRANULARITY_REQUIRED)) {
+	/*
+	 * TODO: Do we need to take into account panel supporting both PSR and
+	 * Panel replay?
+	 */
+
+	/*
+	 * If sink don't have specific granularity requirements set legacy
+	 * ones.
+	 */
+	if (!(intel_dp_get_su_capability(intel_dp) &
+	      DP_PSR2_SU_GRANULARITY_REQUIRED)) {
 		/* As PSR2 HW sends full lines, we do not care about x granularity */
 		w = 4;
 		y = 4;
 		goto exit;
 	}
 
-	r = drm_dp_dpcd_read(&intel_dp->aux, DP_PSR2_SU_X_GRANULARITY, &w, 2);
+	r = drm_dp_dpcd_read(&intel_dp->aux,
+			     intel_dp_get_su_x_granularity_offset(intel_dp),
+			     &w, 2);
 	if (r != 2)
 		drm_dbg_kms(&i915->drm,
-			    "Unable to read DP_PSR2_SU_X_GRANULARITY\n");
+			    "Unable to read selective update x granularity\n");
 	/*
 	 * Spec says that if the value read is 0 the default granularity should
 	 * be used instead.
@@ -492,10 +537,12 @@ static void intel_dp_get_su_granularity(struct intel_dp *intel_dp)
 	if (r != 2 || w == 0)
 		w = 4;
 
-	r = drm_dp_dpcd_read(&intel_dp->aux, DP_PSR2_SU_Y_GRANULARITY, &y, 1);
+	r = drm_dp_dpcd_read(&intel_dp->aux,
+			     intel_dp_get_su_y_granularity_offset(intel_dp),
+			     &y, 1);
 	if (r != 1) {
 		drm_dbg_kms(&i915->drm,
-			    "Unable to read DP_PSR2_SU_Y_GRANULARITY\n");
+			    "Unable to read selective update y granularity\n");
 		y = 4;
 	}
 	if (y == 0)
@@ -588,7 +635,8 @@ void intel_psr_init_dpcd(struct intel_dp *intel_dp)
 	if (intel_dp->psr_dpcd[0])
 		_psr_init_dpcd(intel_dp);
 
-	if (intel_dp->psr.sink_psr2_support)
+	if (intel_dp->psr.sink_psr2_support ||
+	    intel_dp->psr.sink_panel_replay_su_support)
 		intel_dp_get_su_granularity(intel_dp);
 }
 
-- 
2.34.1


  parent reply	other threads:[~2024-04-19 12:12 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 12:11 [PATCH v7 00/11] Panel replay selective update support Jouni Högander
2024-04-19 12:11 ` [PATCH v7 01/11] drm/i915/psr: Rename has_psr2 as has_sel_update Jouni Högander
2024-04-19 12:11 ` [PATCH v7 02/11] drm/i915/dp: Use always vsc revision 0x6 for Panel Replay Jouni Högander
2024-04-19 12:11 ` [PATCH v7 03/11] drm/i915/psr: Rename psr2_enabled as sel_update_enabled Jouni Högander
2024-04-19 12:11 ` [PATCH v7 04/11] drm/panelreplay: dpcd register definition for panelreplay SU Jouni Högander
2024-04-19 12:11 ` [PATCH v7 05/11] drm/i915/psr: Detect panel replay selective update support Jouni Högander
2024-04-19 12:11 ` Jouni Högander [this message]
2024-04-29 11:02   ` [PATCH v7 06/11] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay Manna, Animesh
2024-04-29 11:16     ` Hogander, Jouni
2024-04-29 11:34       ` Manna, Animesh
2024-04-29 11:45         ` Manna, Animesh
2024-04-29 11:46           ` Hogander, Jouni
2024-04-19 12:11 ` [PATCH v7 07/11] drm/i915/psr: Panel replay uses SRD_STATUS to track it's status Jouni Högander
2024-04-19 12:11 ` [PATCH v7 08/11] drm/i915/psr: Do not apply workarounds in case of panel replay Jouni Högander
2024-04-19 12:11 ` [PATCH v7 09/11] drm/i915/psr: Update PSR module parameter descriptions Jouni Högander
2024-04-19 12:11 ` [PATCH v7 10/11] drm/i915/psr: Split intel_psr2_config_valid for panel replay Jouni Högander
2024-04-19 12:11 ` [PATCH v7 11/11] drm/i915/psr: Add panel replay sel update support to debugfs interface Jouni Högander
2024-04-19 12:36 ` ✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support (rev7) Patchwork
2024-04-19 12:36 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-19 12:43 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-22  6:33 ` ✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support (rev8) Patchwork
2024-04-22  6:33 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-22  6:41 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-22  8:37 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240419121141.2665945-7-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox