From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Animesh Manna" <animesh.manna@intel.com>,
"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v7 07/11] drm/i915/psr: Panel replay uses SRD_STATUS to track it's status
Date: Fri, 19 Apr 2024 15:11:37 +0300 [thread overview]
Message-ID: <20240419121141.2665945-8-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240419121141.2665945-1-jouni.hogander@intel.com>
DP Panel replay uses SRD_STATUS to track it's status despite selective
update mode.
Bspec: 53370, 68920
v3:
- do not use PSR2_STATUS for PSR1
v2:
- use intel_dp_is_edp to differentiate
- modify debugfs status as well
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 29400fac13c2..7631aad5ee7a 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -2860,7 +2860,8 @@ void intel_psr_wait_for_idle_locked(const struct intel_crtc_state *new_crtc_stat
if (!intel_dp->psr.enabled)
continue;
- if (intel_dp->psr.sel_update_enabled)
+ if (intel_dp_is_edp(intel_dp) &&
+ intel_dp->psr.sel_update_enabled)
ret = _psr2_ready_for_pipe_update_locked(intel_dp);
else
ret = _psr1_ready_for_pipe_update_locked(intel_dp);
@@ -2881,7 +2882,8 @@ static bool __psr_wait_for_idle_locked(struct intel_dp *intel_dp)
if (!intel_dp->psr.enabled)
return false;
- if (intel_dp->psr.sel_update_enabled) {
+ if (!intel_dp->psr.panel_replay_enabled &&
+ intel_dp->psr.sel_update_enabled) {
reg = EDP_PSR2_STATUS(cpu_transcoder);
mask = EDP_PSR2_STATUS_STATE_MASK;
} else {
@@ -3500,7 +3502,7 @@ psr_source_status(struct intel_dp *intel_dp, struct seq_file *m)
const char *status = "unknown";
u32 val, status_val;
- if (intel_dp->psr.sel_update_enabled) {
+ if (intel_dp_is_edp(intel_dp) && intel_dp->psr.sel_update_enabled) {
static const char * const live_status[] = {
"IDLE",
"CAPTURE",
--
2.34.1
next prev parent reply other threads:[~2024-04-19 12:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 12:11 [PATCH v7 00/11] Panel replay selective update support Jouni Högander
2024-04-19 12:11 ` [PATCH v7 01/11] drm/i915/psr: Rename has_psr2 as has_sel_update Jouni Högander
2024-04-19 12:11 ` [PATCH v7 02/11] drm/i915/dp: Use always vsc revision 0x6 for Panel Replay Jouni Högander
2024-04-19 12:11 ` [PATCH v7 03/11] drm/i915/psr: Rename psr2_enabled as sel_update_enabled Jouni Högander
2024-04-19 12:11 ` [PATCH v7 04/11] drm/panelreplay: dpcd register definition for panelreplay SU Jouni Högander
2024-04-19 12:11 ` [PATCH v7 05/11] drm/i915/psr: Detect panel replay selective update support Jouni Högander
2024-04-19 12:11 ` [PATCH v7 06/11] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay Jouni Högander
2024-04-29 11:02 ` Manna, Animesh
2024-04-29 11:16 ` Hogander, Jouni
2024-04-29 11:34 ` Manna, Animesh
2024-04-29 11:45 ` Manna, Animesh
2024-04-29 11:46 ` Hogander, Jouni
2024-04-19 12:11 ` Jouni Högander [this message]
2024-04-19 12:11 ` [PATCH v7 08/11] drm/i915/psr: Do not apply workarounds in case of " Jouni Högander
2024-04-19 12:11 ` [PATCH v7 09/11] drm/i915/psr: Update PSR module parameter descriptions Jouni Högander
2024-04-19 12:11 ` [PATCH v7 10/11] drm/i915/psr: Split intel_psr2_config_valid for panel replay Jouni Högander
2024-04-19 12:11 ` [PATCH v7 11/11] drm/i915/psr: Add panel replay sel update support to debugfs interface Jouni Högander
2024-04-19 12:36 ` ✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support (rev7) Patchwork
2024-04-19 12:36 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-19 12:43 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-22 6:33 ` ✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support (rev8) Patchwork
2024-04-22 6:33 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-22 6:41 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-22 8:37 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419121141.2665945-8-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox