public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH v2 10/21] drm/i915/dp: Send a link training modeset-retry uevent to all MST connectors
Date: Mon, 20 May 2024 21:58:08 +0300	[thread overview]
Message-ID: <20240520185822.3725844-11-imre.deak@intel.com> (raw)
In-Reply-To: <20240520185822.3725844-1-imre.deak@intel.com>

Send a modeset-retry uevent to all connectors in the same MST topology
after a link training failure and reduction of the link parameters. This
matches the way the same uevent is sent after a DP tunnel BW allocation
failure.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c               | 2 +-
 drivers/gpu/drm/i915/display/intel_dp.h               | 1 -
 drivers/gpu/drm/i915/display/intel_dp_link_training.c | 9 +++++----
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 1f0b7cceea2dc..87f9f12814b93 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -2791,7 +2791,7 @@ intel_dp_audio_compute_config(struct intel_encoder *encoder,
 					intel_dp_is_uhbr(pipe_config);
 }
 
-void intel_dp_queue_modeset_retry_work(struct intel_connector *connector)
+static void intel_dp_queue_modeset_retry_work(struct intel_connector *connector)
 {
 	struct drm_i915_private *i915 = to_i915(connector->base.dev);
 
diff --git a/drivers/gpu/drm/i915/display/intel_dp.h b/drivers/gpu/drm/i915/display/intel_dp.h
index e7b47e7bcd98b..24777c035e2ad 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.h
+++ b/drivers/gpu/drm/i915/display/intel_dp.h
@@ -44,7 +44,6 @@ bool intel_dp_limited_color_range(const struct intel_crtc_state *crtc_state,
 				  const struct drm_connector_state *conn_state);
 int intel_dp_min_bpp(enum intel_output_format output_format);
 void intel_dp_init_modeset_retry_work(struct intel_connector *connector);
-void intel_dp_queue_modeset_retry_work(struct intel_connector *connector);
 void
 intel_dp_queue_modeset_retry_for_link(struct intel_atomic_state *state,
 				      struct intel_encoder *encoder,
diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
index 4f60daa97407d..97d499e4b6ef7 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
@@ -1187,10 +1187,11 @@ static int intel_dp_get_link_train_fallback_values(struct intel_dp *intel_dp,
 	return 0;
 }
 
-static void intel_dp_schedule_fallback_link_training(struct intel_dp *intel_dp,
+static void intel_dp_schedule_fallback_link_training(struct intel_atomic_state *state,
+						     struct intel_dp *intel_dp,
 						     const struct intel_crtc_state *crtc_state)
 {
-	struct intel_connector *intel_connector = intel_dp->attached_connector;
+	struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)->base;
 
 	if (!intel_digital_port_connected(&dp_to_dig_port(intel_dp)->base)) {
 		lt_dbg(intel_dp, DP_PHY_DPRX, "Link Training failed on disconnected sink.\n");
@@ -1206,7 +1207,7 @@ static void intel_dp_schedule_fallback_link_training(struct intel_dp *intel_dp,
 	}
 
 	/* Schedule a Hotplug Uevent to userspace to start modeset */
-	intel_dp_queue_modeset_retry_work(intel_connector);
+	intel_dp_queue_modeset_retry_for_link(state, encoder, crtc_state);
 }
 
 /* Perform the link training on all LTTPRs and the DPRX on a link. */
@@ -1517,7 +1518,7 @@ void intel_dp_start_link_train(struct intel_atomic_state *state,
 		return;
 	}
 
-	intel_dp_schedule_fallback_link_training(intel_dp, crtc_state);
+	intel_dp_schedule_fallback_link_training(state, intel_dp, crtc_state);
 }
 
 void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
-- 
2.43.3


  parent reply	other threads:[~2024-05-20 18:58 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20 18:57 [PATCH v2 00/21] drm/i915/dp_mst: Enable link training fallback Imre Deak
2024-05-20 18:57 ` [PATCH v2 01/21] drm/i915/dp_mst: Align TUs to avoid splitting symbols across MTPs Imre Deak
2024-05-22 18:22   ` Ville Syrjälä
2024-05-20 18:58 ` [PATCH v2 02/21] drm/i915/dp: Move link train params to a substruct in intel_dp Imre Deak
2024-05-20 18:58 ` [PATCH v2 03/21] drm/i915/dp: Move link train fallback to intel_dp_link_training.c Imre Deak
2024-05-22 18:23   ` Ville Syrjälä
2024-06-10 16:13     ` Manasi Navare
2024-05-20 18:58 ` [PATCH v2 04/21] drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values() Imre Deak
2024-05-22 18:23   ` Ville Syrjälä
2024-05-22 18:45     ` Imre Deak
2024-05-23 15:48     ` Jani Nikula
2024-05-20 18:58 ` [PATCH v2 05/21] drm/i915: Factor out function to modeset commit a set of pipes Imre Deak
2024-05-22 18:23   ` Ville Syrjälä
2024-05-20 18:58 ` [PATCH v2 06/21] drm/i915/dp: Use a commit modeset for link retraining MST links Imre Deak
2024-05-23 12:58   ` Ville Syrjälä
2024-05-23 13:26     ` Imre Deak
2024-05-20 18:58 ` [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset Imre Deak
2024-05-22 13:38   ` Imre Deak
2024-05-23 13:23     ` Ville Syrjälä
2024-05-23 13:27       ` Ville Syrjälä
2024-05-23 13:30   ` Ville Syrjälä
2024-05-23 13:46     ` Imre Deak
2024-05-23 13:58       ` Ville Syrjälä
2024-05-23 14:12         ` Imre Deak
2024-05-20 18:58 ` [PATCH v2 08/21] drm/i915/dp: Reduce link params only after retrying with unchanged params Imre Deak
2024-05-20 18:58 ` [PATCH v2 09/21] drm/i915/dp: Pass atomic state to link training function Imre Deak
2024-05-23 14:41   ` Ville Syrjälä
2024-05-23 14:47     ` Imre Deak
2024-05-23 14:54       ` Ville Syrjälä
2024-05-23 14:58         ` Imre Deak
2024-05-23 15:05         ` Ville Syrjälä
2024-05-20 18:58 ` Imre Deak [this message]
2024-05-20 18:58 ` [PATCH v2 11/21] drm/i915/dp: Use check link state work in the hotplug handler Imre Deak
2024-05-20 18:58 ` [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler Imre Deak
2024-05-23 15:08   ` Ville Syrjälä
2024-05-23 15:29     ` Imre Deak
2024-05-23 15:43       ` Ville Syrjälä
2024-05-23 15:54         ` Imre Deak
2024-05-27  5:14   ` gareth.yu
2024-05-27 11:30     ` Imre Deak
2024-05-28  5:33       ` Yu, Gareth
2024-05-20 18:58 ` [PATCH v2 13/21] drm/i915/dp: Use check link state work in the HPD IRQ handler Imre Deak
2024-05-20 18:58 ` [PATCH v2 14/21] drm/i915/dp: Disable link retraining after the last fallback step Imre Deak
2024-05-23 15:28   ` Ville Syrjälä
2024-05-23 16:36     ` Imre Deak
2024-05-20 18:58 ` [PATCH v2 15/21] drm/i915/dp_mst: Reset intel_dp->link_trained during disabling Imre Deak
2024-05-20 18:58 ` [PATCH v2 16/21] drm/i915/dp_mst: Enable link training fallback for MST Imre Deak
2024-05-20 18:58 ` [PATCH v2 17/21] drm/i915/dp: Add debugfs entries to set a target link rate/lane count Imre Deak
2024-05-23 15:25   ` Ville Syrjälä
2024-05-23 16:15     ` Imre Deak
2024-05-20 18:58 ` [PATCH v2 18/21] drm/i915/dp: Add debugfs entries to get the max " Imre Deak
2024-05-20 18:58 ` [PATCH v2 19/21] drm/i915/dp: Add debugfs entry to force link training failure Imre Deak
2024-05-23 15:29   ` Ville Syrjälä
2024-05-23 16:32     ` Imre Deak
2024-05-20 18:58 ` [PATCH v2 20/21] drm/i915/dp: Add debugfs entry to force link retrain Imre Deak
2024-05-20 18:58 ` [PATCH v2 21/21] drm/i915/dp: Add debugfs entry for link training info Imre Deak
2024-05-20 19:30 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp_mst: Enable link training fallback (rev3) Patchwork
2024-05-20 19:30 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-05-20 19:41 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-21  5:58 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-22  4:20 ` ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240520185822.3725844-11-imre.deak@intel.com \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox