Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 4/4] drm/i915/dsb: Use intel_color_uses_dsb()
Date: Fri, 31 May 2024 14:41:01 +0300	[thread overview]
Message-ID: <20240531114101.19994-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240531114101.19994-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Use intel_color_uses_dsb() instead of open coding it in
intel_vblank_evade_init(). Make the logic around DSB a bit
more isolated from the rest of the code.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_vblank.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
index eb80952b0cfd..789b2db4d95e 100644
--- a/drivers/gpu/drm/i915/display/intel_vblank.c
+++ b/drivers/gpu/drm/i915/display/intel_vblank.c
@@ -5,6 +5,7 @@
 
 #include "i915_drv.h"
 #include "i915_reg.h"
+#include "intel_color.h"
 #include "intel_crtc.h"
 #include "intel_de.h"
 #include "intel_display_types.h"
@@ -637,7 +638,8 @@ void intel_vblank_evade_init(const struct intel_crtc_state *old_crtc_state,
 	 * DSB execution waits for the transcoder's undelayed vblank,
 	 * hence we must kick off the commit before that.
 	 */
-	if (new_crtc_state->dsb || new_crtc_state->update_m_n || new_crtc_state->update_lrr)
+	if (intel_color_uses_dsb(new_crtc_state) ||
+	    new_crtc_state->update_m_n || new_crtc_state->update_lrr)
 		evade->min -= adjusted_mode->crtc_vblank_start - adjusted_mode->crtc_vdisplay;
 }
 
-- 
2.44.1


  parent reply	other threads:[~2024-05-31 11:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31 11:40 [PATCH 0/4] drm/i915/dsb: A bit of polish Ville Syrjala
2024-05-31 11:40 ` [PATCH 1/4] drm/i915/dsb: Polish the DSB ID enum Ville Syrjala
2024-06-06 18:57   ` Manna, Animesh
2024-05-31 11:40 ` [PATCH 2/4] drm/i915/dsb: Move DSB ID definition to the header Ville Syrjala
2024-06-06 18:56   ` Manna, Animesh
2024-05-31 11:41 ` [PATCH 3/4] drm/i915/dsb: Pass DSB engine ID to intel_dsb_prepare() Ville Syrjala
2024-06-06 18:56   ` Manna, Animesh
2024-05-31 11:41 ` Ville Syrjala [this message]
2024-06-06 18:56   ` [PATCH 4/4] drm/i915/dsb: Use intel_color_uses_dsb() Manna, Animesh
2024-05-31 12:13 ` [PATCH 0/4] drm/i915/dsb: A bit of polish Rodrigo Vivi
2024-05-31 12:33 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2024-05-31 12:50 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-01 14:46 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240531114101.19994-5-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox