From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Jani Nikula" <jani.nikula@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: [PATCH v3 00/21] drm/i915/dp_mst: Enable link training fallback
Date: Mon, 10 Jun 2024 19:49:12 +0300 [thread overview]
Message-ID: <20240610164933.2947366-1-imre.deak@intel.com> (raw)
This is v3 of [1], addressing the review comments and adding R-bs from
Ville, the main changes being:
- Add the link check work to intel_encoder and the corresponding helper
functions to a new intel_encoder.c file. (Patch 7)
- Add documentation/asserts on intel_atomic_state being valid for MST
vs. possibly NULL for SST links in the link training functions.
(Patch 9,10)
- Lock connection_mutex in the debugfs entries only for the required
intel_dp state. (Patch 17-21)
- Remove the link training info debugfs entry showing the link retrain,
link training failure counters and the retrain disabled state, add a
separate debugfs entry showing only the retrain disabled state.
(Patch 21)
[1] https://lore.kernel.org/all/20240520185822.3725844-1-imre.deak@intel.com
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Imre Deak (21):
drm/i915/dp_mst: Align TUs to avoid splitting symbols across MTPs
drm/i915/dp: Move link train params to a substruct in intel_dp
drm/i915/dp: Move link train fallback to intel_dp_link_training.c
drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values()
drm/i915: Factor out function to modeset commit a set of pipes
drm/i915/dp: Use a commit modeset for link retraining MST links
drm/i915/dp: Recheck link state after modeset
drm/i915/dp: Reduce link params only after retrying with unchanged
params
drm/i915/dp: Pass atomic state to link training function
drm/i915/dp: Send a link training modeset-retry uevent to all MST
connectors
drm/i915/dp: Use check link state work in the hotplug handler
drm/i915/dp: Use check link state work in the detect handler
drm/i915/dp: Use check link state work in the HPD IRQ handler
drm/i915/dp: Disable link retraining after the last fallback step
drm/i915/dp_mst: Reset intel_dp->link_trained during disabling
drm/i915/dp_mst: Enable link training fallback for MST
drm/i915/dp: Add debugfs entries to force the link rate/lane count
drm/i915/dp: Add debugfs entries to get the max link rate/lane count
drm/i915/dp: Add debugfs entry to force link training failure
drm/i915/dp: Add debugfs entry to force link retrain
drm/i915/dp: Add debugfs entry to get the link retrain disabled state
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/g4x_dp.c | 35 +-
drivers/gpu/drm/i915/display/intel_ddi.c | 67 +--
drivers/gpu/drm/i915/display/intel_display.c | 34 ++
drivers/gpu/drm/i915/display/intel_display.h | 3 +
.../drm/i915/display/intel_display_debugfs.c | 2 +
.../drm/i915/display/intel_display_types.h | 25 +-
drivers/gpu/drm/i915/display/intel_dp.c | 270 +++++----
drivers/gpu/drm/i915/display/intel_dp.h | 11 +-
.../drm/i915/display/intel_dp_link_training.c | 538 +++++++++++++++++-
.../drm/i915/display/intel_dp_link_training.h | 8 +-
drivers/gpu/drm/i915/display/intel_dp_mst.c | 30 +-
drivers/gpu/drm/i915/display/intel_encoder.c | 39 ++
drivers/gpu/drm/i915/display/intel_encoder.h | 16 +
drivers/gpu/drm/xe/Makefile | 1 +
15 files changed, 878 insertions(+), 202 deletions(-)
create mode 100644 drivers/gpu/drm/i915/display/intel_encoder.c
create mode 100644 drivers/gpu/drm/i915/display/intel_encoder.h
--
2.43.3
next reply other threads:[~2024-06-10 16:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 16:49 Imre Deak [this message]
2024-06-10 16:49 ` [PATCH v3 01/21] drm/i915/dp_mst: Align TUs to avoid splitting symbols across MTPs Imre Deak
2024-06-10 16:49 ` [PATCH v3 02/21] drm/i915/dp: Move link train params to a substruct in intel_dp Imre Deak
2024-06-10 16:49 ` [PATCH v3 03/21] drm/i915/dp: Move link train fallback to intel_dp_link_training.c Imre Deak
2024-06-10 16:49 ` [PATCH v3 04/21] drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values() Imre Deak
2024-06-10 16:49 ` [PATCH v3 05/21] drm/i915: Factor out function to modeset commit a set of pipes Imre Deak
2024-06-10 16:49 ` [PATCH v3 06/21] drm/i915/dp: Use a commit modeset for link retraining MST links Imre Deak
2024-06-10 16:49 ` [PATCH v3 07/21] drm/i915/dp: Recheck link state after modeset Imre Deak
2024-06-10 18:14 ` [PATCH v4 " Imre Deak
2024-06-10 16:49 ` [PATCH v3 08/21] drm/i915/dp: Reduce link params only after retrying with unchanged params Imre Deak
2024-06-10 16:49 ` [PATCH v3 09/21] drm/i915/dp: Pass atomic state to link training function Imre Deak
2024-06-10 16:49 ` [PATCH v3 10/21] drm/i915/dp: Send a link training modeset-retry uevent to all MST connectors Imre Deak
2024-06-10 16:49 ` [PATCH v3 11/21] drm/i915/dp: Use check link state work in the hotplug handler Imre Deak
2024-06-10 16:49 ` [PATCH v3 12/21] drm/i915/dp: Use check link state work in the detect handler Imre Deak
2024-06-10 16:49 ` [PATCH v3 13/21] drm/i915/dp: Use check link state work in the HPD IRQ handler Imre Deak
2024-06-10 16:49 ` [PATCH v3 14/21] drm/i915/dp: Disable link retraining after the last fallback step Imre Deak
2024-06-10 16:49 ` [PATCH v3 15/21] drm/i915/dp_mst: Reset intel_dp->link_trained during disabling Imre Deak
2024-06-10 16:49 ` [PATCH v3 16/21] drm/i915/dp_mst: Enable link training fallback for MST Imre Deak
2024-06-10 16:49 ` [PATCH v3 17/21] drm/i915/dp: Add debugfs entries to force the link rate/lane count Imre Deak
2024-06-10 16:49 ` [PATCH v3 18/21] drm/i915/dp: Add debugfs entries to get the max " Imre Deak
2024-06-10 16:49 ` [PATCH v3 19/21] drm/i915/dp: Add debugfs entry to force link training failure Imre Deak
2024-06-10 16:49 ` [PATCH v3 20/21] drm/i915/dp: Add debugfs entry to force link retrain Imre Deak
2024-06-10 16:49 ` [PATCH v3 21/21] drm/i915/dp: Add debugfs entry to get the link retrain disabled state Imre Deak
2024-06-10 17:43 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp_mst: Enable link training fallback (rev4) Patchwork
2024-06-10 17:43 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-06-10 17:51 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-06-10 19:29 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp_mst: Enable link training fallback (rev5) Patchwork
2024-06-10 19:30 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-06-10 19:39 ` ✓ Fi.CI.BAT: success " Patchwork
2024-06-11 7:15 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-06-13 19:40 ` Imre Deak
2024-06-12 12:29 ` [PATCH v3 00/21] drm/i915/dp_mst: Enable link training fallback Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610164933.2947366-1-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox