Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	airlied@gmail.com, daniel@ffwll.ch
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Tvrtko Ursulin <tursulin@ursulin.net>
Subject: [PATCH 2/9] drm/i915: Use backlight power constants
Date: Wed, 31 Jul 2024 14:17:14 +0200	[thread overview]
Message-ID: <20240731122311.1143153-3-tzimmermann@suse.de> (raw)
In-Reply-To: <20240731122311.1143153-1-tzimmermann@suse.de>

Replace FB_BLANK_ constants with their counterparts from the
backlight subsystem. The values are identical, so there's no
change in functionality or semantics.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tursulin@ursulin.net>
---
 drivers/gpu/drm/i915/display/intel_backlight.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c
index 071668bfe5d1..6f678c039ed8 100644
--- a/drivers/gpu/drm/i915/display/intel_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_backlight.c
@@ -455,7 +455,7 @@ void intel_backlight_disable(const struct drm_connector_state *old_conn_state)
 	mutex_lock(&i915->display.backlight.lock);
 
 	if (panel->backlight.device)
-		panel->backlight.device->props.power = FB_BLANK_POWERDOWN;
+		panel->backlight.device->props.power = BACKLIGHT_POWER_OFF;
 	panel->backlight.enabled = false;
 	panel->backlight.funcs->disable(old_conn_state, 0);
 
@@ -773,7 +773,7 @@ static void __intel_backlight_enable(const struct intel_crtc_state *crtc_state,
 	panel->backlight.funcs->enable(crtc_state, conn_state, panel->backlight.level);
 	panel->backlight.enabled = true;
 	if (panel->backlight.device)
-		panel->backlight.device->props.power = FB_BLANK_UNBLANK;
+		panel->backlight.device->props.power = BACKLIGHT_POWER_ON;
 }
 
 void intel_backlight_enable(const struct intel_crtc_state *crtc_state,
@@ -870,12 +870,12 @@ static int intel_backlight_device_update_status(struct backlight_device *bd)
 	 */
 	if (panel->backlight.enabled) {
 		if (panel->backlight.power) {
-			bool enable = bd->props.power == FB_BLANK_UNBLANK &&
+			bool enable = bd->props.power == BACKLIGHT_POWER_ON &&
 				bd->props.brightness != 0;
 			panel->backlight.power(connector, enable);
 		}
 	} else {
-		bd->props.power = FB_BLANK_POWERDOWN;
+		bd->props.power = BACKLIGHT_POWER_OFF;
 	}
 
 	drm_modeset_unlock(&i915->drm.mode_config.connection_mutex);
@@ -945,9 +945,9 @@ int intel_backlight_device_register(struct intel_connector *connector)
 					    props.max_brightness);
 
 	if (panel->backlight.enabled)
-		props.power = FB_BLANK_UNBLANK;
+		props.power = BACKLIGHT_POWER_ON;
 	else
-		props.power = FB_BLANK_POWERDOWN;
+		props.power = BACKLIGHT_POWER_OFF;
 
 	name = kstrdup_const("intel_backlight", GFP_KERNEL);
 	if (!name)
-- 
2.45.2


  parent reply	other threads:[~2024-07-31 12:23 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31 12:17 [PATCH 0/9] drm: Use backlight power constants Thomas Zimmermann
2024-07-31 12:17 ` [PATCH 1/9] drm/amdgpu: " Thomas Zimmermann
2024-08-05 19:00   ` Deucher, Alexander
2024-08-06  7:06     ` Thomas Zimmermann
2024-08-07 19:47       ` Alex Deucher
2024-08-08  5:19         ` Thomas Zimmermann
2024-08-08 13:19           ` Alex Deucher
2024-07-31 12:17 ` Thomas Zimmermann [this message]
2024-07-31 12:56   ` [PATCH 2/9] drm/i915: " Jani Nikula
2024-07-31 13:00     ` Thomas Zimmermann
2024-08-01 11:52       ` Jani Nikula
2024-07-31 12:17 ` [PATCH 3/9] drm/panel: panel-novatak-nt35510: " Thomas Zimmermann
2024-08-01 22:37   ` Jessica Zhang
2024-08-23 15:40   ` Linus Walleij
2024-07-31 12:17 ` [PATCH 4/9] drm/panel: panel-orisetech-otm8009a: " Thomas Zimmermann
2024-08-01 22:41   ` Jessica Zhang
2024-07-31 12:17 ` [PATCH 5/9] drm/panel: panel-samsung-s6e63j0x03: " Thomas Zimmermann
2024-08-01 22:41   ` Jessica Zhang
2024-07-31 12:17 ` [PATCH 6/9] drm/panel: panel-samsung-s6e3ha2: " Thomas Zimmermann
2024-08-01 22:46   ` Jessica Zhang
2024-07-31 12:17 ` [PATCH 7/9] drm/panel: panel-sony-acx565akm: " Thomas Zimmermann
2024-08-01 22:46   ` Jessica Zhang
2024-07-31 12:17 ` [PATCH 8/9] drm/radeon: " Thomas Zimmermann
2024-07-31 12:17 ` [PATCH 9/9] drm/tilcdc: " Thomas Zimmermann
2024-08-15  7:59   ` Thomas Zimmermann
2024-08-15  8:07     ` Tomi Valkeinen
2024-08-15  8:08       ` Thomas Zimmermann
2024-07-31 13:02 ` ✗ Fi.CI.SPARSE: warning for drm: " Patchwork
2024-07-31 13:11 ` ✓ Fi.CI.BAT: success " Patchwork
2024-08-01  5:24 ` ✓ Fi.CI.IGT: " Patchwork
2024-08-02  7:00 ` [PATCH 9/9] drm/tilcdc: " jyri.sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240731122311.1143153-3-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox