Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/gem: Remove unnecessary cast
@ 2024-08-14 17:59 Andi Shyti
  2024-08-14 18:51 ` ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Andi Shyti @ 2024-08-14 17:59 UTC (permalink / raw)
  To: intel-gfx, dri-devel; +Cc: Krzysztof Niemiec, Chris Wilson, Andi Shyti

The cast from "long" to "unsigned long" is unnecessary. Remove
it.

In this case, the variables "start" and "end" are of type long
because they need to account for the possibility of negative
values. However, they are subsequently moved to "unsigned long"
since addresses are typically handled as unsigned values.

Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_mman.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index e9b2424156f0..80528ba90a56 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -323,8 +323,8 @@ static void set_address_limits(struct vm_area_struct *area,
 	end = min_t(long, end, vm_end);
 
 	/* Let's move back into the "<< PAGE_SHIFT" domain */
-	*start_vaddr = (unsigned long)start << PAGE_SHIFT;
-	*end_vaddr = (unsigned long)end << PAGE_SHIFT;
+	*start_vaddr = start << PAGE_SHIFT;
+	*end_vaddr = end << PAGE_SHIFT;
 
 	*pfn = (gmadr_start + i915_ggtt_offset(vma)) >> PAGE_SHIFT;
 	*pfn += (*start_vaddr - area->vm_start) >> PAGE_SHIFT;
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-08-23 13:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-14 17:59 [PATCH] drm/i915/gem: Remove unnecessary cast Andi Shyti
2024-08-14 18:51 ` ✗ Fi.CI.BAT: failure for " Patchwork
2024-08-14 21:41 ` ✓ Fi.CI.BAT: success for drm/i915/gem: Remove unnecessary cast (rev2) Patchwork
2024-08-15 18:58 ` [PATCH] drm/i915/gem: Remove unnecessary cast Rodrigo Vivi
2024-08-16  8:20   ` Andi Shyti
2024-08-23 13:37     ` Rodrigo Vivi
2024-08-16  5:15 ` ✗ Fi.CI.IGT: failure for drm/i915/gem: Remove unnecessary cast (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox