From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@linux.intel.com, ville.syrjala@linux.intel.com,
mitulkumar.ajitkumar.golani@intel.com
Subject: [PATCH 03/13] drm/i915/display: Add member fixed_rr to denote Fixed refresh rate with VRRTG
Date: Mon, 2 Sep 2024 13:36:24 +0530 [thread overview]
Message-ID: <20240902080635.2946858-4-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20240902080635.2946858-1-ankit.k.nautiyal@intel.com>
Add fixed_rr member to struct vrr to represent the case where a
fixed refresh rate with VRR timing generator is required.
v2: Move get_config change where vrr.fixed is actually set. (Mitul)
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 4 +++-
drivers/gpu/drm/i915/display/intel_display_types.h | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 78ce402a5cd0..8b437e79c8df 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -1005,7 +1005,8 @@ static bool vrr_params_changed(const struct intel_crtc_state *old_crtc_state,
old_crtc_state->vrr.vmin != new_crtc_state->vrr.vmin ||
old_crtc_state->vrr.vmax != new_crtc_state->vrr.vmax ||
old_crtc_state->vrr.guardband != new_crtc_state->vrr.guardband ||
- old_crtc_state->vrr.pipeline_full != new_crtc_state->vrr.pipeline_full;
+ old_crtc_state->vrr.pipeline_full != new_crtc_state->vrr.pipeline_full ||
+ old_crtc_state->vrr.fixed_rr != new_crtc_state->vrr.fixed_rr;
}
static bool cmrr_params_changed(const struct intel_crtc_state *old_crtc_state,
@@ -5480,6 +5481,7 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
if (!fastset) {
PIPE_CONF_CHECK_BOOL(vrr.enable);
+ PIPE_CONF_CHECK_BOOL(vrr.fixed_rr);
PIPE_CONF_CHECK_I(vrr.vmin);
PIPE_CONF_CHECK_I(vrr.vmax);
PIPE_CONF_CHECK_I(vrr.flipline);
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 868ff8976ed9..62a796f61d20 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1407,7 +1407,7 @@ struct intel_crtc_state {
/* Variable Refresh Rate state */
struct {
- bool enable, in_range;
+ bool enable, in_range, fixed_rr;
u8 pipeline_full;
u16 flipline, vmin, vmax, guardband;
u32 vsync_end, vsync_start;
--
2.45.2
next prev parent reply other threads:[~2024-09-02 8:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 8:06 [PATCH 00/13] Use VRR timing generator for fixed refresh rate modes Ankit Nautiyal
2024-09-02 8:06 ` [PATCH 01/13] drm/i915/dp: Avoid vrr compute config for HDMI sink Ankit Nautiyal
2024-09-02 8:06 ` [PATCH 02/13] drm/i915/dp: fix the Adaptive sync Operation mode for SDP Ankit Nautiyal
2024-09-02 8:06 ` Ankit Nautiyal [this message]
2024-09-03 12:51 ` [PATCH 03/13] drm/i915/display: Add member fixed_rr to denote Fixed refresh rate with VRRTG Ville Syrjälä
2024-09-04 12:54 ` Nautiyal, Ankit K
2024-09-02 8:06 ` [PATCH 04/13] drm/i915/display: Enable MSA Ignore Timing PAR only when in not fixed_rr mode Ankit Nautiyal
2024-09-03 3:15 ` kernel test robot
2024-09-03 7:52 ` kernel test robot
2024-09-02 8:06 ` [PATCH 05/13] drm/i915/dp: Set FAVT mode in DP SDP with fixed refresh rate Ankit Nautiyal
2024-09-02 8:06 ` [PATCH 06/13] drm/i915/vrr: Compute vrr vsync if platforms support it Ankit Nautiyal
2024-09-03 12:45 ` Ville Syrjälä
2024-09-04 12:55 ` Nautiyal, Ankit K
2024-09-02 8:06 ` [PATCH 07/13] drm/i915/hdmi: Use VRR Timing generator for HDMI Ankit Nautiyal
2024-09-02 8:06 ` [PATCH 08/13] drm/i915/display: Disable PSR before disabling VRR Ankit Nautiyal
2024-09-02 8:06 ` [PATCH 09/13] drm/i915/psr: Allow PSR for fixed refrsh rate with VRR TG Ankit Nautiyal
2024-09-02 8:06 ` [PATCH 10/13] drm/i915/vrr: Avoid sending PUSH when VRR TG is used with Fixed refresh rate Ankit Nautiyal
2024-09-03 13:02 ` Ville Syrjälä
2024-09-04 12:57 ` Nautiyal, Ankit K
2024-09-02 8:06 ` [PATCH 11/13] drm/i915/vrr: Handle joiner with vrr Ankit Nautiyal
2024-09-03 13:04 ` Ville Syrjälä
2024-09-04 13:02 ` Nautiyal, Ankit K
2024-09-02 8:06 ` [PATCH 12/13] drm/i915/vrr: Always use VRR timing generator for XELPD+ Ankit Nautiyal
2024-09-03 13:25 ` Ville Syrjälä
2024-09-04 13:08 ` Nautiyal, Ankit K
2024-09-02 8:06 ` [PATCH 13/13] drm/i915/display: Add fixed_rr to crtc_state_dump Ankit Nautiyal
2024-09-02 12:23 ` ✗ Fi.CI.SPARSE: warning for Use VRR timing generator for fixed refresh rate modes (rev5) Patchwork
2024-09-02 12:43 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-02 18:08 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240902080635.2946858-4-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=mitulkumar.ajitkumar.golani@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox