Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: simona@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com,
	javierm@redhat.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: [PATCH v4 04/80] drm: Add client-agnostic setup helper
Date: Mon,  9 Sep 2024 13:30:10 +0200	[thread overview]
Message-ID: <20240909113633.595465-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20240909113633.595465-1-tzimmermann@suse.de>

DRM may support multiple in-kernel clients that run as soon as a DRM
driver has been registered. To select the client(s) in a single place,
introduce drm_client_setup().

Drivers that call the new helper automatically instantiate the kernel's
configured default clients. Only fbdev emulation is currently supported.
Later versions can add support for DRM-based logging, a boot logo or even
a console.

Some drivers handle the color mode for clients internally. Provide the
helper drm_client_setup_with_color_mode() for them.

v4:
- fix docs for drm_client_setup_with_fourcc() (Geert)
v3:
- fix build error
v2:
- add drm_client_setup_with_fourcc() (Laurent)
- push default-format handling into actual clients

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/gpu/drm/Makefile           |  1 +
 drivers/gpu/drm/drm_client_setup.c | 66 ++++++++++++++++++++++++++++++
 include/drm/drm_client_setup.h     | 15 +++++++
 3 files changed, 82 insertions(+)
 create mode 100644 drivers/gpu/drm/drm_client_setup.c
 create mode 100644 include/drm/drm_client_setup.h

diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index d7a684ae6a59..c08f639f9550 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -129,6 +129,7 @@ obj-$(CONFIG_DRM_TTM_HELPER) += drm_ttm_helper.o
 drm_kms_helper-y := \
 	drm_atomic_helper.o \
 	drm_atomic_state_helper.o \
+	drm_client_setup.o \
 	drm_crtc_helper.o \
 	drm_damage_helper.o \
 	drm_encoder_slave.o \
diff --git a/drivers/gpu/drm/drm_client_setup.c b/drivers/gpu/drm/drm_client_setup.c
new file mode 100644
index 000000000000..5969c4ffe31b
--- /dev/null
+++ b/drivers/gpu/drm/drm_client_setup.c
@@ -0,0 +1,66 @@
+// SPDX-License-Identifier: MIT
+
+#include <drm/drm_client_setup.h>
+#include <drm/drm_device.h>
+#include <drm/drm_fbdev_client.h>
+#include <drm/drm_fourcc.h>
+#include <drm/drm_print.h>
+
+/**
+ * drm_client_setup() - Setup in-kernel DRM clients
+ * @dev: DRM device
+ * @format: Preferred pixel format for the device. Use NULL, unless
+ *          there is clearly a driver-preferred format.
+ *
+ * This function sets up the in-kernel DRM clients. Restore, hotplug
+ * events and teardown are all taken care of.
+ *
+ * Drivers should call drm_client_setup() after registering the new
+ * DRM device with drm_dev_register(). This function is safe to call
+ * even when there are no connectors present. Setup will be retried
+ * on the next hotplug event.
+ *
+ * The clients are destroyed by drm_dev_unregister().
+ */
+void drm_client_setup(struct drm_device *dev, const struct drm_format_info *format)
+{
+	int ret;
+
+	ret = drm_fbdev_client_setup(dev, format);
+	if (ret)
+		drm_warn(dev, "Failed to set up DRM client; error %d\n", ret);
+}
+EXPORT_SYMBOL(drm_client_setup);
+
+/**
+ * drm_client_setup_with_fourcc() - Setup in-kernel DRM clients for color mode
+ * @dev: DRM device
+ * @fourcc: Preferred pixel format as 4CC code for the device
+ *
+ * This function sets up the in-kernel DRM clients. It is equivalent
+ * to drm_client_setup(), but expects a 4CC code as second argument.
+ */
+void drm_client_setup_with_fourcc(struct drm_device *dev, u32 fourcc)
+{
+	drm_client_setup(dev, drm_format_info(fourcc));
+}
+EXPORT_SYMBOL(drm_client_setup_with_fourcc);
+
+/**
+ * drm_client_setup_with_color_mode() - Setup in-kernel DRM clients for color mode
+ * @dev: DRM device
+ * @color_mode: Preferred color mode for the device
+ *
+ * This function sets up the in-kernel DRM clients. It is equivalent
+ * to drm_client_setup(), but expects a color mode as second argument.
+ *
+ * Do not use this function in new drivers. Prefer drm_client_setup() with a
+ * format of NULL.
+ */
+void drm_client_setup_with_color_mode(struct drm_device *dev, unsigned int color_mode)
+{
+	u32 fourcc = drm_driver_color_mode_format(dev, color_mode);
+
+	drm_client_setup_with_fourcc(dev, fourcc);
+}
+EXPORT_SYMBOL(drm_client_setup_with_color_mode);
diff --git a/include/drm/drm_client_setup.h b/include/drm/drm_client_setup.h
new file mode 100644
index 000000000000..6c0396b4f815
--- /dev/null
+++ b/include/drm/drm_client_setup.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: MIT */
+
+#ifndef DRM_CLIENT_SETUP_H
+#define DRM_CLIENT_SETUP_H
+
+#include <linux/types.h>
+
+struct drm_device;
+struct drm_format_info;
+
+void drm_client_setup(struct drm_device *dev, const struct drm_format_info *format);
+void drm_client_setup_with_fourcc(struct drm_device *dev, u32 fourcc);
+void drm_client_setup_with_color_mode(struct drm_device *dev, unsigned int color_mode);
+
+#endif
-- 
2.46.0


  parent reply	other threads:[~2024-09-09 11:37 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09 11:30 [PATCH v4 00/80] drm: Provide client setup helper and convert drivers Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 01/80] drm/fbdev-helper: Move color-mode lookup into 4CC format helper Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 02/80] drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 03/80] drm/fbdev: Add memory-agnostic fbdev client Thomas Zimmermann
2024-09-09 11:30 ` Thomas Zimmermann [this message]
2024-09-09 11:30 ` [PATCH v4 05/80] drm/fbdev-dma: Support struct drm_driver.fbdev_probe Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 06/80] drm/arcgpu: Run DRM default client setup Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 07/80] drm/arm/komeda: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 08/80] drm/arm/hdlcd: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 09/80] drm/arm/malidp: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 10/80] drm/aspeed: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 11/80] drm/atmel-hdlcd: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 12/80] drm/fsl-dcu: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 13/80] drm/hisilicon/kirin: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 14/80] drm/hx8357d: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 15/80] drm/ili9163: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 16/80] drm/ili9225: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 17/80] drm/ili9341: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 18/80] drm/ili9486: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 19/80] drm/imx/dcss: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 20/80] drm/imx/ipuv3: " Thomas Zimmermann
2024-09-10  8:30   ` Philipp Zabel
2024-09-09 11:30 ` [PATCH v4 21/80] drm/imx/lcdc: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 22/80] drm/ingenic: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 23/80] drm/kmb: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 24/80] drm/logicvc: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 25/80] drm/mcde: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 26/80] drm/mediatek: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 27/80] drm/meson: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 28/80] drm/mi0283qt: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 29/80] drm/mxsfb/lcdif: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 30/80] drm/mxsfb: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 31/80] drm/panel-mipi-dbi: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 32/80] drm/pl111: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 33/80] drm/renesas/rcar-du: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 34/80] drm/renesas/rz-du: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 35/80] drm/renesas/shmobile: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 36/80] drm/repaper: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 37/80] drm/rockchip: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 38/80] drm/sti: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 39/80] drm/stm: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 40/80] drm/sun4i: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 41/80] drm/tidss: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 42/80] drm/tilcdc: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 43/80] drm/st7586: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 44/80] drm/st7735r: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 45/80] drm/tve200: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 46/80] drm/vc4: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 47/80] drm/xlnx: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 48/80] drm/fbdev-dma: Remove obsolete setup function Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 49/80] drm/fbdev-shmem: Support struct drm_driver.fbdev_probe Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 50/80] drm/ast: Run DRM default client setup Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 51/80] drm/bochs: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 52/80] drm/cirrus: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 53/80] drm/gm12u320: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 54/80] drm/gud: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 55/80] drm/hyperv_drm: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 56/80] drm/mgag200: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 57/80] drm/ofdrm: Use " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 58/80] drm/simpledrm: Run " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 59/80] drm/solomon: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 60/80] drm/udl: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 61/80] drm/virtgpu: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 62/80] drm/vkms: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 63/80] drm/fbdev-shmem: Remove obsolete setup function Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 64/80] drm/fbdev-ttm: Support struct drm_driver.fbdev_probe Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 65/80] drm/amdgpu: Run DRM default client setup Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 66/80] drm/hisilicon/hibmc: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 67/80] drm/loongson: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 68/80] drm/nouveau: " Thomas Zimmermann
2024-09-12 18:04   ` Lyude Paul
2024-09-13  6:23     ` Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 69/80] drm/qxl: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 70/80] drm/vboxvideo: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 71/80] drm/vmwgfx: " Thomas Zimmermann
2024-09-09 17:52   ` Zack Rusin
2024-09-13  6:28     ` Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 72/80] drm/fbdev-ttm: Remove obsolete setup function Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 73/80] drm/armada: Run DRM default client setup Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 74/80] drm/exynos-drm: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 75/80] drm/gma500: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 76/80] drm/msm: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 77/80] drm/radeon: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 78/80] drm/tegra: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 79/80] drm/omapdrm: Remove struct drm_fb_helper from struct omap_fbdev Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 80/80] drm/omapdrm: Run DRM default client setup Thomas Zimmermann
2024-09-09 15:43 ` ✗ Fi.CI.CHECKPATCH: warning for drm: Provide client setup helper and convert drivers (rev4) Patchwork
2024-09-09 15:43 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-09-09 16:06 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-10 19:52 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240909113633.595465-5-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=jfalempe@redhat.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox