Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: simona@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com,
	javierm@redhat.com
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Xinhui Pan" <Xinhui.Pan@amd.com>,
	"Hamza Mahfooz" <hamza.mahfooz@amd.com>
Subject: [PATCH v4 65/80] drm/amdgpu: Run DRM default client setup
Date: Mon,  9 Sep 2024 13:31:11 +0200	[thread overview]
Message-ID: <20240909113633.595465-66-tzimmermann@suse.de> (raw)
In-Reply-To: <20240909113633.595465-1-tzimmermann@suse.de>

Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbdev_probe in struct drm_driver, so that the client
setup can start the common fbdev client.

The amdgpu driver specifies a preferred color mode depending on
the available video memory, with a default of 32. Adapt this for
the new client interface.

v2:
- style changes

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Xinhui Pan <Xinhui.Pan@amd.com>
Tested-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Acked-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 5dd39e6c6223..849d59e2bca7 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -23,6 +23,7 @@
  */
 
 #include <drm/amdgpu_drm.h>
+#include <drm/drm_client_setup.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_fbdev_ttm.h>
 #include <drm/drm_gem.h>
@@ -2341,11 +2342,15 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
 	 */
 	if (adev->mode_info.mode_config_initialized &&
 	    !list_empty(&adev_to_drm(adev)->mode_config.connector_list)) {
+		const struct drm_format_info *format;
+
 		/* select 8 bpp console on low vram cards */
 		if (adev->gmc.real_vram_size <= (32*1024*1024))
-			drm_fbdev_ttm_setup(adev_to_drm(adev), 8);
+			format = drm_format_info(DRM_FORMAT_C8);
 		else
-			drm_fbdev_ttm_setup(adev_to_drm(adev), 32);
+			format = NULL;
+
+		drm_client_setup(adev_to_drm(adev), format);
 	}
 
 	ret = amdgpu_debugfs_init(adev);
@@ -2957,6 +2962,7 @@ static const struct drm_driver amdgpu_kms_driver = {
 	.num_ioctls = ARRAY_SIZE(amdgpu_ioctls_kms),
 	.dumb_create = amdgpu_mode_dumb_create,
 	.dumb_map_offset = amdgpu_mode_dumb_mmap,
+	DRM_FBDEV_TTM_DRIVER_OPS,
 	.fops = &amdgpu_driver_kms_fops,
 	.release = &amdgpu_driver_release_kms,
 #ifdef CONFIG_PROC_FS
@@ -2983,6 +2989,7 @@ const struct drm_driver amdgpu_partition_driver = {
 	.num_ioctls = ARRAY_SIZE(amdgpu_ioctls_kms),
 	.dumb_create = amdgpu_mode_dumb_create,
 	.dumb_map_offset = amdgpu_mode_dumb_mmap,
+	DRM_FBDEV_TTM_DRIVER_OPS,
 	.fops = &amdgpu_driver_kms_fops,
 	.release = &amdgpu_driver_release_kms,
 
-- 
2.46.0


  parent reply	other threads:[~2024-09-09 11:39 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09 11:30 [PATCH v4 00/80] drm: Provide client setup helper and convert drivers Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 01/80] drm/fbdev-helper: Move color-mode lookup into 4CC format helper Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 02/80] drm/fbdev-helper: Set and clear VGA switcheroo client from fb_info Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 03/80] drm/fbdev: Add memory-agnostic fbdev client Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 04/80] drm: Add client-agnostic setup helper Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 05/80] drm/fbdev-dma: Support struct drm_driver.fbdev_probe Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 06/80] drm/arcgpu: Run DRM default client setup Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 07/80] drm/arm/komeda: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 08/80] drm/arm/hdlcd: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 09/80] drm/arm/malidp: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 10/80] drm/aspeed: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 11/80] drm/atmel-hdlcd: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 12/80] drm/fsl-dcu: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 13/80] drm/hisilicon/kirin: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 14/80] drm/hx8357d: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 15/80] drm/ili9163: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 16/80] drm/ili9225: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 17/80] drm/ili9341: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 18/80] drm/ili9486: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 19/80] drm/imx/dcss: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 20/80] drm/imx/ipuv3: " Thomas Zimmermann
2024-09-10  8:30   ` Philipp Zabel
2024-09-09 11:30 ` [PATCH v4 21/80] drm/imx/lcdc: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 22/80] drm/ingenic: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 23/80] drm/kmb: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 24/80] drm/logicvc: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 25/80] drm/mcde: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 26/80] drm/mediatek: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 27/80] drm/meson: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 28/80] drm/mi0283qt: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 29/80] drm/mxsfb/lcdif: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 30/80] drm/mxsfb: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 31/80] drm/panel-mipi-dbi: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 32/80] drm/pl111: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 33/80] drm/renesas/rcar-du: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 34/80] drm/renesas/rz-du: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 35/80] drm/renesas/shmobile: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 36/80] drm/repaper: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 37/80] drm/rockchip: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 38/80] drm/sti: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 39/80] drm/stm: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 40/80] drm/sun4i: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 41/80] drm/tidss: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 42/80] drm/tilcdc: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 43/80] drm/st7586: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 44/80] drm/st7735r: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 45/80] drm/tve200: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 46/80] drm/vc4: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 47/80] drm/xlnx: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 48/80] drm/fbdev-dma: Remove obsolete setup function Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 49/80] drm/fbdev-shmem: Support struct drm_driver.fbdev_probe Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 50/80] drm/ast: Run DRM default client setup Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 51/80] drm/bochs: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 52/80] drm/cirrus: " Thomas Zimmermann
2024-09-09 11:30 ` [PATCH v4 53/80] drm/gm12u320: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 54/80] drm/gud: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 55/80] drm/hyperv_drm: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 56/80] drm/mgag200: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 57/80] drm/ofdrm: Use " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 58/80] drm/simpledrm: Run " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 59/80] drm/solomon: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 60/80] drm/udl: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 61/80] drm/virtgpu: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 62/80] drm/vkms: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 63/80] drm/fbdev-shmem: Remove obsolete setup function Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 64/80] drm/fbdev-ttm: Support struct drm_driver.fbdev_probe Thomas Zimmermann
2024-09-09 11:31 ` Thomas Zimmermann [this message]
2024-09-09 11:31 ` [PATCH v4 66/80] drm/hisilicon/hibmc: Run DRM default client setup Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 67/80] drm/loongson: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 68/80] drm/nouveau: " Thomas Zimmermann
2024-09-12 18:04   ` Lyude Paul
2024-09-13  6:23     ` Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 69/80] drm/qxl: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 70/80] drm/vboxvideo: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 71/80] drm/vmwgfx: " Thomas Zimmermann
2024-09-09 17:52   ` Zack Rusin
2024-09-13  6:28     ` Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 72/80] drm/fbdev-ttm: Remove obsolete setup function Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 73/80] drm/armada: Run DRM default client setup Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 74/80] drm/exynos-drm: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 75/80] drm/gma500: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 76/80] drm/msm: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 77/80] drm/radeon: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 78/80] drm/tegra: " Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 79/80] drm/omapdrm: Remove struct drm_fb_helper from struct omap_fbdev Thomas Zimmermann
2024-09-09 11:31 ` [PATCH v4 80/80] drm/omapdrm: Run DRM default client setup Thomas Zimmermann
2024-09-09 15:43 ` ✗ Fi.CI.CHECKPATCH: warning for drm: Provide client setup helper and convert drivers (rev4) Patchwork
2024-09-09 15:43 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-09-09 16:06 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-10 19:52 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240909113633.595465-66-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamza.mahfooz@amd.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=jfalempe@redhat.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox