From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Brian Norris <briannorris@chromium.org>,
dri-devel@lists.freedesktop.org, Borislav Petkov <bp@alien8.de>,
Julius Werner <jwerner@chromium.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
chrome-platform@lists.linux.dev, intel-gfx@lists.freedesktop.org,
Hugues Bruant <hugues.bruant@gmail.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Alex Deucher <alexander.deucher@amd.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Helge Deller <deller@gmx.de>, Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH v4 1/2] firmware: sysfb: Add a sysfb_handles_screen_info() helper function
Date: Mon, 16 Sep 2024 13:00:25 +0200 [thread overview]
Message-ID: <20240916110040.1688511-2-javierm@redhat.com> (raw)
In-Reply-To: <20240916110040.1688511-1-javierm@redhat.com>
That can be used by drivers to check if the Generic System Framebuffers
(sysfb) support can handle the data contained in the global screen_info.
Drivers might need this information to know if have to setup the system
framebuffer, or if they have to delegate this action to sysfb instead.
Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
Changes in v4:
- New patch to add sysfb_handles_screen_info() helper (Thomas Zimmermann).
drivers/firmware/sysfb.c | 19 +++++++++++++++++++
include/linux/sysfb.h | 7 +++++++
2 files changed, 26 insertions(+)
diff --git a/drivers/firmware/sysfb.c b/drivers/firmware/sysfb.c
index 02a07d3d0d40..770e74be14f3 100644
--- a/drivers/firmware/sysfb.c
+++ b/drivers/firmware/sysfb.c
@@ -77,6 +77,25 @@ void sysfb_disable(struct device *dev)
}
EXPORT_SYMBOL_GPL(sysfb_disable);
+/**
+ * sysfb_handles_screen_info() - reports if sysfb handles the global screen_info
+ *
+ * Callers can use sysfb_handles_screen_info() to determine whether the Generic
+ * System Framebuffers (sysfb) can handle the global screen_info data structure
+ * or not. Drivers might need this information to know if they have to setup the
+ * system framebuffer, or if they have to delegate this action to sysfb instead.
+ *
+ * Returns:
+ * True if sysfb handles the global screen_info data structure.
+ */
+bool sysfb_handles_screen_info(void)
+{
+ const struct screen_info *si = &screen_info;
+
+ return !!screen_info_video_type(si);
+}
+EXPORT_SYMBOL_GPL(sysfb_handles_screen_info);
+
#if defined(CONFIG_PCI)
static bool sysfb_pci_dev_is_enabled(struct pci_dev *pdev)
{
diff --git a/include/linux/sysfb.h b/include/linux/sysfb.h
index bef5f06a91de..07cbab516942 100644
--- a/include/linux/sysfb.h
+++ b/include/linux/sysfb.h
@@ -60,12 +60,19 @@ struct efifb_dmi_info {
void sysfb_disable(struct device *dev);
+bool sysfb_handles_screen_info(void);
+
#else /* CONFIG_SYSFB */
static inline void sysfb_disable(struct device *dev)
{
}
+static inline bool sysfb_handles_screen_info(void)
+{
+ return false;
+}
+
#endif /* CONFIG_SYSFB */
#ifdef CONFIG_EFI
--
2.46.0
next prev parent reply other threads:[~2024-09-16 11:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 11:00 [PATCH v4 0/2] firmware: Avoid coreboot and sysfb to register a pdev for same framebuffer Javier Martinez Canillas
2024-09-16 11:00 ` Javier Martinez Canillas [this message]
2024-09-16 14:26 ` [PATCH v4 1/2] firmware: sysfb: Add a sysfb_handles_screen_info() helper function Thomas Zimmermann
2024-09-16 11:00 ` [PATCH v4 2/2] firmware: coreboot: Don't register a pdev if screen_info data is present Javier Martinez Canillas
2024-09-16 14:50 ` ✗ Fi.CI.CHECKPATCH: warning for firmware: Avoid coreboot and sysfb to register a pdev for same framebuffer Patchwork
2024-09-16 15:16 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-16 22:50 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-19 7:40 ` [PATCH v4 0/2] " Tzung-Bi Shih
2024-09-19 8:27 ` Javier Martinez Canillas
2024-09-30 1:44 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240916110040.1688511-2-javierm@redhat.com \
--to=javierm@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=bp@alien8.de \
--cc=briannorris@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dan.carpenter@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=hugues.bruant@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox