From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Brian Norris <briannorris@chromium.org>,
dri-devel@lists.freedesktop.org, Borislav Petkov <bp@alien8.de>,
Julius Werner <jwerner@chromium.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
chrome-platform@lists.linux.dev, intel-gfx@lists.freedesktop.org,
Hugues Bruant <hugues.bruant@gmail.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Alex Deucher <alexander.deucher@amd.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Helge Deller <deller@gmx.de>, Jani Nikula <jani.nikula@intel.com>,
Tzung-Bi Shih <tzungbi@kernel.org>
Subject: [PATCH v4 0/2] firmware: Avoid coreboot and sysfb to register a pdev for same framebuffer
Date: Mon, 16 Sep 2024 13:00:24 +0200 [thread overview]
Message-ID: <20240916110040.1688511-1-javierm@redhat.com> (raw)
Hello,
This is v4 of a fix to prevent both coreboot and sysfb drivers to register
a platform device to setup a system framebuffer. It has been converted to
a series since contains changes for both drivers, to prevent build issues
on architectures that don't define a global struct screen_info.
Patch #1 adds a sysfb_handles_screen_info() helper that can be used by
drivers to check whether sysfb can use the data set in screen_info or not.
Patch #2 makes the framebuffer_coreboot driver to use that helper to know
if has to setup the system framebuffer or delegate that action to sysfb.
I haven't dropped the collected tags from patch #2 due the logic being
basically the same than in v3.
The patches have only been compiled tested because I don't have access to
a coreboot machine. Please let me know if you plan to merge both patches
through the chrome-platforms tree or if you prefer to get merged through
the drm-misc tree.
Best regards,
Javier
Changes in v4:
- New patch to add sysfb_handles_screen_info() helper (Thomas Zimmermann).
- Use a sysfb_handles_screen_info() helper instead of screen_info_video_type()
to fix build errors on platforms that don't define a struct screen_info
(Thomas Zimmermann).
Changes in v3:
- Fix coreboot spelling to be all in lowercase (Julius Werner).
Changes in v2:
- Declare the struct screen_info as constant variable (Thomas Zimmermann).
- Use screen_info_video_type() instead of checking the screen_info video
types directly (Thomas Zimmermann).
- Fix missing "device" word in a comment (Brian Norris).
- Fix some mispellings in a comment (Brian Norris).
- Change error code returned from -EINVAL to -ENODEV (Brian Norris).
Javier Martinez Canillas (2):
firmware: sysfb: Add a sysfb_handles_screen_info() helper function
firmware: coreboot: Don't register a pdev if screen_info data is
present
.../firmware/google/framebuffer-coreboot.c | 14 ++++++++++++++
drivers/firmware/sysfb.c | 19 +++++++++++++++++++
include/linux/sysfb.h | 7 +++++++
3 files changed, 40 insertions(+)
--
2.46.0
next reply other threads:[~2024-09-16 11:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 11:00 Javier Martinez Canillas [this message]
2024-09-16 11:00 ` [PATCH v4 1/2] firmware: sysfb: Add a sysfb_handles_screen_info() helper function Javier Martinez Canillas
2024-09-16 14:26 ` Thomas Zimmermann
2024-09-16 11:00 ` [PATCH v4 2/2] firmware: coreboot: Don't register a pdev if screen_info data is present Javier Martinez Canillas
2024-09-16 14:50 ` ✗ Fi.CI.CHECKPATCH: warning for firmware: Avoid coreboot and sysfb to register a pdev for same framebuffer Patchwork
2024-09-16 15:16 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-16 22:50 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-19 7:40 ` [PATCH v4 0/2] " Tzung-Bi Shih
2024-09-19 8:27 ` Javier Martinez Canillas
2024-09-30 1:44 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240916110040.1688511-1-javierm@redhat.com \
--to=javierm@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=bp@alien8.de \
--cc=briannorris@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dan.carpenter@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=hugues.bruant@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox