Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 2/4] drm/i915: Clean up gen3 hotplug irq setup
Date: Fri, 27 Sep 2024 17:35:43 +0300	[thread overview]
Message-ID: <20240927143545.8665-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20240927143545.8665-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

For the "always on/unmasked" interrupts we initialize
dev_priv->irq_mask first, then enable_mask. Follow the
same order for the hotplug interrupt so that things are
a bit less confusing.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index a784803f709a..ee7a2a49f08e 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1065,10 +1065,10 @@ static void i915_irq_postinstall(struct drm_i915_private *dev_priv)
 		I915_USER_INTERRUPT;
 
 	if (I915_HAS_HOTPLUG(dev_priv)) {
-		/* Enable in IER... */
-		enable_mask |= I915_DISPLAY_PORT_INTERRUPT;
 		/* and unmask in IMR */
 		dev_priv->irq_mask &= ~I915_DISPLAY_PORT_INTERRUPT;
+		/* Enable in IER... */
+		enable_mask |= I915_DISPLAY_PORT_INTERRUPT;
 	}
 
 	GEN3_IRQ_INIT(uncore, GEN2_, dev_priv->irq_mask, enable_mask);
-- 
2.45.2


  parent reply	other threads:[~2024-09-27 14:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 14:35 [PATCH 0/4] drm/i915: Use the gen3+ irq code on gen2 Ville Syrjala
2024-09-27 14:35 ` [PATCH 1/4] drm/i915: Introduce i915_has_legacy_blc_interrupt() Ville Syrjala
2024-09-27 14:35 ` Ville Syrjala [this message]
2024-09-27 14:35 ` [PATCH 3/4] drm/i915: Clean up some comments in gmch irq code Ville Syrjala
2024-09-27 14:35 ` [PATCH 4/4] drm/i915: Switch over to gen3 irq code on gen2 Ville Syrjala
2024-09-27 14:45   ` Ville Syrjälä
2024-09-27 14:56 ` [PATCH 0/4] drm/i915: Use the gen3+ " Jani Nikula
2024-10-01 15:47   ` Ville Syrjälä
2024-09-27 22:08 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-09-27 22:25 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-28 20:44 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240927143545.8665-3-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox