Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/4] drm/i915: Use the gen3+ irq code on gen2
Date: Fri, 27 Sep 2024 17:56:31 +0300	[thread overview]
Message-ID: <87ed55xi00.fsf@intel.com> (raw)
In-Reply-To: <20240927143545.8665-1-ville.syrjala@linux.intel.com>

On Fri, 27 Sep 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Eliminate the special gen2 irq code by simply reusing the
> gen3+ code on gen2. Works just fine on actual hardware.
>
> I generated the last patch with -U20 to help with review.
> Unfortunately it still didn't pick up i915_irq_handler()
> I don't suppose there's a magic knob to tell git diff
> to include a specific function wholesale in the context?

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


>
> Ville Syrjälä (4):
>   drm/i915: Introduce i915_has_legacy_blc_interrupt()
>   drm/i915: Clean up gen3 hotplug irq setup
>   drm/i915: Clean up some comments in gmch irq code
>   drm/i915: Switch over to gen3 irq code on gen2
>
>  .../gpu/drm/i915/display/intel_display_irq.c  |  38 ++--
>  .../gpu/drm/i915/display/intel_display_irq.h  |   1 -
>  drivers/gpu/drm/i915/i915_irq.c               | 202 ++----------------
>  3 files changed, 28 insertions(+), 213 deletions(-)

-- 
Jani Nikula, Intel

  parent reply	other threads:[~2024-09-27 14:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 14:35 [PATCH 0/4] drm/i915: Use the gen3+ irq code on gen2 Ville Syrjala
2024-09-27 14:35 ` [PATCH 1/4] drm/i915: Introduce i915_has_legacy_blc_interrupt() Ville Syrjala
2024-09-27 14:35 ` [PATCH 2/4] drm/i915: Clean up gen3 hotplug irq setup Ville Syrjala
2024-09-27 14:35 ` [PATCH 3/4] drm/i915: Clean up some comments in gmch irq code Ville Syrjala
2024-09-27 14:35 ` [PATCH 4/4] drm/i915: Switch over to gen3 irq code on gen2 Ville Syrjala
2024-09-27 14:45   ` Ville Syrjälä
2024-09-27 14:56 ` Jani Nikula [this message]
2024-10-01 15:47   ` [PATCH 0/4] drm/i915: Use the gen3+ " Ville Syrjälä
2024-09-27 22:08 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-09-27 22:25 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-28 20:44 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed55xi00.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox