Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 0/1] FOR-CI: drm/i915/guc: Disable ct during GuC reset
@ 2024-10-18 20:55 Zhanjun Dong
  2024-10-18 20:55 ` [PATCH v1 1/1] " Zhanjun Dong
  2024-10-18 22:26 ` ✗ Fi.CI.BAT: failure for FOR-CI: " Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Zhanjun Dong @ 2024-10-18 20:55 UTC (permalink / raw)
  To: intel-gfx, dri-devel; +Cc: Zhanjun Dong

During GuC reset prepare, interrupt disabled before hardware reset.
Add disable ct to prevent unnecessary message processing.

Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>

Zhanjun Dong (1):
  drm/i915/guc: Disable ct during GuC reset

 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c         | 3 +++
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 ++
 2 files changed, 5 insertions(+)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v1 1/1] drm/i915/guc: Disable ct during GuC reset
  2024-10-18 20:55 [PATCH v1 0/1] FOR-CI: drm/i915/guc: Disable ct during GuC reset Zhanjun Dong
@ 2024-10-18 20:55 ` Zhanjun Dong
  2024-10-18 22:26 ` ✗ Fi.CI.BAT: failure for FOR-CI: " Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Zhanjun Dong @ 2024-10-18 20:55 UTC (permalink / raw)
  To: intel-gfx, dri-devel; +Cc: Zhanjun Dong

During GuC reset prepare, interrupt disabled before hardware reset.
Add disable ct to prevent unnecessary message processing.

Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c         | 3 +++
 drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
index 0d5197c0824a..7fd4f8f9131a 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
@@ -1176,6 +1176,9 @@ static bool ct_process_incoming_requests(struct intel_guc_ct *ct)
 	bool done;
 	int err;
 
+	if (!ct->enabled)
+		return true;
+
 	spin_lock_irqsave(&ct->requests.lock, flags);
 	request = list_first_entry_or_null(&ct->requests.incoming,
 					   struct ct_incoming_msg, link);
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 9ede6f240d79..866b71a87630 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -1684,6 +1684,8 @@ void intel_guc_submission_reset_prepare(struct intel_guc *guc)
 	guc->interrupts.disable(guc);
 	__reset_guc_busyness_stats(guc);
 
+	intel_guc_ct_disable(&guc->ct);
+
 	/* Flush IRQ handler */
 	spin_lock_irq(guc_to_gt(guc)->irq_lock);
 	spin_unlock_irq(guc_to_gt(guc)->irq_lock);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* ✗ Fi.CI.BAT: failure for FOR-CI: drm/i915/guc: Disable ct during GuC reset
  2024-10-18 20:55 [PATCH v1 0/1] FOR-CI: drm/i915/guc: Disable ct during GuC reset Zhanjun Dong
  2024-10-18 20:55 ` [PATCH v1 1/1] " Zhanjun Dong
@ 2024-10-18 22:26 ` Patchwork
  1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2024-10-18 22:26 UTC (permalink / raw)
  To: Zhanjun Dong; +Cc: intel-gfx

[-- Attachment #1: Type: text/plain, Size: 13116 bytes --]

== Series Details ==

Series: FOR-CI: drm/i915/guc: Disable ct during GuC reset
URL   : https://patchwork.freedesktop.org/series/140197/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_15562 -> Patchwork_140197v1
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_140197v1 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_140197v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/index.html

Participating hosts (41 -> 40)
------------------------------

  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_140197v1:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@gt_mocs:
    - bat-twl-2:          [PASS][1] -> [DMESG-WARN][2] +2 other tests dmesg-warn
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-twl-2/igt@i915_selftest@live@gt_mocs.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-twl-2/igt@i915_selftest@live@gt_mocs.html

  * igt@i915_selftest@live@guc_hang:
    - bat-mtlp-6:         [PASS][3] -> [DMESG-WARN][4] +1 other test dmesg-warn
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-mtlp-6/igt@i915_selftest@live@guc_hang.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-mtlp-6/igt@i915_selftest@live@guc_hang.html
    - bat-adlp-11:        [PASS][5] -> [DMESG-WARN][6] +2 other tests dmesg-warn
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-adlp-11/igt@i915_selftest@live@guc_hang.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-adlp-11/igt@i915_selftest@live@guc_hang.html
    - bat-arls-2:         [PASS][7] -> [DMESG-WARN][8] +1 other test dmesg-warn
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-arls-2/igt@i915_selftest@live@guc_hang.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-arls-2/igt@i915_selftest@live@guc_hang.html
    - bat-adlp-6:         [PASS][9] -> [DMESG-WARN][10] +4 other tests dmesg-warn
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-adlp-6/igt@i915_selftest@live@guc_hang.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-adlp-6/igt@i915_selftest@live@guc_hang.html
    - bat-dg2-11:         [PASS][11] -> [DMESG-WARN][12] +1 other test dmesg-warn
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-dg2-11/igt@i915_selftest@live@guc_hang.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-dg2-11/igt@i915_selftest@live@guc_hang.html
    - bat-dg2-14:         [PASS][13] -> [DMESG-WARN][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-dg2-14/igt@i915_selftest@live@guc_hang.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-dg2-14/igt@i915_selftest@live@guc_hang.html
    - bat-atsm-1:         [PASS][15] -> [DMESG-WARN][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-atsm-1/igt@i915_selftest@live@guc_hang.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-atsm-1/igt@i915_selftest@live@guc_hang.html
    - bat-dg2-8:          [PASS][17] -> [DMESG-WARN][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-dg2-8/igt@i915_selftest@live@guc_hang.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-dg2-8/igt@i915_selftest@live@guc_hang.html

  * igt@i915_selftest@live@hangcheck:
    - bat-mtlp-8:         [PASS][19] -> [DMESG-WARN][20] +2 other tests dmesg-warn
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-mtlp-8/igt@i915_selftest@live@hangcheck.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-mtlp-8/igt@i915_selftest@live@hangcheck.html
    - bat-adlm-1:         [PASS][21] -> [DMESG-WARN][22] +1 other test dmesg-warn
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-adlm-1/igt@i915_selftest@live@hangcheck.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-adlm-1/igt@i915_selftest@live@hangcheck.html
    - bat-arls-1:         [PASS][23] -> [DMESG-WARN][24] +1 other test dmesg-warn
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-arls-1/igt@i915_selftest@live@hangcheck.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-arls-1/igt@i915_selftest@live@hangcheck.html
    - bat-twl-1:          [PASS][25] -> [DMESG-WARN][26] +1 other test dmesg-warn
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-twl-1/igt@i915_selftest@live@hangcheck.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-twl-1/igt@i915_selftest@live@hangcheck.html
    - bat-arlh-2:         [PASS][27] -> [DMESG-WARN][28] +1 other test dmesg-warn
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-arlh-2/igt@i915_selftest@live@hangcheck.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-arlh-2/igt@i915_selftest@live@hangcheck.html

  * igt@i915_selftest@live@workarounds:
    - bat-dg1-7:          [PASS][29] -> [DMESG-WARN][30] +2 other tests dmesg-warn
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-dg1-7/igt@i915_selftest@live@workarounds.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-dg1-7/igt@i915_selftest@live@workarounds.html
    - bat-adlp-9:         [PASS][31] -> [DMESG-WARN][32] +4 other tests dmesg-warn
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-adlp-9/igt@i915_selftest@live@workarounds.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-adlp-9/igt@i915_selftest@live@workarounds.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@i915_selftest@live@hangcheck:
    - {bat-arlh-3}:       NOTRUN -> [DMESG-WARN][33] +1 other test dmesg-warn
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-arlh-3/igt@i915_selftest@live@hangcheck.html

  
Known issues
------------

  Here are the changes found in Patchwork_140197v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live:
    - bat-mtlp-8:         [PASS][34] -> [DMESG-WARN][35] ([i915#10341])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-mtlp-8/igt@i915_selftest@live.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-mtlp-8/igt@i915_selftest@live.html
    - bat-adlm-1:         [PASS][36] -> [DMESG-WARN][37] ([i915#12133]) +1 other test dmesg-warn
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-adlm-1/igt@i915_selftest@live.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-adlm-1/igt@i915_selftest@live.html
    - bat-arls-1:         [PASS][38] -> [DMESG-WARN][39] ([i915#10341] / [i915#12133])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-arls-1/igt@i915_selftest@live.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-arls-1/igt@i915_selftest@live.html
    - bat-dg1-7:          [PASS][40] -> [DMESG-WARN][41] ([i915#12133])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-dg1-7/igt@i915_selftest@live.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-dg1-7/igt@i915_selftest@live.html
    - bat-twl-1:          [PASS][42] -> [DMESG-WARN][43] ([i915#12133])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-twl-1/igt@i915_selftest@live.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-twl-1/igt@i915_selftest@live.html
    - bat-arlh-2:         [PASS][44] -> [DMESG-WARN][45] ([i915#10341] / [i915#12133])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-arlh-2/igt@i915_selftest@live.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-arlh-2/igt@i915_selftest@live.html
    - bat-arls-2:         [PASS][46] -> [DMESG-WARN][47] ([i915#10341] / [i915#12133])
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-arls-2/igt@i915_selftest@live.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-arls-2/igt@i915_selftest@live.html
    - bat-mtlp-6:         [PASS][48] -> [DMESG-WARN][49] ([i915#10341])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-mtlp-6/igt@i915_selftest@live.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-mtlp-6/igt@i915_selftest@live.html
    - bat-twl-2:          [PASS][50] -> [DMESG-WARN][51] ([i915#12133])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-twl-2/igt@i915_selftest@live.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-twl-2/igt@i915_selftest@live.html
    - bat-dg2-11:         [PASS][52] -> [DMESG-WARN][53] ([i915#12133])
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-dg2-11/igt@i915_selftest@live.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-dg2-11/igt@i915_selftest@live.html
    - bat-dg2-14:         [PASS][54] -> [DMESG-WARN][55] ([i915#12133])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-dg2-14/igt@i915_selftest@live.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-dg2-14/igt@i915_selftest@live.html
    - bat-atsm-1:         [PASS][56] -> [DMESG-WARN][57] ([i915#12133])
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-atsm-1/igt@i915_selftest@live.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-atsm-1/igt@i915_selftest@live.html

  * igt@i915_selftest@live@gt_mocs:
    - bat-arls-1:         [PASS][58] -> [DMESG-WARN][59] ([i915#12133])
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-arls-1/igt@i915_selftest@live@gt_mocs.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-arls-1/igt@i915_selftest@live@gt_mocs.html

  * igt@i915_selftest@live@workarounds:
    - bat-arlh-2:         [PASS][60] -> [DMESG-WARN][61] ([i915#10341])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-arlh-2/igt@i915_selftest@live@workarounds.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-arlh-2/igt@i915_selftest@live@workarounds.html
    - bat-arls-1:         [PASS][62] -> [DMESG-WARN][63] ([i915#10341])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-arls-1/igt@i915_selftest@live@workarounds.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-arls-1/igt@i915_selftest@live@workarounds.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@workarounds:
    - {bat-arlh-3}:       [ABORT][64] ([i915#12061]) -> [PASS][65]
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-arlh-3/igt@i915_selftest@live@workarounds.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-arlh-3/igt@i915_selftest@live@workarounds.html
    - bat-dg2-8:          [DMESG-FAIL][66] ([i915#9500]) -> [PASS][67]
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-dg2-8/igt@i915_selftest@live@workarounds.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-dg2-8/igt@i915_selftest@live@workarounds.html

  
#### Warnings ####

  * igt@i915_selftest@live:
    - bat-dg2-8:          [DMESG-FAIL][68] ([i915#12133] / [i915#9500]) -> [DMESG-WARN][69] ([i915#12133])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15562/bat-dg2-8/igt@i915_selftest@live.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/bat-dg2-8/igt@i915_selftest@live.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#10341]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10341
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
  [i915#12133]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12133
  [i915#9500]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9500


Build changes
-------------

  * Linux: CI_DRM_15562 -> Patchwork_140197v1

  CI-20190529: 20190529
  CI_DRM_15562: fe768c9d3f0cfbe30a1dddf3ae2319d1e04a4403 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_8080: 20fcbc59241a16c84d12f4f6ba390fb46fd65a36 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_140197v1: fe768c9d3f0cfbe30a1dddf3ae2319d1e04a4403 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140197v1/index.html

[-- Attachment #2: Type: text/html, Size: 15500 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-10-18 22:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-18 20:55 [PATCH v1 0/1] FOR-CI: drm/i915/guc: Disable ct during GuC reset Zhanjun Dong
2024-10-18 20:55 ` [PATCH v1 1/1] " Zhanjun Dong
2024-10-18 22:26 ` ✗ Fi.CI.BAT: failure for FOR-CI: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox