From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maarten@mblankhorst.nl, Lankhorst@mblankhorst.nl,
dev@lankhorst.se
Subject: [PATCH 04/10] drm/xe: Defer irq init until after xe_display_init_noaccel
Date: Wed, 6 Nov 2024 15:38:31 +0100 [thread overview]
Message-ID: <20241106143837.195642-4-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20241106143837.195642-1-maarten.lankhorst@linux.intel.com>
Technically, I believe this means that xe_display_init_noirq and
xe_display_init_noaccel can be merged together now.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241105121857.17389-4-maarten.lankhorst@linux.intel.com
Signed-off-by: Maarten Lankhorst,,, <dev@lankhorst.se>
---
drivers/gpu/drm/xe/xe_device.c | 12 ++++--------
drivers/gpu/drm/xe/xe_tile.c | 7 +++++++
2 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index dda7552ad1a55..f6f127788bb8b 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -41,7 +41,6 @@
#include "xe_hw_engine_group.h"
#include "xe_hwmon.h"
#include "xe_irq.h"
-#include "xe_memirq.h"
#include "xe_mmio.h"
#include "xe_module.h"
#include "xe_observation.h"
@@ -682,9 +681,6 @@ int xe_device_probe(struct xe_device *xe)
err = xe_ggtt_init_early(tile->mem.ggtt);
if (err)
return err;
- err = xe_memirq_init(&tile->memirq);
- if (err)
- return err;
}
for_each_gt(gt, xe, id) {
@@ -704,10 +700,6 @@ int xe_device_probe(struct xe_device *xe)
if (err)
return err;
- err = xe_irq_install(xe);
- if (err)
- goto err;
-
err = probe_has_flat_ccs(xe);
if (err)
goto err;
@@ -745,6 +737,10 @@ int xe_device_probe(struct xe_device *xe)
goto err;
}
+ err = xe_irq_install(xe);
+ if (err)
+ goto err;
+
for_each_gt(gt, xe, id) {
last_gt = id;
diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
index 2825553b568f7..d07c1fba793ca 100644
--- a/drivers/gpu/drm/xe/xe_tile.c
+++ b/drivers/gpu/drm/xe/xe_tile.c
@@ -10,6 +10,7 @@
#include "xe_device.h"
#include "xe_ggtt.h"
#include "xe_gt.h"
+#include "xe_memirq.h"
#include "xe_migrate.h"
#include "xe_pcode.h"
#include "xe_sa.h"
@@ -179,6 +180,12 @@ int xe_tile_init_noalloc(struct xe_tile *tile)
int xe_tile_init(struct xe_tile *tile)
{
+ int err;
+
+ err = xe_memirq_init(&tile->memirq);
+ if (err)
+ return err;
+
tile->mem.kernel_bb_pool = xe_sa_bo_manager_init(tile, SZ_1M, 16);
if (IS_ERR(tile->mem.kernel_bb_pool))
return PTR_ERR(tile->mem.kernel_bb_pool);
--
2.45.2
next prev parent reply other threads:[~2024-11-06 14:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 14:38 [PATCH 01/10] drm/xe: Remove double pageflip Maarten Lankhorst
2024-11-06 14:38 ` [PATCH 02/10] drm/xe/display: Add intel_plane_initial_vblank_wait Maarten Lankhorst
2024-11-06 14:38 ` [PATCH 03/10] drm/xe: Move suballocator init to after display init Maarten Lankhorst
2024-11-06 14:38 ` Maarten Lankhorst [this message]
2024-11-06 14:38 ` [PATCH 05/10] drm/xe/display: Use a single early init call for display Maarten Lankhorst
2024-11-06 14:38 ` [PATCH 06/10] drm/xe/sriov: Move VF bootstrap and query_config to vf_guc_init Maarten Lankhorst
2024-11-06 14:38 ` [PATCH 07/10] drm/xe: Simplify GuC early initialisation Maarten Lankhorst
2024-11-06 14:38 ` [PATCH 08/10] drm/xe: Make it possible to read instance0 MCR registers after xe_gt_mcr_init_early Maarten Lankhorst
2024-11-06 14:38 ` [PATCH 09/10] drm/xe: Split init of xe_gt_init_hwconfig to xe_gt_init and *_early Maarten Lankhorst
2024-11-06 14:38 ` [PATCH 10/10] fixup! drm/xe/display: Add intel_plane_initial_vblank_wait Maarten Lankhorst
2024-11-06 17:16 ` ✗ Fi.CI.BUILD: failure for series starting with [01/10] drm/xe: Remove double pageflip Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106143837.195642-4-maarten.lankhorst@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=Lankhorst@mblankhorst.nl \
--cc=Maarten@mblankhorst.nl \
--cc=dev@lankhorst.se \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox