Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Sousa <gustavo.sousa@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Luca Coelho <luciano.coelho@intel.com>,
	Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH v2 15/17] drm/i915/dmc_wl: Use HAS_DMC() in HAS_DMC_WAKELOCK()
Date: Wed,  6 Nov 2024 18:50:41 -0300	[thread overview]
Message-ID: <20241106215231.103474-16-gustavo.sousa@intel.com> (raw)
In-Reply-To: <20241106215231.103474-1-gustavo.sousa@intel.com>

In order to be able to use the DMC wakelock, we also need to know that
the display hardware has support for DMC. For that, include HAS_DMC() in
the definition of HAS_DMC_WAKELOCK().

Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
index 65d17c6cbbb3..43aa1b2501d7 100644
--- a/drivers/gpu/drm/i915/display/intel_display_device.h
+++ b/drivers/gpu/drm/i915/display/intel_display_device.h
@@ -147,7 +147,7 @@ struct intel_display_platforms {
 #define HAS_DDI(i915)			(DISPLAY_INFO(i915)->has_ddi)
 #define HAS_DISPLAY(i915)		(DISPLAY_RUNTIME_INFO(i915)->pipe_mask != 0)
 #define HAS_DMC(i915)			(DISPLAY_RUNTIME_INFO(i915)->has_dmc)
-#define HAS_DMC_WAKELOCK(i915)		(DISPLAY_VER(i915) >= 20)
+#define HAS_DMC_WAKELOCK(i915)		(HAS_DMC(i915) && DISPLAY_VER(i915) >= 20)
 #define HAS_DOUBLE_BUFFERED_M_N(i915)	(DISPLAY_VER(i915) >= 9 || IS_BROADWELL(i915))
 #define HAS_DP_MST(i915)		(DISPLAY_INFO(i915)->has_dp_mst)
 #define HAS_DP20(i915)			(IS_DG2(i915) || DISPLAY_VER(i915) >= 14)
-- 
2.47.0


  parent reply	other threads:[~2024-11-06 21:53 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06 21:50 [PATCH v2 00/17] drm/i915/dmc_wl: Fixes and enablement for Xe3_LPD Gustavo Sousa
2024-11-06 21:50 ` [PATCH v2 01/17] drm/i915/dmc_wl: Use i915_mmio_reg_offset() instead of reg.reg Gustavo Sousa
2024-11-07  9:23   ` Jani Nikula
2024-11-07 10:39   ` Luca Coelho
2024-11-06 21:50 ` [PATCH v2 02/17] drm/xe: Mimic i915 behavior for non-sleeping MMIO wait Gustavo Sousa
2024-11-07 10:40   ` Luca Coelho
2024-11-06 21:50 ` [PATCH v2 03/17] drm/i915/dmc_wl: Use non-sleeping variant of " Gustavo Sousa
2024-11-07 10:42   ` Luca Coelho
2024-11-06 21:50 ` [PATCH v2 04/17] drm/i915/dmc_wl: Check for non-zero refcount in release work Gustavo Sousa
2024-11-06 21:50 ` [PATCH v2 05/17] drm/i915/dmc_wl: Get wakelock when disabling dynamic DC states Gustavo Sousa
2024-11-07 10:43   ` Luca Coelho
2024-11-06 21:50 ` [PATCH v2 06/17] drm/i915/dmc_wl: Use sentinel item for range tables Gustavo Sousa
2024-11-06 21:50 ` [PATCH v2 07/17] drm/i915/dmc_wl: Extract intel_dmc_wl_reg_in_range() Gustavo Sousa
2024-11-07 10:44   ` Luca Coelho
2024-11-06 21:50 ` [PATCH v2 08/17] drm/i915/dmc_wl: Rename lnl_wl_range to powered_off_ranges Gustavo Sousa
2024-11-07 10:46   ` Luca Coelho
2024-11-06 21:50 ` [PATCH v2 09/17] drm/i915/dmc_wl: Track registers touched by the DMC Gustavo Sousa
2024-11-07 10:47   ` Luca Coelho
2024-11-06 21:50 ` [PATCH v2 10/17] drm/i915/dmc_wl: Allow simpler syntax for single reg in range tables Gustavo Sousa
2024-11-07 10:48   ` Luca Coelho
2024-11-06 21:50 ` [PATCH v2 11/17] drm/i915/dmc_wl: Deal with existing references when disabling Gustavo Sousa
2024-11-06 21:50 ` [PATCH v2 12/17] drm/i915/dmc_wl: Couple enable/disable with dynamic DC states Gustavo Sousa
2024-11-06 21:50 ` [PATCH v2 13/17] drm/i915/dmc_wl: Add and use HAS_DMC_WAKELOCK() Gustavo Sousa
2024-11-07 10:49   ` Luca Coelho
2024-11-06 21:50 ` [PATCH v2 14/17] drm/i915/dmc_wl: Init only after we have runtime device info Gustavo Sousa
2024-11-07 10:50   ` Luca Coelho
2024-11-06 21:50 ` Gustavo Sousa [this message]
2024-11-07 10:51   ` [PATCH v2 15/17] drm/i915/dmc_wl: Use HAS_DMC() in HAS_DMC_WAKELOCK() Luca Coelho
2024-11-06 21:50 ` [PATCH v2 16/17] drm/i915/dmc_wl: Sanitize enable_dmc_wl according to hardware support Gustavo Sousa
2024-11-06 21:50 ` [PATCH v2 17/17] drm/i915/xe3lpd: Use DMC wakelock by default Gustavo Sousa
2024-11-07 10:51   ` Luca Coelho
2024-11-06 22:24 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc_wl: Fixes and enablement for Xe3_LPD (rev2) Patchwork
2024-11-06 22:24 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-11-06 22:46 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-11-07 18:36   ` Gustavo Sousa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241106215231.103474-16-gustavo.sousa@intel.com \
    --to=gustavo.sousa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox