From: Gustavo Sousa <gustavo.sousa@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Luca Coelho <luciano.coelho@intel.com>,
Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH v3 14/18] drm/i915/dmc_wl: Init only after we have runtime device info
Date: Thu, 7 Nov 2024 15:27:19 -0300 [thread overview]
Message-ID: <20241107182921.102193-15-gustavo.sousa@intel.com> (raw)
In-Reply-To: <20241107182921.102193-1-gustavo.sousa@intel.com>
We should be able to use the DMC wakelock only if the display hardware
has support for DMC. We will add a check for that in an upcoming change.
Since info for DMC availability (HAS_DMC()) needs runtime device info,
move the call to intel_dmc_wl_init() to a place where we know we have
the hardware has been probed for such an info (i.e. after
intel_display_device_info_runtime_init()).
Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_driver.c b/drivers/gpu/drm/i915/display/intel_display_driver.c
index 56b78cf6b854..4257cc380475 100644
--- a/drivers/gpu/drm/i915/display/intel_display_driver.c
+++ b/drivers/gpu/drm/i915/display/intel_display_driver.c
@@ -200,7 +200,6 @@ void intel_display_driver_early_probe(struct drm_i915_private *i915)
intel_dpll_init_clock_hook(i915);
intel_init_display_hooks(i915);
intel_fdi_init_hook(i915);
- intel_dmc_wl_init(&i915->display);
}
/* part #1: call before irq install */
@@ -238,6 +237,7 @@ int intel_display_driver_probe_noirq(struct drm_i915_private *i915)
return 0;
intel_dmc_init(display);
+ intel_dmc_wl_init(display);
i915->display.wq.modeset = alloc_ordered_workqueue("i915_modeset", 0);
i915->display.wq.flip = alloc_workqueue("i915_flip", WQ_HIGHPRI |
--
2.47.0
next prev parent reply other threads:[~2024-11-07 18:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 18:27 [PATCH v3 00/18] drm/i915/dmc_wl: Fixes and enablement for Xe3_LPD Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 01/18] drm/i915/dmc_wl: Use i915_mmio_reg_offset() instead of reg.reg Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 02/18] drm/xe: Mimic i915 behavior for non-sleeping MMIO wait Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 03/18] drm/i915/dmc_wl: Use non-sleeping variant of " Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 04/18] drm/i915/dmc_wl: Check for non-zero refcount in release work Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 05/18] drm/i915/dmc_wl: Get wakelock when disabling dynamic DC states Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 06/18] drm/i915/dmc_wl: Use sentinel item for range tables Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 07/18] drm/i915/dmc_wl: Extract intel_dmc_wl_reg_in_range() Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 08/18] drm/i915/dmc_wl: Rename lnl_wl_range to powered_off_ranges Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 09/18] drm/i915/dmc_wl: Track registers touched by the DMC Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 10/18] drm/i915/dmc_wl: Allow simpler syntax for single reg in range tables Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 11/18] drm/i915/dmc_wl: Deal with existing references when disabling Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 12/18] drm/i915/dmc_wl: Couple enable/disable with dynamic DC states Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 13/18] drm/i915/dmc_wl: Add and use HAS_DMC_WAKELOCK() Gustavo Sousa
2024-11-07 18:27 ` Gustavo Sousa [this message]
2024-11-07 18:27 ` [PATCH v3 15/18] drm/i915/dmc_wl: Use HAS_DMC() in HAS_DMC_WAKELOCK() Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 16/18] drm/i915/dmc_wl: Sanitize enable_dmc_wl according to hardware support Gustavo Sousa
2024-11-07 18:27 ` [PATCH v3 17/18] drm/i915/dmc_wl: Do nothing until initialized Gustavo Sousa
2024-11-07 19:23 ` Luca Coelho
2024-11-07 20:14 ` Gustavo Sousa
2024-11-07 20:22 ` Gustavo Sousa
2024-11-08 9:57 ` Luca Coelho
2024-11-08 13:10 ` Gustavo Sousa
2024-11-07 20:47 ` Gustavo Sousa
2024-11-08 10:00 ` Luca Coelho
2024-11-07 18:27 ` [PATCH v3 18/18] drm/i915/xe3lpd: Use DMC wakelock by default Gustavo Sousa
2024-11-07 19:04 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc_wl: Fixes and enablement for Xe3_LPD (rev3) Patchwork
2024-11-07 19:04 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-11-07 19:29 ` ✓ Fi.CI.BAT: success " Patchwork
2024-11-07 21:32 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107182921.102193-15-gustavo.sousa@intel.com \
--to=gustavo.sousa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox