[PATCH] drm/i915/hdcp: Change log level for HDMI HDCP LIC check

[PATCH] drm/i915/hdcp: Change log level for HDMI HDCP LIC check

[Suraj Kandpal]

We don't need to shout out loud if there is a Link Integrity
Failure. This does not mean HDCP has failed, it is expected and
taken into account in the HDCP Spec. The real failure happens when
we are not able to reauthenticate and get HDCP running again for
which we already have the right logging.

--v2
-Remove the log altogether [Ankit]

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_hdmi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 23c270a8c4aa..4e1a9d6ae862 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -1607,7 +1607,6 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *dig_port,
 		if (intel_hdmi_hdcp_check_link_once(dig_port, connector))
 			return true;
 
-	drm_err(display->drm, "Link check failed\n");
 	return false;
 }
 
-- 
2.34.1

✗ Fi.CI.BUILD: failure for drm/i915/hdcp: Change log level for HDMI HDCP LIC check (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915/hdcp: Change log level for HDMI HDCP LIC check (rev2)
URL   : https://patchwork.freedesktop.org/series/141867/
State : failure

== Summary ==

Error: make failed
  CALL    scripts/checksyscalls.sh
  DESCEND objtool
  INSTALL libsubcmd_headers
  CC [M]  drivers/gpu/drm/i915/display/intel_hdmi.o
drivers/gpu/drm/i915/display/intel_hdmi.c: In function ‘intel_hdmi_hdcp_check_link’:
drivers/gpu/drm/i915/display/intel_hdmi.c:1603:31: error: unused variable ‘display’ [-Werror=unused-variable]
 1603 |         struct intel_display *display = to_intel_display(dig_port);
      |                               ^~~~~~~
cc1: all warnings being treated as errors
make[6]: *** [scripts/Makefile.build:229: drivers/gpu/drm/i915/display/intel_hdmi.o] Error 1
make[5]: *** [scripts/Makefile.build:478: drivers/gpu/drm/i915] Error 2
make[4]: *** [scripts/Makefile.build:478: drivers/gpu/drm] Error 2
make[3]: *** [scripts/Makefile.build:478: drivers/gpu] Error 2
make[2]: *** [scripts/Makefile.build:478: drivers] Error 2
make[1]: *** [/home/kbuild2/kernel/Makefile:1936: .] Error 2
make: *** [Makefile:224: __sub-make] Error 2
Build failed, no error log produced

Re: [PATCH] drm/i915/hdcp: Change log level for HDMI HDCP LIC check

[kernel test robot]

Hi Suraj,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on linus/master v6.12 next-20241128]
[cannot apply to drm-intel/for-linux-next-fixes drm-tip/drm-tip]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Suraj-Kandpal/drm-i915-hdcp-Change-log-level-for-HDMI-HDCP-LIC-check/20241129-170750
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
patch link:    https://lore.kernel.org/r/20241129090530.1814774-1-suraj.kandpal%40intel.com
patch subject: [PATCH] drm/i915/hdcp: Change log level for HDMI HDCP LIC check
config: i386-buildonly-randconfig-005-20241129 (https://download.01.org/0day-ci/archive/20241129/202411292051.mFVQ48G0-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241129/202411292051.mFVQ48G0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411292051.mFVQ48G0-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/gpu/drm/i915/display/intel_hdmi.c:31:
   In file included from include/linux/i2c.h:19:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:21:
   In file included from include/linux/mm.h:2213:
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
>> drivers/gpu/drm/i915/display/intel_hdmi.c:1603:24: warning: unused variable 'display' [-Wunused-variable]
    1603 |         struct intel_display *display = to_intel_display(dig_port);
         |                               ^~~~~~~
   2 warnings generated.


vim +/display +1603 drivers/gpu/drm/i915/display/intel_hdmi.c

2320175feb74a11 drivers/gpu/drm/i915/intel_hdmi.c         Sean Paul    2018-01-08  1598  
b08239b2f471909 drivers/gpu/drm/i915/display/intel_hdmi.c Oliver Barta 2020-05-04  1599  static
038bac8970ac1c9 drivers/gpu/drm/i915/display/intel_hdmi.c Sean Paul    2020-08-18  1600  bool intel_hdmi_hdcp_check_link(struct intel_digital_port *dig_port,
038bac8970ac1c9 drivers/gpu/drm/i915/display/intel_hdmi.c Sean Paul    2020-08-18  1601  				struct intel_connector *connector)
b08239b2f471909 drivers/gpu/drm/i915/display/intel_hdmi.c Oliver Barta 2020-05-04  1602  {
1138137c2c48f03 drivers/gpu/drm/i915/display/intel_hdmi.c Jani Nikula  2024-08-30 @1603  	struct intel_display *display = to_intel_display(dig_port);
b08239b2f471909 drivers/gpu/drm/i915/display/intel_hdmi.c Oliver Barta 2020-05-04  1604  	int retry;
b08239b2f471909 drivers/gpu/drm/i915/display/intel_hdmi.c Oliver Barta 2020-05-04  1605  
b08239b2f471909 drivers/gpu/drm/i915/display/intel_hdmi.c Oliver Barta 2020-05-04  1606  	for (retry = 0; retry < 3; retry++)
038bac8970ac1c9 drivers/gpu/drm/i915/display/intel_hdmi.c Sean Paul    2020-08-18  1607  		if (intel_hdmi_hdcp_check_link_once(dig_port, connector))
b08239b2f471909 drivers/gpu/drm/i915/display/intel_hdmi.c Oliver Barta 2020-05-04  1608  			return true;
b08239b2f471909 drivers/gpu/drm/i915/display/intel_hdmi.c Oliver Barta 2020-05-04  1609  
b08239b2f471909 drivers/gpu/drm/i915/display/intel_hdmi.c Oliver Barta 2020-05-04  1610  	return false;
b08239b2f471909 drivers/gpu/drm/i915/display/intel_hdmi.c Oliver Barta 2020-05-04  1611  }
b08239b2f471909 drivers/gpu/drm/i915/display/intel_hdmi.c Oliver Barta 2020-05-04  1612  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[PATCH] drm/i915/hdcp: Remove log for HDMI HDCP LIC check

[Suraj Kandpal]

We don't need to shout out loud if there is a Link Integrity
Failure. This does not mean HDCP has failed, it is expected and
taken into account in the HDCP Spec. The real failure happens when
we are not able to reauthenticate and get HDCP running again for
which we already have the right logging.

--v2
-Remove the log altogether [Ankit]

--v3
-Remove useless display variable

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_hdmi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 23c270a8c4aa..63e56c9ff516 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -1600,14 +1600,12 @@ static
 bool intel_hdmi_hdcp_check_link(struct intel_digital_port *dig_port,
 				struct intel_connector *connector)
 {
-	struct intel_display *display = to_intel_display(dig_port);
 	int retry;
 
 	for (retry = 0; retry < 3; retry++)
 		if (intel_hdmi_hdcp_check_link_once(dig_port, connector))
 			return true;
 
-	drm_err(display->drm, "Link check failed\n");
 	return false;
 }
 
-- 
2.34.1

Re: [PATCH] drm/i915/hdcp: Remove log for HDMI HDCP LIC check

[Nautiyal, Ankit K]

On 12/2/2024 11:34 AM, Suraj Kandpal wrote:
> We don't need to shout out loud if there is a Link Integrity
> Failure. This does not mean HDCP has failed, it is expected and
> taken into account in the HDCP Spec. The real failure happens when
> we are not able to reauthenticate and get HDCP running again for
> which we already have the right logging.
>
> --v2
> -Remove the log altogether [Ankit]
>
> --v3
> -Remove useless display variable
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>

LGTM.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

> ---
>   drivers/gpu/drm/i915/display/intel_hdmi.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 23c270a8c4aa..63e56c9ff516 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1600,14 +1600,12 @@ static
>   bool intel_hdmi_hdcp_check_link(struct intel_digital_port *dig_port,
>   				struct intel_connector *connector)
>   {
> -	struct intel_display *display = to_intel_display(dig_port);
>   	int retry;
>   
>   	for (retry = 0; retry < 3; retry++)
>   		if (intel_hdmi_hdcp_check_link_once(dig_port, connector))
>   			return true;
>   
> -	drm_err(display->drm, "Link check failed\n");
>   	return false;
>   }
>   

✗ i915.CI.BAT: failure for drm/i915/hdcp: Change log level for HDMI HDCP LIC check (rev3)

[Patchwork]

== Series Details ==

Series: drm/i915/hdcp: Change log level for HDMI HDCP LIC check (rev3)
URL   : https://patchwork.freedesktop.org/series/141867/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_15764 -> Patchwork_141867v3
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_141867v3 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_141867v3, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141867v3/index.html

Participating hosts (46 -> 45)
------------------------------

  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_141867v3:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live:
    - fi-pnv-d510:        NOTRUN -> [INCOMPLETE][1] +1 other test incomplete
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141867v3/fi-pnv-d510/igt@i915_selftest@live.html

  
Known issues
------------

  Here are the changes found in Patchwork_141867v3 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_pm_rpm@module-reload:
    - bat-rpls-4:         [PASS][2] -> [FAIL][3] ([i915#12903])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15764/bat-rpls-4/igt@i915_pm_rpm@module-reload.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141867v3/bat-rpls-4/igt@i915_pm_rpm@module-reload.html

  * igt@kms_psr@psr-primary-mmap-gtt:
    - fi-pnv-d510:        NOTRUN -> [SKIP][4] +31 other tests skip
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141867v3/fi-pnv-d510/igt@kms_psr@psr-primary-mmap-gtt.html

  
#### Possible fixes ####

  * igt@dmabuf@all-tests:
    - bat-apl-1:          [INCOMPLETE][5] ([i915#12904]) -> [PASS][6] +1 other test pass
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15764/bat-apl-1/igt@dmabuf@all-tests.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141867v3/bat-apl-1/igt@dmabuf@all-tests.html

  * igt@i915_pm_rpm@module-reload:
    - bat-dg1-7:          [FAIL][7] ([i915#12903]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15764/bat-dg1-7/igt@i915_pm_rpm@module-reload.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141867v3/bat-dg1-7/igt@i915_pm_rpm@module-reload.html

  * igt@i915_selftest@live:
    - bat-mtlp-8:         [ABORT][9] ([i915#12061]) -> [PASS][10] +1 other test pass
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15764/bat-mtlp-8/igt@i915_selftest@live.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141867v3/bat-mtlp-8/igt@i915_selftest@live.html

  * igt@kms_busy@basic@modeset:
    - {bat-mtlp-9}:       [DMESG-WARN][11] ([i915#12695]) -> [PASS][12] +4 other tests pass
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15764/bat-mtlp-9/igt@kms_busy@basic@modeset.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141867v3/bat-mtlp-9/igt@kms_busy@basic@modeset.html

  * igt@kms_flip@basic-flip-vs-dpms@a-dp1:
    - bat-apl-1:          [DMESG-WARN][13] ([i915#12921]) -> [PASS][14] +1 other test pass
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15764/bat-apl-1/igt@kms_flip@basic-flip-vs-dpms@a-dp1.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141867v3/bat-apl-1/igt@kms_flip@basic-flip-vs-dpms@a-dp1.html

  
#### Warnings ####

  * igt@gem_exec_gttfill@basic:
    - fi-pnv-d510:        [ABORT][15] ([i915#13169]) -> [SKIP][16]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15764/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141867v3/fi-pnv-d510/igt@gem_exec_gttfill@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
  [i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
  [i915#12695]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12695
  [i915#12903]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12903
  [i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
  [i915#12921]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12921
  [i915#13169]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13169
  [i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
  [i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
  [i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
  [i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
  [i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
  [i915#5274]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5274
  [i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
  [i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
  [i915#9159]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9159
  [i915#9688]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9688


Build changes
-------------

  * Linux: CI_DRM_15764 -> Patchwork_141867v3

  CI-20190529: 20190529
  CI_DRM_15764: 9b0aa1ea1d6b35c6eb7e641e5b81b33c297ca4ff @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_8132: 7675e070cb74c6808050764367f978f6b74ebc36 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_141867v3: 9b0aa1ea1d6b35c6eb7e641e5b81b33c297ca4ff @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141867v3/index.html

[PATCH] drm/i915/hdcp: Change log level for HDMI HDCP LIC check

[Suraj Kandpal]

We don't need to shout out loud if there is a Link Integrity
Failure. This does not mean HDCP has failed, it is expected and
taken into account in the HDCP Spec. The real failure happens when
we are not able to reauthenticate and get HDCP running again for
which we already have the right logging.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 23c270a8c4aa..fa679b5d5510 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -1607,7 +1607,7 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *dig_port,
 		if (intel_hdmi_hdcp_check_link_once(dig_port, connector))
 			return true;
 
-	drm_err(display->drm, "Link check failed\n");
+	drm_dbg_kms(display->drm, "Link check failed\n");
 	return false;
 }
 
-- 
2.34.1

Re: [PATCH] drm/i915/hdcp: Change log level for HDMI HDCP LIC check

[Nautiyal, Ankit K]

On 11/28/2024 12:04 PM, Suraj Kandpal wrote:
> We don't need to shout out loud if there is a Link Integrity
> Failure. This does not mean HDCP has failed, it is expected and
> taken into account in the HDCP Spec. The real failure happens when
> we are not able to reauthenticate and get HDCP running again for
> which we already have the right logging.
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 23c270a8c4aa..fa679b5d5510 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1607,7 +1607,7 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *dig_port,
>   		if (intel_hdmi_hdcp_check_link_once(dig_port, connector))
>   			return true;
>   
> -	drm_err(display->drm, "Link check failed\n");
> +	drm_dbg_kms(display->drm, "Link check failed\n");

I agree, we do re-authentication after this so this is not an error at 
this point.

We already have below debug message in case check_link() fails for 
either hdmi/dp in intel_hdcp.c

         drm_dbg_kms(display->drm,
                     "[CONNECTOR:%d:%s] HDCP link failed, retrying 
authentication\n",
                     connector->base.base.id, connector->base.name);

Perhaps just dropping this message altogether will be better.

Regards,

Ankit

>   	return false;
>   }
>