From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com
Subject: [PATCH 2/3] drm/i915: relocate _VGA_MSR_WRITE register definition
Date: Fri, 13 Dec 2024 13:51:10 +0200 [thread overview]
Message-ID: <20241213115111.335474-2-jani.nikula@intel.com> (raw)
In-Reply-To: <20241213115111.335474-1-jani.nikula@intel.com>
Move _VGA_MSR_WRITE to intel_crt_regs.h. It's not necessarily the
optimal place for it, but hands down better than i915_reg.h.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_crt_regs.h | 2 ++
drivers/gpu/drm/i915/i915_reg.h | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_crt_regs.h b/drivers/gpu/drm/i915/display/intel_crt_regs.h
index 9a93020b9a7e..571a67ae9afa 100644
--- a/drivers/gpu/drm/i915/display/intel_crt_regs.h
+++ b/drivers/gpu/drm/i915/display/intel_crt_regs.h
@@ -45,4 +45,6 @@
#define ADPA_VSYNC_ACTIVE_HIGH REG_BIT(4)
#define ADPA_HSYNC_ACTIVE_HIGH REG_BIT(3)
+#define _VGA_MSR_WRITE _MMIO(0x3c2)
+
#endif /* __INTEL_CRT_REGS_H__ */
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index a204d0e7fdcf..33cfe07a9b2e 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -144,8 +144,6 @@
#define GEN6_STOLEN_RESERVED_ENABLE (1 << 0)
#define GEN11_STOLEN_RESERVED_ADDR_MASK (0xFFFFFFFFFFFULL << 20)
-#define _VGA_MSR_WRITE _MMIO(0x3c2)
-
#define _GEN7_PIPEA_DE_LOAD_SL 0x70068
#define _GEN7_PIPEB_DE_LOAD_SL 0x71068
#define GEN7_PIPE_DE_LOAD_SL(pipe) _MMIO_PIPE(pipe, _GEN7_PIPEA_DE_LOAD_SL, _GEN7_PIPEB_DE_LOAD_SL)
--
2.39.5
next prev parent reply other threads:[~2024-12-13 11:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 11:51 [PATCH 1/3] drm/i915: split out i9xx_wm_regs.h Jani Nikula
2024-12-13 11:51 ` Jani Nikula [this message]
2024-12-16 12:02 ` [PATCH 2/3] drm/i915: relocate _VGA_MSR_WRITE register definition Luca Coelho
2024-12-13 11:51 ` [PATCH 3/3] drm/i915: move DDI_CLK_VALFREQ next to other Cx0 PHY registers Jani Nikula
2024-12-16 12:03 ` Luca Coelho
2024-12-13 12:20 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: split out i9xx_wm_regs.h Patchwork
2024-12-13 12:37 ` ✓ i915.CI.BAT: success " Patchwork
2024-12-13 15:59 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-16 12:01 ` [PATCH 1/3] " Luca Coelho
2024-12-16 13:16 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213115111.335474-2-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox