Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: intel-gfx@lists.freedesktop.org, v5-000intel-xe@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, jani.nikula@intel.com,
	ville.syrjala@intel.com
Subject: [PATCH v5 5/7] drm/i915/scaler: Limit pipe scaler downscaling factors for YUV420
Date: Wed, 15 Jan 2025 20:47:12 +0530	[thread overview]
Message-ID: <20250115151714.3665211-6-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20250115151714.3665211-1-mitulkumar.ajitkumar.golani@intel.com>

Limit downscaling to less than 1.5 (source/destination) in
the horizontal direction and 1.0 in the vertical direction,
When configured for Pipe YUV 420 encoding for port output.

Bspec: 50441

Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
 drivers/gpu/drm/i915/display/skl_scaler.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index 72344044d9d3..c9d7966b37ff 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -456,6 +456,16 @@ static int intel_atomic_setup_scaler(struct intel_crtc_state *crtc_state,
 		calculate_max_scale(crtc, 0, *scaler_id,
 				    &max_hscale, &max_vscale);
 
+		/*
+		 * When configured for Pipe YUV 420 encoding for port output,
+		 * limit downscaling to less than 1.5 (source/destination) in
+		 * the horizontal direction and 1.0 in the vertical direction.
+		 */
+		if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420) {
+			max_hscale = 0x18000 - 1;
+			max_vscale = 0x10000;
+		}
+
 		hscale = drm_rect_calc_hscale(&src, &crtc_state->pch_pfit.dst,
 					      0, max_hscale);
 		vscale = drm_rect_calc_vscale(&src, &crtc_state->pch_pfit.dst,
-- 
2.48.0


  parent reply	other threads:[~2025-01-15 15:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-15 15:17 [PATCH v5 0/7] Check Scaler and DSC Prefill Latency Against Vblank Mitul Golani
2025-01-15 15:17 ` [PATCH v5 1/7] drm/i915/scaler: Add and compute scaling factors Mitul Golani
2025-01-15 15:17 ` [PATCH v5 2/7] drm/i915/scaler: Use crtc_state to setup plane or pipe scaler Mitul Golani
2025-01-15 15:17 ` [PATCH v5 3/7] drm/i915/scaler: Refactor max_scale computation Mitul Golani
2025-01-16 11:47   ` Nautiyal, Ankit K
2025-01-15 15:17 ` [PATCH v5 4/7] drm/i915/scaler: Compute scaling factors for pipe scaler Mitul Golani
2025-01-16 11:51   ` Nautiyal, Ankit K
2025-01-15 15:17 ` Mitul Golani [this message]
2025-01-16 12:02   ` [PATCH v5 5/7] drm/i915/scaler: Limit pipe scaler downscaling factors for YUV420 Nautiyal, Ankit K
2025-01-15 15:17 ` [PATCH v5 6/7] drm/i915/scaler: Check if vblank is sufficient for scaler Mitul Golani
2025-01-16 13:01   ` Nautiyal, Ankit K
2025-01-15 15:17 ` [PATCH v5 7/7] drm/i915/dsc: Check if vblank is sufficient for dsc prefill Mitul Golani
2025-01-16 13:04   ` Nautiyal, Ankit K
2025-01-15 15:59 ` [PATCH v5 0/7] Check Scaler and DSC Prefill Latency Against Vblank Golani, Mitulkumar Ajitkumar
2025-01-15 22:07 ` ✗ Fi.CI.SPARSE: warning for Check Scaler and DSC Prefill Latency Against Vblank (rev3) Patchwork
2025-01-15 22:25 ` ✓ i915.CI.BAT: success " Patchwork
2025-01-16  4:03 ` ✗ i915.CI.Full: failure " Patchwork
2025-01-16  7:02 ` ✓ i915.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250115151714.3665211-6-mitulkumar.ajitkumar.golani@intel.com \
    --to=mitulkumar.ajitkumar.golani@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=v5-000intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox