Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: gareth.yu@intel.com
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org,
	shawn.c.lee.intel.om@freedesktop.org, william.tseng@intel.com,
	ankit.k.nautiyal@intel.com, Gareth Yu <gareth.yu@intel.com>,
	Suraj Kandpal <suraj.kandpal@intel.com>,
	Juha-Pekka Heikkil <juha-pekka.heikkila@intel.com>
Subject: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation
Date: Fri, 21 Feb 2025 12:14:01 +0800	[thread overview]
Message-ID: <20250221041401.2219258-1-gareth.yu@intel.com> (raw)

From: Gareth Yu <gareth.yu@intel.com>

The condition change is because Gen 14 begins to support DSC 1.2
and need to check if the sink supports DSC1.2

Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13719

Cc: Suraj Kandpal <suraj.kandpal@intel.com>
Cc: Juha-Pekka Heikkil <juha-pekka.heikkila@intel.com>
Signed-off-by: Gareth Yu <gareth.yu@intel.com>
---
 drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
index b355c479eda3..555180e40b72 100644
--- a/drivers/gpu/drm/i915/display/intel_vdsc.c
+++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
@@ -320,7 +320,7 @@ int intel_dsc_compute_params(struct intel_crtc_state *pipe_config)
 	 * upto uncompressed bpp-1, hence add calculations for all the rc
 	 * parameters
 	 */
-	if (DISPLAY_VER(dev_priv) >= 13) {
+	if ((DISPLAY_VER(dev_priv) >= 14) && (vdsc_cfg->dsc_version_minor >= 2)) {
 		calculate_rc_params(vdsc_cfg);
 	} else {
 		if ((compressed_bpp == 8 ||
-- 
2.34.1


             reply	other threads:[~2025-02-21  3:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21  4:14 gareth.yu [this message]
2025-02-21  4:43 ` [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation Kandpal, Suraj
2025-02-21  5:05   ` Yu, Gareth
2025-02-21  5:12     ` Kandpal, Suraj
2025-02-21  5:26     ` Kandpal, Suraj
2025-02-21  4:48 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2025-02-21  5:06 ` ✗ i915.CI.BAT: failure " Patchwork
2025-02-24  9:06 ` [PATCH] " Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250221041401.2219258-1-gareth.yu@intel.com \
    --to=gareth.yu@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=juha-pekka.heikkila@intel.com \
    --cc=shawn.c.lee.intel.om@freedesktop.org \
    --cc=suraj.kandpal@intel.com \
    --cc=william.tseng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox