Re: [PATCH] drm/i915/vdsc: Correct the conditions of DSC1.1 and DSC 1.2 for rc params calculation

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 21 Feb 2025, gareth.yu@intel.com wrote:
> From: Gareth Yu <gareth.yu@intel.com>
>
> The condition change is because Gen 14 begins to support DSC 1.2
> and need to check if the sink supports DSC1.2
>
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13719
>
> Cc: Suraj Kandpal <suraj.kandpal@intel.com>
> Cc: Juha-Pekka Heikkil <juha-pekka.heikkila@intel.com>
> Signed-off-by: Gareth Yu <gareth.yu@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
> index b355c479eda3..555180e40b72 100644
> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> @@ -320,7 +320,7 @@ int intel_dsc_compute_params(struct intel_crtc_state *pipe_config)
>  	 * upto uncompressed bpp-1, hence add calculations for all the rc
>  	 * parameters
>  	 */
> -	if (DISPLAY_VER(dev_priv) >= 13) {
> +	if ((DISPLAY_VER(dev_priv) >= 14) && (vdsc_cfg->dsc_version_minor >= 2)) {

Please do not add unnecessary parenthesis. They're a distraction.

BR,
Jani.

>  		calculate_rc_params(vdsc_cfg);
>  	} else {
>  		if ((compressed_bpp == 8 ||

-- 
Jani Nikula, Intel